@vouchfor/embeds 1.2.1 → 1.2.2

package/dist/iife/player-embed/src/components/DialogEmbed/index.d.ts

@@ -16,6 +16,7 @@ declare class DialogEmbed extends LitElement {
     preload: DialogEmbedProps['preload'];
     disableAutoplay: DialogEmbedProps['disableAutoplay'];
     aspectRatio: DialogEmbedProps['aspectRatio'];
+    private _id;
     private _handleRootClick;
     connectedCallback(): void;
     disconnectedCallback(): void;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vouchfor/embeds",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "license": "MIT",
   "author": "Aaron Williams",
   "main": "dist/es/embeds.js",

package/src/components/DialogEmbed/Dialog.stories.ts

@@ -35,6 +35,18 @@ const _DialogEmbed = ({
         aspectRatio=${ifDefined(aspectRatio)}
         @error=${console.log}
       ></vouch-embed-dialog>
+      <vouch-embed-dialog
+        env=${ifDefined(env)}
+        apiKey=${ifDefined(apiKey)}
+        vouchId=${ifDefined(vouchId)}
+        templateId=${ifDefined(templateId)}
+        .questions=${questions}
+        .controls=${controls}
+        ?autoplay=${autoplay}
+        preload=${ifDefined(preload)}
+        aspectRatio=${ifDefined(aspectRatio)}
+        @error=${console.log}
+      ></vouch-embed-dialog>
     </div>
   `;
 };

package/src/components/DialogEmbed/DialogPortal.ts

@@ -29,19 +29,25 @@ class DialogPortal extends LitElement {
 
   @state() open = false;
 
-  private _handleToggle = () => {
-    this.open = !this.open;
-
-    if (this.open) {
-      if (!this.disableAutoplay && this._mediaPlayerRef?.value) {
-        this._mediaPlayerRef.value.muted = false;
-        this._mediaPlayerRef.value.play();
+  private _handleToggle = ({ detail }: CustomEvent<string>) => {
+    // Because we have to attach this listener to the document since this element is portalled outside of the button,
+    // we also have to make sure that this player is actually the one we want to open and play by passing in an ID
+    // from the button wrapper parent and checking against that same ID we pass as the event detail
+    if (this.id === detail) {
+      this.open = !this.open;
+
+      if (this.open) {
+        if (!this.disableAutoplay && this._mediaPlayerRef?.value) {
+          this._mediaPlayerRef.value.muted = false;
+          this._mediaPlayerRef.value.play();
+        }
+      } else {
+        this._mediaPlayerRef?.value?.pause();
       }
-    } else {
-      this._mediaPlayerRef?.value?.pause();
     }
   };
 
+  // We could do the same thing on close and check for the correct ID but it doesn't really matter
   private _handleClose = () => {
     this.open = false;
     this._mediaPlayerRef?.value?.pause();
@@ -70,7 +76,13 @@ class DialogPortal extends LitElement {
   }
 
   protected createRenderRoot(): HTMLElement | DocumentFragment {
-    return document.body;
+    // We must create a new node here because portalling into the same node (document.body) causes the second
+    // element to overwrite the first for some reason (not behaviour really stated in the docs)
+    // I am fairly certain this function is only run once as the default behaviour creates the open shadow root
+    // and returns that shadow root in this function: https://lit.dev/docs/components/shadow-dom/#implementing-createrenderroot
+    const newNode = document.createElement('div');
+    document.body.appendChild(newNode);
+    return newNode;
   }
 
   render() {

package/src/components/DialogEmbed/index.ts

@@ -1,6 +1,7 @@
 import { css, html, LitElement } from 'lit';
 import { customElement, property } from 'lit/decorators.js';
 import { ifDefined } from 'lit/directives/if-defined.js';
+import { v4 as uuidv4 } from 'uuid';
 
 import type { PlayerEmbedProps } from '../PlayerEmbed';
 
@@ -41,8 +42,10 @@ class DialogEmbed extends LitElement {
   @property({ type: Boolean }) disableAutoplay: DialogEmbedProps['disableAutoplay'] = false;
   @property({ type: Number }) aspectRatio: DialogEmbedProps['aspectRatio'] = 0;
 
+  private _id = uuidv4();
+
   private _handleRootClick = () => {
-    this.dispatchEvent(new CustomEvent('dialogembed:click', { bubbles: true, composed: true }));
+    this.dispatchEvent(new CustomEvent('dialogembed:click', { detail: this._id, bubbles: true, composed: true }));
   };
 
   connectedCallback(): void {
@@ -61,6 +64,7 @@ class DialogEmbed extends LitElement {
         <vmp-button size="large">Play</vmp-button>
       </slot>
       <vouch-embed-dialog-portal
+        id=${this._id}
         ?autoplay=${false}
         vouchId=${ifDefined(this.vouchId)}
         templateId=${ifDefined(this.templateId)}