@vouchfor/embeds 0.0.0-experiment.5d16720 → 0.0.0-experiment.62328c8

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vouchfor/embeds",
-  "version": "0.0.0-experiment.5d16720",
+  "version": "0.0.0-experiment.62328c8",
   "license": "MIT",
   "author": "Aaron Williams",
   "main": "dist/es/embeds.js",
@@ -26,7 +26,7 @@
     "lint:staged": "lint-staged",
     "prepublishOnly": "yarn build",
     "size": "size-limit",
-    "storybook": "yarn prebuild && storybook dev -p 6006",
+    "storybook": "yarn prebuild && storybook dev -p 6007",
     "prebuild": "yarn build:deps && yarn generate:manifest",
     "test": "true"
   },
@@ -35,8 +35,8 @@
     "**/*.{md,json,yml}": "prettier --write"
   },
   "dependencies": {
-    "@lit/task": "1.0.0",
-    "@vouchfor/media-player": "0.0.0-experiment.5d16720",
+    "@lit/task": "^1.0.0",
+    "@vouchfor/media-player": "0.0.0-experiment.62328c8",
     "uuid": "^9.0.1"
   },
   "peerDependencies": {

package/src/components/Embed/Embed.stories.ts

@@ -10,30 +10,18 @@ type EmbedArgs = EmbedProps & {
   showVouch?: boolean;
 };
 
-const _Embed = ({
-  vouchId,
-  templateId,
-  preload,
-  autoplay,
-  env,
-  apiKey,
-  controls,
-
-  resolution,
-  aspectRatio
-}: EmbedArgs) => {
+const _Embed = ({ vouchId, templateId, preload, autoplay, env, apiKey, controls, aspectRatio }: EmbedArgs) => {
   return html`
     <div style="height: 100vh">
       <vouch-embed
         env=${ifDefined(env)}
         apiKey=${ifDefined(apiKey)}
-        ?autoplay=${autoplay}
         vouchId=${ifDefined(vouchId)}
         templateId=${ifDefined(templateId)}
-        resolution=${ifDefined(resolution)}
-        aspectRatio=${ifDefined(aspectRatio)}
-        preload=${ifDefined(preload)}
         .controls=${controls}
+        ?autoplay=${autoplay}
+        preload=${ifDefined(preload)}
+        aspectRatio=${ifDefined(aspectRatio)}
       ></vouch-embed>
     </div>
   `;
@@ -55,7 +43,6 @@ const Embed: Story = {
     apiKey: 'TVik9uTMgE-PD25UTHIS6gyl0hMBWC7AT4dkpdlLBT4VIfDWZJrQiCk6Ak7m1',
     vouchId: '6JQEIPeStt',
     templateId: '7d0113f7-3f9a-4bdd-97e3-07ee6eec5730',
-    resolution: 1080,
     aspectRatio: 0,
     preload: 'none',
     autoplay: false

package/src/components/Embed/controllers/fetcher.ts

@@ -1,7 +1,6 @@
 import { Task } from '@lit/task';
 
 import type { Embed, EmbedProps } from '..';
-import type { TemplateInstance } from '@vouchfor/canvas-video';
 import type { ReactiveControllerHost } from 'lit';
 import type { Environment } from '~/utils/env';
 
@@ -21,8 +20,6 @@ class FetcherController {
   host: EmbedHost;
 
   private _fetching = false;
-  private _vouch: EmbedProps['data'] | null = null;
-  private _template: TemplateInstance | null = null;
 
   set fetching(value) {
     if (this._fetching !== value) {
@@ -34,50 +31,22 @@ class FetcherController {
     return this._fetching;
   }
 
-  set vouch(value) {
-    if (this._vouch !== value) {
-      this._vouch = value;
-      this.host.requestUpdate();
-    }
-  }
-  get vouch() {
-    return this._vouch;
-  }
-
-  set template(value) {
-    if (this._template !== value) {
-      this._template = value;
-      this.host.requestUpdate();
-    }
-  }
-  get template() {
-    return this._template;
-  }
-
-  private async getVouch(env: Environment, apiKey: string, vouchId?: string) {
+  private async getVouch(env: Environment, apiKey: string, vouchId: string) {
     const { embedApiUrl } = getEnvUrls(env);
 
-    if (vouchId) {
-      return fetch(`${embedApiUrl}/vouches/${vouchId}`, {
-        method: 'GET',
-        headers: [['X-Api-Key', apiKey]]
-      }).then((response) => response.json());
-    }
-
-    return null;
+    return fetch(`${embedApiUrl}/vouches/${vouchId}`, {
+      method: 'GET',
+      headers: [['X-Api-Key', apiKey]]
+    }).then((response) => response.json());
   }
 
-  private async getTemplate(env: Environment, apiKey: string, templateId?: string) {
+  private async getTemplate(env: Environment, apiKey: string, templateId: string) {
     const { embedApiUrl } = getEnvUrls(env);
 
-    if (templateId) {
-      return fetch(`${embedApiUrl}/templates/${templateId}`, {
-        method: 'GET',
-        headers: [['X-Api-Key', apiKey]]
-      }).then((response) => response.json());
-    }
-
-    return null;
+    return fetch(`${embedApiUrl}/templates/${templateId}`, {
+      method: 'GET',
+      headers: [['X-Api-Key', apiKey]]
+    }).then((response) => response.json());
   }
 
   constructor(host: EmbedHost) {
@@ -86,22 +55,26 @@ class FetcherController {
       this.host,
       async ([env, apiKey, data, vouchId, templateId]: TaskDeps) => {
         try {
-          this.vouch = null;
-          this.template = null;
+          host.vouch = undefined;
+          host.template = undefined;
 
           if (data) {
-            const template = await this.getTemplate(env, apiKey, templateId);
-            this.vouch = data;
-            this.template = data?.settings?.template?.instance ?? template;
+            let template;
+            if (templateId) {
+              this.fetching = true;
+              template = await this.getTemplate(env, apiKey, templateId);
+            }
+            host.vouch = data;
+            host.template = template ?? data?.settings?.template?.instance;
           } else if (vouchId) {
             this.fetching = true;
 
             const [vouch, template] = await Promise.all([
               this.getVouch(env, apiKey, vouchId),
-              this.getTemplate(env, apiKey, templateId)
+              templateId ? this.getTemplate(env, apiKey, templateId) : null
             ]);
-            this.vouch = vouch;
-            this.template = vouch?.settings?.template?.instance ?? template;
+            host.vouch = vouch;
+            host.template = template ?? vouch?.settings?.template?.instance;
           }
         } finally {
           this.fetching = false;

package/src/components/Embed/index.ts

@@ -1,9 +1,9 @@
 import { html, LitElement } from 'lit';
-import { customElement, property } from 'lit/decorators.js';
+import { customElement, property, state } from 'lit/decorators.js';
 import { ifDefined } from 'lit/directives/if-defined.js';
 import { createRef, ref } from 'lit/directives/ref.js';
 
-import type { Scene } from '@vouchfor/canvas-video';
+import type { Scene, TemplateInstance } from '@vouchfor/canvas-video';
 import type { MediaPlayer, MediaPlayerProps } from '@vouchfor/media-player';
 import type { Ref } from 'lit/directives/ref.js';
 import type { Environment } from '~/utils/env';
@@ -14,10 +14,7 @@ import { TrackingController } from './controllers/tracking';
 
 import '@vouchfor/media-player';
 
-type EmbedProps = Pick<
-  MediaPlayerProps,
-  'data' | 'resolution' | 'aspectRatio' | 'preload' | 'autoplay' | 'controls'
-> & {
+type EmbedProps = Pick<MediaPlayerProps, 'data' | 'aspectRatio' | 'preload' | 'autoplay' | 'controls'> & {
   env: Environment;
   apiKey: string;
   vouchId?: string;
@@ -35,12 +32,10 @@ class Embed extends LitElement {
   @property({ type: String }) env: EmbedProps['env'] = 'prod';
   @property({ type: String }) apiKey: EmbedProps['apiKey'] = '';
 
+  @property({ type: Array }) controls: EmbedProps['controls'];
   @property({ type: String }) preload: EmbedProps['preload'] = 'auto';
   @property({ type: Boolean }) autoplay: EmbedProps['autoplay'] = false;
-
-  @property({ type: Number }) resolution: EmbedProps['resolution'] = 1080;
   @property({ type: Number }) aspectRatio: EmbedProps['aspectRatio'] = 0;
-  @property({ type: Array }) controls: EmbedProps['controls'];
 
   private eventController = new EventForwardController(this, [
     'durationchange',
@@ -74,13 +69,8 @@ class Embed extends LitElement {
   // @ts-ignore
   private _trackingController = new TrackingController(this);
 
-  get vouch() {
-    return this._fetcherController.vouch;
-  }
-
-  get template() {
-    return this._fetcherController.template;
-  }
+  @state() vouch: EmbedProps['data'];
+  @state() template: TemplateInstance | undefined;
 
   get fetching() {
     return this._fetcherController.fetching;
@@ -176,18 +166,17 @@ class Embed extends LitElement {
 
   render() {
     return html`
-      <vmp-media-player
+      <vmp-new-media-player
         ${ref(this._mediaPlayerRef)}
         ${this.eventController.register()}
         ?autoplay=${this.autoplay}
         ?loading=${this.fetching}
         .data=${this.vouch}
         .template=${this.template}
-        resolution=${ifDefined(this.resolution)}
         aspectRatio=${ifDefined(this.aspectRatio)}
         preload=${ifDefined(this.preload)}
         .controls=${this.controls}
-      ></vmp-media-player>
+      ></vmp-new-media-player>
     `;
   }
 }

package/src/utils/env.ts

@@ -18,7 +18,7 @@ const devPublicApiUrl = 'https://bshyfw4h5a.execute-api.ap-southeast-2.amazonaws
 const stagingPublicApiUrl = 'https://gyzw7rpbq3.execute-api.ap-southeast-2.amazonaws.com/staging';
 const prodPublicApiUrl = 'https://vfcjuim1l3.execute-api.ap-southeast-2.amazonaws.com/prod';
 
-const devEmbedApiUrl = 'http://localhost:6060/v1';
+const devEmbedApiUrl = 'https://embed-dev.vouchfor.com/v1';
 const stagingEmbedApiUrl = 'https://embed-staging.vouchfor.com/v1';
 const prodEmbedApiUrl = 'https://embed.vouchfor.com/v1';