@vouchfor/embeds 0.0.0-experiment.1b80037 → 0.0.0-experiment.1f98c5e

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vouchfor/embeds",
-  "version": "0.0.0-experiment.1b80037",
+  "version": "0.0.0-experiment.1f98c5e",
   "license": "MIT",
   "author": "Aaron Williams",
   "main": "dist/es/embeds.js",
@@ -26,21 +26,22 @@
     "lint:staged": "lint-staged",
     "prepublishOnly": "yarn build",
     "size": "size-limit",
-    "storybook": "yarn prebuild && storybook dev -p 6006",
+    "storybook": "yarn prebuild && storybook dev -p 6007",
     "prebuild": "yarn build:deps && yarn generate:manifest",
-    "test": "true"
+    "test": "rm -rf test/lib && yarn prebuild && vite build --mode test && web-test-runner",
+    "test:ci": "yarn test"
   },
   "lint-staged": {
     "**/*.{ts,tsx,js}": "eslint --fix --quiet",
     "**/*.{md,json,yml}": "prettier --write"
   },
   "dependencies": {
-    "@lit/task": "1.0.0",
-    "@vouchfor/media-player": "0.0.0-experiment.1b80037",
+    "@lit/task": "^1.0.0",
+    "@vouchfor/media-player": "0.0.0-experiment.1f98c5e",
     "uuid": "^9.0.1"
   },
   "peerDependencies": {
-    "lit": "^3.0.2"
+    "lit": "^3.1.0"
   },
   "devDependencies": {
     "@esm-bundle/chai": "^4.3.4-fix.0",
@@ -62,13 +63,14 @@
     "eslint": "^8.50.0",
     "eslint-plugin-import": "^2.28.1",
     "lint-staged": "^14.0.1",
-    "lit": "^2.8.0",
+    "lit": "^3.1.0",
     "prettier": "^3.0.3",
     "react": "^18.2.0",
     "react-dom": "^18.2.0",
     "storybook": "^7.4.5",
     "typescript": "^5.1.3",
     "vite": "^4.4.9",
+    "vite-plugin-commonjs": "^0.10.0",
     "vite-plugin-dts": "^3.6.0",
     "web-component-analyzer": "^1.1.7"
   }

package/src/components/Embed/Embed.spec.ts

@@ -0,0 +1,17 @@
+import { expect } from '@esm-bundle/chai';
+// import { fixture } from '@open-wc/testing';
+// import { html } from 'lit';
+
+// import type { Embed } from './index.js';
+
+// Can't use typescript aliases with esbuild file transforms apparently
+// No idea what a good way to actually build before testing is, the examples give nothing
+// https://modern-web.dev/guides/test-runner/typescript/
+import '../../test/lib/embeds.js';
+
+describe('Embeds', () => {
+  it('passes', async () => {
+    expect(true).to.be.true;
+    // const player = await fixture<Embed>(html`<vouch-embed aspectratio=${1}></vouch-embed>`);
+  });
+});

package/src/components/Embed/Embed.stories.ts

@@ -13,13 +13,12 @@ type EmbedArgs = EmbedProps & {
 const _Embed = ({
   vouchId,
   templateId,
+  questions,
   preload,
   autoplay,
   env,
   apiKey,
   controls,
-
-  resolution,
   aspectRatio
 }: EmbedArgs) => {
   return html`
@@ -27,13 +26,14 @@ const _Embed = ({
       <vouch-embed
         env=${ifDefined(env)}
         apiKey=${ifDefined(apiKey)}
-        ?autoplay=${autoplay}
         vouchId=${ifDefined(vouchId)}
         templateId=${ifDefined(templateId)}
-        resolution=${ifDefined(resolution)}
-        aspectRatio=${ifDefined(aspectRatio)}
-        preload=${ifDefined(preload)}
+        .questions=${questions}
         .controls=${controls}
+        ?autoplay=${autoplay}
+        preload=${ifDefined(preload)}
+        aspectRatio=${ifDefined(aspectRatio)}
+        @error=${console.log}
       ></vouch-embed>
     </div>
   `;
@@ -51,11 +51,11 @@ type Story = StoryObj<EmbedArgs>;
 
 const Embed: Story = {
   args: {
-    env: 'dev',
+    env: 'local',
     apiKey: 'TVik9uTMgE-PD25UTHIS6gyl0hMBWC7AT4dkpdlLBT4VIfDWZJrQiCk6Ak7m1',
     vouchId: '6JQEIPeStt',
-    templateId: '7d0113f7-3f9a-4bdd-97e3-07ee6eec5730',
-    resolution: 1080,
+    templateId: '357fc118-e179-4171-9446-ff2b8e9d1b29',
+    questions: [],
     aspectRatio: 0,
     preload: 'none',
     autoplay: false
@@ -63,7 +63,7 @@ const Embed: Story = {
   argTypes: {
     env: {
       control: 'radio',
-      options: ['prod', 'staging', 'dev']
+      options: ['local', 'dev', 'staging', 'prod']
     },
     preload: {
       control: 'radio',

package/src/components/Embed/controllers/fetcher.ts

@@ -1,7 +1,7 @@
 import { Task } from '@lit/task';
+import { v4 as uuidv4 } from 'uuid';
 
 import type { Embed, EmbedProps } from '..';
-import type { TemplateInstance } from '@vouchfor/canvas-video';
 import type { ReactiveControllerHost } from 'lit';
 import type { Environment } from '~/utils/env';
 
@@ -9,7 +9,7 @@ import { getEnvUrls } from '~/utils/env';
 
 type EmbedHost = ReactiveControllerHost & Embed;
 
-type TaskDeps = [
+type FetchTaskDeps = [
   EmbedProps['env'],
   EmbedProps['apiKey'],
   EmbedProps['data'],
@@ -17,12 +17,13 @@ type TaskDeps = [
   EmbedProps['templateId']
 ];
 
+type FilterTaskDeps = [EmbedProps['data'], EmbedProps['questions']];
+
 class FetcherController {
   host: EmbedHost;
 
   private _fetching = false;
-  private _vouch: EmbedProps['data'] | null = null;
-  private _template: TemplateInstance | null = null;
+  private _vouch: EmbedProps['data'];
 
   set fetching(value) {
     if (this._fetching !== value) {
@@ -34,74 +35,94 @@ class FetcherController {
     return this._fetching;
   }
 
-  set vouch(value) {
-    if (this._vouch !== value) {
-      this._vouch = value;
-      this.host.requestUpdate();
-    }
-  }
-  get vouch() {
-    return this._vouch;
-  }
-
-  set template(value) {
-    if (this._template !== value) {
-      this._template = value;
-      this.host.requestUpdate();
-    }
-  }
-  get template() {
-    return this._template;
-  }
-
-  private async getVouch(env: Environment, apiKey: string, vouchId?: string) {
+  private getVouch = async (env: Environment, apiKey: string, vouchId: string) => {
     const { embedApiUrl } = getEnvUrls(env);
 
-    if (vouchId) {
-      return fetch(`${embedApiUrl}/vouches/${vouchId}`, {
+    const cacheCheck = uuidv4();
+    const res = await fetch(`${embedApiUrl}/vouches/${vouchId}`, {
+      method: 'GET',
+      headers: [
+        ['X-Api-Key', apiKey],
+        ['X-Cache-Check', cacheCheck]
+      ]
+    });
+
+    const vouch = await res.json();
+    this.host.dispatchEvent(new CustomEvent('vouch:loaded', { detail: vouch?.id }));
+
+    // HACK: we're currently using API Gateway caching on the embed API without any invalidation logic,
+    // so to ensure that the cache stays up to date, whenever we detect a cache hit we trigger another
+    // API call with the `Cache-Control` header which will re-fill the cache
+    const resCacheCheck = res?.headers?.get('X-Cache-Check');
+    if (resCacheCheck !== cacheCheck) {
+      fetch(`${embedApiUrl}/vouches/${vouchId}`, {
         method: 'GET',
-        headers: [['X-Api-Key', apiKey]]
-      }).then((response) => response.json());
+        headers: [
+          ['X-Api-Key', apiKey],
+          ['Cache-Control', 'max-age=0']
+        ]
+      });
     }
 
-    return null;
-  }
+    return vouch;
+  };
 
-  private async getTemplate(env: Environment, apiKey: string, templateId?: string) {
+  private getTemplate = async (env: Environment, apiKey: string, templateId: string) => {
     const { embedApiUrl } = getEnvUrls(env);
 
-    if (templateId) {
-      return fetch(`${embedApiUrl}/templates/${templateId}`, {
+    const cacheCheck = uuidv4();
+    const res = await fetch(`${embedApiUrl}/templates/${templateId}`, {
+      method: 'GET',
+      headers: [
+        ['X-Api-Key', apiKey],
+        ['X-Cache-Check', cacheCheck]
+      ]
+    });
+    const template = await res.json();
+
+    // HACK: we're currently using API Gateway caching on the embed API without any invalidation logic,
+    // so to ensure that the cache stays up to date, whenever we detect a cache hit we trigger another
+    // API call with the `Cache-Control` header which will re-fill the cache
+    const resCacheCheck = res?.headers?.get('X-Cache-Check');
+    if (resCacheCheck !== cacheCheck) {
+      fetch(`${embedApiUrl}/templates/${templateId}`, {
         method: 'GET',
-        headers: [['X-Api-Key', apiKey]]
-      }).then((response) => response.json());
+        headers: [
+          ['X-Api-Key', apiKey],
+          ['Cache-Control', 'max-age=0']
+        ]
+      });
     }
 
-    return null;
-  }
+    return template;
+  };
 
   constructor(host: EmbedHost) {
     this.host = host;
-    new Task<TaskDeps, void>(
+    new Task<FetchTaskDeps, void>(
       this.host,
-      async ([env, apiKey, data, vouchId, templateId]: TaskDeps) => {
+      async ([env, apiKey, data, vouchId, templateId]: FetchTaskDeps) => {
         try {
-          this.vouch = null;
-          this.template = null;
+          host.vouch = undefined;
+          host.template = undefined;
 
           if (data) {
-            const template = await this.getTemplate(env, apiKey, templateId);
-            this.vouch = data;
-            this.template = data?.settings?.template?.instance ?? template;
+            let template;
+            if (templateId) {
+              this.fetching = true;
+              template = await this.getTemplate(env, apiKey, templateId);
+            }
+            this._vouch = data;
+            host.template = template ?? data?.settings?.template?.instance;
           } else if (vouchId) {
             this.fetching = true;
 
             const [vouch, template] = await Promise.all([
               this.getVouch(env, apiKey, vouchId),
-              this.getTemplate(env, apiKey, templateId)
+              templateId ? this.getTemplate(env, apiKey, templateId) : null
             ]);
-            this.vouch = vouch;
-            this.template = vouch?.settings?.template?.instance ?? template;
+            this._vouch = vouch;
+            host.template = template ?? vouch?.settings?.template?.instance;
           }
         } finally {
           this.fetching = false;
@@ -109,6 +130,22 @@ class FetcherController {
       },
       () => [host.env, host.apiKey, host.data, host.vouchId, host.templateId]
     );
+
+    // This second task is to be able to filter the vouch without fetching it again if only the questions changed
+    new Task<FilterTaskDeps, void>(
+      this.host,
+      ([vouch, questions]: FilterTaskDeps) => {
+        host.vouch = vouch
+          ? {
+              ...vouch,
+              questions: {
+                items: vouch?.questions.items.filter((_, index) => !questions?.length || questions?.includes(index + 1))
+              }
+            }
+          : undefined;
+      },
+      () => [this._vouch, host.questions]
+    );
   }
 }
 

package/src/components/Embed/controllers/tracking.ts

@@ -1,18 +1,20 @@
+import { TEMPLATE_VERSION } from '@vouchfor/canvas-video';
 import { v4 as uuidv4 } from 'uuid';
 
 import type { Embed } from '..';
 import type { VideoEventDetail } from '@vouchfor/media-player';
 import type { ReactiveController, ReactiveControllerHost } from 'lit';
 
+import packageJson from '../../../../package.json';
 import { getEnvUrls } from '~/utils/env';
 
-const STREAMED_THROTTLE = 2000;
+const MINIMUM_SEND_THRESHOLD = 1;
 
 type EmbedHost = ReactiveControllerHost & Embed;
 
 type TrackingEvent = 'VOUCH_LOADED' | 'VOUCH_RESPONSE_VIEWED' | 'VIDEO_PLAYED' | 'VIDEO_STREAMED';
 type TrackingPayload = {
-  vouchId: string;
+  vouchId?: string;
   answerId?: string;
   streamStart?: number;
   streamEnd?: number;
@@ -36,21 +38,23 @@ class TrackingController implements ReactiveController {
   private _hasPlayed = false;
   private _hasLoaded: BooleanMap = {};
   private _answersViewed: BooleanMap = {};
-  private _streamedTime: TimeMap = {};
-  private _streamedPrevTimestamp: TimeMap = {};
+  private _streamStartTime: TimeMap = {};
+  private _streamLatestTime: TimeMap = {};
+  private _currentlyPlayingVideo: VideoEventDetail | null = null;
 
   constructor(host: EmbedHost) {
     this.host = host;
     host.addController(this);
   }
 
-  private _findVouchId() {
-    if (this.host.data) {
-      if ('uuid' in this.host.data) {
-        return this.host.data.uuid;
-      }
-      return this.host.data.id;
+  private _findVouchId(payload?: TrackingPayload) {
+    if (payload && 'vouchId' in payload) {
+      return payload.vouchId;
+    }
+    if (this.host.vouch) {
+      return this.host.vouch.id;
     }
+    return null;
   }
 
   private _createVisitor = (visitorId: string) => {
@@ -116,7 +120,7 @@ class TrackingController implements ReactiveController {
     });
 
     return {
-      source: 'media_player',
+      source: this.host.trackingSource,
       time: new Date(),
       region,
       country,
@@ -124,20 +128,31 @@ class TrackingController implements ReactiveController {
       screenWidth: window.screen.width,
       referrer: document.referrer,
       currentUrl: location.href,
+      embedType: 'media-player-embed',
+      embedVersion: packageJson.version,
+      templateVersion: TEMPLATE_VERSION,
       ...utmParams
     };
   };
 
-  private _sendTrackingEvent = (event: TrackingEvent, payload: TrackingPayload) => {
+  private _sendTrackingEvent = (event: TrackingEvent, payload?: TrackingPayload) => {
+    const vouchId = this._findVouchId(payload);
+
+    if (!vouchId || this.host.disableTracking) {
+      return;
+    }
+
     const { publicApiUrl } = getEnvUrls(this.host.env);
     const { client, tab, request, visitor } = this._getUids();
 
-    // Don't send tracking if we don't have a source
     navigator.sendBeacon(
-      `${publicApiUrl}/api/events`,
+      `${publicApiUrl}/api/v2/events`,
       JSON.stringify({
         event,
-        payload,
+        payload: {
+          ...payload,
+          vouchId
+        },
         context: {
           'x-uid-client': client,
           'x-uid-tab': tab,
@@ -149,6 +164,26 @@ class TrackingController implements ReactiveController {
     );
   };
 
+  private _streamEnded = () => {
+    if (this._currentlyPlayingVideo) {
+      const { id, key } = this._currentlyPlayingVideo;
+      // Don't send a tracking event when seeking backwards
+      if (this._streamLatestTime[key] > this._streamStartTime[key] + MINIMUM_SEND_THRESHOLD) {
+        // Send a video streamed event any time the stream ends to capture the time between starting
+        // the video and the video stopping for any reason (pausing, deleting the embed node or closing the browser)
+        this._sendTrackingEvent('VIDEO_STREAMED', {
+          answerId: id,
+          streamStart: this._streamStartTime[key],
+          streamEnd: this._streamLatestTime[key]
+        });
+      }
+
+      // Make sure these events are only sent once by deleting the start and latest times
+      delete this._streamStartTime[key];
+      delete this._streamLatestTime[key];
+    }
+  };
+
   private _handleVouchLoaded = ({ detail: vouchId }: CustomEvent<string>) => {
     if (!vouchId) {
       return;
@@ -156,91 +191,84 @@ class TrackingController implements ReactiveController {
 
     // Only send loaded event once per session
     if (!this._hasLoaded[vouchId]) {
-      this._sendTrackingEvent('VOUCH_LOADED', {
-        vouchId
-      });
+      this._sendTrackingEvent('VOUCH_LOADED', { vouchId });
       this._hasLoaded[vouchId] = true;
     }
   };
 
   private _handlePlay = () => {
-    const vouchId = this._findVouchId();
-
-    if (!vouchId) {
-      return;
-    }
-
     // Only send the video played event once per session
     if (!this._hasPlayed) {
       this._sendTrackingEvent('VIDEO_PLAYED', {
-        vouchId,
         streamStart: this.host.currentTime
       });
       this._hasPlayed = true;
     }
   };
 
-  private _handleVideoPlay = ({ detail: { id, node } }: CustomEvent<VideoEventDetail>) => {
-    const vouchId = this._findVouchId();
-    if (!vouchId) {
-      return;
-    }
+  private _handleVideoPlay = ({ detail: { id, key, node } }: CustomEvent<VideoEventDetail>) => {
     // Only increment play count once per session
-    if (!this._answersViewed[id]) {
+    if (!this._answersViewed[key]) {
       this._sendTrackingEvent('VOUCH_RESPONSE_VIEWED', {
-        vouchId,
         answerId: id
       });
-      this._answersViewed[id] = true;
+      this._answersViewed[key] = true;
     }
-    this._streamedTime[id] = node.currentTime;
-    this._streamedPrevTimestamp[id] = Date.now();
-  };
 
-  private _handleVideoTimeUpdate = ({ detail: { id, node } }: CustomEvent<VideoEventDetail>) => {
-    const vouchId = this._findVouchId();
-    if (!vouchId) {
-      return;
+    if (!this._streamStartTime[key]) {
+      this._streamStartTime[key] = node.currentTime;
+      this._streamLatestTime[key] = node.currentTime;
     }
-    const currentTimestamp = Date.now();
+  };
+
+  private _handleVideoTimeUpdate = ({ detail: { id, key, node } }: CustomEvent<VideoEventDetail>) => {
     if (
+      // We only want to count any time that the video is actually playing
       !this.host.paused &&
-      // Only fire the video seeked event when this video is the active one
-      id === this.host.scene?.video?.id &&
-      // Throttle the frequency that we send streamed events while playing
-      currentTimestamp - this._streamedPrevTimestamp[id] > STREAMED_THROTTLE
+      // Only update the latest time if this event fires for the currently active video
+      id === this.host.scene?.video?.id
     ) {
+      this._currentlyPlayingVideo = { id, key, node };
+      this._streamLatestTime[key] = node.currentTime;
+    }
+  };
+
+  private _handleVideoPause = ({ detail: { id, key } }: CustomEvent<VideoEventDetail>) => {
+    if (this._streamLatestTime[key] > this._streamStartTime[key] + MINIMUM_SEND_THRESHOLD) {
       this._sendTrackingEvent('VIDEO_STREAMED', {
-        vouchId,
         answerId: id,
-        streamStart: this._streamedTime[id],
-        streamEnd: node.currentTime
+        streamStart: this._streamStartTime[key],
+        streamEnd: this._streamLatestTime[key]
       });
-      this._streamedTime[id] = node.currentTime;
-      this._streamedPrevTimestamp[id] = currentTimestamp;
     }
+    delete this._streamStartTime[key];
+    delete this._streamLatestTime[key];
   };
 
-  private _handleVideoPause = ({ detail: { id, node } }: CustomEvent<VideoEventDetail>) => {
-    const vouchId = this._findVouchId();
-    if (!vouchId) {
-      return;
+  private _pageUnloading = () => {
+    this._streamEnded();
+    // This will try to send the same stream event again so we delete the start and latest
+    // time in stream ended so that there is no times to send and the pause event does nothing
+    this.host.pause();
+  };
+
+  private _handleVisibilityChange = () => {
+    if (document.visibilityState === 'hidden') {
+      this._pageUnloading();
     }
-    // Send a video streamed event any time the video pauses then reset the streamed state
-    // We do this to capture the last bit of time that the video was played between the previous
-    // stream event and the video being paused manually or stopping because it ended
-    this._sendTrackingEvent('VIDEO_STREAMED', {
-      vouchId,
-      answerId: id,
-      streamStart: this._streamedTime[id],
-      streamEnd: node.currentTime
-    });
-    delete this._streamedTime[id];
-    delete this._streamedPrevTimestamp[id];
+  };
+
+  private _handlePageHide = () => {
+    this._pageUnloading();
   };
 
   hostConnected() {
     requestAnimationFrame(() => {
+      if ('onvisibilitychange' in document) {
+        document.addEventListener('visibilitychange', this._handleVisibilityChange);
+      } else {
+        window.addEventListener('pagehide', this._handlePageHide);
+      }
       this.host.addEventListener('vouch:loaded', this._handleVouchLoaded);
       this.host.mediaPlayer?.addEventListener('play', this._handlePlay);
       this.host.mediaPlayer?.addEventListener('video:play', this._handleVideoPlay);
@@ -250,6 +278,12 @@ class TrackingController implements ReactiveController {
   }
 
   hostDisconnected() {
+    this._streamEnded();
+    if ('onvisibilitychange' in document) {
+      document.removeEventListener('visibilitychange', this._handleVisibilityChange);
+    } else {
+      window.removeEventListener('pagehide', this._handlePageHide);
+    }
     this.host.removeEventListener('vouch:loaded', this._handleVouchLoaded);
     this.host.mediaPlayer?.removeEventListener('play', this._handlePlay);
     this.host.mediaPlayer?.removeEventListener('video:play', this._handleVideoPlay);