@voltro/cli 0.33.0 → 0.35.0

package/templates/agent-docs/security.md

@@ -22,6 +22,35 @@ Please report suspected vulnerabilities **privately** — never in public issues
 
 You'll get an **acknowledgement within 3 business days**, an assessment once we've reproduced the issue, and a **coordinated disclosure** timeline agreed with you — with credit in the release notes if you'd like it. We don't run a paid bug-bounty program yet, but we genuinely value responsible disclosure.
 
+## Procedures are default-DENY
+
+Every wire-exposed procedure must declare **who may call it**. A `*.query.ts` /
+`*.mutation.ts` / `*.action.ts` / `*.stream.ts` that declares neither `guards:`
+nor `openAccess:` is refused at boot — by `voltro dev`, by `voltro serve`, and by
+`voltro doctor` as a preflight.
+
+Before this, `guards:` defaulted to "allowed": a discovered procedure with no
+guard was callable by any authenticated session. Nothing in the code said so,
+and the only structural check was a report a human had to run.
+
+```ts
+guards: [{ scope: 'invoices:read' }]          // the caller must hold a scope
+openAccess: 'public pricing, no caller data'  // anyone may call it — and why
+internal: true                                // not on the wire at all
+```
+
+`openAccess` takes a reason rather than a boolean on purpose: without an explicit
+way to declare an endpoint open, the only way to satisfy the gate is to invent a
+guard, and the guard people invent is one every caller already holds. That reads
+as protection and enforces nothing.
+
+The whole app can opt out with one field — `security: { defaultDeny: false }` in
+`app.config.ts`. There is no environment variable for it: the only direction
+anyone reaches for is off, and an env var is how that becomes permanent in one CI
+job with no diff to review. Full detail — including how plugin routes are
+covered per-request in the dispatch spine rather than by the boot gate — in
+[Authorization](/docs/authentication/authorization).
+
 ## Outbound HTTP is SSRF-guarded by default
 
 The `HttpClient` your handlers `yield*` refuses internal targets:
@@ -88,6 +117,403 @@ DNS is not resolved. A public hostname that *resolves* to a private address (DNS
 rebinding) still passes. That vector needs network-layer egress control; it is
 stated here rather than silently implied.
 
+## Where the transport settings live
+
+Everything in the next three sections — the origin check, which proxies may
+forward a client IP, and the response headers — is one `security:` block in
+`app.config.ts`, read identically by `voltro dev` and `voltro serve`:
+
+```ts
+// app.config.ts
+export default {
+  security: {
+    // Cross-site protection for every state-changing request. Default 'same-origin'.
+    originGuard: 'same-origin',
+    // Extra origins to accept — a split web/api deployment.
+    allowedOrigins: ['https://app.example.com'],
+    // Whose x-forwarded-for to believe. Empty (the default) ignores the header.
+    trustedProxies: ['private'],
+    // Security response headers. On by default; 'strict' applies the api policy to HTML too.
+    headers: { mode: 'default' },
+  },
+}
+```
+
+Every field has a safe default, so an app that writes none of this is already
+protected. Each also has an environment override, listed with its section below
+— use those to correct a deployment you cannot rebuild, and the config file for
+everything else. A security decision that exists only as an exported variable on
+one machine is invisible to code review.
+
+## Cross-site requests are refused
+
+**Every request that can change state is checked** — anything but `GET`, `HEAD`
+and `OPTIONS` — plus the `/ws` upgrade, which is a GET. That is deliberately a
+rule about the METHOD rather than a list of paths, because a mutation reaches
+your api by more than one road: `POST /rpc`, every REST route projected from a
+`publicApi:` mutation, everything in `apiConfig.restRoutes`, and
+`POST /v1/api-keys`. They all resolve the caller through the same auth chain,
+so they are all reachable **with the session cookie automatically attached**.
+
+A browser request is accepted when its `Origin` matches the `Host` it was
+addressed to, or is in your allowlist. Anything else gets `403 origin not
+allowed` — including `Origin: null`, which is what a sandboxed iframe sends, and
+a request with no `Origin` whose `Sec-Fetch-Site` says `cross-site`.
+
+Before this, framework-wide CSRF protection rested entirely on the
+`SameSite=Lax` cookie default — one caller-overridable attribute that still
+permits top-level-navigation POST, and that does nothing at all for a
+bearer/JWT flow.
+
+Reads are not checked: a `GET` cannot be a cross-site write, and checking it
+would break every link into your api.
+
+### A split web/api deployment must declare its origins
+
+If your web app is served from a different origin than your api, say so — or
+every mutation, every REST write and every socket from that page will 403:
+
+```ts
+// app.config.ts
+export default {
+  security: {
+    allowedOrigins: ['https://app.example.com', 'https://admin.example.com'],
+  },
+}
+```
+
+Same-origin apps (the default layout, and anything behind one ingress) need no
+change. `security: { originGuard: 'off' }` disables the check; a misspelled
+value falls back to **enforcing**, never to off.
+
+Environment overrides, for a deployment you cannot rebuild:
+`VOLTRO_ALLOWED_ORIGINS` (comma-separated) and `VOLTRO_ORIGIN_GUARD=off`. If you
+embed the runtime yourself, the same values are
+`RpcServerOptions.security.originGuard` / `.allowedOrigins`.
+
+### Server-to-server callers are exempt, and that is deliberate
+
+A request carrying neither `Origin` nor `Sec-Fetch-Site` did not come from a
+browsing context, so it is allowed. That covers:
+
+- **SSR loaders** — `voltro dev` / `voltro start` render pages server-side and
+  their loaders call the api from node, which attaches no origin header. Without
+  this exemption, server-side first paint would break on every page with a
+  loader.
+- mobile SDKs, `curl`, and any other service calling your api.
+
+A CSRF attack needs the victim's ambient credentials, and only a browser attaches
+those — a browser cannot be made to omit `Origin` on a cross-origin POST or a
+WebSocket handshake. An attacker's own server can POST without one, but it has no
+session to ride: that is simply an unauthenticated request, and auth and guards
+still apply to it.
+
+Origins are compared by **authority** (host + port), not scheme. Behind a
+TLS-terminating ingress your app sees plain http while the browser reports
+`https://…`, and there is no unforgeable way to learn the external scheme.
+
+### Local development is not a special case you have to configure
+
+When **both** the origin and the `Host` are loopback (`localhost`, `127.0.0.1`,
+`*.localhost`), the request is accepted. That is the `voltro dev` layout: the web
+dev server proxies the api with `changeOrigin: true`, so the api sees
+`Host: localhost:4000` while the browser correctly reports
+`Origin: http://localhost:5190`. Strictly compared those differ, and every dev
+session would lose its websocket.
+
+Both sides must be loopback. A production api on `api.example.com` still refuses
+`Origin: http://localhost:5190` — a browser cannot be made to claim a loopback
+origin it is not on.
+
+**Testing a dev server from a phone on your wifi is the one case that needs a
+line.** The page is then `http://192.168.1.5:5190`, which is not loopback, so the
+socket is refused and the api logs `refused cross-site request` naming the
+origin. Add it while you test:
+
+```ts
+// app.config.ts
+export default {
+  security: {
+    allowedOrigins: ['http://192.168.1.5:5190'],
+  },
+}
+```
+
+The carve-out is deliberately not widened to "both sides are private
+addresses": on a self-hosted internal deployment that would accept any other
+host on the same network, which is a different claim than "the attacker already
+runs code on this machine".
+
+### Routes that a third party legitimately POSTs to
+
+A few surfaces are outside the check, because their caller cannot be a browser
+riding your user's cookie:
+
+- **The inspect surface** (`/_voltro/inspect/*`) — token-gated, and meant to be
+  read cross-origin by the local and cloud dashboards.
+- **Incoming webhooks** (`*.webhook.tsx`) — authenticated by the sender's
+  signature, which the framework refuses to boot without.
+- **Plugin routes that declare it.** First-party examples:
+  `@voltro/plugin-sso-saml` (`/saml` — the IdP makes the browser form-POST a
+  signed assertion, which IS a cross-site POST), `@voltro/plugin-storage`'s
+  upload routes (a signed upload ticket, plus their own CORS allowlist),
+  `@voltro/plugin-billing`'s webhook and `@voltro/plugin-scim` (bearer-only).
+
+If you write a plugin HTTP route in that category, declare it:
+
+```ts
+import type { PluginHttpRoute } from '@voltro/protocol'
+
+const route: PluginHttpRoute = {
+  method: 'POST',
+  path: '/partner/callback',
+  // The signature on the body is the authority — not the session cookie.
+  originGuard: 'exempt',
+  handle: async (req) => {
+    if (!verifySignature(req)) return { status: 401 }
+    return { status: 204 }
+  },
+}
+```
+
+Apply exactly one test before you write that line: *if an attacker's page makes
+a browser send this request with your user's cookies attached, does anything
+happen?* If the answer is "no — it still needs a signature, a bearer token or a
+signed ticket the attacker does not have", the route is exempt. Otherwise it is
+not. The exemption covers the route's whole path prefix, not the sub-paths its
+handler branches on.
+
+## The client IP comes from the socket, not from a header
+
+`x-forwarded-for` is a request header, so **any client can write it**. Voltro
+ignores it unless you declare which proxies are allowed to forward — the address
+used for rate limiting, geo-blocking and audit records is
+`socket.remoteAddress`, the one value nobody upstream of the kernel can forge.
+
+If you run behind a load balancer, ingress or CDN **and** rate-limit or geo-block
+per IP, declare it:
+
+```ts
+// app.config.ts
+export default {
+  security: {
+    trustedProxies: ['private'],        // RFC1918 + CGNAT + link-local + unique-local
+    // ['loopback']                     — local / docker-compose
+    // ['10.0.0.0/8', 'fc00::/7']       — explicit CIDRs
+    // ['2']                            — trust two hops
+    // ['*']                            — any peer; only when your ingress
+    //                                    OVERWRITES rather than appends
+  },
+}
+```
+
+The environment override is `VOLTRO_TRUSTED_PROXIES`, comma-separated
+(`VOLTRO_TRUSTED_PROXIES=10.0.0.0/8,fc00::/7`).
+
+With a list configured, the peer that opened the connection must itself be
+trusted, and the chain is walked right-to-left past every declared proxy — so a
+client that prepends a fake hop cannot push the resolved address further left.
+The same setting decides whether `x-forwarded-proto` is believed, which is what
+gates HSTS below.
+
+Without it, a per-IP limiter still works; it just counts every request against
+your proxy's address instead of the caller's. Embedders pass the same list as
+`RpcServerOptions.security.trustedProxies`.
+
+### The same address reaches your plugin routes
+
+A plugin HTTP route receives it as `req.remoteAddr` — already resolved through
+the policy above. **Use that, never `req.headers['x-forwarded-for']`.** The
+built-in auth routes do: what `@voltro/plugin-auth` and
+`@voltro/plugin-auth-social` write into `sessions.ipAddress` is the resolved
+address, so the column a breach investigation reads cannot be chosen by the
+caller.
+
+```ts
+import type { PluginHttpRoute } from '@voltro/protocol'
+
+const route: PluginHttpRoute = {
+  method: 'POST',
+  path: '/partner/callback',
+  handle: async (req) => {
+    // Resolved once per request; `undefined` only when there is no socket
+    // address (a unix socket, or a hand-built request in a test).
+    await audit(req.remoteAddr ?? null)
+    return { status: 204 }
+  },
+}
+```
+
+## Security headers ship by default
+
+Every response from the api listener carries:
+
+```
+content-security-policy: default-src 'none'; frame-ancestors 'none'; base-uri 'none'; form-action 'none'
+x-frame-options: DENY
+referrer-policy: no-referrer
+x-content-type-options: nosniff
+strict-transport-security: max-age=15552000; includeSubDomains   (https only)
+```
+
+`default-src 'none'` is safe here because this listener serves the **api** —
+rpc JSON, the socket upgrade, inspect routes, webhooks, plugin routes — not your
+web app's HTML, which is a different listener. A `text/html` response from a
+plugin route gets a relaxed policy instead
+(`frame-ancestors 'none'; base-uri 'none'; object-src 'none'`), so a docs page
+still renders while clickjacking and base-tag injection stay closed.
+
+HSTS is sent **only over https** and deliberately never carries `preload`:
+preload is effectively irreversible for a domain, so it has to be your decision.
+`Cross-Origin-Opener-Policy` and `Cross-Origin-Resource-Policy` are not defaulted
+either — guessing them breaks a legitimate cross-origin dashboard — but you can
+add them.
+
+A route that sets a header itself always wins; the framework only fills gaps.
+
+The whole policy is one field, including an `extra` bag for headers the
+framework does not default:
+
+```ts
+// app.config.ts
+export default {
+  security: {
+    headers: {
+      mode: 'default',                              // 'off' | 'default' | 'strict'
+      hsts: 'max-age=31536000; includeSubDomains',  // or false to drop it
+      extra: { 'permissions-policy': 'geolocation=()' },
+    },
+  },
+}
+```
+
+`mode: 'strict'` applies the api policy to HTML too. That is the documented
+trade: it blanks `@voltro/plugin-openapi`'s `/docs` page, which loads its viewer
+from a CDN. Choose it when this listener serves no HTML you own.
+
+Environment overrides: `VOLTRO_SECURITY_HEADERS` (`off|default|strict`),
+`VOLTRO_CSP`, `VOLTRO_CSP_HTML`, `VOLTRO_HSTS` — each accepting `off` to drop
+just that one. Embedders pass the same object as
+`RpcServerOptions.security.headers`.
+
+## Incoming webhooks must verify their caller
+
+An incoming webhook is a **public POST that runs your application code**. A
+`defineIncomingWebhook({...})` that declares no signature scheme now refuses to
+boot, naming the endpoint.
+
+```ts
+export default defineIncomingWebhook({
+  id: 'orders.paid',
+  provider: stripeWebhookProvider(),   // HMAC scheme + replay window + idempotency
+  payload: OrderPaid,
+  handler: async (ctx) => { /* the caller is already verified here */ },
+})
+```
+
+Four ways to satisfy it:
+
+| Declaration | Means |
+|---|---|
+| `provider: stripeWebhookProvider()` | a preset brings the scheme, replay window and idempotency key |
+| `signature: { _tag: 'hmac', … }` | a hand-declared scheme for a sender with its own convention |
+| `verification: 'provider'` | your handler verifies with the provider's own SDK |
+| `verification: 'none'` | deliberately public — a gateway or IP allow-list owns the boundary; logged as a warning on every boot |
+
+A signature-verified webhook reads its shared secret from an env var named after
+its id:
+
+```bash
+VOLTRO_WEBHOOK_SECRET_ORDERS_PAID=<the value the sender holds>
+```
+
+**A missing secret is now a 503, not a skipped check.** It used to run the
+handler unverified, so forgetting one variable silently converted a verified
+webhook into an open one — in production, with nothing in the code to review.
+The framework never invents this value: the sender holds the other half, so a
+generated secret would authenticate nobody.
+
+### `voltro doctor` tells you before a deploy does
+
+The preflight reports the same verdict the boot reaches:
+
+```
+incoming webhook verification
+  ✓ signature / provider verified            2
+  ! deliberately public (none)               1
+      internal.sync — `verification: 'none'`; a gateway / IP allow-list owns this URL
+  ✗ nothing verifies the caller              0
+```
+
+An endpoint in the last row exits non-zero — that app does not start. The middle
+row never fails; it is there so a deliberately public URL is visible in a review
+instead of only in a boot log. Both rows are in `voltro doctor --json` under
+`webhookVerification`.
+
+## The rpc body cap counts bytes as they arrive — and answers 413 either way
+
+`POST /rpc` is capped at 8 MiB (`VOLTRO_MAX_RPC_BODY_BYTES`). The limit is
+enforced **while the body streams**, so a `Transfer-Encoding: chunked` request
+with no `Content-Length` is cut off at the cap rather than buffered without
+bound. A declared oversize length is still rejected up front, so an honest client
+gets its `413` without uploading anything.
+
+**Both shapes end in the same response:**
+
+| Request | Response |
+| --- | --- |
+| `Content-Length` over the cap | `413 Payload Too Large`, before the upload |
+| `Transfer-Encoding: chunked` over the cap | `413 Payload Too Large`, once the counter crosses the cap |
+| Either, under the cap | handled normally |
+
+The refusal is logged server-side under the `voltro:security` scope, with the cap
+and the number of bytes read before the server stopped (never the body's real
+size — it is not read).
+
+Uploads ride separate plugin routes with their own `limits.maxBytes`, and are
+unaffected.
+
+## Logs are redacted by default
+
+Every logger surface — `createLogger`, `makeLogger`, `LoggerLayer` — installs a redactor with no configuration, and it runs **before** formatting and **before** the sink fan-out, so a masked value reaches neither stdout nor any downstream sink (the CLI buffer, logship, Datadog).
+
+```ts
+import { createLogger } from '@voltro/logger'
+
+const log = createLogger({ scope: 'orders' })
+log.info('request', { headers: req.headers, body: input })
+// → headers.authorization = [redacted]
+//   headers.cookie        = [redacted]
+//   body.newPassword      = [redacted]
+//   headers['user-agent'] = curl/8      ← untouched
+```
+
+Three rules, all on:
+
+- **Key names** (`DEFAULT_REDACT_KEYS`) — matched exactly on a normalised key, so `apiKey`, `api_key`, `API-KEY` and `Api Key` are one key. Credentials, bearer/API tokens, `authorization` / `cookie` / `set-cookie` / `x-api-key`, session and second-factor values, and the payment / government identifiers (`creditCard`, `cvv`, `iban`, `ssn`, …) that must never reach a log index.
+- **Key fragments** (`DEFAULT_REDACT_KEY_PARTS`) — substring matches for the compound names real code writes: `newPassword`, `oldPassword`, `stripeApiKey`, `userAccessToken`.
+- **Value shapes** — a credential is masked regardless of its key: `Bearer …`, `Basic …`, a JWT, `sk_` / `pk_` / `whsec_`-prefixed keys, GitHub / Slack / AWS key ids, a PEM private key.
+
+There is deliberately **no entropy heuristic**. A trace id, a content hash, a git sha and a base64 thumbnail are all long and high-entropy — a redactor that eats the fields an incident is read through gets switched off wholesale, which costs more than the gap it closed.
+
+### Adding to the list, and why nothing subtracts
+
+`redactKeys` **adds**; it does not replace:
+
+```ts
+createLogger({ redactKeys: ['patientId', 'policyNumber'] })
+```
+
+There is no way to remove a built-in key. The only reason to un-mask `password` is to read it while debugging, and the answer to that is to log a non-secret projection — not to publish the value to stdout and to whatever log shipper the deployment happens to have. A subtraction knob would also apply to every **dependency** logging under that key, including plugins you never read, which is a blast radius an app cannot assess.
+
+The deliberate escape hatch is `redact`, a transform you write and own — and it runs *after* the built-in redactor, so it can mask more and structurally cannot unmask:
+
+```ts
+createLogger({ redact: (record) => ({ ...record, fields: { ...record.fields, region: 'eu' } }) })
+```
+
+> **If a log line you relied on went quiet**, rename the field rather than reaching for an exemption. `traceId`, `requestId` and `cookieName` are all untouched — the framework's own session diagnostic was renamed from `cookie` to `cookieName` for exactly this reason.
+
 ## Auditing what your log tables actually hold
 
 ```bash