@volter/world-runtime 3.0.102 → 3.0.103

package/dist/src/up-task.js

@@ -14,6 +14,7 @@ export function superviseWorldUp(configId, options) {
         });
         let reply;
         let failure;
+        let settled = false;
         const cancel = (signal) => {
             if (child.connected)
                 child.send({ type: 'cancel', signal }, error => { if (error)
@@ -23,8 +24,31 @@ export function superviseWorldUp(configId, options) {
         const onTerm = () => cancel('SIGTERM');
         process.on('SIGINT', onInt);
         process.on('SIGTERM', onTerm);
-        child.on('error', error => { failure = error; });
-        child.on('message', message => { reply = message; });
+        // `up` is done the moment the owner answers: the caller settles on the reply and lets go of the owner (its channel
+        // and its handle), never waiting on its 'close'. 'close' waits for every inherited descriptor to end, and in a
+        // browser tab's kernel a service the owner started still held one: run 29 printed "returning: the World is up" at
+        // 7.54 s and this process stayed until the 10 s stop. With no reply, the owner's channel closing and its exit settle it.
+        const settle = () => {
+            if (settled)
+                return;
+            settled = true;
+            offSignal('SIGINT', onInt);
+            offSignal('SIGTERM', onTerm);
+            if (child.connected)
+                child.disconnect();
+            child.unref();
+            if (failure)
+                reject(failure);
+            else if (reply && 'error' in reply)
+                reject(new Error(reply.error));
+            else if (reply)
+                done(reply.instance);
+            else
+                reject(new Error(`World boot owner exited without a result (${child.signalCode ?? child.exitCode}); inspect \`volter-world status\` and the lifecycle log`));
+        };
+        child.on('error', error => { failure = error; if (!child.pid)
+            settle(); });
+        child.on('message', message => { reply = message; settle(); });
         child.once('spawn', () => {
             const request = { type: 'start', configId, options: { ...options, root: resolve(options.root ?? process.cwd()) } };
             child.send(request, error => { if (error) {
@@ -33,17 +57,14 @@ export function superviseWorldUp(configId, options) {
                     child.disconnect();
             } });
         });
-        child.once('close', (code, signal) => {
-            offSignal('SIGINT', onInt);
-            offSignal('SIGTERM', onTerm);
-            if (failure)
-                reject(failure);
-            else if (reply && 'error' in reply)
-                reject(new Error(reply.error));
-            else if (reply && code === 0)
-                done(reply.instance);
+        // No reply: every message the channel carried has been delivered once it disconnects; the owner's exit says why.
+        child.once('disconnect', () => {
+            if (reply)
+                return;
+            if (child.exitCode !== null || child.signalCode !== null)
+                settle();
             else
-                reject(new Error(`World boot owner exited without a result (${signal ?? code}); inspect \`volter-world status\` and the lifecycle log`));
+                child.once('exit', settle);
         });
     });
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@volter/world-runtime",
-  "version": "3.0.102",
+  "version": "3.0.103",
   "description": "World configs for twins: boot named local runtimes, allocate ports, generate world.env/instance.json, and run apps against fake-key twin worlds.",
   "keywords": [
     "twin",
@@ -69,14 +69,14 @@
     "node": ">=22.3"
   },
   "peerDependencies": {
-    "@volter/world-core": "3.0.102",
-    "@volter/world-console": "3.0.97"
+    "@volter/world-core": "3.0.103",
+    "@volter/world-console": "3.0.98"
   },
   "dependencies": {
     "@electric-sql/pglite": "0.5.8",
     "@electric-sql/pglite-pgvector": "0.0.9",
     "@volter/world-access": "3.0.1",
-    "@volter/world-core": "3.0.102",
+    "@volter/world-core": "3.0.103",
     "mongodb": "~6.20.0",
     "pg-gateway": "0.3.0-beta.4",
     "smol-toml": "^1.8.0",

package/src/up-task.ts

@@ -20,6 +20,7 @@ export function superviseWorldUp(configId: string, options: UpWorldOptions): Pro
     });
     let reply: UpTaskReply | undefined;
     let failure: Error | undefined;
+    let settled = false;
     const cancel = (signal: 'SIGINT' | 'SIGTERM') => {
       if (child.connected) child.send({ type: 'cancel', signal }, error => { if (error) failure ??= error; });
     };
@@ -27,19 +28,33 @@ export function superviseWorldUp(configId: string, options: UpWorldOptions): Pro
     const onTerm = () => cancel('SIGTERM');
     process.on('SIGINT', onInt);
     process.on('SIGTERM', onTerm);
-    child.on('error', error => { failure = error; });
-    child.on('message', message => { reply = message as UpTaskReply; });
-    child.once('spawn', () => {
-      const request: UpTaskRequest = { type: 'start', configId, options: { ...options, root: resolve(options.root ?? process.cwd()) } };
-      child.send(request, error => { if (error) { failure = error; if (child.connected) child.disconnect(); } });
-    });
-    child.once('close', (code, signal) => {
+    // `up` is done the moment the owner answers: the caller settles on the reply and lets go of the owner (its channel
+    // and its handle), never waiting on its 'close'. 'close' waits for every inherited descriptor to end, and in a
+    // browser tab's kernel a service the owner started still held one: run 29 printed "returning: the World is up" at
+    // 7.54 s and this process stayed until the 10 s stop. With no reply, the owner's channel closing and its exit settle it.
+    const settle = () => {
+      if (settled) return;
+      settled = true;
       offSignal('SIGINT', onInt);
       offSignal('SIGTERM', onTerm);
+      if (child.connected) child.disconnect();
+      child.unref();
       if (failure) reject(failure);
       else if (reply && 'error' in reply) reject(new Error(reply.error));
-      else if (reply && code === 0) done(reply.instance);
-      else reject(new Error(`World boot owner exited without a result (${signal ?? code}); inspect \`volter-world status\` and the lifecycle log`));
+      else if (reply) done(reply.instance);
+      else reject(new Error(`World boot owner exited without a result (${child.signalCode ?? child.exitCode}); inspect \`volter-world status\` and the lifecycle log`));
+    };
+    child.on('error', error => { failure = error; if (!child.pid) settle(); });
+    child.on('message', message => { reply = message as UpTaskReply; settle(); });
+    child.once('spawn', () => {
+      const request: UpTaskRequest = { type: 'start', configId, options: { ...options, root: resolve(options.root ?? process.cwd()) } };
+      child.send(request, error => { if (error) { failure = error; if (child.connected) child.disconnect(); } });
+    });
+    // No reply: every message the channel carried has been delivered once it disconnects; the owner's exit says why.
+    child.once('disconnect', () => {
+      if (reply) return;
+      if (child.exitCode !== null || child.signalCode !== null) settle();
+      else child.once('exit', settle);
     });
   });
 }