@volter/threejs-runtime 0.5.65 → 0.5.66

package/package.json

@@ -2,7 +2,7 @@
   "name": "@volter/threejs-runtime",
   "author": "Volter AI, Inc.",
   "license": "Apache-2.0",
-  "version": "0.5.65",
+  "version": "0.5.66",
   "publishConfig": {
     "access": "public"
   },
@@ -43,7 +43,7 @@
     "@dimforge/rapier3d-compat": "^0.14.0",
     "@recast-navigation/three": "^0.43.0",
     "@sparkjsdev/spark": "^2.1.0",
-    "@volter/editor-project": "0.5.65",
+    "@volter/editor-project": "0.5.66",
     "n8ao": "^1.10.1",
     "postprocessing": "^6.38.0",
     "quarks.core": "0.16.0",

package/src/animation/xstate-animation-binding.ts

@@ -1,8 +1,6 @@
 import type { SystemFn, SystemOptions, SystemPhaseName } from '@volter/editor-project/core/system-phase';
 import * as THREE from 'three';
 import type { AnyStateMachine } from 'xstate';
-import { deleteUserData, getUserData, setUserData } from '../ecs/user-data';
-import { attachAnimationRuntimeInspection } from './runtime-inspection';
 import {
   type AnimationBoneMask,
   type AnimationMetaStateNodeLike,
@@ -67,7 +65,7 @@ export interface XStateAnimationSnapshot {
  *    compare `Actor<StateMachine<…>>` from one copy against `AnyActorRef` from
  *    the other — structurally, through `system`, `src`, `_parent` and a generic
  *    `select`, until it gives up with `TS2321: Excessive stack depth`. Measured
- *    on a fresh scaffold + `vgai add humanoid`, where every in-repo gate
+ *    on a fresh scaffold with a second xstate copy, where every in-repo gate
  *    stayed green because the monorepo resolves exactly one copy. A shape this
  *    shallow cannot blow that budget however many copies are in play.
  *
@@ -113,8 +111,6 @@ export interface XStateAnimationBindingOptions {
   selectParameters?: (context: unknown) => Record<string, number | boolean>;
   /** Root whose named Bone/Object3D hierarchy is used by `boneMask`. Defaults to mixer root. */
   root?: THREE.Object3D;
-  /** Entity that exposes this binding to editor/runtime inspection. Defaults to `root`. */
-  owner?: THREE.Object3D;
   /**
    * Engine runner used to register `tick` in the canonical animation phase.
    * Pass `ctx.systems`; disposal removes the callback automatically. When
@@ -144,29 +140,10 @@ export interface XStateAnimationBinding {
   getParameters: () => ReadonlyMap<string, number | boolean>;
   /** Current native composition, useful to the editor and game diagnostics. */
   getActiveLayers: () => readonly XStateAnimationLayerState[];
-  /** Unsubscribe, stop/uncache actions, and remove owner inspection data. Idempotent. */
+  /** Unsubscribe and stop/uncache actions. Idempotent. */
   dispose: () => void;
 }
 
-let inspectionVersion = 0;
-const inspectionListeners = new Set<() => void>();
-
-/** React/useSyncExternalStore-compatible lifecycle signal for live editor inspection. */
-export function subscribeXStateAnimationBindings(listener: () => void): () => void {
-  inspectionListeners.add(listener);
-  return () => inspectionListeners.delete(listener);
-}
-
-/** Monotonic snapshot changed whenever a binding is attached or disposed. */
-export function getXStateAnimationBindingsVersion(): number {
-  return inspectionVersion;
-}
-
-function notifyInspectionLifecycle(): void {
-  inspectionVersion++;
-  for (const listener of inspectionListeners) listener();
-}
-
 interface WeightedClip {
   clip: string;
   actionKey: string;
@@ -288,7 +265,6 @@ export function bindXStateAnimation(
       '[bindXStateAnimation] a THREE.Object3D `root` option is required when the mixer uses AnimationObjectGroup',
     );
   }
-  const owner = options.owner ?? root;
   const machineRoot = machineOfXStateActor(actor).root as unknown as AnimationMetaStateNodeLike;
   const entries: MachineAnimationMetaEntry[] = collectMachineAnimationMeta(machineRoot);
   const metaByStateId = new Map(entries.map((entry) => [entry.stateId, entry.meta]));
@@ -379,7 +355,6 @@ export function bindXStateAnimation(
 
   const activeLayers = new Map<string, ActiveState>();
   let disposed = false;
-  let detachRuntimeInspection = () => {};
   function silence(weights: WeightedClip[], except: string | undefined, duration: number): void {
     for (const weighted of weights) {
       if (weighted.actionKey === except) continue;
@@ -514,7 +489,6 @@ export function bindXStateAnimation(
     dispose(): void {
       if (disposed) return;
       disposed = true;
-      detachRuntimeInspection();
       options.systems?.remove('animation', tick);
       subscription.unsubscribe();
       for (const { action, clip } of actionCache.values()) {
@@ -523,15 +497,8 @@ export function bindXStateAnimation(
       }
       actionCache.clear();
       activeLayers.clear();
-      if (getUserData(owner, '_xstateAnimation') === binding) {
-        deleteUserData(owner, '_xstateAnimation');
-        notifyInspectionLifecycle();
-      }
     },
   };
-  detachRuntimeInspection = attachAnimationRuntimeInspection(owner, { mixer, clips });
-  setUserData(owner, '_xstateAnimation', binding);
-  notifyInspectionLifecycle();
   options.systems?.add('animation', tick);
   return binding;
 }

package/src/ecs/user-data.ts

@@ -42,16 +42,8 @@
  *
  * Animation (load-bearing — ED5 disposal contract):
  * - `_animMixer`          — THREE.AnimationMixer driving this subtree's clips.
- * - `_animClips`          — Map<string, AnimationClip> discovered on the GLTF (E5 —
- *                           lets game code build its own XState-driven
- *                           binding via `bindXStateAnimation` over the SAME
- *                           mixer; see xstate-animation-binding.ts).
  * - `_availableClips`     — string[] of clip names discovered on the GLTF
- *                           (inspector dropdown; same names as `_animClips`' keys).
- * - `_animationRuntime`   — format-neutral live native mixer/action inspection.
- * - `_xstateBehavior`     — optional live XState behavior actor inspection.
- * - `_xstateAnimation`    — compatibility handle for the optional XState→Three
- *                           bridge; animation UI never discovers through it.
+ *                           (inspector dropdown).
  *
  * Disposal contract:
  * - `__sharedGeometry`    — `true` when a mesh's geometry is shared/cached and MUST
@@ -132,9 +124,6 @@ import type { Object3DAuthoringSubjectMark } from '../adapter/object3d-authoring
 import type { RapierEditableBody } from '../adapter/rapier-physics-adapter';
 import type { ReflectionProbeMark } from '../adapter/reflection-probe';
 import type { TriggerVolumeMark } from '../adapter/trigger-volume';
-import type { AnimationRuntimeInspection } from '../animation/runtime-inspection';
-import type { XStateAnimationBinding } from '../animation/xstate-animation-binding';
-import type { XStateBehaviorInspection } from '../behavior/xstate-inspection';
 import { ObjectMarkKeys, type ObjectMarkSchema } from './object-marks';
 
 export type { EditorHelperType } from './object-marks';
@@ -156,11 +145,7 @@ export interface UserDataSchema extends ObjectMarkSchema {
   _particleSystem: ParticleSystem;
   gaussianSplat: { src: string; numSplats: number };
   _animMixer: THREE.AnimationMixer;
-  _animClips: Map<string, THREE.AnimationClip>;
   _availableClips: string[];
-  _animationRuntime: AnimationRuntimeInspection;
-  _xstateBehavior: XStateBehaviorInspection;
-  _xstateAnimation: XStateAnimationBinding;
   __sharedGeometry: boolean;
   __shadeOrig: THREE.Material | THREE.Material[];
   __shadeUnlit: THREE.Material[];
@@ -213,11 +198,7 @@ export const UserDataKeys = {
   _particleSystem: '_particleSystem',
   gaussianSplat: 'gaussianSplat',
   _animMixer: '_animMixer',
-  _animClips: '_animClips',
   _availableClips: '_availableClips',
-  _animationRuntime: '_animationRuntime',
-  _xstateBehavior: '_xstateBehavior',
-  _xstateAnimation: '_xstateAnimation',
   __sharedGeometry: '__sharedGeometry',
   __shadeOrig: '__shadeOrig',
   __shadeUnlit: '__shadeUnlit',

package/src/animation/runtime-inspection.ts

@@ -1,45 +0,0 @@
-import type * as THREE from 'three';
-import { deleteUserData, getUserData, setUserData } from '../ecs/user-data';
-
-/**
- * Live native animation playback for editor tools, READ-ONLY. A world states
- * what it is playing; nothing here moves it. Time on an editor stage belongs
- * to the stage transport (`@editor/animation/stage-transport`, WORK.md §The
- * stage transport and the animation door), and the transport writes time by
- * seeking a SUBJECT, never through this inspection door.
- * This is instrumentation, not an animation asset or graph format.
- */
-export interface AnimationRuntimeInspection {
-  readonly mixer: THREE.AnimationMixer;
-  readonly clips: ReadonlyMap<string, THREE.AnimationClip>;
-}
-
-let version = 0;
-const listeners = new Set<() => void>();
-
-function notify(): void {
-  version++;
-  for (const listener of listeners) listener();
-}
-
-export function subscribeAnimationRuntimeInspections(listener: () => void): () => void {
-  listeners.add(listener);
-  return () => listeners.delete(listener);
-}
-
-export function animationRuntimeInspectionsVersion(): number {
-  return version;
-}
-
-export function attachAnimationRuntimeInspection(
-  owner: THREE.Object3D,
-  inspection: AnimationRuntimeInspection,
-): () => void {
-  setUserData(owner, '_animationRuntime', inspection);
-  notify();
-  return () => {
-    if (getUserData(owner, '_animationRuntime') !== inspection) return;
-    deleteUserData(owner, '_animationRuntime');
-    notify();
-  };
-}

package/src/behavior/xstate-inspection.ts

@@ -1,51 +0,0 @@
-import type * as THREE from 'three';
-import type { AnyStateMachine } from 'xstate';
-import { deleteUserData, getUserData, setUserData } from '../ecs/user-data';
-
-/** Minimal structural actor surface needed by the live behavior debugger. */
-export interface InspectableXStateActor {
-  readonly getSnapshot: () => {
-    readonly value: unknown;
-    readonly context: unknown;
-    readonly machine?: AnyStateMachine;
-  };
-  readonly subscribe: (next: (snapshot: { readonly value: unknown }) => void) => {
-    unsubscribe: () => void;
-  };
-  readonly logic?: AnyStateMachine;
-}
-
-export interface XStateBehaviorInspection {
-  readonly actor: InspectableXStateActor;
-  readonly machine: AnyStateMachine;
-}
-
-let version = 0;
-const listeners = new Set<() => void>();
-
-function notify(): void {
-  version++;
-  for (const listener of listeners) listener();
-}
-
-export function subscribeXStateBehaviorInspections(listener: () => void): () => void {
-  listeners.add(listener);
-  return () => listeners.delete(listener);
-}
-
-export function xstateBehaviorInspectionsVersion(): number {
-  return version;
-}
-
-export function attachXStateBehaviorInspection(
-  owner: THREE.Object3D,
-  inspection: XStateBehaviorInspection,
-): () => void {
-  setUserData(owner, '_xstateBehavior', inspection);
-  notify();
-  return () => {
-    if (getUserData(owner, '_xstateBehavior') !== inspection) return;
-    deleteUserData(owner, '_xstateBehavior');
-    notify();
-  };
-}