@volter/supercode-teams 0.2.77 → 0.2.78

package/client.mjs

@@ -7,6 +7,7 @@ import { randomBytes } from 'node:crypto';
 import { EventEmitter } from 'node:events';
 import { Channel } from '@volter/teams/channel';
 import { openLocalMachine, openRemoteMachine, StreamRpc, fromWebPage } from '@volter/teams/client';
+import { lineSplitter } from './lines.mjs';
 
 export { openLocalMachine, openRemoteMachine, StreamRpc, fromWebPage };
 
@@ -32,15 +33,9 @@ export async function execServerBridge(channel, harness, { host = '127.0.0.1' }
     catch (error) { if (own) ch?.close?.(); socket.close(1011, String(error.message ?? error).slice(0, 120)); return; }
     if (own) stream.on('close', () => ch.close?.());
     if (socket.readyState !== socket.OPEN) { stream.close('client closed'); return; }
-    let buffer = '';
+    const lines = lineSplitter();
     stream.on('data', (chunk) => {
-      buffer += Buffer.from(chunk, 'base64').toString('utf8');
-      let nl;
-      while ((nl = buffer.indexOf('\n')) >= 0) {
-        const line = buffer.slice(0, nl);
-        buffer = buffer.slice(nl + 1);
-        if (line) socket.send(line);
-      }
+      for (const line of lines(Buffer.from(chunk, 'base64').toString('utf8'))) if (line) socket.send(line);
     });
     stream.on('close', (reason) => socket.close(1000, String(reason ?? '').slice(0, 120)));
     for (const data of early.splice(0)) send(data);
@@ -62,15 +57,9 @@ export function harnessTransport(channel) {
     get running() { return stream !== null && !stream.closed; },
     async start(handlers) {
       stream = await channel.open('harness');
-      let buffer = '';
+      const lines = lineSplitter();
       stream.on('data', (chunk) => {
-        buffer += chunk;
-        let index;
-        while ((index = buffer.indexOf('\n')) >= 0) {
-          const line = buffer.slice(0, index);
-          buffer = buffer.slice(index + 1);
-          if (line) handlers.onLine(line);
-        }
+        for (const line of lines(chunk)) if (line) handlers.onLine(line);
       });
       stream.on('close', (reason) => handlers.onExit(null, reason ?? null));
     },

package/lines.mjs

@@ -0,0 +1,19 @@
+/** Splits a stream's chunks into its complete lines, in time linear in its length: each chunk is scanned once and a
+ *  line joined once, when its newline arrives. Appending to one buffer and searching it from the start again on
+ *  every chunk is quadratic in a long line, and one answer (a large session's `sessions.load`, a whole machine's
+ *  `sessions.discover`) is a line of tens of megabytes. */
+export function lineSplitter() {
+  let pending = [];
+  return (chunk) => {
+    const text = String(chunk), lines = [];
+    let from = 0, at;
+    while ((at = text.indexOf('\n', from)) >= 0) {
+      pending.push(text.slice(from, at));
+      lines.push(pending.join(''));
+      pending = [];
+      from = at + 1;
+    }
+    if (from < text.length) pending.push(text.slice(from));
+    return lines;
+  };
+}

package/machine.mjs

@@ -37,6 +37,7 @@ import { TmuxTerminalHost, classifyAttentionSignal, composerHoldsDraft, composer
 // than failing the load: a POSIX daemon never needs it. Windows needs a supercode-terminal with PtyTerminalHost.
 import * as terminal from '@volter/supercode-terminal';
 import { findLiveReceipt, mintFrontendCredential } from '@volter/supercode-harness-sdk/live-runtime';
+import { lineSplitter } from './lines.mjs';
 import { NODE_PROTOCOL } from '@volter/teams/channel';
 import { holds, observesPanes } from '@volter/teams/admission';
 import { MachineCore, MACHINE_VERSION } from '@volter/teams/machine-core';
@@ -163,7 +164,6 @@ export class TeamsMachine extends MachineCore {
     // How many pane attachments a principal may hold (limits.json); every refusal is logged.
     this.attachmentsByPrincipal = new Map(); // principal → live pane attachments
     this.serve = null;
-    this.serveBuffer = '';
     this.routes = new Map(); // routing key (subscription/connection id) → connection index
     this.portsDir = join(home, 'ports');
     // Panes whose REMOTE input is refused. It survives a daemon restart:
@@ -228,14 +228,10 @@ export class TeamsMachine extends MachineCore {
   #startServe() {
     const child = spawn(this.supercodeBin, ['harness', 'serve'], { stdio: ['pipe', 'pipe', 'pipe'], env: this.env });
     child.stdout.setEncoding('utf8');
+    // A restarted serve starts on a line of its own, never on the tail its predecessor left unfinished.
+    const serveLines = lineSplitter();
     child.stdout.on('data', (chunk) => {
-      this.serveBuffer += chunk;
-      let index;
-      while ((index = this.serveBuffer.indexOf('\n')) >= 0) {
-        const line = this.serveBuffer.slice(0, index);
-        this.serveBuffer = this.serveBuffer.slice(index + 1);
-        if (line) this.#routeServeLine(line);
-      }
+      for (const line of serveLines(chunk)) if (line) this.#routeServeLine(line);
     });
     child.stderr.setEncoding('utf8');
     child.stderr.on('data', (text) => this.emit('serve-stderr', text));
@@ -350,13 +346,9 @@ export class TeamsMachine extends MachineCore {
     entry.harness = stream;
     accept();
     this.log.append({ principal, cap: 'harness', target: '*', outcome: 'opened' });
-    let buffer = '';
+    const lines = lineSplitter();
     stream.on('data', (chunk) => {
-      buffer += chunk;
-      let nl;
-      while ((nl = buffer.indexOf('\n')) >= 0) {
-        const line = buffer.slice(0, nl);
-        buffer = buffer.slice(nl + 1);
+      for (const line of lines(chunk)) {
         if (!line) continue;
         let message;
         try { message = JSON.parse(line); } catch { continue; }
@@ -1048,13 +1040,9 @@ export class TeamsMachine extends MachineCore {
   }
 
   #serveNodeRpc(entry, stream) {
-    let buffer = '';
+    const lines = lineSplitter();
     stream.on('data', async (chunk) => {
-      buffer += chunk;
-      let nl;
-      while ((nl = buffer.indexOf('\n')) >= 0) {
-        const line = buffer.slice(0, nl);
-        buffer = buffer.slice(nl + 1);
+      for (const line of lines(chunk)) {
         if (!line) continue;
         let request;
         try { request = JSON.parse(line); } catch { continue; }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@volter/supercode-teams",
-  "version": "0.2.77",
+  "version": "0.2.78",
   "type": "module",
   "description": "A machine daemon serving this machine's doors, and a local or remote Teams server for shared session discovery, OpenTelemetry ingestion and access to enrolled machines.",
   "license": "MIT",