@volter/supercode-orchestrator 0.5.197 → 0.5.198

package/board/ci.mjs

@@ -197,8 +197,12 @@ function checkoutPresent(path) {
  *  workspace and a branch, e.g. `create "<what>" --subtask-of <arc> --workspace worktree:<repository> --branch <name>`.
  *  Their PRs are the arc's whatever the branch is named. */
 function registeredBranches(board, id) {
+  // Keep the two keys in their own lookups. An OR across the joined tables makes SQLite scan every task.
+  // Exclude the arc from the second arm even if a malformed record names itself as its subtask.
   const rows = board.db.prepare(`SELECT t.branch_name, t.workspace_kind, c.workspace_anchor FROM tasks t JOIN supercode_cards c ON c.task_id=t.id
-    WHERE (t.id=? OR c.subtask_of=?) AND t.status != 'cancelled' AND t.workspace_kind IN ('worktree','dir') AND t.branch_name IS NOT NULL`).all(id, id);
+    WHERE t.id=? AND t.status != 'cancelled' AND t.workspace_kind IN ('worktree','dir') AND t.branch_name IS NOT NULL
+    UNION ALL SELECT t.branch_name, t.workspace_kind, c.workspace_anchor FROM supercode_cards c JOIN tasks t ON t.id=c.task_id
+    WHERE c.subtask_of=? AND t.id!=? AND t.status != 'cancelled' AND t.workspace_kind IN ('worktree','dir') AND t.branch_name IS NOT NULL`).all(id, id, id);
   const out = [];
   for (const row of rows) {
     if (!row.workspace_anchor || /^(\/|~|[A-Za-z]:[\\/])/.test(row.workspace_anchor)) continue;
@@ -374,7 +378,9 @@ async function commitTime({ url, head }) {
  * a review request naming that head, before the next request. A head is reviewed once. */
 export function judgedHead(board, id, head) {
   if (!head) return null;
-  return board.db.prepare(`SELECT v.id, v.kind FROM task_events r JOIN task_events v ON v.task_id = r.task_id
+  // A request's JSON head list is checked once before visiting its verdicts. Without CROSS JOIN SQLite starts
+  // from every verdict and reparses the same older requests for each of them (including heads never requested).
+  return board.db.prepare(`SELECT v.id, v.kind FROM task_events r CROSS JOIN task_events v ON v.task_id = r.task_id
     AND v.kind IN ('changes_requested', 'review_pass') AND v.id > r.id
     AND v.id < COALESCE((SELECT MIN(n.id) FROM task_events n WHERE n.task_id = r.task_id AND n.kind = 'review_requested' AND n.id > r.id), 9223372036854775807)
     AND NOT EXISTS (SELECT 1 FROM task_events x WHERE x.task_id=r.task_id AND x.kind='review_voided' AND x.id>v.id AND json_extract(x.payload,'$.review_request')=r.id)

package/board/dispatch.mjs

@@ -300,7 +300,9 @@ const nativeKey = (machine, harness, sessionId) => `${normalMachine(machine)}\u0
 async function discoverNative(machine, harness, sessionId) {
   if (offlineMachine(machine)) throw unavailable(`native liveness unavailable: machine ${normalMachine(machine)} is offline`);
   // the machine's own harness door, this one's or another's, as every other harness read here is
-  const result = await doorOn(machine, 'harness.v1.sessions.discover', { harnesses: [harness], query: sessionId, limit: 2000 }, { timeout: NATIVE_DISCOVERY_MS });
+  // Liveness uses the native activity receipt, never transcript previews. A name miss can match many retained
+  // rows; opening every one for its messages delays the board's liveness decision for data it never reads.
+  const result = await doorOn(machine, 'harness.v1.sessions.discover', { harnesses: [harness], query: sessionId, limit: 2000, include_latest_candidates: false }, { timeout: NATIVE_DISCOVERY_MS });
   const page = result.code === 0 ? lastJson(result.stdout) : null;
   if (!Array.isArray(page?.sessions)) throw unavailable(`native liveness unavailable on ${machine}: ${(result.stderr || result.stdout).trim().slice(-300)}`);
   // whole: every source read, nothing truncated, from an index that keeps every session's own row (subscriberGone)

package/board/store.mjs

@@ -237,6 +237,25 @@ function layOutSummaryIndex(db) {
   }
 }
 
+// Human card reads ask for insertion order. The older task/timestamp and task/kind indexes filter the card but
+// sort its whole history (payloads included) on the owner's thread. Keep those indexes for their other queries;
+// these carry only the card key and row id. Report each one-time creation before it holds the connection.
+function layOutHistoryIndexes(db) {
+  for (const [table, index] of [['task_events', 'idx_events_task_id'], ['task_comments', 'idx_comments_task_id'], ['task_runs', 'idx_runs_task_id']]) {
+    if (indexed(db, index)) continue;
+    const report = text => { writeSync(2, text); if (current().kind === 'caller') current().err(text); };
+    report(`board: creating index ${index}: one-time history scan and index write on the owner connection\n`);
+    const began = performance.now();
+    let made = false;
+    try { db.exec(`CREATE INDEX IF NOT EXISTS ${index} ON ${table}(task_id, id)`); made = true; }
+    finally {
+      const ms = performance.now() - began;
+      noteStep(`board open index ${index}`, ms);
+      report(`board: index ${index} ${made ? 'created' : 'creation failed'} after ${Math.round(ms)} ms\n`);
+    }
+  }
+}
+
 /** Hermes's tables on a fresh board, supercode's own table and columns on every one. */
 export function layOut(db, { fresh }) {
   if (fresh) db.exec(SCHEMA);
@@ -249,6 +268,7 @@ export function layOut(db, { fresh }) {
   // any statement is prepared; no statement names it, so a store without it is only slower.
   db.exec('CREATE INDEX IF NOT EXISTS idx_supercode_cards_subtask_of ON supercode_cards(subtask_of)');
   layOutEventIndex(db);
+  layOutHistoryIndexes(db);
   // A covering summary index keeps human listings out of task records' body overflow pages.
   layOutSummaryIndex(db);
   // The calling session's run (CALLER_RUN_ADDRESS) and its cards (SESSION_CURRENT_RUNS, SESSION_BOUND, SESSION_RUNS):

package/board/workflow.mjs

@@ -383,33 +383,36 @@ function timeOf(db, task) {
 function askedOf(id) { return mailboxAnswers.get(id)?.askedOf ?? null; }
 
 /** The scope an expression is evaluated in: the card (with its relations), the event, params, time, extras. */
-export function scopeOf(db, board, task, { params, event = {}, extra = {} } = {}) {
+export function scopeOf(db, board, task, { params, event = {}, extra = {}, lazy = false } = {}) {
+  // Only read-only guards opt into demand reads. Mutation scopes materialize before any write,
+  // keeping `before` and run-history fields pinned to their original snapshot.
+  const once = (read) => { let done = false, value; return () => { if (!done) { value = read(); done = true; } return value; }; };
   const status = statusOf(db, task);
   // a related card's status is the workflow's, as the card's own is (`stored_as`: what kanban.db holds)
   const related = 'COALESCE(c.stage, t.status) AS status, t.status AS stored_as';
-  const parents = all(db, `SELECT t.id, ${related}, t.title FROM tasks t JOIN task_links l ON l.parent_id = t.id LEFT JOIN supercode_cards c ON c.task_id = t.id WHERE l.child_id = ?`, task.id);
-  const children = all(db, `SELECT t.id, ${related} FROM tasks t JOIN task_links l ON l.child_id = t.id LEFT JOIN supercode_cards c ON c.task_id = t.id WHERE l.parent_id = ?`, task.id);
-  const lastRun = one(db, 'SELECT * FROM task_runs WHERE task_id = ? AND ended_at IS NOT NULL ORDER BY ended_at DESC, id DESC LIMIT 1', task.id);
-  const lastCompleted = one(db, "SELECT * FROM task_runs WHERE task_id = ? AND outcome = 'completed' ORDER BY ended_at DESC LIMIT 1", task.id);
-  const asked = json(one(db, "SELECT payload FROM task_events WHERE task_id = ? AND kind = 'review_requested' ORDER BY id DESC LIMIT 1", task.id)?.payload, {}) ?? {};
-  const changes = json(one(db, "SELECT payload FROM task_events WHERE task_id = ? AND kind = 'changes_requested' ORDER BY id DESC LIMIT 1", task.id)?.payload, {}) ?? {};
-  const interruption = json(one(db, `SELECT payload FROM task_events WHERE task_id = ? AND kind IN ('blocked', 'block_loop_detected', 'dependency_wait', 'gave_up',
+  const parents = once(() => all(db, `SELECT t.id, ${related}, t.title FROM tasks t JOIN task_links l ON l.parent_id = t.id LEFT JOIN supercode_cards c ON c.task_id = t.id WHERE l.child_id = ?`, task.id));
+  const children = once(() => all(db, `SELECT t.id, ${related} FROM tasks t JOIN task_links l ON l.child_id = t.id LEFT JOIN supercode_cards c ON c.task_id = t.id WHERE l.parent_id = ?`, task.id));
+  const lastRun = once(() => one(db, 'SELECT * FROM task_runs WHERE task_id = ? AND ended_at IS NOT NULL ORDER BY ended_at DESC, id DESC LIMIT 1', task.id));
+  const lastCompleted = once(() => one(db, "SELECT * FROM task_runs WHERE task_id = ? AND outcome = 'completed' ORDER BY ended_at DESC LIMIT 1", task.id));
+  const asked = once(() => json(one(db, "SELECT payload FROM task_events WHERE task_id = ? AND kind = 'review_requested' ORDER BY id DESC LIMIT 1", task.id)?.payload, {}) ?? {});
+  const changes = once(() => json(one(db, "SELECT payload FROM task_events WHERE task_id = ? AND kind = 'changes_requested' ORDER BY id DESC LIMIT 1", task.id)?.payload, {}) ?? {});
+  const interruption = once(() => json(one(db, `SELECT payload FROM task_events WHERE task_id = ? AND kind IN ('blocked', 'block_loop_detected', 'dependency_wait', 'gave_up',
     'unblocked', 'changes_requested', 'review_reopened', 'status', 'reclaimed', 'stale', 'timed_out', 'crashed', 'spawn_failed', 'rate_limited', 'session_lost')
-    ORDER BY id DESC LIMIT 1`, task.id)?.payload, {}) ?? {};
-  const lastBlock = one(db, "SELECT kind, payload FROM task_events WHERE task_id = ? AND kind IN ('blocked', 'unblocked', 'dependency_wait') ORDER BY id DESC LIMIT 1", task.id);
-  const waitingOn = lastBlock?.kind === 'blocked' ? json(lastBlock.payload, {})?.waiting_on ?? null : null;
-  const currentRun = task.current_run_id ? one(db, 'SELECT metadata FROM task_runs WHERE id = ?', task.current_run_id) : null;
-  const session = json(currentRun?.metadata, {})?.supercode ?? {};
+    ORDER BY id DESC LIMIT 1`, task.id)?.payload, {}) ?? {});
+  const lastBlock = once(() => one(db, "SELECT kind, payload FROM task_events WHERE task_id = ? AND kind IN ('blocked', 'unblocked', 'dependency_wait') ORDER BY id DESC LIMIT 1", task.id));
+  const waitingOn = once(() => lastBlock()?.kind === 'blocked' ? json(lastBlock().payload, {})?.waiting_on ?? null : null);
+  const currentRun = once(() => task.current_run_id ? one(db, 'SELECT metadata FROM task_runs WHERE id = ?', task.current_run_id) : null);
+  const session = once(() => json(currentRun()?.metadata, {})?.supercode ?? {});
   const state = one(db, 'SELECT * FROM supercode_cards WHERE task_id = ?', task.id) ?? {};
   const blocks = json(state.blocked_by, []) ?? [];
   const card = {
     ...task,
-    creator_address: creatorOf(db, task.id),
-    completion_owner_address: completionOwnerOf(db, task.id),
-    latest_review: latestReview(db, task.id) ?? {},
-    review_candidate: reviewCandidate(board, task.id) ?? {},
+    get creator_address() { return creatorOf(db, task.id); },
+    get completion_owner_address() { return completionOwnerOf(db, task.id); },
+    get latest_review() { return latestReview(db, task.id) ?? {}; },
+    get review_candidate() { return reviewCandidate(board, task.id) ?? {}; },
     ci: completionEvidence(board, task.id),
-    dispatch_hold: one(db, "SELECT kind FROM task_events WHERE task_id=? AND kind IN ('dispatch_held','dispatch_released','session_adopted') ORDER BY id DESC LIMIT 1", task.id)?.kind === 'dispatch_held',
+    get dispatch_hold() { return one(db, "SELECT kind FROM task_events WHERE task_id=? AND kind IN ('dispatch_held','dispatch_released','session_adopted') ORDER BY id DESC LIMIT 1", task.id)?.kind === 'dispatch_held'; },
     status,
     blocked_by: blocks,
     paused: json(state.paused, null),
@@ -419,8 +422,8 @@ export function scopeOf(db, board, task, { params, event = {}, extra = {} } = {}
 
     stored_as: task.status,
     board: board.slug,
-    parents,
-    children,
+    get parents() { return parents(); },
+    get children() { return children(); },
     acceptance_complete: () => {
       const lines = String(task.body ?? '').split('\n');
       let acceptance = false;
@@ -431,33 +434,38 @@ export function scopeOf(db, board, task, { params, event = {}, extra = {} } = {}
         return /^\s*[-*] \[[xX]\] .+: \S.+$/.test(line);
       });
     },
-    counters: { failures: Number(task.consecutive_failures || 0), block_recurrences: Number(task.block_recurrences || 0), goal_turns: Number(session.goal_turns || 0) },
+    get counters() { return { failures: Number(task.consecutive_failures || 0), block_recurrences: Number(task.block_recurrences || 0), goal_turns: Number(session().goal_turns || 0) }; },
     goal_mode: Boolean(task.goal_mode),
-    implementer: asked.implementer ?? task.assignee,
-    last_reviewer: changes.reviewer ?? null,
-    arc: task.subtask_of ? one(db, `SELECT t.id, ${related}, t.title, t.body, t.assignee FROM tasks t LEFT JOIN supercode_cards c ON c.task_id = t.id WHERE t.id = ?`, task.subtask_of) ?? null : null,
+    get implementer() { return asked().implementer ?? task.assignee; },
+    get last_reviewer() { return changes().reviewer ?? null; },
+    get arc() { return task.subtask_of ? one(db, `SELECT t.id, ${related}, t.title, t.body, t.assignee FROM tasks t LEFT JOIN supercode_cards c ON c.task_id = t.id WHERE t.id = ?`, task.subtask_of) ?? null : null; },
     // the cards filed as its subtasks (`create --subtask-of`), in the order they were filed
-    subtasks: all(db, `SELECT t.id, ${related}, t.title, t.assignee FROM tasks t JOIN supercode_cards c ON c.task_id = t.id WHERE c.subtask_of = ? ORDER BY t.created_at`, task.id),
-    queue_reason: json(one(db, "SELECT payload FROM task_events WHERE task_id = ? AND kind = 'respawn_guarded' AND created_at >= ? ORDER BY id DESC LIMIT 1",
-      task.id, Number(one(db, 'SELECT since FROM supercode_cards WHERE task_id = ?', task.id)?.since ?? 0))?.payload, {})?.reason ?? null,
+    get subtasks() { return all(db, `SELECT t.id, ${related}, t.title, t.assignee FROM tasks t JOIN supercode_cards c ON c.task_id = t.id WHERE c.subtask_of = ? ORDER BY t.created_at`, task.id); },
+    get queue_reason() { return json(one(db, "SELECT payload FROM task_events WHERE task_id = ? AND kind = 'respawn_guarded' AND created_at >= ? ORDER BY id DESC LIMIT 1",
+      task.id, Number(one(db, 'SELECT since FROM supercode_cards WHERE task_id = ?', task.id)?.since ?? 0))?.payload, {})?.reason ?? null; },
     // the message whose answer the standing block waits for (`block --waiting-on`), and that answer's id once it has landed
-    waiting_on: waitingOn,
-    answer: () => answerTo(waitingOn),
+    get waiting_on() { return waitingOn(); },
+    answer: () => answerTo(waitingOn()),
     // the seconds its runs spent, by the role each run was for (implementer: coding, reviewer: reviewing, …), an open
     // run counted to now; `waiting` is the rest of its life since it was filed
-    time: timeOf(db, task),
+    get time() { return timeOf(db, task); },
     // whether an edit of its text only ticks outcome lines (the card's own session's door to its acceptance)
     only_ticks: (body) => onlyTicks(task.body, body),
-    asked_of: () => askedOf(waitingOn),
-    last_block_event: one(db, "SELECT kind FROM task_events WHERE task_id = ? AND kind IN ('blocked', 'unblocked') ORDER BY id DESC LIMIT 1", task.id)?.kind ?? null,
+    asked_of: () => askedOf(waitingOn()),
+    get last_block_event() { return one(db, "SELECT kind FROM task_events WHERE task_id = ? AND kind IN ('blocked', 'unblocked') ORDER BY id DESC LIMIT 1", task.id)?.kind ?? null; },
     // where the latest interruption says the card resumes (any status the workflow declares); none recorded: null
-    resume_status: interruption.resume_status ?? interruption.retry_status ?? interruption.source_status ?? null,
-    last_run: lastRun ?? {},
-    last_completed: lastCompleted ?? null,
+    get resume_status() { const value = interruption(); return value.resume_status ?? value.retry_status ?? value.source_status ?? null; },
+    get last_run() { return lastRun() ?? {}; },
+    get last_completed() { return lastCompleted() ?? null; },
     events_since: (t, kinds = []) => all(db, `SELECT kind FROM task_events WHERE task_id = ? AND created_at >= ?${kinds.length ? ` AND kind IN (${kinds.map(() => '?').join(', ')})` : ''}`, task.id, t, ...kinds),
     // the latest event of each kind on the card: kind → { created_at, payload }
-    last_events: Object.fromEntries(all(db, 'SELECT e.id, e.kind, e.created_at, e.payload FROM task_events e JOIN (SELECT kind, MAX(id) AS id FROM task_events WHERE task_id = ? GROUP BY kind) l ON l.id = e.id', task.id)
-      .map((r) => [r.kind, { id: r.id, created_at: r.created_at, payload: json(r.payload, {}) ?? {} }])),
+    get last_events() {
+      const events = Object.fromEntries(all(db, 'SELECT e.id, e.kind, e.created_at, e.payload FROM task_events e JOIN (SELECT kind, MAX(id) AS id FROM task_events WHERE task_id = ? GROUP BY kind) l ON l.id = e.id', task.id)
+      .map((r) => [r.kind, { id: r.id, created_at: r.created_at, payload: json(r.payload, {}) ?? {} }]));
+      const runMeta = json(currentRun()?.metadata, {}) ?? {};
+      for (const e of [...Object.values(runMeta.last_events ?? {}), ...(runMeta.events ?? [])]) events[e.kind] = { created_at: e.at, payload: e.payload ?? {} };
+      return events;
+    },
     comments_since: (t) => all(db, 'SELECT author, body, created_at FROM task_comments WHERE task_id = ? AND created_at >= ?', task.id, t),
     // the latest commit naming this card on its work branches and default branch, in its workspace's repository (a
     // subtask's: its arc's), as epoch seconds
@@ -467,9 +475,21 @@ export function scopeOf(db, board, task, { params, event = {}, extra = {} } = {}
       return lastCommitAt(own ?? arcWs ?? null, task.id);
     },
   };
-  const runMeta = json(currentRun?.metadata, {}) ?? {};
-  for (const e of [...Object.values(runMeta.last_events ?? {}), ...(runMeta.events ?? [])]) card.last_events[e.kind] = { created_at: e.at, payload: e.payload ?? {} };
-  for (const [key, expr] of Object.entries(loaded.get(board.root)?.workflow?.derived ?? {})) card[key] = evaluate(expr, { card, event, params, now: now() });
+  // Cache each field for this scope only. Never share a history snapshot between calls or writes.
+  for (const [key, property] of Object.entries(Object.getOwnPropertyDescriptors(card))) {
+    if (!property.get) continue;
+    const read = () => {
+      const value = property.get.call(card);
+      Object.defineProperty(card, key, { value, writable: true, enumerable: true, configurable: true });
+      return value;
+    };
+    Object.defineProperty(card, key, { get: read, enumerable: true, configurable: true });
+    if (!lazy) read();
+  }
+  for (const [key, expr] of Object.entries(loaded.get(board.root)?.workflow?.derived ?? {})) {
+    const value = evaluate(expr, { card, event, params, now: now() });
+    Object.defineProperty(card, key, { value, writable: true, enumerable: true, configurable: true });
+  }
   return {
     card,
     requester: actorOf(),
@@ -694,10 +714,17 @@ export function settle(db, board, entry, id, effects = []) {
   for (let hops = 0; hops < 16; hops += 1) {
     const task = cardOf(db, id);
     const from = statusOf(db, task);
-    const scope = scopeOf(db, board, task, { params, extra: { lanes: lanesIn(entry) } });
-    let t = (workflow.statuses[from]?.always ?? []).find((x) => holds(x.guard ?? null, scope));
+    const state = workflow.statuses[from];
+    // An unchanged card with no automatic/timed moves needs no history scope at all. The organization's five
+    // statuses have none, but recomputeReady used to read every history field on every unsettled card anyway.
+    if (!state?.always?.length && !state?.after?.length) { projectStatus(db, board, entry, id); return effects; }
+    // Timed moves may record their fired marker in dueAfter: pin their scope before that write. Other guards
+    // remain read-only until a transition is selected, then capture every `before` field before take mutates it.
+    const scope = scopeOf(db, board, task, { params, lazy: !state?.after?.length, extra: { lanes: lanesIn(entry) } });
+    let t = (state?.always ?? []).find((x) => holds(x.guard ?? null, scope));
     if (!t) t = dueAfter(db, workflow, task, from, scope);
     if (!t) { projectStatus(db, board, entry, id); return effects; }
+    Object.values(scope.card);
     const to = take(db, board, entry, task, from, t, scope, effects);
     if (to === from) return effects;
   }
@@ -1225,7 +1252,7 @@ export function fireRun(db, board, entry, id, name, { roles = [], payload = {},
 
 function relationActive(db, board, entry, task) {
   const policy = entry.workflow.relations?.blocked_by;
-  return Boolean(policy) && holds(policy.guard ?? null, scopeOf(db, board, task, { params: entry.params }));
+  return Boolean(policy) && holds(policy.guard ?? null, scopeOf(db, board, task, { params: entry.params, lazy: true }));
 }
 function settleRelations(db, board, entry, id, effects) {
   if (!relationActive(db, board, entry, cardOf(db, id))) return;
@@ -1266,7 +1293,7 @@ export function storedStatus(db, board, entry, id) {
   const task = cardOf(db, id);
   const status = statusOf(db, task);
   if (!entry.workflow.stored_as?.length) return { status, stored: task.status };
-  const scope = scopeOf(db, board, task, { params: entry.params });
+  const scope = scopeOf(db, board, task, { params: entry.params, lazy: true });
   const rule = entry.workflow.stored_as.find((r) => holds(r.guard, scope));
   return { status, stored: rule?.status ?? storedAs(entry.workflow, status) };
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@volter/supercode-orchestrator",
-  "version": "0.5.197",
+  "version": "0.5.198",
   "type": "module",
   "description": "The orchestrator runtime over the Volter Harness ontology: one typed operational model whose folder is its serialization, read and written through the harness orchestration doors (docs/ORCHESTRATOR-IR.md)",
   "exports": {
@@ -28,7 +28,7 @@
     "check-types": "node scripts/generate-types.mjs --check"
   },
   "dependencies": {
-    "@volter/supercode-teams": "^0.3.329",
+    "@volter/supercode-teams": "^0.3.330",
     "@volter/supercode-terminal": "^0.3.8",
     "@volter/supercode-harness-sdk": "^0.3.101",
     "@volter/teams": "0.2.91",