@volter/supercode-orchestrator 0.5.158 → 0.5.159

package/board/cli.mjs

@@ -26,7 +26,7 @@ import * as slowLog from '@volter/supercode-harness-sdk/slow-log';
 import { basename, dirname, join, resolve } from 'node:path';
 import { fileURLToPath } from 'node:url';
 import { homedir, tmpdir, userInfo } from 'node:os';
-import { actorOf, heldConfigWatched, heldDocumentsChanged, heldDocumentsWatched, holdBoards, retireHeldBoards, releaseHeldBoards, publishMarked, view, backingPaths, layOut, backingOf, boardExists, boardPath, briefPath, DEFAULT_BOARD, event, json, listBoards, logsDir, now, openBoard, setActor, setPrincipal, principalOf, isCaller, tx } from './store.mjs';
+import { actorOf, CALLER_RUN_ADDRESS, heldConfigWatched, heldDocumentsChanged, heldDocumentsWatched, holdBoards, retireHeldBoards, releaseHeldBoards, publishMarked, view, backingPaths, layOut, backingOf, boardExists, boardPath, briefPath, DEFAULT_BOARD, event, json, listBoards, logsDir, now, openBoard, setActor, setPrincipal, principalOf, isCaller, tx } from './store.mjs';
 import { isLocalWorkspace } from './workspace.mjs';
 import { openZtrackBoard } from './ztrack.mjs';
 import * as engine from './engine.mjs';
@@ -357,7 +357,7 @@ export async function runVerb(argv) {
   await readAgentMains(root);
   const sid = listing && !args.mine ? null : callerSession();
   // what this command records is the calling session's act (its address, as its subscriptions name it)
-  current().recorded = sid && boardExists(root, slug) ? withBoard((b) => b.db.prepare("SELECT json_extract(metadata, '$.supercode.address') AS address FROM task_runs WHERE json_extract(metadata, '$.supercode.session_id') = ? ORDER BY id DESC LIMIT 1").get(sid)?.address) ?? null : null;
+  current().recorded = sid && boardExists(root, slug) ? withBoard((b) => b.db.prepare(CALLER_RUN_ADDRESS).get(sid)?.address) ?? null : null;
   if (sid) setActor(callerAddress());
   setPrincipal(await callerPrincipal(root, sid, { teams: !sid && !READS.has(verb) }));
   // the dispatcher as the owner holds it, said once per call (owner-health.mjs; nothing is read for it)

package/board/store.mjs

@@ -143,6 +143,14 @@ export function listBoards(root) {
   return out;
 }
 
+// The run a session's own verb is recorded against, by the session the dispatcher wrote in the run's metadata: asked on
+// every verb a session runs (cli.mjs). The lookup and its index are written from the same two expressions, because
+// SQLite uses an expression index only for a statement that writes the expression the same way.
+const RUN_SESSION = "json_extract(metadata, '$.supercode.session_id')";
+const RUN_ADDRESS = "json_extract(metadata, '$.supercode.address')";
+export const CALLER_RUN_ADDRESS = `SELECT ${RUN_ADDRESS} AS address FROM task_runs WHERE ${RUN_SESSION} = ? ORDER BY id DESC LIMIT 1`;
+const RUN_SESSION_INDEX = 'idx_runs_supercode_session';
+
 /** Hermes's tables on a fresh board, supercode's own table and columns on every one. */
 export function layOut(db, { fresh }) {
   if (fresh) db.exec(SCHEMA);
@@ -154,6 +162,24 @@ export function layOut(db, { fresh }) {
   // each read walked every card's row. Laid out here, after the column it names exists on a store of any age and before
   // any statement is prepared; no statement names it, so a store without it is only slower.
   db.exec('CREATE INDEX IF NOT EXISTS idx_supercode_cards_subtask_of ON supercode_cards(subtask_of)');
+  // The calling session's run (CALLER_RUN_ADDRESS): without this index each lookup read every run's whole metadata,
+  // overflow pages included. `id` keeps a session's runs in the order the lookup asks for, and the address makes the
+  // index answer the lookup without reading the run. No statement names it, so a store without it is only slower, and a
+  // release that does not know it keeps it current like any other index. Its first creation reads `task_runs` once.
+  // A run whose metadata SQLite cannot read as JSON refuses the creation: the board opens without the index, says which
+  // rows to look for, and tries again on its next open. Once the index is there, SQLite refuses a write of such
+  // metadata to a run.
+  if (db.prepare("SELECT 1 FROM sqlite_master WHERE type = 'table' AND name = 'task_runs'").get()) {
+    try { db.exec(`CREATE INDEX IF NOT EXISTS ${RUN_SESSION_INDEX} ON task_runs(${RUN_SESSION}, id, ${RUN_ADDRESS})`); }
+    catch (error) {
+      if (contention(error)) throw error;
+      const said = current().said;
+      if (!said.has(RUN_SESSION_INDEX)) {
+        said.add(RUN_SESSION_INDEX);
+        current().err(`board: warning: index ${RUN_SESSION_INDEX} on task_runs was not created (${error.message}); the board is open without it and each session's verb reads every run. The runs that refuse it: SELECT id FROM task_runs WHERE metadata IS NOT NULL AND NOT json_valid(metadata, 6)\n`);
+      }
+    }
+  }
   const effectColumns = new Set(db.prepare('PRAGMA table_info(supercode_effects)').all().map((c) => c.name));
   for (const [column, type] of Object.entries(EFFECT_COLUMNS)) if (!effectColumns.has(column)) db.exec(`ALTER TABLE supercode_effects ADD COLUMN ${column} ${type}`);
   // what changed is marked by the store itself, whoever writes it (published.mjs)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@volter/supercode-orchestrator",
-  "version": "0.5.158",
+  "version": "0.5.159",
   "type": "module",
   "description": "The orchestrator runtime over the Volter Harness ontology: one typed operational model whose folder is its serialization, read and written through the harness orchestration doors (docs/ORCHESTRATOR-IR.md)",
   "exports": {