@volter/supercode-orchestrator 0.5.134 → 0.5.136

package/board/dispatch.mjs

@@ -2895,6 +2895,11 @@ function noCodeReviewDue(board, id) {
   });
 }
 
+/** Whether the arc's last review event is a pass: its review is over, and neither requested, returned nor voided since. */
+function passedReview(board, id) {
+  return view(board, (db) => db.prepare("SELECT kind FROM task_events WHERE task_id = ? AND kind IN ('review_requested', 'changes_requested', 'review_pass','review_voided') ORDER BY id DESC LIMIT 1").get(id)?.kind === 'review_pass');
+}
+
 /** Whether a card body ticks some outcome under its Acceptance heading. */
 function outcomeTicked(body) {
   let acceptance = false;
@@ -2947,7 +2952,10 @@ async function activatePullRequestReviews(board, entry, report, effects, { only
       // requested the next run is the implementer's, until a new head is pushed.
       // An arc that closed its tasks having changed no code gets its one review of the act itself (ADR 0003).
       if (!payload && noCodeReviewDue(board, id)) payload = await noCodeChange(board, id);
-      if (!payload) { report.queued.push([id, 'review waits: no open or unjudged merged PR on its declared branches, and no completed disposition']); continue; }
+      // An arc whose last verdict is a pass, with nothing unjudged since, waits on no review: what is left is its
+      // session's done request and the manager's or creator's `complete`, and the round says that (volter-org
+      // t_b499d0cf and t_a2bd2a5f were logged as waiting for a review every round for hours after theirs passed).
+      if (!payload) { report.queued.push([id, passedReview(board, id) ? 'its review passed and no PR head is unjudged since: no review is due; the arc waits on `complete`' : 'review waits: no open or unjudged merged PR on its declared branches, and no completed disposition']); continue; }
       if (payload.waits) { report.queued.push([id, `review waits: ${payload.waits}`]); payload = null; continue; }
       if (!payload.no_code && !await reviewDue(board, id, payload.pr.map((url, index) => ({ url, head: payload.pr_head[index] })))) {
         report.queued.push([id, `review waits: every open PR head (${payload.pr.join(', ')}) has a verdict or predates the last one; push a commit that answers it`]);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@volter/supercode-orchestrator",
-  "version": "0.5.134",
+  "version": "0.5.136",
   "type": "module",
   "description": "The orchestrator runtime over the Volter Harness ontology: one typed operational model whose folder is its serialization, read and written through the harness orchestration doors (docs/ORCHESTRATOR-IR.md)",
   "exports": {
@@ -24,8 +24,8 @@
     "check-types": "node scripts/generate-types.mjs --check"
   },
   "dependencies": {
-    "@volter/supercode-harness-sdk": "^0.3.89",
-    "@volter/teams": "0.2.52",
+    "@volter/supercode-harness-sdk": "^0.3.90",
+    "@volter/teams": "0.2.53",
     "@volter/ztrack": "^2.4.23",
     "yaml": "^2.9.0"
   },