@volter/supercode-orchestrator 0.5.132 → 0.5.133

package/board/ci.mjs

@@ -333,22 +333,27 @@ async function knownRepositories() {
 
 /** Whether the arc's open PRs (`[{ url, head }]`) call for its review: some head no verdict judged that is new work.
  *  Before any verdict every unjudged head is. After a verdict, a PR it judged with a new head is, and so is a head
- *  committed after that verdict (a new PR carrying the fixes, or any PR after a verdict that named none). A PR that
- *  joins with a head committed before the verdict is not: after changes are requested the next run is the
- *  implementer's until it pushes. */
+ *  committed after that verdict (a new PR carrying the fixes, or any PR after a verdict that named none). After changes
+ *  are requested, a PR that joins with a head committed before the verdict is not: the next run is the implementer's
+ *  until it pushes. After a pass nothing is owed by the implementer, so a PR that verdict's request did not name is due
+ *  at whatever head it has: one that was a draft or stacked on another PR's branch when the request was made, and
+ *  became the arc's once that PR merged (t_bbbd2086's #1355, committed 2 h before the pass that named only #1353). */
 export async function reviewDue(board, id, prs) {
   const unjudged = prs.filter((p) => !judgedHead(board, id, p.head));
   if (!unjudged.length) return false;
   const voided = board.db.prepare("SELECT r.payload FROM task_events v JOIN task_events r ON r.id=json_extract(v.payload,'$.review_request') AND r.task_id=v.task_id WHERE v.task_id=? AND v.kind='review_voided' ORDER BY v.id DESC LIMIT 1").get(id);
   if (candidatePullRequests(voided && JSON.parse(voided.payload)?.ci).some(j => unjudged.some(p => p.url === j.pr.url && p.head === j.commit))) return true;
   const last = board.db.prepare(`SELECT r.payload, (SELECT MIN(v.created_at) FROM task_events v WHERE v.task_id = r.task_id
-      AND v.kind IN ('changes_requested', 'review_pass') AND v.id > r.id) AS verdict_at
+      AND v.kind IN ('changes_requested', 'review_pass') AND v.id > r.id) AS verdict_at,
+      (SELECT v.kind FROM task_events v WHERE v.task_id = r.task_id
+      AND v.kind IN ('changes_requested', 'review_pass') AND v.id > r.id ORDER BY v.id LIMIT 1) AS verdict
     FROM task_events r WHERE r.task_id = ? AND r.kind = 'review_requested'
     AND EXISTS (SELECT 1 FROM task_events v WHERE v.task_id = r.task_id AND v.kind IN ('changes_requested', 'review_pass') AND v.id > r.id)
     ORDER BY r.id DESC LIMIT 1`).get(id);
   if (!last) return true;
   const judged = candidatePullRequests(JSON.parse(last.payload)?.ci);
   if (judged.some((j) => prs.some((p) => p.url === j.pr.url && p.head !== j.commit))) return true;
+  if (last.verdict === 'review_pass' && unjudged.some((p) => !judged.some((j) => j.pr.url === p.url))) return true;
   for (const p of unjudged) if (((await commitTime(p)) ?? 0) > Number(last.verdict_at)) return true;
   return false;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@volter/supercode-orchestrator",
-  "version": "0.5.132",
+  "version": "0.5.133",
   "type": "module",
   "description": "The orchestrator runtime over the Volter Harness ontology: one typed operational model whose folder is its serialization, read and written through the harness orchestration doors (docs/ORCHESTRATOR-IR.md)",
   "exports": {