@volter/supercode-orchestrator 0.4.147 → 0.4.149

package/hermes-locks.mjs

@@ -13,7 +13,7 @@ import { spawn, spawnSync } from 'node:child_process';
 import { createHash } from 'node:crypto';
 import { closeSync, existsSync, mkdirSync, openSync, readFileSync, renameSync, rmSync, unlinkSync, writeSync } from 'node:fs';
 import { homedir } from 'node:os';
-import { dirname, join, resolve } from 'node:path';
+import { join, resolve } from 'node:path';
 
 /** Hermes's gateway kind, the `kind` of every record it writes. */
 export const GATEWAY_KIND = 'hermes-gateway';
@@ -143,25 +143,6 @@ export function holdGatewayLock(home, { python = 'python3' } = {}) {
   return holdFileLock(join(resolve(home), 'gateway.lock'), home, { python, what: `${resolve(home)} is served by`, tail: 'one runtime serves a home at a time' });
 }
 
-/**
- * Hold the board's one dispatcher lock, `<root>/kanban/.dispatcher.lock` (Hermes's
- * `_acquire_singleton_lock`, which every Hermes gateway takes before it dispatches). Resolves
- * `{ release }`; rejects, naming the holder, when another dispatcher holds it.
- */
-export function holdDispatcherLock(root, { python = 'python3' } = {}) {
-  const path = join(resolve(root), 'kanban', '.dispatcher.lock');
-  mkdirSync(join(resolve(root), 'kanban'), { recursive: true });
-  return holdFileLock(path, root, { python, what: `the board at ${resolve(root)} is dispatched by`, tail: 'one dispatcher serves a board' });
-}
-
-/**
- * Hold one board's per-tick lock, `<kanban.db>.dispatch.lock` (Hermes's `_dispatch_tick_lock`), for one tick: a
- * one-shot `dispatch` never ticks a board beside another dispatcher. Rejects, naming the holder, when it is held.
- */
-export function holdBoardTickLock(dbPath, { python = 'python3' } = {}) {
-  return holdFileLock(`${dbPath}.dispatch.lock`, dirname(dbPath), { python, what: `the board ${dbPath} is being ticked by`, tail: 'one tick at a time' });
-}
-
 function holdFileLock(path, home, { python, what, tail }) {
   return new Promise((done, fail) => {
     let child;

package/mcp/hermes-kanban-tools.json

@@ -102,11 +102,19 @@
         },
         "commit": {
           "type": "string",
-          "description": "Exact commit deployed by the CI run."
+          "description": "Exact pushed branch head for a subtask, or merged deployment commit for an arc."
         },
         "ci_run": {
           "type": "integer",
           "description": "GitHub Actions deployment run id for that exact commit."
+        },
+        "branch": {
+          "type": "string",
+          "description": "Pushed worktree branch for source completion."
+        },
+        "reviewed_sha": {
+          "type": "string",
+          "description": "The full PR head SHA this reviewer ran, matching the recorded request."
         }
       },
       "required": []
@@ -146,7 +154,7 @@
   },
   {
     "name": "kanban_request_review",
-    "description": "Hand the task off for review: implementation, self-review, and verification are complete and you want a human (or reviewer) to look before it is marked done. Moves the task to the 'review' column and notifies the subscriber. Unlike ``kanban_block`` this is NOT a blocker \u2014 it never counts toward unblock-loop detection, so a task can cycle through review across follow-ups without ever being falsely escalated to triage. Use this instead of blocking with a free-form 'review-required:' reason.",
+    "description": "Request independent review of the opened PR at its exact pushed head. The dispatcher starts the declared reviewer when the arc tasks are closed. Deployment CI is not a review gate.",
     "inputSchema": {
       "type": "object",
       "properties": {
@@ -173,11 +181,27 @@
         },
         "commit": {
           "type": "string",
-          "description": "Exact commit deployed by the CI run."
+          "description": "Exact pushed worktree branch head for independent review."
         },
-        "ci_run": {
-          "type": "integer",
-          "description": "GitHub Actions deployment run id for that exact commit."
+        "pr": {
+          "type": [
+            "string",
+            "array"
+          ],
+          "items": {
+            "type": "string"
+          },
+          "description": "Every opened PR the arc changed, one URL each (its own repository's and any other repository it changed)."
+        },
+        "pr_head": {
+          "type": [
+            "string",
+            "array"
+          ],
+          "items": {
+            "type": "string"
+          },
+          "description": "The full 40-character pushed head SHA of each PR, in the same order as pr."
         }
       },
       "required": [
@@ -345,10 +369,6 @@
     "inputSchema": {
       "type": "object",
       "properties": {
-        "review_only": {
-          "type": "boolean",
-          "description": "Declare a standalone independent review job, where permitted by the home's manager policy. Its verdict is accepted without another review of the review; implementation arcs keep their independent review requirement."
-        },
         "title": {
           "type": "string",
           "description": "Short task title (required)."
@@ -494,13 +514,21 @@
   },
   {
     "name": "kanban_request_state",
-    "description": "Request a manager decision on block, pause, done or cancelled through the home workflow. Includes its rules in manager mail and leaves card/run state unchanged.",
+    "description": "Request a manager decision on block, pause, done or cancelled for one or several task_ids through the home workflow. Nearby requests from the same session share one retained mail. Includes the home's rules and leaves card/run state unchanged.",
     "inputSchema": {
       "type": "object",
       "properties": {
         "task_id": {
           "type": "string"
         },
+        "task_ids": {
+          "type": "array",
+          "items": {
+            "type": "string"
+          },
+          "minItems": 1,
+          "description": "Cards whose state is requested together; each must be in your permitted scope."
+        },
         "state": {
           "type": "string",
           "enum": [
@@ -524,15 +552,49 @@
         },
         "commit": {
           "type": "string",
-          "description": "Exact commit deployed by the CI run."
+          "description": "Pushed branch head for a source verdict or subtask, or merged commit for final arc completion."
         },
         "ci_run": {
           "type": "integer",
-          "description": "GitHub Actions deployment run id for that exact commit."
+          "description": "Legacy receipt field; deployment is not a board completion requirement."
         },
         "deployed_sha": {
           "type": "string",
-          "description": "The deployed commit the independent reviewer actually inspected."
+          "description": "Legacy receipt field; deployment is not a board completion requirement."
+        },
+        "branch": {
+          "type": "string",
+          "description": "The pushed worktree branch the reviewer inspected."
+        },
+        "reviewed_sha": {
+          "type": [
+            "string",
+            "array"
+          ],
+          "items": {
+            "type": "string"
+          },
+          "description": "Every requested PR head this independent reviewer inspected (full SHAs)."
+        },
+        "pr": {
+          "type": [
+            "string",
+            "array"
+          ],
+          "items": {
+            "type": "string"
+          },
+          "description": "PR URLs, optional when using the recorded review candidate."
+        },
+        "pr_head": {
+          "type": [
+            "string",
+            "array"
+          ],
+          "items": {
+            "type": "string"
+          },
+          "description": "Full PR head SHAs; reviewers can use reviewed_sha instead."
         }
       },
       "required": [

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@volter/supercode-orchestrator",
-  "version": "0.4.147",
+  "version": "0.4.149",
   "type": "module",
   "description": "The orchestrator runtime over the Volter Harness ontology: one typed operational model whose folder is its serialization, read and written through the harness orchestration doors (docs/ORCHESTRATOR-IR.md)",
   "exports": {
@@ -25,7 +25,7 @@
   },
   "dependencies": {
     "@volter/supercode-harness-sdk": "^0.3.41",
-    "@volter/ztrack": "^2.4.19",
+    "@volter/ztrack": "^2.4.21",
     "yaml": "^2.9.0",
     "@volter/supercode-teams": "^0.2.145"
   },

package/board/rows.mjs

@@ -1,132 +0,0 @@
-// Normalized runtime rows. Card text remains in the document; this stores only runtime
-// tables, run fields and small indexing metadata. No application locks or snapshot rewrites.
-import { json } from './store.mjs';
-const quote = s => `"${s.replaceAll('"', '""')}"`;
-const RUNTIME = new Set(['claim_lock','claim_expires','worker_pid','last_heartbeat_at','current_run_id','consecutive_failures','last_failure_error','block_recurrences','session_id','workspace_path']);
-const OMIT = new Set(['tasks','supercode_cards','task_links','sqlite_sequence']);
-export class RuntimeRows {
-  constructor(db) { this.db=db; this.revision=null; this.tables=new Map(); this.runtime={}; this.clocks={}; this.sequences={}; this.cachedTasks={}; this.cachedCards={}; }
-  normalized() { return Boolean(this.db.prepare("SELECT 1 FROM sqlite_master WHERE type='table' AND name='runtime_rows'").get()); }
-  watch(mem) {
-    mem.exec('CREATE TEMP TABLE IF NOT EXISTS _runtime_dirty (name TEXT, key TEXT)');
-    for (const {name,sql} of mem.prepare("SELECT name,sql FROM sqlite_master WHERE type='table' AND name NOT LIKE 'sqlite_%'").all()) {
-      const columns=mem.prepare(`PRAGMA table_info(${quote(name)})`).all();
-      const keys=columns.filter(c=>c.pk).sort((a,b)=>a.pk-b.pk).map(c=>c.name);
-      if (!keys.length) keys.push('rowid');
-      this.tables.set(name,{name,sql,keys,columns});
-      const key=prefix=>`json_array(${keys.map(k=>`${prefix}.${quote(k)}`).join(',')})`;
-      for(const [suffix,verb,prefix] of [['i','INSERT','NEW'],['u','UPDATE','NEW'],['d','DELETE','OLD']])
-        mem.exec(`CREATE TEMP TRIGGER IF NOT EXISTS ${quote(`_runtime_${name}_${suffix}`)} AFTER ${verb} ON main.${quote(name)} BEGIN INSERT OR IGNORE INTO _runtime_dirty VALUES ('${name}',${key(prefix)}); END`);
-    }
-    mem.exec('DELETE FROM _runtime_dirty');
-  }
-  insert(mem,name,row,key=null) {
-    if(row===null) {
-      const table=this.tables.get(name);if(!table)return;
-      mem.prepare(`DELETE FROM ${quote(name)} WHERE ${table.keys.map(k=>`${quote(k)} IS ?`).join(' AND ')}`).run(...JSON.parse(key));return;
-    }
-    const keys=Object.keys(row);
-    mem.prepare(`INSERT OR REPLACE INTO ${quote(name)} (${keys.map(quote).join(',')}) VALUES (${keys.map(()=>'?').join(',')})`).run(...keys.map(k=>row[k]??null));
-  }
-  load(mem,{fresh=false}={}) {
-    if(!this.normalized())return false;
-    if(fresh) {
-      for(const row of this.db.prepare('SELECT name,sql FROM runtime_schema').all()) mem.exec(row.sql.replace('CREATE TABLE ','CREATE TABLE IF NOT EXISTS '));
-      this.watch(mem);
-    }
-    const query=this.revision===null?'SELECT * FROM runtime_rows':'SELECT * FROM runtime_rows WHERE revision>?';
-    const rows=this.revision===null?this.db.prepare(query).all():this.db.prepare(query).all(this.revision);
-    for(const row of rows) {
-      const value=json(row.value,null);
-      if(row.name==='@runtime') { if(value)this.runtime[row.key]=value;else delete this.runtime[row.key]; }
-      else if(row.name==='@clock') { if(value)this.clocks[row.key]=value;else delete this.clocks[row.key]; }
-      else if(row.name==='@sequence') { if(value)this.sequences[row.key]=value;else delete this.sequences[row.key]; }
-      else if(row.name==='@task_cache') { if(value)this.cachedTasks[row.key]=value;else delete this.cachedTasks[row.key]; }
-      else if(row.name==='@card_cache') { if(value)this.cachedCards[row.key]=value;else delete this.cachedCards[row.key]; }
-      else this.insert(mem,row.name,value,row.key);
-    }
-    if (mem.prepare("SELECT 1 FROM sqlite_master WHERE name='sqlite_sequence'").get()) {
-      for (const [name, value] of Object.entries(this.sequences)) {
-        const sequence = mem.prepare('SELECT seq FROM sqlite_sequence WHERE name=?').get(name);
-        if (sequence) mem.prepare('UPDATE sqlite_sequence SET seq=MAX(seq,?) WHERE name=?').run(value.seq,name);
-        else mem.prepare('INSERT INTO sqlite_sequence(name,seq) VALUES(?,?)').run(name,value.seq);
-      }
-    }
-    this.revision=Number(this.db.prepare("SELECT value FROM state WHERE key='rows_revision'").get()?.value??0);
-    return true;
-  }
-  changes(mem,{all=false}={}) {
-    const dirty=all?[...this.tables.values()].flatMap(t=>mem.prepare(`SELECT ${t.keys.map(quote).join(',')} FROM ${quote(t.name)}`).all().map(row=>({name:t.name,key:JSON.stringify(t.keys.map(k=>row[k]))}))):mem.prepare('SELECT DISTINCT name,key FROM _runtime_dirty').all();
-    const changes = dirty.map(({name,key})=>{
-      const table=this.tables.get(name);
-      const row=mem.prepare(`SELECT * FROM ${quote(name)} WHERE ${table.keys.map(k=>`${quote(k)} IS ?`).join(' AND ')}`).get(...JSON.parse(key))??null;
-      if(name==='tasks')return {name:'@runtime',key:JSON.parse(key)[0],value:row&&Object.fromEntries(Object.entries(row).filter(([k])=>RUNTIME.has(k))),source:{name,key,row}};
-      if(name==='supercode_cards')return {name:'@clock',key:JSON.parse(key)[0],value:row&&{workspace_root:row.workspace_root,since:row.since,after_fired:row.after_fired,next_run_at:row.next_run_at},source:{name,key,row}};
-      return {name,key,value:row,source:{name,key,row}};
-    }).filter(change=>{
-      if(all)return true;
-      const {name,key,value,source}=change;
-      if(name==='task_links') {
-        const [parent,child]=JSON.parse(key);
-        const before=json(this.cachedCards[child]?.blocked_by,[]).some(b=>b.kind==='card'&&b.id===parent);
-        return before!==Boolean(source.row);
-      }
-      const before=this.db.prepare('SELECT value FROM runtime_rows WHERE name=? AND key=?').get(name,key)?.value??null;
-      if(before!==(value===null?null:JSON.stringify(value)))return true;
-      if(name==='@runtime') {
-        const fields=row=>row&&Object.fromEntries(Object.entries(row).filter(([k])=>k!=='status'));
-        return JSON.stringify(fields(source.row))!==JSON.stringify(fields(this.cachedTasks[key]??null));
-      }
-      if(name==='@clock')return JSON.stringify(source.row)!==JSON.stringify(this.cachedCards[key]??null);
-      return false;
-    });
-    if (mem.prepare("SELECT 1 FROM sqlite_master WHERE name='sqlite_sequence'").get()) {
-      for (const row of mem.prepare('SELECT name,seq FROM sqlite_sequence').all()) {
-        if (Number(this.sequences[row.name]?.seq) !== Number(row.seq)) changes.push({name:'@sequence',key:row.name,value:row,source:{name:'sqlite_sequence',key:JSON.stringify([row.name]),row}});
-      }
-    }
-    return changes;
-  }
-  mirror(changes, revision) {
-    const previous=Number(this.db.prepare("SELECT value FROM state WHERE key='read_revision'").get()?.value??-1);
-    for(const name of ['tasks','supercode_cards']) {
-      const table=this.tables.get(name); if(!table)return;
-      this.db.exec(table.sql.replace(/^CREATE TABLE (?:IF NOT EXISTS )?(?:"[^"]+"|\w+)/,`CREATE TABLE IF NOT EXISTS ${quote('read_'+name)}`));
-      const columns=this.db.prepare(`PRAGMA table_info(${quote('read_'+name)})`).all();
-      for(const c of table.columns) if(!columns.some(old=>old.name===c.name))this.db.exec(`ALTER TABLE ${quote('read_'+name)} ADD COLUMN ${quote(c.name)} ${c.type}${c.dflt_value==null?'':` DEFAULT ${c.dflt_value}`}`);
-
-    }
-    const rows=previous===revision-1?changes.filter(c=>['tasks','supercode_cards'].includes(c.source.name)).map(c=>c.source):this.db.prepare("SELECT name,key,value FROM runtime_rows WHERE name IN ('@task_cache','@card_cache')").all().map(r=>({name:r.name==='@task_cache'?'tasks':'supercode_cards',key:JSON.stringify([r.key]),row:json(r.value,null)}));
-    for(const {name,key,row} of rows) {
-      const table=this.tables.get(name), target=quote('read_'+name);
-      if(!row) {this.db.prepare(`DELETE FROM ${target} WHERE ${table.keys.map(k=>`${quote(k)} IS ?`).join(' AND ')}`).run(...JSON.parse(key));continue;}
-      const keys=Object.keys(row);
-      this.db.prepare(`INSERT OR REPLACE INTO ${target} (${keys.map(quote)}) VALUES (${keys.map(()=>'?')})`).run(...keys.map(k=>row[k]??null));
-    }
-    this.db.prepare("INSERT INTO state VALUES('read_revision',?) ON CONFLICT(key) DO UPDATE SET value=excluded.value").run(String(revision));
-  }
-  write(changes) {
-    this.db.exec(`CREATE TABLE IF NOT EXISTS runtime_schema(name TEXT PRIMARY KEY,sql TEXT NOT NULL); CREATE TABLE IF NOT EXISTS runtime_rows(name TEXT,key TEXT,value TEXT,revision INTEGER NOT NULL,PRIMARY KEY(name,key)); CREATE INDEX IF NOT EXISTS runtime_rows_revision ON runtime_rows(revision); CREATE INDEX IF NOT EXISTS runtime_rows_task ON runtime_rows(name,json_extract(value,'$.task_id'),json_extract(value,'$.id')); CREATE INDEX IF NOT EXISTS runtime_rows_id ON runtime_rows(name,json_extract(value,'$.id'))`);
-    const revision=Number(this.db.prepare("SELECT value FROM state WHERE key='rows_revision'").get()?.value??0)+1;
-    const statement=this.db.prepare('INSERT INTO runtime_rows VALUES(?,?,?,?) ON CONFLICT(name,key) DO UPDATE SET value=excluded.value,revision=excluded.revision');
-    for(const {name,key,value,source} of changes) {
-      if (OMIT.has(name)) continue;
-      const encoded=value===null?null:JSON.stringify(value);
-      if (this.db.prepare('SELECT value FROM runtime_rows WHERE name=? AND key=?').get(name,key)?.value !== encoded) statement.run(name,key,encoded,revision);
-      if(name==='@runtime' || name==='@clock') {
-        const cacheName=name==='@runtime'?'@task_cache':'@card_cache';
-        const cache=name==='@runtime'?this.cachedTasks:this.cachedCards;
-        const encodedCache=source?.row?JSON.stringify(source.row):null;
-        if (this.db.prepare('SELECT value FROM runtime_rows WHERE name=? AND key=?').get(cacheName,key)?.value !== encodedCache) statement.run(cacheName,key,encodedCache,revision);
-        if(source?.row)cache[key]=source.row;else delete cache[key];
-      }
-      if(name==='@runtime') { if(value)this.runtime[key]=value;else delete this.runtime[key]; }
-      if(name==='@clock') { if(value)this.clocks[key]=value;else delete this.clocks[key]; }
-      if(name==='@sequence') { if(value)this.sequences[key]=value;else delete this.sequences[key]; }
-    }
-    for(const {name,sql} of this.tables.values())if(!OMIT.has(name))this.db.prepare('INSERT OR IGNORE INTO runtime_schema VALUES(?,?)').run(name,sql);
-    this.db.prepare("INSERT INTO state VALUES('rows_revision',?) ON CONFLICT(key) DO UPDATE SET value=excluded.value").run(String(revision));
-    this.mirror(changes,revision);
-    this.revision=revision;
-  }
-}