@volter/supercode-orchestrator 0.4.147 → 0.4.148

package/board/workflow.mjs

@@ -11,8 +11,9 @@ import { resolve, relative, isAbsolute } from 'node:path';
 import { randomBytes } from 'node:crypto';
 import { actorOf, appendRunObservation, event as record, json, now } from './store.mjs';
 import { evaluate, holds, render } from './expr.mjs';
-import { completionEvidence } from './ci.mjs';
+import { completionEvidence, reviewCandidate } from './ci.mjs';
 import { isWorkspacePath } from './workspace.mjs';
+import { identifyNotice } from './notices.mjs';
 
 const loaded = new Map();
 
@@ -251,6 +252,7 @@ export function scopeOf(db, board, task, { params, event = {}, extra = {} } = {}
     completion_owner_address: completionOwnerOf(db, task.id),
     review_only: Boolean(state.review_only),
     latest_review: latestReview(db, task.id) ?? {},
+    review_candidate: reviewCandidate(board, task.id) ?? {},
     ci: completionEvidence(board, task.id),
     dispatch_hold: one(db, "SELECT kind FROM task_events WHERE task_id=? AND kind IN ('dispatch_held','dispatch_released','session_adopted') ORDER BY id DESC LIMIT 1", task.id)?.kind === 'dispatch_held',
     status,
@@ -356,11 +358,15 @@ function queueTransitionNotice(db, board, entry, task, from, name, payload, befo
   const afterState = beforeRun && json(one(db, 'SELECT metadata FROM task_runs WHERE id=?', beforeRun.id)?.metadata, {})?.supercode?.state;
   if (!beforeRun || (state(task, from) === state(after, to) && beforeState === afterState) || effects.some((e) => e.kind === 'session_notice' && e.runId === beforeRun.id)) return;
   const session = json(beforeRun.metadata, {})?.supercode;
+  const cancellation = session?.launch_cancellation;
+  if (cancellation?.key === session?.launch_key && cancellation?.status === 'cancelled' && cancellation?.cancelled === true &&
+      cancellation?.outcome === 'not_issued' && cancellation?.live === false && cancellation?.pane === null) return;
   const address = session?.address ?? (session?.session_id && session.machine ? `sc:${session.machine}:${session.harness ?? 'claude-code'}:${session.session_id}` : null);
   if (!address && !session?.launch_key && !session?.pane) return;
   const scope = scopeOf(db, board, after, { params: entry.params, event: { ...payload, verb: name, from, to }, extra: { run: { id: beforeRun.id } } });
-  const text = render(entry.workflow.notify?.worker?.run_changed ?? '{{card.id}}: {{event.verb}} changed run {{run.id}} ({{event.from}} → {{event.to}}). Stop work under the previous run; follow the board’s current state. {{event.reason ?? ""}}', scope);
+  const body = render(entry.workflow.notify?.worker?.run_changed ?? '{{card.id}}: {{event.verb}} changed run {{run.id}} ({{event.from}} → {{event.to}}). Stop work under the previous run; follow the board’s current state. {{event.reason ?? ""}}', scope);
   const source = one(db, 'SELECT MAX(id) AS id FROM task_events WHERE task_id = ?', task.id)?.id;
+  const text = identifyNotice({ id: source, kind: name, run_id: beforeRun.id, created_at: now() }, body);
   const effect = { kind: 'session_notice', id: task.id, runId: beforeRun.id, address, text, sourceEvent: source, verb: name, messageKey: `board-run-notice-${randomBytes(16).toString('hex')}` };
   const inserted = run(db, 'INSERT INTO supercode_effects (effect) VALUES (?)', JSON.stringify(effect));
   effects.push({ ...effect, durableId: Number(inserted.lastInsertRowid) });
@@ -385,7 +391,7 @@ export function fire(db, board, entry, id, name, { roles = [], payload = {}, ext
   const candidates = transitionsFor(workflow, from, name);
   if (!candidates.length) throw new Error(`${id} is ${from}; ${name.replace(/_/g, '-')} does not apply there`);
   // `sender`: the roles the event was sent with (a validator can ask who is asking)
-  const scope = scopeOf(db, board, task, { params, event: payload, extra: { lanes: lanesIn(entry), ...extra, sender: roles } });
+  const scope = scopeOf(db, board, task, { params, event: payload, extra: { lanes: lanesIn(entry), ...extra, sender: roles, verb: name } });
   const allowed = candidates.filter((t) => !t.by?.length || t.by.some((r) => roles.includes(r)));
   if (!allowed.length) {
     const state = name === 'complete' ? 'done' : name === 'cancel' ? 'cancelled' : null;
@@ -555,7 +561,7 @@ const FORMAT = {
   blocked: ({ e, after, source }) => ({ reason: e.reason ?? null, on: e.on ?? null, waiting_on: e.waiting_on ?? null, recurrences: Number(after.block_recurrences || 0), source_status: source }),
   block_loop_detected: ({ e, after, source, params }) => ({ reason: e.reason ?? null, kind: e.kind ?? null, recurrences: Number(after.block_recurrences || 0), limit: params.block_recurrence_limit, source_status: source }),
   dependency_wait: ({ e, source }) => ({ reason: e.reason ?? null, on: e.on ?? null, source_status: source }),
-  review_requested: ({ e, before, after }) => ({ summary: firstLine(e.summary), ci: e.ci ?? null, implementer: before.assignee, reviewer: after.assignee !== before.assignee ? after.assignee : (e.reviewer ?? null) }),
+  review_requested: ({ e, before, after }) => ({ summary: firstLine(e.summary), ci: e.ci ?? null, pr: e.ci?.pr ?? null, commit: e.ci?.commit ?? null, implementer: before.assignee, reviewer: after.assignee !== before.assignee ? after.assignee : (e.reviewer ?? null) }),
   // the reviewer is the lane that reviewed (the card's assignee while in review), unless the verdict names one
   changes_requested: ({ e, before, after }) => ({ reason: e.reason ?? null, reviewer: e.reviewer ?? before.assignee ?? null, implementer: after.assignee }),
   review_reopened: ({ after, to }) => ({ status: to, implementer: after.assignee }),
@@ -775,6 +781,9 @@ const ACTIONS = {
     if (said?.workspace) {
       const task = cardOf(ctx.db, ctx.id), ws = said.workspace;
       if (task.current_run_id) throw new Error('end the current run before changing its workspace');
+      ACTIONS.forget_session(ctx, '*');
+      const prior = one(ctx.db, 'SELECT workspace_anchor FROM supercode_cards WHERE task_id=?', ctx.id);
+      record(ctx.db, ctx.id, 'workspace_changed', { from: { kind: task.workspace_kind, repository: prior?.workspace_anchor, branch: task.branch_name }, to: { kind: ws.kind, repository: ws.repository, branch: ws.branch } }, null);
       run(ctx.db, 'UPDATE tasks SET workspace_kind=?,workspace_path=?,branch_name=? WHERE id=?', ws.kind, ws.path ?? null, ws.branch ?? null, ctx.id);
       cardField(ctx, 'workspace_anchor', ws.repository ?? null);
       cardField(ctx, 'workspace_root', null);
@@ -854,12 +863,18 @@ const ACTIONS = {
     if (!to) throw new Error(`the workflow asks nobody about ${ctx.id} (ask.to is empty)`);
     const id = `m-${randomBytes(12).toString('hex')}`;
     ctx.scope.asked = id;
-    record(ctx.db, ctx.id, 'board_message', { to: String(to), text: `${String(text ?? '')}\n\nAnswer with reply_to ${id}.`, message_id: id }, null);
+    const batch = ctx.scope.verb === 'request_state' ? {
+      requester: actorOf() ?? ctx.scope.requester,
+      window_seconds: Math.max(1, Math.min(60, Number(ctx.entry.params.request_batch_seconds) || 10)),
+    } : null;
+    record(ctx.db, ctx.id, 'board_message', { to: String(to), text: batch ? String(text ?? '') : `${String(text ?? '')}\n\nAnswer with reply_to ${id}.`, message_id: id, ...(batch ? { batch } : {}) }, null);
     ctx.effects.push({ kind: 'board_message', id: ctx.id });
   },
   send_to_actor(ctx, text) {
     const effect = { kind: 'send_to_actor', id: ctx.id, runId: ctx.runId, text, messageKey: `board-actor-${randomBytes(16).toString('hex')}` };
     const inserted = run(ctx.db, 'INSERT INTO supercode_effects (effect) VALUES (?)', JSON.stringify(effect));
+    effect.text = identifyNotice({ id: `notice-${inserted.lastInsertRowid}`, kind: 'actor_notice', run_id: ctx.runId, created_at: now() }, text);
+    run(ctx.db, 'UPDATE supercode_effects SET effect=? WHERE id=?', JSON.stringify(effect), Number(inserted.lastInsertRowid));
     ctx.effects.push({ ...effect, durableId: Number(inserted.lastInsertRowid) });
   },
 };

package/board/ztrack.mjs

@@ -8,7 +8,7 @@ import { RuntimeRows } from './rows.mjs';
 import { DatabaseSync } from 'node:sqlite';
 import { actorOf, event, json, now, setActor } from './store.mjs';
 import { fire, projectStatus, statusOf, workflowFor } from './workflow.mjs';
-import { inspectCompletionEvidence, withCompletionEvidence } from './ci.mjs';
+import { completionPhase, inspectCompletionEvidence, withCompletionEvidence } from './ci.mjs';
 
 const require = createRequire(import.meta.url);
 const hash = (text) => createHash('sha256').update(text).digest('hex');
@@ -598,7 +598,7 @@ class ZtrackBoard {
       for (const row of prepared.rows) {
         const payload = json(row.payload, {}) ?? {};
         if (row.kind !== 'completed' || payload.__supercode_export || !this.db.prepare('SELECT 1 FROM tasks WHERE id=?').get(row.task_id)) continue;
-        prepared.evidence.set(row.id, inspectCompletionEvidence(this.board(), row.task_id, entry, payload));
+        prepared.evidence.set(row.id, inspectCompletionEvidence(this.board(), row.task_id, entry, payload, completionPhase(this.board(), row.task_id, entry, 'complete', payload, ['hermes'])));
       }
       return prepared;
     } finally { compat.close(); }

package/mcp/hermes-kanban-tools.json

@@ -102,11 +102,19 @@
         },
         "commit": {
           "type": "string",
-          "description": "Exact commit deployed by the CI run."
+          "description": "Exact pushed branch head for a subtask, or merged deployment commit for an arc."
         },
         "ci_run": {
           "type": "integer",
           "description": "GitHub Actions deployment run id for that exact commit."
+        },
+        "branch": {
+          "type": "string",
+          "description": "Pushed worktree branch for source completion."
+        },
+        "reviewed_sha": {
+          "type": "string",
+          "description": "The full PR head SHA this reviewer ran, matching the recorded request."
         }
       },
       "required": []
@@ -146,7 +154,7 @@
   },
   {
     "name": "kanban_request_review",
-    "description": "Hand the task off for review: implementation, self-review, and verification are complete and you want a human (or reviewer) to look before it is marked done. Moves the task to the 'review' column and notifies the subscriber. Unlike ``kanban_block`` this is NOT a blocker \u2014 it never counts toward unblock-loop detection, so a task can cycle through review across follow-ups without ever being falsely escalated to triage. Use this instead of blocking with a free-form 'review-required:' reason.",
+    "description": "Request independent review of the opened PR at its exact pushed head. The dispatcher starts the declared reviewer when the arc tasks are closed. Deployment CI is not a review gate.",
     "inputSchema": {
       "type": "object",
       "properties": {
@@ -173,11 +181,19 @@
         },
         "commit": {
           "type": "string",
-          "description": "Exact commit deployed by the CI run."
+          "description": "Exact pushed worktree branch head for independent review."
         },
-        "ci_run": {
-          "type": "integer",
-          "description": "GitHub Actions deployment run id for that exact commit."
+        "branch": {
+          "type": "string",
+          "description": "The worktree branch whose pushed head is reviewed before merge."
+        },
+        "pr": {
+          "type": "string",
+          "description": "Opened PR URL for the candidate in this worktree repository."
+        },
+        "pr_head": {
+          "type": "string",
+          "description": "Full 40-character SHA of the pushed PR head to review."
         }
       },
       "required": [
@@ -494,13 +510,21 @@
   },
   {
     "name": "kanban_request_state",
-    "description": "Request a manager decision on block, pause, done or cancelled through the home workflow. Includes its rules in manager mail and leaves card/run state unchanged.",
+    "description": "Request a manager decision on block, pause, done or cancelled for one or several task_ids through the home workflow. Nearby requests from the same session share one retained mail. Includes the home's rules and leaves card/run state unchanged.",
     "inputSchema": {
       "type": "object",
       "properties": {
         "task_id": {
           "type": "string"
         },
+        "task_ids": {
+          "type": "array",
+          "items": {
+            "type": "string"
+          },
+          "minItems": 1,
+          "description": "Cards whose state is requested together; each must be in your permitted scope."
+        },
         "state": {
           "type": "string",
           "enum": [
@@ -524,15 +548,31 @@
         },
         "commit": {
           "type": "string",
-          "description": "Exact commit deployed by the CI run."
+          "description": "Pushed branch head for a source verdict or subtask, or merged commit for final arc completion."
         },
         "ci_run": {
           "type": "integer",
-          "description": "GitHub Actions deployment run id for that exact commit."
+          "description": "Legacy receipt field; deployment is not a board completion requirement."
         },
         "deployed_sha": {
           "type": "string",
-          "description": "The deployed commit the independent reviewer actually inspected."
+          "description": "Legacy receipt field; deployment is not a board completion requirement."
+        },
+        "branch": {
+          "type": "string",
+          "description": "The pushed worktree branch the reviewer inspected."
+        },
+        "reviewed_sha": {
+          "type": "string",
+          "description": "Exact pushed branch head the independent reviewer actually inspected."
+        },
+        "pr": {
+          "type": "string",
+          "description": "PR URL, optional when using the recorded review candidate."
+        },
+        "pr_head": {
+          "type": "string",
+          "description": "Full PR head SHA; reviewers can use reviewed_sha instead."
         }
       },
       "required": [

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@volter/supercode-orchestrator",
-  "version": "0.4.147",
+  "version": "0.4.148",
   "type": "module",
   "description": "The orchestrator runtime over the Volter Harness ontology: one typed operational model whose folder is its serialization, read and written through the harness orchestration doors (docs/ORCHESTRATOR-IR.md)",
   "exports": {
@@ -25,7 +25,7 @@
   },
   "dependencies": {
     "@volter/supercode-harness-sdk": "^0.3.41",
-    "@volter/ztrack": "^2.4.19",
+    "@volter/ztrack": "^2.4.20",
     "yaml": "^2.9.0",
     "@volter/supercode-teams": "^0.2.145"
   },