@volter/supercode-orchestrator 0.4.133 → 0.4.135

package/board/ci.mjs

@@ -1,8 +1,10 @@
 // Deployment evidence is observed before a board mutation. No network or Git
 // process runs inside the optimistic transaction that decides completion.
 import { spawnSync } from 'node:child_process';
-import { readFileSync, realpathSync, writeFileSync, renameSync } from 'node:fs';
+import { readFileSync, realpathSync, writeFileSync, renameSync, lstatSync } from 'node:fs';
 import { dirname, join, relative } from 'node:path';
+import { homedir } from 'node:os';
+import { pathToFileURL } from 'node:url';
 import { createHash } from 'node:crypto';
 
 const observations = new Map();
@@ -43,6 +45,27 @@ export function observeCompletionEvidence(board, id, entry, payload = {}) {
     const repo = /(?:github\.com[:/])([^/]+\/[^/]+?)(?:\.git)?$/.exec(remote)?.[1];
     if (!repo) throw new Error('Deployment evidence requires this workspace\'s GitHub origin.');
     Object.assign(state, { commit, repository: repo });
+    const controller = entry.params.completion_ci.controller_deployments?.[repo];
+    if (controller) {
+      const expand = value => value.startsWith('~/') ? join(homedir(), value.slice(2)) : value;
+      const installed = expand(controller.installed_path);
+      if (!lstatSync(installed).isSymbolicLink()) throw new Error('The controller installation must be the declared checkout symlink.');
+      const skill = realpathSync(installed), checkout = run('git', ['rev-parse', '--show-toplevel'], skill);
+      const origin = /(?:github\.com[:/])([^/]+\/[^/]+?)(?:\.git)?$/.exec(run('git', ['remote', 'get-url', 'origin'], checkout))?.[1];
+      if (origin !== repo) throw new Error('The controller installation points to another repository.');
+      const head = run('git', ['rev-parse', 'HEAD'], checkout);
+      run('git', ['merge-base', '--is-ancestor', commit, head], checkout);
+      run('git', ['diff', '--quiet', 'HEAD', '--', relative(checkout, join(skill, 'scripts'))], checkout);
+      const sourceHash = run(process.execPath, ['--experimental-strip-types', '--input-type=module', '-e',
+        'const m=await import(process.argv[1]); process.stdout.write(m.installedSourceHash())', pathToFileURL(join(skill, 'scripts/controller-diagnostics.ts')).href], checkout);
+      const port = Number(readFileSync(expand(controller.port_file), 'utf8').trim());
+      if (!Number.isInteger(port) || port < 1 || port > 65535) throw new Error('The controller has no valid retained port.');
+      const url = `http://127.0.0.1:${port}/health`;
+      const health = JSON.parse(run('curl', ['--fail', '--silent', '--show-error', '--max-time', '2', url], checkout));
+      if (!health.alive || !health.cdp_connected || health.restart_required !== false || health.controller?.source_hash !== sourceHash || health.installed_source_hash !== sourceHash) throw new Error('The running browser controller has not loaded the committed installed code.');
+      Object.assign(state, { ready: true, workflow: 'installed browser controller', run_id: `${health.controller.pid}@${health.controller.started_at}`, status: 'completed', conclusion: 'success', deployed_sha: head, url, source_hash: sourceHash });
+      return state;
+    }
     if (entry.params.completion_ci.keeper_repositories?.includes(repo)) {
       const receiptPath = join(board.root, 'runtime-deployment.json');
       const receipt = JSON.parse(readFileSync(receiptPath, 'utf8'));
@@ -55,22 +78,43 @@ export function observeCompletionEvidence(board, id, entry, payload = {}) {
     }
     const configured = entry.params.completion_ci.workflows?.[repo] ?? entry.params.completion_ci.workflows?.['*'];
     if (!Array.isArray(configured) || !configured.length) throw new Error(`No deployment workflow is declared for ${repo} in completion_ci.workflows.`);
-    const matchedRules = (entry.params.completion_ci.path_workflows?.[repo] ?? []).filter(rule =>
-      records.some(([, , names]) => names.split('\n').some(path => rule.paths.some(prefix => path.startsWith(prefix)))));
-    const deploymentWorkflows = matchedRules.length ? configured.filter(name => matchedRules.every(rule => rule.workflows.includes(name))) : configured;
+    const matchedRules = (entry.params.completion_ci.path_workflows?.[repo] ?? []).map(rule => ({ ...rule,
+      changed_at: records.find(([, , names]) => names.split('\n').some(path => rule.paths.some(prefix => path.startsWith(prefix))))?.[1]
+    })).filter(rule => rule.changed_at);
     const requestedRun = payload.ci_run ?? payload['ci-run'] ?? payload.metadata?.ci_run ?? (old?.commit === commit ? old?.run_id : null);
     let receipt;
     if (requestedRun) {
       receipt = JSON.parse(run('gh', ['run', 'view', String(requestedRun), '--repo', repo, '--json', 'databaseId,workflowName,headSha,status,conclusion,url'], path));
     } else {
       const runs = JSON.parse(run('gh', ['run', 'list', '--repo', repo, '--commit', commit, '--limit', '100', '--json', 'databaseId,workflowName,headSha,status,conclusion,url'], path));
-      receipt = runs.find(row => deploymentWorkflows.includes(row.workflowName));
+      receipt = runs.find(row => configured.includes(row.workflowName));
     }
     if (!receipt) throw new Error(`No deployment CI run exists for ${repo}@${commit}.`);
     Object.assign(state, { run_id: receipt.databaseId, workflow: receipt.workflowName, status: receipt.status, conclusion: receipt.conclusion, url: receipt.url });
     if (receipt.headSha !== commit) throw new Error(`CI run ${receipt.databaseId} is for ${receipt.headSha}, not ${commit}.`);
-    if (!deploymentWorkflows.includes(receipt.workflowName)) throw new Error(`${receipt.workflowName} is not a declared deployment workflow for ${repo}.`);
+    if (!configured.includes(receipt.workflowName)) throw new Error(`${receipt.workflowName} is not a declared deployment workflow for ${repo}.`);
     if (receipt.status !== 'completed' || receipt.conclusion !== 'success') throw new Error(`Deployment CI ${receipt.databaseId} is ${receipt.status}/${receipt.conclusion || 'pending'}.`);
+    // A later SDK publication need not rebuild unchanged native code. It does
+    // need a successful native deployment containing this task's native changes.
+    // Retain each artifact's actual SHA, rather than calling the SDK run a native release.
+    state.coverage = [];
+    let successful;
+    for (const rule of matchedRules) {
+      if (rule.workflows.includes(receipt.workflowName)) continue;
+      successful ??= JSON.parse(run('gh', ['run', 'list', '--repo', repo, '--status', 'success', '--limit', '100', '--json', 'databaseId,workflowName,headSha,status,conclusion,url'], path));
+      const covering = successful.find(row => {
+        if (!rule.workflows.includes(row.workflowName) || !configured.includes(row.workflowName)) return false;
+        try {
+          run('git', ['merge-base', '--is-ancestor', rule.changed_at, row.headSha], path);
+          run('git', ['merge-base', '--is-ancestor', row.headSha, commit], path);
+          // Any later change in these paths requires another native deployment,
+          // even when a different task authored that change.
+          return run('git', ['diff', '--name-only', row.headSha, commit], path).split('\n').every(name => !rule.paths.some(prefix => name.startsWith(prefix)));
+        } catch { return false; }
+      });
+      if (!covering) throw new Error(`No successful ${rule.workflows.join('/')} deployment covers ${rule.paths.join(', ')} through ${commit}.`);
+      state.coverage.push({ paths: rule.paths, commit: covering.headSha, workflow: covering.workflowName, run_id: covering.databaseId, conclusion: covering.conclusion, url: covering.url });
+    }
     state.deployed_sha = commit;
     state.ready = true;
     state.reason = null;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@volter/supercode-orchestrator",
-  "version": "0.4.133",
+  "version": "0.4.135",
   "type": "module",
   "description": "The orchestrator runtime over the Volter Harness ontology: one typed operational model whose folder is its serialization, read and written through the harness orchestration doors (docs/ORCHESTRATOR-IR.md)",
   "exports": {