@volter/supercode-orchestrator 0.4.128 → 0.4.129

package/board/cli.mjs

@@ -302,6 +302,7 @@ export async function runWorkflow(argv) {
       }), true);
       let answer = { id: created.id, existing: created.existing };
       if (args.adopt) {
+        withBoard(b => { if (!rolesFor(b.db, created.id, sid, workflowFor(root).params).includes('manager')) throw new Error('Only the manager adopts an existing session.'); });
         const adopted = withBoard(b => adoptSession(b, created.id, args.adopt, { ttl: settings.ttl }));
         answer = { ...answer, started: true, session: adopted.address, mode: adopted.mode };
       } else if (!args['no-start'] && !created.existing && !args['subtask-of']) {
@@ -827,6 +828,7 @@ export async function runWorkflow(argv) {
     }
     case 'adopt': {
       need(2, 'a card id and a session');
+      withBoard(b => { if (!rolesFor(b.db, id, sid, workflowFor(root).params).includes('manager')) throw new Error('Only the manager adopts an existing session.'); });
       const { settings } = await laneState(root);
       const got = withBoard((b) => adoptSession(b, id, rest[1], { workspace: args.workspace ?? null, ttl: settings.ttl, assignee: args.assignee ?? null, role: args.role ?? null }));
       say(args, `${id} is worked by ${got.address} (pane ${got.pane ?? '?'} in ${got.workspace ?? 'its card\'s directory'})`, { ok: true, ...got });

package/board/dispatch.mjs

@@ -1212,6 +1212,12 @@ function resolveLocalWorkspace(board, task) {
  * its card. `who` is an address, a session id, or a `name@machine` the fleet lists.
  */
 export function adoptSession(board, id, who, { workspace = null, ttl, assignee = null, role = null } = {}) {
+  // Hold before discovery or any other process I/O: a failed attachment remains
+  // visible and cannot race a dispatcher into launching a replacement worker.
+  tx(board, db => {
+    if (!getTask(db, id)) throw new Error(`no card ${id}`);
+    event(db, id, 'dispatch_held', { session: who, reason: 'adoption requested' });
+  });
   const fleet = observeFleet();
   if (!fleet.ok) throw new Error(`supercode could not read the fleet: ${fleet.error}`);
   const found = fleet.sessions.find((s) => s.address === who || s.address.endsWith(`:${who}`) || s.name === who);

package/board/engine.mjs

@@ -170,6 +170,7 @@ export function createCard(board, spec) {
   ws.path = declared.path;
   spec = { ...spec, branch: declared.branch ?? spec.branch };
   const initial = spec.initialStatus ?? null;
+  if (initial === 'running' && (spec.noStart || spec.adopt)) throw new Error('A held or awaiting-adoption card cannot be created initially running.');
   if (initial && !['blocked', 'running'].includes(initial)) throw new Error('initial status is blocked or running');
   if (spec.provider && !spec.model) throw new Error('a provider needs a model');
   return tx(board, (db) => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@volter/supercode-orchestrator",
-  "version": "0.4.128",
+  "version": "0.4.129",
   "type": "module",
   "description": "The orchestrator runtime over the Volter Harness ontology: one typed operational model whose folder is its serialization, read and written through the harness orchestration doors (docs/ORCHESTRATOR-IR.md)",
   "exports": {