@volter/supercode-frontend-vscode 0.1.43 → 0.1.45

package/dist/extension.js

@@ -411,7 +411,7 @@ export async function activate(context) {
     const boundId = (resource) => resolveSessionBinding(resource, controls?.state.sessions ?? [], resourceBindings);
     let applying = Promise.resolve();
     // the reason the last send from a new chat made no conversation, said by that draft's request handler
-    let refusedSend;
+    const refusedSends = new Map(); // by the draft's resource ('' when the send named none)
     let pendingDraft;
     let focusedResource;
     let focusGeneration = 0;
@@ -734,12 +734,10 @@ export async function activate(context) {
         if (!controls)
             throw new Error('This host does not expose harness or model configuration.');
         const active = managed();
-        // A send from a blank chat lands here, and the workbench does not show its error: say it, then refuse.
+        // its caller (a new chat's first send) says the refusal in that chat
         const refusal = busyRefusal(active, 'starting a new chat');
-        if (refusal) {
-            void vscode.window.showWarningMessage(refusal);
+        if (refusal)
             throw new Error(refusal);
-        }
         if (active)
             await saveManagedHistory(active);
         const state = await controls.select(selection);
@@ -750,8 +748,6 @@ export async function activate(context) {
     const openNewChat = async () => {
         if (!controls || !granted.has('chatSessionsProvider'))
             throw new Error('This host does not expose native conversation creation.');
-        // Its callers (the new-chat pickers) swallow the cancellation, so the warning is the one message shown. An error
-        // would reach the person as a bare "Canceled" or not at all through the contributed-command boundary.
         // A turn running elsewhere does not stop a draft: its first send is refused there, in the chat (`create`).
         // Code-OSS materializes this untitled session on first send, awaiting our
         // newChatSessionItemHandler before accepting/clearing the draft. Never boot
@@ -818,7 +814,6 @@ export async function activate(context) {
         try {
             // Open before the picker: a send can beat its result across the extension-
             // host boundary. Materialization awaits this exact draft's choice too.
-            // Inside the try: a busy refusal is a cancellation already explained.
             const opened = draft = await openNewChat();
             picking = (async () => {
                 const choice = await pick();
@@ -847,6 +842,44 @@ export async function activate(context) {
     // Publish capability-honest input groups only after the handoff descriptor is available.
     if (controls?.state.connection)
         await connectManaged().catch(error => log.warn(`Could not attach before registering chat input: ${String(error)}`));
+    const createConversation = async (inputState) => {
+        if (!controls)
+            throw new Error('The host does not expose conversation creation.');
+        const busy = busyRefusal(managed(), 'starting a new chat');
+        if (busy)
+            throw new Error(busy);
+        const draft = activeDraft();
+        // the picker ends in a cancellation for a sign-in choice too: the draft's choice says which (sign-in is refused
+        // below, in the chat); a draft that went away is the real cancellation
+        await draft?.choosing?.catch(() => undefined);
+        if (draft && activeDraft() !== draft)
+            throw new vscode.CancellationError();
+        await controls.refresh();
+        controlsChanged.fire();
+        const choice = draft?.choice;
+        const loginHarness = choice?.kind === 'signIn' ? choice.harness : undefined;
+        if (loginHarness && !controls.state.harnesses.some(h => h.id === loginHarness && h.autoStart)) {
+            throw new Error(`Finish signing in with ${harnessDisplayName(loginHarness)} before sending.`);
+        }
+        if (choice?.kind !== 'agent' && controls.state.setup && !controls.state.setup.ready) {
+            throw new Error('Sign in before sending; use Check again after signing in.');
+        }
+        const selection = choice?.kind === 'agent' ? choice.selection
+            : { harness: loginHarness ?? controls.state.selection.harness, model: '', effort: '' };
+        const pending = applying.then(() => applySelection(selection));
+        applying = pending.then(() => undefined, () => undefined);
+        const connection = await pending;
+        // The picker shows the host's default until someone changes it; only a change is the person's choice.
+        const selected = inputState.groups.find(group => group.id === 'permissions')?.selected?.id;
+        const picked = selected === 'ask' || selected === 'autoApprove' ? selected : permission ?? newChatDefault();
+        choosePermission(connection.id, picked, permission !== undefined ? null : newChatDefault());
+        permission = undefined;
+        if (pendingDraft === draft) {
+            pendingDraft = undefined;
+            controlsChanged.fire();
+        }
+        return connection;
+    };
     const providerControls = {
         changed: controlsChanged.event,
         currentOptions,
@@ -885,45 +918,19 @@ export async function activate(context) {
             else
                 permission = turnPermission(value);
         },
+        // A send that makes no conversation (another turn runs, or the host or a sign-in refuses it) answers no item: the
+        // host then runs the request on the draft itself, and its handler says why in the chat. A rejection here reaches
+        // nobody (the host's acceptInput drops it), so every refusal goes that way (#1282 review).
         create: async (inputState) => {
-            if (!controls)
-                throw new Error('The host does not expose conversation creation.');
-            // A send while another turn runs makes no conversation: the host then runs the request on the draft itself, and
-            // its handler says why in the chat. A rejection here reaches nobody (the host's acceptInput drops it).
-            const busy = busyRefusal(managed(), 'starting a new chat');
-            if (busy) {
-                refusedSend = busy;
-                return undefined;
-            }
-            const draft = activeDraft();
-            await draft?.choosing;
-            if (draft && activeDraft() !== draft)
-                throw new vscode.CancellationError();
-            await controls.refresh();
-            controlsChanged.fire();
-            const choice = draft?.choice;
-            const loginHarness = choice?.kind === 'signIn' ? choice.harness : undefined;
-            if (loginHarness && !controls.state.harnesses.some(h => h.id === loginHarness && h.autoStart)) {
-                throw new Error(`Finish signing in with ${harnessDisplayName(loginHarness)} before sending. Your draft is kept.`);
-            }
-            if (choice?.kind !== 'agent' && controls.state.setup && !controls.state.setup.ready) {
-                throw new Error('Sign in before sending. Your draft is kept; use Check again after signing in.');
+            try {
+                return await createConversation(inputState);
             }
-            const selection = choice?.kind === 'agent' ? choice.selection
-                : { harness: loginHarness ?? controls.state.selection.harness, model: '', effort: '' };
-            const pending = applying.then(() => applySelection(selection));
-            applying = pending.then(() => undefined, () => undefined);
-            const connection = await pending;
-            // The picker shows the host's default until someone changes it; only a change is the person's choice.
-            const selected = inputState.groups.find(group => group.id === 'permissions')?.selected?.id;
-            const picked = selected === 'ask' || selected === 'autoApprove' ? selected : permission ?? newChatDefault();
-            choosePermission(connection.id, picked, permission !== undefined ? null : newChatDefault());
-            permission = undefined;
-            if (pendingDraft === draft) {
-                pendingDraft = undefined;
-                controlsChanged.fire();
+            catch (error) {
+                if (error instanceof vscode.CancellationError)
+                    throw error;
+                refusedSends.set(activeDraft()?.resource.toString() ?? '', String(error?.message ?? error));
+                return undefined;
             }
-            return connection;
         },
         resolve: (resource) => connectionFor(resource, false),
         attached: (connection) => attachedIds.has(connection.id),
@@ -1170,11 +1177,13 @@ export async function activate(context) {
     const handler = async (request, chatContext, stream, token) => {
         await applying;
         const requestedResource = chatContext.chatSessionContext?.chatSessionItem?.resource;
-        if (refusedSend && requestedResource?.path.startsWith('/untitled-') && !boundId(requestedResource)) {
-            const refusal = refusedSend;
-            refusedSend = undefined;
+        const refusedKey = requestedResource?.path.startsWith('/untitled-') && !boundId(requestedResource)
+            ? [requestedResource.toString(), ''].find(key => refusedSends.has(key)) : undefined;
+        if (refusedKey !== undefined) {
+            const refusal = refusedSends.get(refusedKey);
+            refusedSends.delete(refusedKey);
             // thrown as is: the workbench writes a handler's error into the chat
-            throw new Error(`${refusal} Nothing was sent; send it again in a new chat once that turn has ended.`);
+            throw new Error(`${refusal} Nothing was sent; send it again in a new chat.`);
         }
         if (controls?.state.setup && !controls.state.setup.ready) {
             stream.markdown('Sign in before sending a message. Use **New Chat: Choose Agent** to get started.');

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@volter/supercode-frontend-vscode",
   "displayName": "Volter Harness",
-  "version": "0.1.43",
+  "version": "0.1.45",
   "type": "module",
   "description": "VS Code chat-view frontend for an existing Volter Harness SDK runtime",
   "publisher": "volter-ai-dev",