@volter/supercode-frontend-vscode 0.1.38 → 0.1.40

package/README.md

@@ -152,8 +152,10 @@ owns no processes.
 The permission group offers **Ask for approval** and, on an answerable interactive attachment,
 **Auto approve**. Policies are scoped by conversation and read throughout the turn: switching to
 **Auto approve** while a turn runs answers the approvals already waiting and every later one.
-A lifecycle host may declare `defaultPermission: "autoApprove"` for conversations no one has
-picked a mode for (Model Editor does); it applies to Claude Code and Codex where the runtime answers approvals
+A lifecycle host may start the conversations it creates in **Auto approve**: it records
+`defaultPermission: "autoApprove"` on each such conversation and declares `newChatPermission` for the new
+chat's picker (Model Editor does). A conversation without its own recorded default asks, so one that existed
+before a host began doing this keeps its behaviour. It applies to Claude Code and Codex where the runtime answers approvals
 through Chat, every other harness keeps its own prompts, and a person's explicit pick always
 wins. Only a pick that differs from the default (or replaces an earlier pick) is saved, so the
 default is never stored as a choice (a pick equal to the default follows the default if it later

package/dist/extension.js

@@ -13,6 +13,8 @@ import { acceptedDecisions, opaqueText, projectEvent, projectPendingRequests, pr
 const SESSION_SCHEME = 'supercode';
 /** The harnesses whose model and reasoning effort a new chat can set (the host passes them to the CLI). */
 const CONFIGURABLE_HARNESSES = ['claude-code', 'codex'];
+/** How long an automatic approval may go unanswered before its card is shown for the person to answer. */
+const AUTO_ANSWER_SETTLE_MS = 15_000;
 const PARTICIPANT_ID = 'supercode.chat';
 const DEFAULT_PARTICIPANT_ID = 'supercode.chat.default';
 /** `package.json` gates the `isDefault` participant on this key. */
@@ -238,6 +240,8 @@ function writePart(stream, part, state) {
             return;
         }
         case 'answers':
+            if (part.approval && part.answers.length > 0 && state.quiet?.(part.answers[0].requestId))
+                return;
             if (part.approval && nativeInTurnApprovalCards && part.answers.length > 0) {
                 stream.confirmation(part.title, part.message, {
                     kind: 'supercode.inTurnApproval', version: 1, answers: part.answers,
@@ -370,18 +374,22 @@ export async function activate(context) {
     // The approval sweeps of each conversation's running turns, so a picker change reaches a turn already running.
     const runningTurns = new Map();
     const answeredRequests = new Map();
-    // The host's default for a conversation no one has chosen for (Model Editor declares Auto approve).
-    const hostDefault = () => controls?.state.defaultPermission === 'autoApprove' ? 'autoApprove' : 'ask';
+    // The mode a NEW chat's picker shows (`HostState.newChatPermission`; Model Editor declares Auto approve). It is
+    // never applied to a conversation that exists: that reads its own recorded default below.
+    const newChatDefault = () => controls?.state.newChatPermission === 'autoApprove' ? 'autoApprove' : 'ask';
     const canAnswer = (connection) => Boolean(connection.session.descriptor?.actions.respond && connection.session.permissions.has('approve'));
-    // The host's default for one conversation: Auto approve only for a conversation the host manages and only
-    // where this Chat can answer the runtime's approvals, read from its live connection, or, while it is not
-    // connected, from the harness the host records for it (hosted Claude Code and Codex answer through Chat).
-    // A runtime attached by address and every other harness keep their own prompts.
+    // The default of one conversation: the one the host recorded for THAT conversation when it created it
+    // (`ManagedChatSession.defaultPermission`), so a conversation that existed before a host began starting chats
+    // in Auto approve keeps asking. Auto approve only for a conversation the host manages and only where this Chat
+    // can answer the runtime's approvals, read from its live connection, or, while it is not connected, from its
+    // harness (hosted Claude Code and Codex answer through Chat). A runtime attached by address and every other
+    // harness keep their own prompts.
     const defaultFor = (id) => {
-        if (hostDefault() !== 'autoApprove' || attachedIds.has(id))
+        const session = controls?.state.sessions.find(entry => entry.id === id);
+        if (session?.defaultPermission !== 'autoApprove' || attachedIds.has(id))
             return 'ask';
         const connection = frontends.get(id);
-        const harness = controls?.state.sessions.find(session => session.id === id)?.selection.harness ?? '';
+        const harness = session.selection.harness;
         // Only the harnesses whose approvals this default was decided for; a runtime that answers through another
         // protocol (an ACP agent) keeps asking until a host names it.
         return ['claude-code', 'codex'].includes(harness) && (!connection || canAnswer(connection)) ? 'autoApprove' : 'ask';
@@ -489,7 +497,7 @@ export async function activate(context) {
     }
     const currentOptions = (resource) => {
         const id = resource ? boundId(resource) : controls?.state.activeSession;
-        return { permissions: id ? approvalFor(id) : permission ?? hostDefault() };
+        return { permissions: id ? approvalFor(id) : permission ?? newChatDefault() };
     };
     const savedConnections = new Map();
     const saveManagedHistory = async (connection) => {
@@ -871,7 +879,7 @@ export async function activate(context) {
             const connection = await pending;
             // The picker shows the host's default until someone changes it; only a change is the person's choice.
             const picked = turnPermission(inputState.groups.find(group => group.id === 'permissions')?.selected?.id);
-            choosePermission(connection.id, picked, permission !== undefined ? null : hostDefault());
+            choosePermission(connection.id, picked, permission !== undefined ? null : newChatDefault());
             permission = undefined;
             if (pendingDraft === draft) {
                 pendingDraft = undefined;
@@ -997,6 +1005,21 @@ export async function activate(context) {
         // never both answer the same request (the second answer would be refused and noted as a failure).
         const answered = answeredRequests.get(connection.id) ?? new Set();
         answeredRequests.set(connection.id, answered);
+        // Requests whose card was not shown because this watch was going to answer them.
+        const unshown = new Set();
+        const answers = (requestId) => {
+            if (approval() !== 'autoApprove' || token.isCancellationRequested || !canAnswer(connection))
+                return false;
+            const pending = connection.session.pendingRequests.get(requestId);
+            // Hidden only when this watch's own sweep will answer it: one another watch claimed keeps its card here.
+            if (!pending || pending.kind !== 'approval' || answered.has(requestId))
+                return false;
+            const decisions = acceptedDecisions(pending);
+            if (decisions && !decisions.includes('allow'))
+                return false;
+            unshown.add(requestId);
+            return true;
+        };
         const sweep = () => {
             if (approval() !== 'autoApprove' || token.isCancellationRequested || !canAnswer(connection))
                 return;
@@ -1017,16 +1040,42 @@ export async function activate(context) {
                 catch {
                     log.info(text.trim());
                 } };
+                const label = opaqueText(named ?? `request #${pending.id}`, 200);
+                // A card this watch hid is shown when its automatic answer fails or does not settle: a typed reply cannot
+                // reach a running turn, its buttons can. With the response closed, the person is told an approval waits.
+                const showCard = () => {
+                    if (!unshown.delete(pending.id) || !connection.session.pendingRequests.has(pending.id))
+                        return;
+                    try {
+                        writeProjected(stream, projectPendingRequests([pending], {
+                            connectionId: connection.id,
+                            canRespond: connection.session.descriptor?.actions.respond !== false,
+                        }), granted, { toolInputs: new Map(), toolNames: new Map() });
+                    }
+                    catch {
+                        void vscode.window.showWarningMessage(`${connection.label}: ${label} is waiting for approval. Open its chat to answer it.`);
+                    }
+                };
+                const unsettled = setTimeout(() => {
+                    note(`\nAuto approve has had no answer for ${label} for ${AUTO_ANSWER_SETTLE_MS / 1000} s. Use the approval buttons to answer.\n`);
+                    showCard();
+                }, AUTO_ANSWER_SETTLE_MS);
                 void connection.session.respond({ kind: 'approval', request_id: pending.id, decision: 'allow' }).then(() => {
-                    note(`\n_auto-approved: ${opaqueText(named ?? `request #${pending.id}`, 200)}_\n`);
+                    clearTimeout(unsettled);
+                    // A card that was never shown needs no note: its resolution line says it was allowed.
+                    if (unshown.has(pending.id))
+                        return;
+                    note(`\n_auto-approved: ${label}_\n`);
                 }, error => {
+                    clearTimeout(unsettled);
                     note(`\nApproval failed: ${String(error.message || error)}. Use the approval buttons to answer.\n`);
+                    showCard();
                 });
             }
         };
         const sweeps = runningTurns.get(connection.id) ?? new Set();
         runningTurns.set(connection.id, sweeps.add(sweep));
-        return { sweep, dispose: () => {
+        return { sweep, answers, dispose: () => {
                 sweeps.delete(sweep);
                 if (!sweeps.size && runningTurns.get(connection.id) === sweeps) {
                     runningTurns.delete(connection.id);
@@ -1051,6 +1100,7 @@ export async function activate(context) {
             });
         });
         const watch = watchApprovals(connection, stream, token, approval);
+        state.quiet = watch.answers;
         let completed = false;
         try {
             await connection.session.runTurn(prompt, (event) => {
@@ -1706,7 +1756,7 @@ function registerSessions(context, frontends, participant, granted, handler, his
                         // already waiting and later ones; Ask leaves them for the person, as before.
                         const watch = controls && !controls.attached(connection) ? controls.watchApprovals(connection, stream, token) : undefined;
                         try {
-                            const state = { toolInputs: new Map(), toolNames: new Map() };
+                            const state = { toolInputs: new Map(), toolNames: new Map(), quiet: watch?.answers };
                             writeProjected(stream, projectPendingRequests(connection.session.pendingRequests.values(), {
                                 connectionId: connection.id,
                                 canRespond: connection.session.descriptor?.actions.respond !== false,

package/dist/host-controls.d.ts

@@ -13,12 +13,14 @@ export interface ChatChoice {
     autoStart?: boolean;
     efforts?: string[];
 }
+/** `defaultPermission`: the approval mode the host started this conversation in when no one picked one; absent, it asks. */
 export interface ManagedChatSession {
     id: string;
     selection: ChatSelection;
     identity: string | null;
     title: string;
     created: number;
+    defaultPermission?: 'ask' | 'autoApprove';
 }
 /** Host-owned operations. The host revalidates commands before native terminal execution. */
 export interface ChatSetupAction {
@@ -51,9 +53,9 @@ export interface HostState {
     actualModel?: string | null;
     configurable: boolean;
     setup?: ChatSetupState;
-    /** The approval mode of a conversation no one has picked one for. `autoApprove` takes effect only
-     *  where the runtime can answer approvals through Chat; absent, every conversation asks. */
-    defaultPermission?: 'ask' | 'autoApprove';
+    /** The mode a new chat's picker shows. A conversation's own default is its `ManagedChatSession.defaultPermission`;
+     *  this is never applied to one that exists. `autoApprove` takes effect only where the runtime can answer approvals. */
+    newChatPermission?: 'ask' | 'autoApprove';
 }
 export interface HostSelectionResult extends HostState {
     connection: Record<string, string>;

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@volter/supercode-frontend-vscode",
   "displayName": "Volter Harness",
-  "version": "0.1.38",
+  "version": "0.1.40",
   "type": "module",
   "description": "VS Code chat-view frontend for an existing Volter Harness SDK runtime",
   "publisher": "volter-ai-dev",