@volter/editor-threejs 0.5.81 → 0.5.83

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@volter/editor-threejs",
   "author": "Volter AI, Inc.",
-  "version": "0.5.81",
+  "version": "0.5.83",
   "publishConfig": {
     "access": "public"
   },
@@ -135,12 +135,12 @@
     "serving": "./dist-node/serving.mjs"
   },
   "dependencies": {
-    "@volter/editor-project": "0.5.81",
+    "@volter/editor-project": "0.5.83",
     "@sparkjsdev/spark": "^2.1.0",
     "three.quarks": "^0.16.0",
     "zod": "^4.3.6",
     "typescript": "5.9.3",
-    "@volter/editor-sdk": "0.5.81",
+    "@volter/editor-sdk": "0.5.83",
     "postprocessing": "6.38.3",
     "quarks.core": "0.16.0",
     "@fortawesome/free-solid-svg-icons": "^7.2.0"

package/src/kit/viewport-commands.ts

@@ -23,6 +23,7 @@ import { captureSizeFromCommand } from '@volter/editor-sdk/kit/capture-size';
 import type { EditorShellStore, HelperVisibility } from './editor-shell-store';
 import { editorHost } from '@volter/editor-sdk/host';
 import { entityObject3D } from './entity-object';
+import { VIEWPORT_SHADING_MODES } from '../render/viewport-shading';
 import { focusedStageStore } from '@volter/editor-sdk/kit/stage-context';
 import {
   setViewGridVisible,
@@ -239,9 +240,17 @@ export const viewportCommands: CommandContribution['commands'] = {
   }),
   'set-shading-mode': verb((store, cmd) => {
     const documentSession = activeObject3DDocumentSession();
+    // A MODE THE VIEWPORT DOES NOT DRAW IS REFUSED BY NAME: an unknown one reached the renderer
+    // and every frame after it threw (`editor.shading('material')`).
+    const mode = cmd['mode'];
+    const known: readonly string[] = documentSession
+      ? [...VIEWPORT_SHADING_MODES, 'uv', 'vertex-colors']
+      : VIEWPORT_SHADING_MODES;
+    if (typeof mode !== 'string' || !known.includes(mode)) {
+      return { ok: false, error: `No shading mode "${String(mode)}"; the modes are ${known.join(', ')}.` };
+    }
     // `preview` and `rendered` are lit as a stage says (Blender's Material Preview and Rendered);
     // where no stage says, they would draw as Solid under another name.
-    const mode = cmd['mode'];
     if (mode === 'preview' || mode === 'rendered') {
       const documentId = activeWorkspaceDocumentId();
       const stageKind = documentId ? viewPresentationBinding(documentId)?.stageKind : undefined;

package/src/render/viewport-shading.ts

@@ -1,19 +1,23 @@
 import * as THREE from 'three';
 import { createNeutralMatcapTexture } from './matcap-texture';
 
-/** Temporary developer-facing shading modes. These never become scene data. */
-export type ViewportShadingMode =
-  | 'solid'
-  /** Authored materials, as `solid`; a stage lights it by a preview (Blender's Material Preview). */
-  | 'preview'
-  /** Authored materials, as `solid`; a stage lights it by the scene (Blender's Rendered). */
-  | 'rendered'
-  | 'clay'
-  | 'unlit'
-  | 'wireframe'
-  | 'matcap'
-  | 'normals'
-  | 'overdraw';
+/**
+ * Temporary developer-facing shading modes. These never become scene data. `preview` is authored
+ * materials lit by a preview (Blender's Material Preview) and `rendered` authored materials lit by
+ * the scene (Blender's Rendered), each as a stage says.
+ */
+export const VIEWPORT_SHADING_MODES = [
+  'solid',
+  'preview',
+  'rendered',
+  'clay',
+  'unlit',
+  'wireframe',
+  'matcap',
+  'normals',
+  'overdraw',
+] as const;
+export type ViewportShadingMode = (typeof VIEWPORT_SHADING_MODES)[number];
 
 type MaterialPair = {
   clay: THREE.MeshStandardMaterial;