@volter/editor-threejs 0.5.212 → 0.5.214

package/dist-node/serving.mjs

@@ -5,17 +5,7 @@ import ts from "typescript";
 // serving/animation-live-module.ts
 var ANIMATION_LIVE_MODULE_ID = "virtual:volter-three-animation-live";
 var animationLiveModuleSource = `
-const live = (globalThis[Symbol.for('volter.three.animation.live')] ??= {
-  mixers: new Map(),
-  listeners: new Set(),
-  version: 0,
-});
-function notify() {
-  live.version++;
-  for (const listener of live.listeners) {
-    try { listener(); } catch (error) { console.error(error); }
-  }
-}
+const live = (globalThis[Symbol.for('volter.three.animation.live')] ??= { mixers: new Map() });
 export function __volterMixer(mixer, key) {
   if (!mixer || typeof mixer.clipAction !== 'function') return mixer;
   if (mixer.__volterMixerKey) return mixer;
@@ -28,10 +18,8 @@ export function __volterMixer(mixer, key) {
     if (action) {
       const played = action.getClip();
       const target = action.getRoot();
-      let changed = false;
-      if (played && !entry.clips.has(played.name)) { entry.clips.set(played.name, played); changed = true; }
-      if (target && !entry.roots.has(target)) { entry.roots.add(target); changed = true; }
-      if (changed) notify();
+      if (played && !entry.clips.has(played.name)) entry.clips.set(played.name, played);
+      if (target) entry.roots.add(target);
     }
     return action;
   };
@@ -40,10 +28,8 @@ export function __volterMixer(mixer, key) {
     const result = uncacheRoot.call(this, root);
     entry.roots.delete(root);
     if (root === this.getRoot()) live.mixers.delete(this);
-    notify();
     return result;
   };
-  notify();
   return mixer;
 }
 /** drei's \`useAnimations\` result: its mixer, and the clips it was handed. */
@@ -52,11 +38,9 @@ export function __volterAnimations(result, key) {
   __volterMixer(result.mixer, key);
   const entry = live.mixers.get(result.mixer);
   if (entry && Array.isArray(result.clips)) {
-    let changed = false;
     for (const clip of result.clips) {
-      if (clip && clip.name && !entry.clips.has(clip.name)) { entry.clips.set(clip.name, clip); changed = true; }
+      if (clip && clip.name && !entry.clips.has(clip.name)) entry.clips.set(clip.name, clip);
     }
-    if (changed) notify();
   }
   return result;
 }

package/package.json

@@ -2,7 +2,7 @@
   "name": "@volter/editor-threejs",
   "publisher": "volter",
   "author": "Volter AI, Inc.",
-  "version": "0.5.212",
+  "version": "0.5.214",
   "engines": {
     "vscode": "*"
   },
@@ -83,7 +83,6 @@
     "./kit/components/stage-transform-chrome": "./src/kit/components/stage-transform-chrome.ts",
     "./kit/components/stage-transform-tools": "./src/kit/components/stage-transform-tools.tsx",
     "./kit/components/standard-viewport-dressing": "./src/kit/components/standard-viewport-dressing.ts",
-    "./kit/components/world-root-binding": "./src/kit/components/world-root-binding.ts",
     "./kit/constraint-helper": "./src/kit/constraint-helper.ts",
     "./kit/editor-shell-store": "./src/kit/editor-shell-store.ts",
     "./kit/editor-viewport": "./src/kit/editor-viewport.ts",
@@ -95,7 +94,6 @@
     "./kit/model-thumbnail": "./src/kit/model-thumbnail.ts",
     "./kit/projection/three": "./src/kit/projection/three.ts",
     "./kit/reflection-probe-helper": "./src/kit/reflection-probe-helper.ts",
-    "./kit/scene-document-viewport": "./src/kit/scene-document-viewport.ts",
     "./kit/scene-framing": "./src/kit/scene-framing.ts",
     "./kit/scene-view-fog": "./src/kit/scene-view-fog.ts",
     "./kit/spatial-handle-visuals": "./src/kit/spatial-handle-visuals.ts",
@@ -416,11 +414,11 @@
     }
   },
   "dependencies": {
-    "@volter/project": "0.5.212",
+    "@volter/project": "0.5.214",
     "@sparkjsdev/spark": "^2.1.0",
     "three.quarks": "^0.16.0",
     "typescript": "5.9.3",
-    "@volter/sdk": "0.5.212",
+    "@volter/sdk": "0.5.214",
     "postprocessing": "6.39.5",
     "quarks.core": "0.16.0",
     "@fortawesome/free-solid-svg-icons": "^7.2.0"

package/serving/animation-live-module.ts

@@ -12,17 +12,7 @@
 export const ANIMATION_LIVE_MODULE_ID = 'virtual:volter-three-animation-live';
 
 export const animationLiveModuleSource = `
-const live = (globalThis[Symbol.for('volter.three.animation.live')] ??= {
-  mixers: new Map(),
-  listeners: new Set(),
-  version: 0,
-});
-function notify() {
-  live.version++;
-  for (const listener of live.listeners) {
-    try { listener(); } catch (error) { console.error(error); }
-  }
-}
+const live = (globalThis[Symbol.for('volter.three.animation.live')] ??= { mixers: new Map() });
 export function __volterMixer(mixer, key) {
   if (!mixer || typeof mixer.clipAction !== 'function') return mixer;
   if (mixer.__volterMixerKey) return mixer;
@@ -35,10 +25,8 @@ export function __volterMixer(mixer, key) {
     if (action) {
       const played = action.getClip();
       const target = action.getRoot();
-      let changed = false;
-      if (played && !entry.clips.has(played.name)) { entry.clips.set(played.name, played); changed = true; }
-      if (target && !entry.roots.has(target)) { entry.roots.add(target); changed = true; }
-      if (changed) notify();
+      if (played && !entry.clips.has(played.name)) entry.clips.set(played.name, played);
+      if (target) entry.roots.add(target);
     }
     return action;
   };
@@ -47,10 +35,8 @@ export function __volterMixer(mixer, key) {
     const result = uncacheRoot.call(this, root);
     entry.roots.delete(root);
     if (root === this.getRoot()) live.mixers.delete(this);
-    notify();
     return result;
   };
-  notify();
   return mixer;
 }
 /** drei's \`useAnimations\` result: its mixer, and the clips it was handed. */
@@ -59,11 +45,9 @@ export function __volterAnimations(result, key) {
   __volterMixer(result.mixer, key);
   const entry = live.mixers.get(result.mixer);
   if (entry && Array.isArray(result.clips)) {
-    let changed = false;
     for (const clip of result.clips) {
-      if (clip && clip.name && !entry.clips.has(clip.name)) { entry.clips.set(clip.name, clip); changed = true; }
+      if (clip && clip.name && !entry.clips.has(clip.name)) entry.clips.set(clip.name, clip);
     }
-    if (changed) notify();
   }
   return result;
 }

package/src/animation/live-mixers.ts

@@ -19,15 +19,13 @@ export interface LiveMixer {
 
 interface Registry {
   readonly mixers: Map<unknown, LiveMixer>;
-  readonly listeners: Set<() => void>;
-  version: number;
 }
 
 const REGISTRY = Symbol.for('volter.three.animation.live');
 
 function registry(): Registry {
   const holder = globalThis as unknown as Record<symbol, Registry | undefined>;
-  return (holder[REGISTRY] ??= { mixers: new Map(), listeners: new Set(), version: 0 });
+  return (holder[REGISTRY] ??= { mixers: new Map() });
 }
 
 /** The live mixer that animates `object`, or null when the game animates it with none. */
@@ -43,9 +41,3 @@ export function liveMixerFor(object: THREE.Object3D): LiveMixer | null {
 export function liveMixers(): LiveMixer[] {
   return [...registry().mixers.values()];
 }
-
-export function subscribeLiveMixers(listener: () => void): () => void {
-  const listeners = registry().listeners;
-  listeners.add(listener);
-  return () => listeners.delete(listener);
-}

package/src/kit/animation/three-clips-subject.ts

@@ -5,7 +5,7 @@
  * reaches clips loaded through useGLTF and useAnimations. Subjects seek through
  * AnimationMixer.setTime; the transport owns playback position.
  */
-import { liveMixerFor, subscribeLiveMixers } from '@volter/editor-threejs/animation/live-mixers';
+import { liveMixerFor } from '@volter/editor-threejs/animation/live-mixers';
 import * as THREE from 'three';
 import type { StageTransport } from '@volter/sdk/animation/stage-transport';
 
@@ -104,62 +104,22 @@ function attachInspected(object: THREE.Object3D, transport: StageTransport): (()
   return detach;
 }
 
-/**
- * One scan of a mounted root, and the handle that keeps it current.
- *
- * `refresh()` DIFFS by object uuid rather than re-attaching: a rescan of an
- * unchanged tree must not detach and re-attach every subject, because that
- * would reset which clip each one is showing under a person's hands. The
- * caller decides when to rescan (the stage host throttles it and skips it
- * while the world is driving time).
- */
+/** One scan of a mounted root, and the handle that detaches what it attached. */
 export interface ClipSubjectScan {
-  refresh(): void;
   dispose(): void;
 }
 
-export function scanClipSubjects(
-  root: THREE.Object3D | (() => THREE.Object3D | null),
-  transport: StageTransport,
-  options: {
-    /** Rescan when the game registers or drops a mixer. */
-    readonly rescanOnLiveMixers?: boolean;
-  } = {},
-): ClipSubjectScan {
+export function scanClipSubjects(root: THREE.Object3D, transport: StageTransport): ClipSubjectScan {
   const attached = new Map<string, () => void>();
-
-  const refresh = (): void => {
-    const seen = new Set<string>();
-    // A getter for a stage whose rendered scene is not fixed at construction:
-    // a world stage draws the session store's scene once the world mounts.
-    const current = typeof root === 'function' ? root() : root;
-    current?.traverse((object) => {
-      if (attached.has(object.uuid)) {
-        seen.add(object.uuid);
-        return;
-      }
-      // The inspection wins when an object has both: it means a world binding
-      // is already driving that skeleton, and a second mixer over it would
-      // give one object two writers.
-      const detach = attachInspected(object, transport) ?? attachOwnClips(object, transport);
-      if (!detach) return;
-      attached.set(object.uuid, detach);
-      seen.add(object.uuid);
-    });
-    for (const [uuid, detach] of [...attached]) {
-      if (seen.has(uuid)) continue;
-      detach();
-      attached.delete(uuid);
-    }
-  };
-
-  refresh();
-  const stopMixers = options.rescanOnLiveMixers ? subscribeLiveMixers(refresh) : () => {};
-
+  root.traverse((object) => {
+    // The project's own mixer wins when an object has both: the project's
+    // code is already driving that skeleton, and a second mixer over it would
+    // give one object two writers.
+    const detach = attachInspected(object, transport) ?? attachOwnClips(object, transport);
+    if (detach) attached.set(object.uuid, detach);
+  });
   return {
-    refresh,
     dispose: () => {
-      stopMixers();
       for (const detach of attached.values()) detach();
       attached.clear();
     },

package/src/kit/authoring/component-instance-root.ts

@@ -105,9 +105,8 @@ function forwardedCallsiteOid(object: THREE.Object3D | null | undefined): string
  * same oid twice, and both mint the same shape of id: the first one seen in
  * depth-first order keeps the bare address, later ones get `#1`, `#2`, ….
  *
- * The suffix is spelled HERE and nowhere else: the minting walks
- * (`projection/three.ts`, `R3fSourceAuthoringAdapter.indexGraph`), the authority
- * check and the presence report all use this one.
+ * The suffix is spelled HERE and nowhere else; the minting walk
+ * (`projection/three.ts`) uses this one.
  */
 export function occurrenceId(baseId: string, occurrence: number): string {
   return occurrence === 0 ? baseId : `${baseId}#${occurrence}`;

package/src/kit/components/Object3DDocumentToolbar.tsx

@@ -112,8 +112,7 @@ export function Object3DDocumentToolbar({
     session?.getSnapshot ?? noSessionVersion,
   );
   // THIS STAGE's own store and its own helpers: the shared panels read
-  // whichever store the FOCUSED document's stage runs on , and a toolbar is a control over ITS document, never over the
-  // world root's.
+  // whichever store the FOCUSED document's stage runs on, and a toolbar is a control over ITS document.
   useSyncExternalStore(subscribeStageStores, stageStoresVersion, stageStoresVersion);
   const stage = stageStore(documentId);
   useSyncExternalStore(

package/src/kit/components/Object3DDocumentViewport.tsx

@@ -9,7 +9,7 @@
 import { lazy, Suspense, useEffect } from 'react';
 import { announceDocumentStage } from '@volter/sdk/document-viewports';
 import type { Object3DDocumentViewportProps } from './StageHost';
-import { OBJECT3D_SURFACE_BUILDING, ViewportSurfaceStatus } from '../viewport-surface-status';
+import { Progress } from '@volter/sdk/progress';
 
 const LazyObject3DDocumentViewport = lazy(async () => {
   const module = await import('./StageHost');
@@ -26,9 +26,7 @@ export function Object3DDocumentViewport(props: Object3DDocumentViewportProps) {
   return (
     <Suspense
       fallback={
-        <ViewportSurfaceStatus testId="object3d-document-loading">
-          {OBJECT3D_SURFACE_BUILDING}
-        </ViewportSurfaceStatus>
+        props.chromeless ? null : <Progress documentId={props.documentId} title="Preparing the viewport" />
       }
     >
       <LazyObject3DDocumentViewport {...props} />