@volcanicminds/backend 2.2.6 → 2.2.8

package/lib/loader/schedules.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */
 import _ from 'lodash'
 import type { JobSchedule } from '../../types/global.js'
 import { normalizePatterns } from '../util/path.js'
@@ -11,55 +12,50 @@ export function load(): any[] {
   const jobs: any = []
 
   const jobScheduleDefaults: JobSchedule = {
-    active: false, // boolean (required)
-    type: 'interval', // cron|interval, default: interval
-    async: true, // boolean, default: true
-    preventOverrun: true, // boolean, default: true
+    active: false,
+    type: 'interval',
+    async: true,
+    preventOverrun: true,
 
-    cron: {
-      // expression: null // required if type = 'cron', use cron syntax (if not specified cron will be disabled)
-      // timezone: null // optional, like "Europe/Rome" (to test)
-    },
+    cron: {},
 
     interval: {
-      days: 0, // number, default 0
-      hours: 0, // number, default 0
-      minutes: 0, // number, default 0
-      seconds: 0, // number, default 0
-      milliseconds: 0, // number, default 0
-      runImmediately: false // boolean, default: false
+      days: 0,
+      hours: 0,
+      minutes: 0,
+      seconds: 0,
+      milliseconds: 0,
+      runImmediately: false
     }
   }
 
   patterns.forEach((pattern) => {
-    log.t && log.trace('Looking for ' + pattern)
+    if (log.t) log.trace('Looking for ' + pattern)
     globSync(pattern, { windowsPathsNoEscape: true }).forEach((f: string) => {
-      log.t && log.trace(`* Add job schedule from ${f}`)
+      if (log.t) log.trace(`* Add job schedule from ${f}`)
 
       const jobName = path.basename(f, path.extname(f))
-      let { job, schedule: s } = require(f)
+      const { job, schedule: s } = require(f)
 
       let isLoadedAndEnabled = false
       if (s && s.active) {
         isLoadedAndEnabled = true
 
-        // apply defaults
-
         let schedule = _.cloneDeep(jobScheduleDefaults)
         schedule = _.merge(schedule, s)
 
         if (!job || typeof job !== 'function') {
-          log.t && log.error(`* Job ${jobName} `)
+          if (log.t) log.error(`* Job ${jobName} `)
           isLoadedAndEnabled = false
         }
 
         if (!schedule.type || !['cron', 'interval'].includes(schedule.type)) {
-          log.t && log.error(`* Job ${jobName}: schedule.type must be cron or interval`)
+          if (log.t) log.error(`* Job ${jobName}: schedule.type must be cron or interval`)
           isLoadedAndEnabled = false
         }
 
         if (schedule.type === 'cron' && !schedule.cron?.expression) {
-          log.t && log.error(`* Job ${jobName}: schedule.cron.expression not defined`)
+          if (log.t) log.error(`* Job ${jobName}: schedule.cron.expression not defined`)
           isLoadedAndEnabled = false
         }
 
@@ -68,24 +64,25 @@ export function load(): any[] {
           const totalIntervalMs = milliseconds + 1000 * (seconds + 60 * (minutes + 60 * (hours + 24 * days)))
 
           if (totalIntervalMs < 1000) {
-            log.t && log.error(`* Job ${jobName}: schedule.interval must have a total greater or equal to 1s`)
+            if (log.t) log.error(`* Job ${jobName}: schedule.interval must have a total greater or equal to 1s`)
             isLoadedAndEnabled = false
           }
         }
 
-        isLoadedAndEnabled &&
+        if (isLoadedAndEnabled) {
           jobs.push({
             jobName,
             schedule,
             job
           })
+        }
       }
 
-      log.t && log.trace(`* Job schedule ${jobName} ${isLoadedAndEnabled ? 'enabled' : 'disabled'}`)
+      if (log.t) log.trace(`* Job schedule ${jobName} ${isLoadedAndEnabled ? 'enabled' : 'disabled'}`)
     })
   })
 
-  log.d && log.debug(`Schedule Jobs loaded: ${jobs?.length || 0}`)
+  if (log.d) log.debug(`Schedule Jobs loaded: ${jobs?.length || 0}`)
   return jobs
 }
 

package/lib/loader/schemas.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */
 import _ from 'lodash'
 import { normalizePatterns } from '../util/path.js'
 import { globSync } from 'glob'
@@ -13,7 +14,7 @@ export async function apply(server: any): Promise<void> {
   const customSchemaIds = new Set()
   let schemaCount = 0
 
-  log.t && log.trace('Looking for custom schemas in ' + customSchemaPath)
+  if (log.t) log.trace('Looking for custom schemas in ' + customSchemaPath)
   const customFiles = globSync(customSchemaPath, { windowsPathsNoEscape: true })
 
   for (const f of customFiles) {
@@ -31,11 +32,11 @@ export async function apply(server: any): Promise<void> {
         }
       })
     } catch (e) {
-      log.w && log.warn(`Could not load custom schema file: ${f}`, e)
+      if (log.w) log.warn(`Could not load custom schema file: ${f}`, e)
     }
   }
 
-  log.t && log.trace('Looking for base schemas in ' + baseSchemaPath)
+  if (log.t) log.trace('Looking for base schemas in ' + baseSchemaPath)
   const baseFiles = globSync(baseSchemaPath, { windowsPathsNoEscape: true })
 
   for (const f of baseFiles) {
@@ -65,31 +66,32 @@ export async function apply(server: any): Promise<void> {
                 customSchema.required = mergedRequired
               }
 
-              log.d && log.debug(`* Schema [${baseSchema.$id}] deeply merged with core definition.`)
+              if (log.d) log.debug(`* Schema [${baseSchema.$id}] deeply merged with core definition`)
+              if (log.w) log.warn(`* Schema [${baseSchema.$id}] overrided with custom definition`)
             }
           } else {
-            log.trace(`* Registering base schema [${baseSchema.$id}] from ${schemaFileName}`)
+            log.trace(`* Schema [${baseSchema.$id}] from ${schemaFileName} registeerd`)
             server.addSchema(baseSchema)
             schemaCount++
           }
         } else if (name !== 'default') {
-          log.w && log.warn(`* Schema with no $id found in ${schemaFileName} (export ${name}), cannot be registered.`)
+          if (log.w) log.warn(`* Schema with no $id found in ${schemaFileName} (export ${name}), cannot be registered`)
         }
       })
     } catch (e) {
-      log.w && log.warn(`Could not load base schema file: ${f}`, e)
+      if (log.w) log.warn(`Could not load base schema file: ${f}`, e)
     }
   }
 
   customSchemas.forEach((schema) => {
-    log.trace(`* Registering custom schema [${schema.$id}]`)
+    log.trace(`* Custom schema [${schema.$id}] registered`)
     try {
       server.addSchema(schema)
       schemaCount++
     } catch (e: any) {
-      log.e && log.error(`Error registering schema ${schema.$id}: ${e.message}`)
+      if (log.e) log.error(`Error registering schema ${schema.$id}: ${e.message}`)
     }
   })
 
-  log.d && log.debug(`Schemas loaded: ${schemaCount} referenceable by $ref`)
+  if (log.d) log.debug(`Schemas loaded: ${schemaCount} referenceable by $ref`)
 }

package/lib/loader/tracking.ts

@@ -11,7 +11,7 @@ export async function load() {
   const patterns = normalizePatterns(['..', 'config', 'tracking.{ts,js}'], ['src', 'config', 'tracking.{ts,js}'])
 
   for (const pattern of patterns) {
-    log.t && log.trace('Looking for ' + pattern)
+    if (log.t) log.trace('Looking for ' + pattern)
     const files = globSync(pattern, { windowsPathsNoEscape: true })
 
     for (const f of files) {
@@ -23,7 +23,7 @@ export async function load() {
 
       trackConfig = { ...trackConfig, ...config }
 
-      enableAll &&
+      if (enableAll) {
         changes.forEach((change) => {
           const tc: TrackChanges = { primaryKey: primaryKey, changeEntity: changeEntity, ...change } as TrackChanges
           const code = getCodeBy(tc.method, tc.path)
@@ -35,11 +35,12 @@ export async function load() {
             trackChangesList[code] = tc
           }
         })
+      }
     }
   }
 
   const keys = Object.keys(trackChangesList) || []
-  log.d && log.debug(`Tracking changes loaded: ${keys?.length || 0}`)
+  if (log.d) log.debug(`Tracking changes loaded: ${keys?.length || 0}`)
   return { tracking: trackChangesList, trackingConfig: trackConfig }
 }
 

package/lib/loader/translation.ts

@@ -1,3 +1,5 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */
+/* eslint-disable prefer-const */
 import path from 'path'
 import { globSync } from 'glob'
 import { I18n } from 'i18n'

package/lib/middleware/isAdmin.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */
 import { FastifyReply, FastifyRequest } from 'fastify'
 
 export function preHandler(req: FastifyRequest, res: FastifyReply, done: any) {
@@ -8,7 +9,7 @@ export function preHandler(req: FastifyRequest, res: FastifyReply, done: any) {
 
     throw new Error('User without this privilege')
   } catch (err) {
-    log.e && log.error(`Upps, something just happened ${err}`)
+    if (log.e) log.error(`Upps, something just happened ${err}`)
     res.code(403).send(new Error('User without this privilege'))
   }
 }

package/lib/middleware/isAuthenticated.ts

@@ -1,14 +1,15 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */
 import { FastifyReply, FastifyRequest } from 'fastify'
 
 export function preHandler(req: FastifyRequest, res: FastifyReply, done: any) {
   try {
-    if (!!req.user?.getId()) {
+    if (req.user?.getId()) {
       return done()
     }
 
     throw new Error('Unauthorized')
   } catch (err) {
-    log.e && log.error(`Upps, something just happened ${err}`)
+    if (log.e) log.error(`Upps, something just happened ${err}`)
     return res.code(401).send(new Error('Unauthorized')) // must be authorized first
   }
 }

package/lib/middleware/preAuth.ts

@@ -1,3 +1,3 @@
 import { FastifyReply, FastifyRequest } from 'fastify'
 
-export async function preHandler(req: FastifyRequest, res: FastifyReply) {}
+export async function preHandler(_req: FastifyRequest, _res: FastifyReply) {}

package/lib/middleware/preForgotPasswordHandler.ts

@@ -1,3 +1,3 @@
 import { FastifyReply, FastifyRequest } from 'fastify'
 
-export async function preHandler(req: FastifyRequest, res: FastifyReply) {}
+export async function preHandler(_req: FastifyRequest, _res: FastifyReply) {}

package/lib/schemas/auth.ts

@@ -54,6 +54,7 @@ export const authMfaChallengeSchema = {
   nullable: true,
   properties: {
     mfaRequired: { type: 'boolean' },
+    mfaSetupRequired: { type: 'boolean' },
     tempToken: { type: 'string' }
   }
 }

package/lib/util/common.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */
 import { FastifyRequest } from 'fastify'
 import type { Data } from '../../types/global.js'
 

package/lib/util/errors.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */
 export class TranslatedError extends Error {
   locale: string
   status: number

package/lib/util/logger.ts

@@ -39,7 +39,7 @@ const loggerConfig = {
   }
 }
 
-let logger = pino(loggerConfig)
+const logger = pino(loggerConfig)
 const logLevel = logger.levels.values[loggerConfig.level]
 
 // Level:	trace	debug	info	warn	error	fatal	silent

package/lib/util/mark.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */
 import require from './require.js'
 const pkg = require('root-require')('package.json')
 
@@ -6,21 +7,21 @@ const pkg = require('root-require')('package.json')
  */
 
 export function print(logg: any = log): void {
-  logg.i && logg.info('Ciao')
-  logg.i && logg.info(`              ,--.                  ,--.      `)
-  logg.i && logg.info(`.--.  ,--,---.|  |,---.,--,--,--,--\\\`--',---. `)
-  logg.i && logg.info(` \\  ''  | .-. |  / .--' ,-.  |      ,--/ .--' `)
-  logg.i && logg.info(`  \\    /' '-' |  \\ \`--\\ '-'  |  ||  |  \\ \`--. `)
-  logg.i && logg.info(`   \`--'  \`---'\`--'\`---'\`--\`--\`--''--\`--'\`---' `)
-  logg.i && logg.info('')
-  logg.t && logg.trace(`Package ${pkg.name}`)
-  logg.i && logg.info(`License ${pkg.license}`)
-  logg.i && logg.info(`Version ${pkg.version}`)
-  logg.i && logg.info(`Codename ${pkg.codename}`)
-  logg.i && logg.info(`Environment ${process.env.NODE_ENV}`)
-  logg.t && logg.trace(`Platform ${process.platform} ${process.arch}`)
-  logg.t && logg.trace(`Root path ${process.cwd()}`)
-  logg.t && logg.trace(`Node ${process.version}`)
-  logg.t && logg.trace(`Release ${JSON.stringify(process.release)}`)
-  logg.t && logg.trace(`Versions ${JSON.stringify(process.versions)}`)
+  if (logg.i) logg.info('Ciao')
+  if (logg.i) logg.info(`              ,--.                  ,--.      `)
+  if (logg.i) logg.info(`.--.  ,--,---.|  |,---.,--,--,--,--\\\`--',---. `)
+  if (logg.i) logg.info(` \\  ''  | .-. |  / .--' ,-.  |      ,--/ .--' `)
+  if (logg.i) logg.info(`  \\    /' '-' |  \\ \`--\\ '-'  |  ||  |  \\ \`--. `)
+  if (logg.i) logg.info(`   \`--'  \`---'\`--'\`---'\`--\`--\`--''--\`--'\`---' `)
+  if (logg.i) logg.info('')
+  if (logg.t) logg.trace(`Package ${pkg.name}`)
+  if (logg.i) logg.info(`License ${pkg.license}`)
+  if (logg.i) logg.info(`Version ${pkg.version}`)
+  if (logg.i) logg.info(`Codename ${pkg.codename}`)
+  if (logg.i) logg.info(`Environment ${process.env.NODE_ENV}`)
+  if (logg.t) logg.trace(`Platform ${process.platform} ${process.arch}`)
+  if (logg.t) logg.trace(`Root path ${process.cwd()}`)
+  if (logg.t) logg.trace(`Node ${process.version}`)
+  if (logg.t) logg.trace(`Release ${JSON.stringify(process.release)}`)
+  if (logg.t) logg.trace(`Versions ${JSON.stringify(process.versions)}`)
 }

package/lib/util/regexp.ts

@@ -4,13 +4,13 @@
  */
 export const username = /(?=^.{3,33}$)^[a-z][a-z0-9]*[._-]?[a-z0-9]+$/gi
 export const emailAlt =
-  /^(([^<>()\[\]\\.,;:\s@"]+(\.[^<>()\[\]\\.,;:\s@"]+)*)|(".+"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/
+  /^(([^<>()[\]\\.,;:\s@"]+(\.[^<>()[\]\\.,;:\s@"]+)*)|(".+"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/
 
 /*
  * email can have multiple words
  * email can use . - or + for smart labeling
  */
-export const email = /^\w+([\.+-]?\w+)*@\w+([\.-]?\w+)*(\.\w{2,3})+$/
+export const email = /^\w+([.+-]?\w+)*@\w+([.-]?\w+)*(\.\w{2,3})+$/
 
 /*
  * password must contain 1 number (0-9)
@@ -20,7 +20,7 @@ export const email = /^\w+([\.+-]?\w+)*@\w+([\.-]?\w+)*(\.\w{2,3})+$/
  * password is 8-64 characters with no space
  */
 export const password =
-  /^(?=.*[a-z])(?=.*[A-Z])(?=.*\d)(?=.*[!@#$%&*()-_=+\[\]\{\}\\|;:\'",.<>?\^])[A-Za-z\d!@#$%&*()-_=+\[\]\{\}\\|;:\'",.<>?\^]{8,}$/
+  /^(?=.*[a-z])(?=.*[A-Z])(?=.*\d)(?=.*[!@#$%&*()-_=+[\]{}|;:'",.<>?^])[A-Za-z\d!@#$%&*()-_=+[\]{}|;:'",.<>?^]{8,}$/
 export const zipCode = /(^\d{5}$)|(^\d{5}-\d{4}$)/
 export const taxCodePersona =
   /^[a-zA-Z]{6}[0-9]{2}[abcdehlmprstABCDEHLMPRST]{1}[0-9]{2}([a-zA-Z]{1}[0-9]{3})[a-zA-Z]{1}$/

package/lib/util/tracker.ts

@@ -1,7 +1,8 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */
 import dayjs from 'dayjs'
 import type { FastifyRequest, FastifyReply } from '../../types/global.js'
 
-export async function initialize(req: FastifyRequest, reply: FastifyReply) {
+export async function initialize(req: FastifyRequest, _reply: FastifyReply) {
   if (req.server['dataBaseManager'].isImplemented()) {
     const tc = getTrackingConfigIfEnabled(req)
     const allData = { ...req.parameters(), ...req.data() }
@@ -11,7 +12,8 @@ export async function initialize(req: FastifyRequest, reply: FastifyReply) {
         if (allData && tc.entity && tc.primaryKey && tc.primaryKey in allData) {
           const key = allData[tc.primaryKey]
           req.trackingData = await req.server['dataBaseManager'].retrieveBy(tc.entity, key)
-          log.trace(`Tracking changes: found id ${req.trackingData ? req.trackingData[tc.primaryKey] : null}`)
+          if (log.t)
+            log.trace(`Tracking changes: found id ${req.trackingData ? req.trackingData[tc.primaryKey] : null}`)
         }
       } catch (error) {
         log.error(`Tracking changes: error on ${tc.code}`)
@@ -21,7 +23,7 @@ export async function initialize(req: FastifyRequest, reply: FastifyReply) {
   }
 }
 
-export async function track(req: FastifyRequest, reply: FastifyReply, payload: any) {
+export async function track(req: FastifyRequest, _reply: FastifyReply, payload: any) {
   if (req.server['dataBaseManager'].isImplemented()) {
     const tc = getTrackingConfigIfEnabled(req)
     if (tc) {
@@ -66,7 +68,7 @@ export async function track(req: FastifyRequest, reply: FastifyReply, payload: a
         }
 
         if (addChange) {
-          log.trace(`Tracking changes: add ${changeEntity} for ${entity}, ${id}, ${userId}, ${status}`)
+          if (log.t) log.trace(`Tracking changes: add ${changeEntity} for ${entity}, ${id}, ${userId}, ${status}`)
           await req.server['dataBaseManager'].addChange(entity, id, status, userId, contents, changeEntity)
         }
       } catch (error) {

package/lib/util/yn.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */
 'use strict'
 
 export default function yn(value: any, defaultValue: boolean): boolean {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@volcanicminds/backend",
-  "version": "2.2.6",
+  "version": "2.2.8",
   "type": "module",
   "codename": "rome",
   "license": "MIT",
@@ -55,6 +55,10 @@
     "test:full": "cross-env PORT=2231 NODE_ENV=memory BROWSER=false mocha --loader=tsx ./test/index.spec.ts -t 100000",
     "reset": "npm install && npm update && npm run build",
     "upgrade-deps": "npx npm-check-updates -u",
+    "lint": "eslint .",
+    "lint:fix": "eslint . --fix",
+    "type-check": "tsc --noEmit",
+    "check-all": "npm run lint && npm run type-check",
     "combine": "node combine.js"
   },
   "dependencies": {
@@ -87,13 +91,18 @@
     "toad-scheduler": "^3.1.0"
   },
   "devDependencies": {
+    "@eslint/js": "^9.39.1",
     "@types/mocha": "^10.0.10",
+    "@types/semver": "^7.7.1",
     "cross-env": "^10.1.0",
+    "eslint": "^9.39.1",
     "expect": "^30.2.0",
+    "globals": "^16.5.0",
     "mocha": "^11.7.5",
     "npm-upgrade": "^3.1.2",
     "tsx": "^4.19.2",
-    "typescript": "^5.9.3"
+    "typescript": "^5.9.3",
+    "typescript-eslint": "^8.48.0"
   },
   "repository": {
     "type": "git",