@vola-trebla/croak 0.1.1 → 0.1.3

package/dist/cli.js

@@ -18,7 +18,7 @@ import { anthropicTriage, DEFAULT_MODEL } from "./llm/client.js";
 import { renderScan, scanToJson } from "./repo-report.js";
 import { ScanTargetError, scanRepoAt } from "./scan.js";
 import { aggregate } from "./verdict.js";
-export const VERSION = "0.1.1";
+export const VERSION = "0.1.3";
 export const EXIT = { ok: 0, block: 1, usage: 2, incomplete: 3 };
 export const EXIT_USAGE = EXIT.usage;
 const DEFAULT_DEPS = {

package/dist/install/detectors.js

@@ -33,29 +33,36 @@ function sourceProblem(resolved, name, version) {
         return `is downloaded over ${url.protocol.replace(":", "")}, not https`;
     return `comes from ${url.host}${url.username === "" ? "" : " with credentials in the URL"}, not ${REGISTRY}`;
 }
-export const source = (changes) => changes.flatMap((c) => {
-    if (c.entry.link) {
-        return [
-            {
-                ruleId: "install/source",
-                severity: "info",
-                file: label(c),
-                message: "is a workspace link, not a download",
-            },
-        ];
-    }
-    const problem = sourceProblem(c.entry.resolved, c.entry.name, c.entry.version);
-    return problem === undefined
-        ? []
-        : [
-            {
-                ruleId: "install/source",
-                severity: "warn",
-                file: label(c),
-                message: `${what(c)} and ${problem}`,
-            },
-        ];
-});
+export const source = (changes) => {
+    const folders = new Set(changes.map((c) => c.entry.path));
+    return changes.flatMap((c) => {
+        if (c.entry.link &&
+            c.entry.resolved !== undefined &&
+            folders.has(c.entry.resolved))
+            return [];
+        if (c.entry.link) {
+            return [
+                {
+                    ruleId: "install/source",
+                    severity: "info",
+                    file: label(c),
+                    message: "is a workspace link, not a download",
+                },
+            ];
+        }
+        const problem = sourceProblem(c.entry.resolved, c.entry.name, c.entry.version);
+        return problem === undefined
+            ? []
+            : [
+                {
+                    ruleId: "install/source",
+                    severity: "warn",
+                    file: label(c),
+                    message: `${what(c)} and ${problem}`,
+                },
+            ];
+    });
+};
 export const integrity = (changes) => changes
     .filter((c) => !c.entry.link &&
     c.entry.resolved !== undefined &&

package/dist/install/metadata.js

@@ -79,7 +79,10 @@ export function metadataFindings(change, facts, now = new Date()) {
         ? "; with an install script, this is the pattern of a hijacked maintainer account"
         : "";
     if (recentRelease) {
-        findings.push(finding("install/recent-release", "warn", `was published ${facts.ageDays} day(s) ago; new versions of popular packages are where hijacks land first`));
+        const when = facts.ageDays !== undefined && facts.ageDays < 0
+            ? "has a publish time after this machine's clock"
+            : `was published ${facts.ageDays} day(s) ago`;
+        findings.push(finding("install/recent-release", "warn", `${when}; new versions of popular packages are where hijacks land first`));
     }
     if (provenanceDropped) {
         findings.push(finding("install/provenance", hijack ? "block" : "warn", `has no provenance, although earlier versions were published with it${pattern}`));

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vola-trebla/croak",
-  "version": "0.1.1",
+  "version": "0.1.3",
   "description": "Croak before you install: a pre-execution gate for package installs, built for AI agents",
   "keywords": [
     "security",

package/scripts/croak-hook.sh

@@ -15,8 +15,10 @@ here=$(dirname "$self")
 cli="$here/../dist/cli.js"
 install="$here/croak-install.sh"
 [ -f "$cli" ] || deny "$cli not found (run pnpm build in the croak repo)"
-# Below Node 24.2 the CLI's entry point does not run and exits 0 with no
-# output: every step would "succeed" silently, and every install would pass.
+# croak needs Node 24.2 or later (package.json engines). On a Node whose
+# entry point check does not run, the CLI exits 0 with no output, and every
+# step would "succeed" silently; on others, behaviour croak was never tested
+# with would decide. Either way: deny instead.
 node -e 'const [a, b] = process.versions.node.split(".").map(Number); process.exit(a > 24 || (a === 24 && b >= 2) ? 0 : 1)' ||
   deny "croak needs Node 24.2 or later (found $(node --version 2>/dev/null || echo none))"
 

package/scripts/croak-install.sh

@@ -229,12 +229,20 @@ if ! isolated "$@" >"$work/plan.log" 2>&1; then
   tail -n 15 "$work/plan.log" >&2
   exit 3
 fi
-if [ ! -f "$work/plan/$lockname" ] && [ -n "$member" ] && [ -f "$work/plan/$member/$lockname" ]; then
-  # The package manager planned the folder as its own project: the workspace
-  # does not list it, and the real install runs there too. That plan lacked
-  # the folder's own lockfile and sanitized manifest, so plan the folder again
-  # as a project of its own, exactly as outside any workspace (D48). croak
-  # plan still refuses a --member the lockfile does not list (M6 review).
+# The copy holds package.json files only, so a lockfile in the member's folder
+# means the package manager planned that folder apart from the workspace, as
+# the real install will. Decide by that, never by the root lockfile, which the
+# package manager then left as it was and the repository may have forged (D52).
+if [ -n "$member" ] && [ -f "$work/plan/$member/$lockname" ]; then
+  if [ "$manager" != npm ]; then
+    # pnpm writes one for a real member too (sharedWorkspaceLockfile: false);
+    # planning it alone would leave the rest of the workspace out.
+    echo "croak-install: $manager planned $member apart from its workspace, so this install was not checked" >&2
+    exit 3
+  fi
+  # npm installs a folder the workspace does not list as a project of its own.
+  # That plan lacked the folder's own lockfile and sanitized manifest, so plan
+  # the folder again, exactly as outside any workspace (D48).
   cd "$start"
   if [ "$manager" = npm ] && [ -f npm-shrinkwrap.json ]; then
     echo "croak-install: npm-shrinkwrap.json is not supported yet, so this install was not checked" >&2