@voidlabs.gg/voidshift-agents 0.5.0 → 0.5.1

package/dist/control.d.ts

@@ -1,5 +1,6 @@
 import { type AgentsConfig, type Tracker as Kind } from './config.ts';
 import { type Current, type RunEntry } from './state.ts';
+import { type Trackers } from './tracker.ts';
 import type { Check, ToolCommand, ToolContext } from './types.ts';
 export { parsePlistArgs } from './launchd.ts';
 export declare const trackersInUse: (config: Pick<AgentsConfig, "workflows">) => Kind[];
@@ -23,5 +24,12 @@ export interface CancelDeps {
     cancelCard: (card: string, label: string, source: Kind) => Promise<boolean>;
 }
 export declare function cancelCurrent(ctx: ToolContext, c: Current, deps: CancelDeps): Promise<void>;
+export declare function trackerWarnings(kinds: Kind[], trackers: Trackers): Promise<{
+    kind: Kind;
+    message: string;
+}[]>;
+export declare function workingLine(current: (Current & {
+    elapsedMinutes: number;
+}) | null): string;
 export declare const controlCommands: Record<string, ToolCommand>;
 export declare function controlChecks(ctx: ToolContext): Promise<Check[]>;

package/dist/control.js

@@ -230,23 +230,30 @@ const realDeps = (ctx) => ({
         }
     },
 });
-async function startCmd(ctx) {
-    if (!Object.keys(readAgentsConfig(ctx.configDir).workflows).length) {
-        ctx.log('No workflows yet. Create one first: vsf agents workflow add.');
-        return 1;
-    }
-    const trackers = trackersFor(ctx.configDir);
-    for (const kind of trackersInUse(readAgentsConfig(ctx.configDir))) {
+// One message per tracker whose key is missing or refused. The tick skips a
+// tracker it cannot open, so these warn rather than stop the runner.
+export async function trackerWarnings(kinds, trackers) {
+    const out = [];
+    for (const kind of kinds) {
         try {
             await trackers(kind).viewer();
         }
         catch (err) {
             const msg = err.message;
             const flag = kind === 'linear' ? '' : ` --${kind}`;
-            ctx.log(/^No .* API key/.test(msg) ? msg : `${TRACKERS[kind].name} did not accept the key: ${msg}. Run vsf agents key${flag}.`);
-            return 1;
+            out.push({ kind, message: /^No .* API key/.test(msg) ? msg : `${TRACKERS[kind].name} did not accept the key: ${msg}. Run vsf agents key${flag}.` });
         }
     }
+    return out;
+}
+async function startCmd(ctx) {
+    if (!Object.keys(readAgentsConfig(ctx.configDir).workflows).length) {
+        ctx.log('No workflows yet. Create one first: vsf agents workflow add.');
+        return 1;
+    }
+    for (const w of await trackerWarnings(trackersInUse(readAgentsConfig(ctx.configDir)), trackersFor(ctx.configDir))) {
+        ctx.log(`Warning: ${w.message.replace(/\.?$/, '.')} Workflows on ${TRACKERS[w.kind].name} are skipped until then.`);
+    }
     setPaused(ctx.configDir, false);
     if (!runnerService().start(ctx.home, program(ctx), logPath(ctx.configDir))) {
         ctx.log('Could not start the runner. Check vsf agents logs.');
@@ -263,6 +270,14 @@ async function stopCmd(ctx) {
     ctx.log('Runner stopped.');
     return 0;
 }
+// The lock holds the round as the card's vs-vN label shows it; 0 before any round.
+export function workingLine(current) {
+    if (!current)
+        return '';
+    if (!current.card)
+        return ' Checking now.';
+    return ` Working on ${current.card}${current.title ? ` "${current.title}"` : ''} (${[current.workflow, current.step, current.round ? `round ${current.round}` : '', `${current.elapsedMinutes}m`].filter(Boolean).join(', ')}).`;
+}
 const status = guard(async (args, ctx) => {
     const p = parse('status', args, { json: { type: 'boolean' } }, ctx);
     if (typeof p === 'number')
@@ -291,11 +306,7 @@ const status = guard(async (args, ctx) => {
         ctx.log(JSON.stringify({ engine: config.engine, runner, lastTick, current, parked, interrupted, workflows, projects }, null, 2));
         return 0;
     }
-    const working = current && !current.card
-        ? ' Checking now.'
-        : current
-            ? ` Working on ${current.card ?? 'a card'}${current.title ? ` "${current.title}"` : ''} (${[current.workflow, current.step, current.round !== undefined ? `round ${current.round + 1}` : '', `${current.elapsedMinutes}m`].filter(Boolean).join(', ')}).`
-            : '';
+    const working = workingLine(current);
     if (runner === 'running')
         ctx.log(`Runner: running.${working}`);
     else if (runner === 'paused')

package/dist/runner.js

@@ -1,6 +1,6 @@
 import { existsSync, mkdirSync } from 'node:fs';
 import { basename, join } from 'node:path';
-import { LABELS, PLAN_HEADING, buildPrompt, findingsFor, fixTarget, isStatusLabel, latestPlan, parseDevResult, parseVerdict, planBody, qaPassed, stageLabels, verdictBlock, } from "./workflow.js";
+import { LABELS, PLAN_HEADING, buildPrompt, findingsFor, fixTarget, isStatusLabel, latestPlan, needsPlan, parseDevResult, parseVerdict, planBody, qaPassed, stageLabels, verdictBlock, } from "./workflow.js";
 import { agentsDir, hasWork, isCardTrigger, resolveStep, stepId, stepIdLabel } from "./config.js";
 import { lastDue, parseCron } from "./cron.js";
 import { runAgent, stopAgents } from "./engine.js";
@@ -138,10 +138,7 @@ export async function runCard(card, trigger, workflowName, workflow, project, rc
             throw new Park(`Workflow ${workflowName} has no ${stepIdLabel(opts.from)} step.`);
         // A scheduled run has no card to plan on, so its task is the plan unless a Plan step writes one.
         let plan = isCardTrigger(trigger) ? latestPlan(await linear.comments(card.identifier)) : card.description ?? null;
-        const firstPlan = steps.findIndex((d, n) => n >= from && d.output === 'plan');
-        // A check before any commits is a check on the plan, like Plan review.
-        const needsPlan = steps.findIndex((d, n) => n >= from && (d.output === 'commits' || (d.output === 'verdict' && d.builtin !== 'vs-qa')));
-        if (!plan && needsPlan >= 0 && (firstPlan < 0 || firstPlan > needsPlan)) {
+        if (!plan && needsPlan(steps, from)) {
             throw new Park('No plan comment (starting with "## Plan") was found. Publish a plan first, or start the workflow with Plan.');
         }
         await stage(stageOf(steps[from]));

package/dist/workflow.d.ts

@@ -49,4 +49,8 @@ export interface PromptInput {
 export declare function buildPrompt(p: PromptInput): string;
 export declare function verdictBlock<T>(steps: T[], i: number, isVerdict: (s: T) => boolean): [number, number];
 export declare function fixTarget<T>(steps: T[], blockStart: number, isProducer: (s: T) => boolean): number;
+export declare function needsPlan(steps: {
+    output: string;
+    builtin?: string;
+}[], from: number): boolean;
 export declare function planBody(output: string): string;

package/dist/workflow.js

@@ -105,6 +105,21 @@ export function fixTarget(steps, blockStart, isProducer) {
             return j;
     return -1;
 }
+// Whether a run starting at `from` needs a plan comment: some step before any
+// Plan step writes commits or checks the plan. A check counts as a plan check
+// only when a Plan step comes before it, so a review-only workflow runs bare.
+export function needsPlan(steps, from) {
+    for (let n = from; n < steps.length; n++) {
+        const s = steps[n];
+        if (s.output === 'plan')
+            return false;
+        if (s.output === 'commits')
+            return true;
+        if (s.output === 'verdict' && s.builtin !== 'vs-qa' && (s.builtin === 'vs-plan-review' || steps.slice(0, n).some((d) => d.output === 'plan')))
+            return true;
+    }
+    return false;
+}
 // Plan output minus the trailing RESULT line, ready to post.
 export function planBody(output) {
     return output.replace(/^\s*RESULT:.*$/gim, '').trim();

package/pack/vs-plan/SKILL.md

@@ -94,7 +94,9 @@ The plan file holds the detail. In the chat, keep it short and plain:
 Start straight at Understanding. Do not repeat the card id or title; the card
 already shows them.
 
-Length follows the change: under 350 words for a small one, never padded.
+Outcome first. Under 350 words for a small change, never over 700 for any
+change. File and line detail only in Surfaces; no code blocks over 5 lines;
+Six angles lists only angles that apply.
 
 **Understanding.** Two to four sentences: what the card asks, what it got
 wrong, which reading you chose.
@@ -123,6 +125,7 @@ anything a human must click.
 - No ticket ids in code comments.
 - No em dashes or en dashes.
 - No narration of process. State findings.
+- Do not quote code the dev agent can read.
 
 ## When you run inside a workflow
 

package/pack/vs-plan-review/SKILL.md

@@ -41,7 +41,8 @@ main points.
 2. The findings that change what gets built, most important first, at most 5,
    one short plain line each: what is wrong and what to do about it.
 3. Everything smaller in one line: `Minor: ...`.
-4. A short `Details` section: for each finding, the file and line that proves it.
+4. A short `Details` section: one line per finding, the file and line that
+   proves it.
 5. Last line, exactly one of:
 
 ```
@@ -56,6 +57,7 @@ fixes to the plan file.
 
 - No em dashes or en dashes.
 - No narration of process. State findings.
+- Whole review under 300 words.
 
 ## When you run inside a workflow
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@voidlabs.gg/voidshift-agents",
-  "version": "0.5.0",
+  "version": "0.5.1",
   "description": "Agents for Claude Code and Codex that plan, build and QA Linear cards, chained and run in the background.",
   "license": "Apache-2.0",
   "repository": {
@@ -40,7 +40,7 @@
   "scripts": {
     "build": "rm -rf dist && tsc -p tsconfig.json",
     "typecheck": "tsc -p tsconfig.json --noEmit",
-    "test": "node --test test/*.test.ts",
+    "test": "node --test --test-force-exit --test-timeout=60000 test/*.test.ts",
     "prepublishOnly": "rm -rf dist && tsc -p tsconfig.json"
   },
   "devDependencies": {