@voiceflow/eslint-config 7.3.2 → 7.3.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@voiceflow/eslint-config",
-  "version": "7.3.2",
+  "version": "7.3.4",
   "main": "src/index.js",
   "files": [
     "src"
@@ -10,6 +10,7 @@
     "lint:eslint": "yarn g:eslint",
     "lint:fix": "yarn g:run-p -c \"lint:eslint --fix\" \"lint:prettier --write\"",
     "lint:prettier": "yarn g:prettier --check",
+    "test": "yarn test:dependencies",
     "test:dependencies": "yarn g:depcruise"
   },
   "dependencies": {
@@ -36,5 +37,5 @@
   "volta": {
     "extends": "../../package.json"
   },
-  "gitHead": "2630533e0ac88531992cfed2551626f6b7c33127"
+  "gitHead": "820ec7568fff4fe6d8a1671c0c14048d722dd73c"
 }

package/src/index.js

@@ -1,6 +1,7 @@
 const base = require('./base');
 const typescript = require('./presets/typescript');
+const nest = require('./presets/nest');
 const utility = require('./presets/utility');
 
 /** @type {import('eslint').Linter.FlatConfig[]} */
-module.exports = [...base, typescript, utility];
+module.exports = [...base, typescript, nest, utility];

package/src/presets/common.js

@@ -104,6 +104,7 @@ module.exports = [
       'promise/no-return-wrap': 'off',
       'promise/no-promise-in-callback': 'off',
       'promise/no-callback-in-promise': 'off',
+      'promise/no-nesting': 'off',
     },
   },
 ];

package/src/presets/nest.js

@@ -0,0 +1,10 @@
+module.exports = {
+  files: ['**/*.controller.ts', '**/*.decorator.ts', '**/*.factory.ts', '**/*.module.ts', '**/*.service.ts'],
+
+  rules: {
+    // NestJS imports can be considered "unused" by this rule, but NestJS uses them for dependency injection.
+    // We can enforce no type imports to ensure that NestJS can inject correctly.
+    // See: https://github.com/typescript-eslint/typescript-eslint/issues/2559#issuecomment-692780580
+    '@typescript-eslint/consistent-type-imports': ['off'],
+  },
+};

package/src/presets/typescript.js

@@ -29,11 +29,13 @@ module.exports = {
     '@typescript-eslint/consistent-type-imports': ['error', { prefer: 'type-imports' }],
 
     // off
+    'no-undef': 'off',
     'no-shadow': 'off',
     'no-redeclare': 'off',
     'no-unused-vars': 'off',
     'no-use-before-define': 'off',
     'no-useless-constructor': 'off',
+    'no-empty-function': ['error', { allow: ['constructors'] }],
 
     '@typescript-eslint/explicit-module-boundary-types': 'off',
     '@typescript-eslint/no-non-null-assertion': 'off',

package/src/presets/utility.js

@@ -1,4 +1,4 @@
-const EXTENSIONS = ['js', 'jsx', 'cjs', 'mjs', 'ts', 'tsx', 'cts', 'mts'].join(',');
+const EXTENSIONS = `{${['js', 'jsx', 'cjs', 'mjs', 'ts', 'tsx', 'cts', 'mts'].join(',')}}`;
 
 /** @type {import('eslint').Linter.FlatConfig} */
 module.exports = {