@voiceflow/eslint-config 7.17.0 → 7.17.1-3b37425.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@voiceflow/eslint-config",
-  "version": "7.17.0",
+  "version": "7.17.1-3b37425.2+3b37425",
   "type": "module",
   "exports": {
     ".": "./src/index.js",
@@ -19,8 +19,9 @@
     "test:dependencies": "yarn g:depcruise --ignore-known"
   },
   "dependencies": {
-    "@typescript-eslint/eslint-plugin": "8.47.0",
-    "@typescript-eslint/parser": "8.47.0",
+    "@stylistic/eslint-plugin": "5.6.1",
+    "@typescript-eslint/eslint-plugin": "8.49.0",
+    "@typescript-eslint/parser": "8.49.0",
     "eslint-config-airbnb-base": "15.0.0",
     "eslint-config-prettier": "10.1.8",
     "eslint-formatter-junit": "9.0.1",
@@ -28,8 +29,9 @@
     "eslint-import-resolver-typescript": "4.4.4",
     "eslint-plugin-eslint-comments": "3.2.0",
     "eslint-plugin-import": "2.32.0",
-    "eslint-plugin-jsdoc": "61.3.0",
+    "eslint-plugin-jsdoc": "61.5.0",
     "eslint-plugin-mdx": "3.6.2",
+    "eslint-plugin-n": "17.23.1",
     "eslint-plugin-no-secrets": "2.2.1",
     "eslint-plugin-prettier": "5.5.4",
     "eslint-plugin-promise": "7.2.1",
@@ -41,7 +43,7 @@
   },
   "devDependencies": {
     "@voiceflow/dependency-cruiser-config": "1.9.0",
-    "@voiceflow/eslint-plugin": "1.7.0"
+    "@voiceflow/eslint-plugin": "1.7.1-3b37425.2+3b37425"
   },
   "peerDependencies": {
     "@voiceflow/eslint-plugin": "^1"
@@ -52,5 +54,5 @@
   "volta": {
     "extends": "../../package.json"
   },
-  "gitHead": "f5a0d348e42864b285e87e723a51fb3f54e1e9c4"
+  "gitHead": "3b374257e6632aa66f4ec50e161ad49b26a44380"
 }

package/src/index.js

@@ -1,9 +1,36 @@
-import base from './base.js';
+import airbnb from './presets/airbnb.js';
+import common from './presets/common.js';
+import import_ from './presets/import.js';
 import mdx from './presets/mdx.js';
 import nest from './presets/nest.js';
+import stylistic from './presets/stylistic.js';
 import typescript from './presets/typescript.js';
 import utility from './presets/utility.js';
 import voiceflow from './presets/voiceflow.js';
 
 /** @type {import('eslint').Linter.Config[]} */
-export default [...base, ...typescript, ...mdx, ...nest, ...utility, ...voiceflow];
+export default [
+  {
+    ignores: [
+      '**/build/**',
+      '**/dist/**',
+      '**/node_modules/**',
+      '**/sonar/**',
+      '**/generated/**',
+      '**/.yarn/**',
+      '**/.yalc/**',
+      '**/.turbo/**',
+      '**/.vercel/**',
+      '**/*.json',
+    ],
+  },
+  ...airbnb,
+  ...common,
+  ...import_,
+  ...stylistic,
+  ...typescript,
+  ...mdx,
+  ...nest,
+  ...utility,
+  ...voiceflow,
+];

package/src/presets/common.js

@@ -1,5 +1,6 @@
 import comments from 'eslint-plugin-eslint-comments';
 import jsdoc from 'eslint-plugin-jsdoc';
+import node from 'eslint-plugin-n';
 import noSecrets from 'eslint-plugin-no-secrets';
 import prettier from 'eslint-plugin-prettier/recommended';
 import promise from 'eslint-plugin-promise';
@@ -15,6 +16,7 @@ export default [
       sonarjs,
       promise,
       unicorn,
+      node,
       'eslint-comments': comments,
       'you-dont-need-lodash-underscore': youDontNeed,
       'no-secrets': noSecrets,
@@ -38,10 +40,7 @@ export default [
 
     rules: {
       // error
-      'arrow-parens': ['error', 'always'],
-      'callback-return': 'error',
       'capitalized-comments': 'error',
-      'handle-callback-err': 'error',
       'max-depth': ['error', 3],
       'max-len': [
         'error',
@@ -56,11 +55,10 @@ export default [
       'max-nested-callbacks': ['error', 5],
       'max-params': ['error', 5],
       'no-console': 'error',
-      'no-process-exit': 'error',
+      'no-object-constructor': 'error',
+      'no-new-native-nonconstructor': 'error',
       'no-useless-call': 'error',
-      'quote-props': ['error', 'as-needed'],
       'prefer-arrow-callback': ['error', { allowNamedFunctions: true, allowUnboundThis: true }],
-      'lines-between-class-members': 'error',
       'no-restricted-imports': [
         'error',
         {
@@ -78,6 +76,14 @@ export default [
 
       'no-secrets/no-secrets': 'error',
 
+      'node/callback-return': 'error',
+      'node/global-require': 'error',
+      'node/handle-callback-err': 'error',
+      'node/no-deprecated-api': 'error',
+      'node/no-new-require': 'error',
+      'node/no-path-concat': 'error',
+      'node/no-process-exit': 'error',
+
       'unicorn/better-regex': 'error',
       'unicorn/prefer-set-has': 'error',
 
@@ -92,13 +98,21 @@ export default [
       'no-plusplus': 'off',
       'no-continue': 'off',
       'require-jsdoc': 'off', // not sure we want this
-      quotes: ['error', 'single', 'avoid-escape'],
       'valid-jsdoc': 'off',
       'func-names': 'off',
+      'global-require': 'off',
       'class-methods-use-this': 'off',
       camelcase: 'off',
+      'lines-around-directive': 'off',
+      'lines-between-class-members': 'off',
+      'no-buffer-constructor': 'off',
+      'no-new-object': 'off',
+      'no-new-require': 'off',
+      'no-new-symbol': 'off',
+      'no-path-concat': 'off',
       'no-underscore-dangle': 'off',
       'no-restricted-syntax': 'off',
+      'no-return-await': 'off',
       'sonarjs/new-cap': 'off',
       'sonarjs/no-unreachable': 'off',
       'sonarjs/no-commented-code': 'off',

package/src/presets/nest.js

@@ -1,4 +1,4 @@
-/** @type {import('eslint').Linter.Config} */
+/** @type {import('eslint').Linter.Config[]} */
 export default [
   {
     files: ['**/*.controller.ts', '**/*.decorator.ts', '**/*.factory.ts', '**/*.module.ts', '**/*.service.ts'],

package/src/presets/stylistic.js

@@ -0,0 +1,23 @@
+import stylistic from '@stylistic/eslint-plugin';
+
+/** @type {import('eslint').Linter.Config[]} */
+export default [
+  stylistic.configs['disable-legacy'],
+  {
+    plugins: {
+      '@stylistic': stylistic,
+    },
+    rules: {
+      '@stylistic/arrow-parens': 'error',
+      '@stylistic/padding-line-between-statements': [
+        'error',
+        { blankLine: 'always', prev: 'directive', next: '*' },
+        { blankLine: 'any', prev: 'directive', next: 'directive' },
+      ],
+      '@stylistic/lines-between-class-members': 'error',
+      '@stylistic/quote-props': ['error', 'as-needed'],
+      '@stylistic/quotes': ['error', 'single', { avoidEscape: true }],
+      '@stylistic/spaced-comment': 'error',
+    },
+  },
+];

package/src/presets/typescript.js

@@ -18,13 +18,6 @@ export default [
       ...typescript.configs.recommended.rules,
 
       // error
-      '@typescript-eslint/no-empty-interface': [
-        'error',
-        {
-          // Allow `interface T extends U {}`
-          allowSingleExtends: true,
-        },
-      ],
       '@typescript-eslint/no-empty-object-type': [
         'error',
         {

package/src/base.js

@@ -1,26 +0,0 @@
-import airbnb from './presets/airbnb.js';
-import common from './presets/common.js';
-import import_ from './presets/import.js';
-import voiceflow from './presets/voiceflow.js';
-
-/** @type {import('eslint').Linter.Config[]} */
-export default [
-  {
-    ignores: [
-      '**/build/**',
-      '**/dist/**',
-      '**/node_modules/**',
-      '**/sonar/**',
-      '**/generated/**',
-      '**/.yarn/**',
-      '**/.yalc/**',
-      '**/.turbo/**',
-      '**/.vercel/**',
-      '**/*.json',
-    ],
-  },
-  ...airbnb,
-  ...common,
-  ...import_,
-  ...voiceflow,
-];