@voiceflow/eslint-config 3.2.2 → 4.0.0

package/.eslintrc.js

@@ -1,5 +1,5 @@
 module.exports = {
-  extends: ['@voiceflow/eslint-config', '@voiceflow/eslint-config/utility'],
+  extends: ['.'],
   rules: {
     'no-secrets/no-secrets': 'off',
   },

package/config/base.js

@@ -6,10 +6,12 @@ module.exports = {
     'plugin:eslint-comments/recommended',
     'plugin:you-dont-need-lodash-underscore/compatible',
   ],
-  plugins: ['sonarjs', 'promise', 'optimize-regex', 'prefer-arrow', 'no-secrets', 'filenames', 'you-dont-need-lodash-underscore'],
+  plugins: ['sonarjs', 'promise', 'prefer-arrow', 'no-secrets', 'you-dont-need-lodash-underscore', 'unicorn'],
   parserOptions: {
     ecmaVersion: 9,
   },
+  // https://eslint.org/docs/user-guide/configuring/rules#report-unused-eslint-disable-comments
+  reportUnusedDisableDirectives: true,
   rules: {
     // error
     'arrow-parens': ['error', 'always'],
@@ -50,7 +52,8 @@ module.exports = {
 
     'no-secrets/no-secrets': 'error',
 
-    'optimize-regex/optimize-regex': 'error',
+    'unicorn/better-regex': 'error',
+    'unicorn/prefer-string-slice': 'error',
 
     // warn
     'sonarjs/no-duplicate-string': 'warn',
@@ -62,5 +65,9 @@ module.exports = {
     quotes: ['error', 'single', 'avoid-escape'],
     'valid-jsdoc': 'off',
     'func-names': 'off',
+    'class-methods-use-this': 'off',
+    'import/prefer-default-export': 'off',
+    camelcase: 'off',
+    'no-underscore-dangle': 'off',
   },
 };

package/config/import.js

@@ -19,6 +19,7 @@ module.exports = {
     // off
     'sort-imports': 'off',
     'import/order': 'off',
+    'import/no-named-as-default': 'off',
   },
   settings: {
     'import/extensions': ['.js', '.ts', '.jsx', '.tsx'],

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@voiceflow/eslint-config",
   "description": "ESLint config for voiceflow",
-  "version": "3.2.2",
+  "version": "4.0.0",
   "author": "Eric Hacke",
   "bugs": {
     "url": "https://github.com/voiceflow/eslint-config/issues"
@@ -12,45 +12,43 @@
     }
   },
   "dependencies": {
-    "@typescript-eslint/eslint-plugin": "^4.20.0",
-    "@typescript-eslint/parser": "^4.20.0",
+    "@typescript-eslint/eslint-plugin": "^4.31.0",
+    "@typescript-eslint/parser": "^4.31.0",
     "eslint-config-airbnb-base": "^14.2.1",
-    "eslint-config-prettier": "^8.1.0",
-    "eslint-import-resolver-typescript": "^2.4.0",
-    "eslint-plugin-compat": "^3.1.1",
-    "eslint-plugin-cypress": "^2.11.2",
+    "eslint-config-prettier": "^8.3.0",
+    "eslint-import-resolver-typescript": "^2.5.0",
+    "eslint-plugin-compat": "^3.13.0",
+    "eslint-plugin-cypress": "^2.11.3",
     "eslint-plugin-eslint-comments": "^3.1.1",
-    "eslint-plugin-filenames": "^1.3.2",
-    "eslint-plugin-import": "^2.22.1",
-    "eslint-plugin-jest": "^24.3.2",
+    "eslint-plugin-import": "^2.24.2",
+    "eslint-plugin-jest": "^24.4.0",
     "eslint-plugin-jsx-a11y": "^6.2.1",
-    "eslint-plugin-lodash": "^7.2.0",
-    "eslint-plugin-mocha": "^8.1.0",
+    "eslint-plugin-lodash": "^7.3.0",
+    "eslint-plugin-mocha": "^9.0.0",
     "eslint-plugin-no-secrets": "^0.8.9",
-    "eslint-plugin-optimize-regex": "^1.2.0",
     "eslint-plugin-prefer-arrow": "^1.2.3",
-    "eslint-plugin-prettier": "^3.1.0",
-    "eslint-plugin-promise": "^4.3.1",
-    "eslint-plugin-react": "^7.23.1",
+    "eslint-plugin-prettier": "^4.0.0",
+    "eslint-plugin-promise": "^5.1.0",
+    "eslint-plugin-react": "^7.25.1",
     "eslint-plugin-react-hooks": "^4.2.0",
     "eslint-plugin-simple-import-sort": "^7.0.0",
-    "eslint-plugin-sonarjs": "^0.6.0",
+    "eslint-plugin-sonarjs": "^0.10.0",
+    "eslint-plugin-unicorn": "^37.0.1",
     "eslint-plugin-xss": "^0.1.9",
-    "eslint-plugin-you-dont-need-lodash-underscore": "^6.11.0"
+    "eslint-plugin-you-dont-need-lodash-underscore": "^6.12.0"
   },
   "devDependencies": {
-    "@voiceflow/commitlint-config": "^1.1.0",
-    "@voiceflow/eslint-config": "^3.2.1",
-    "@voiceflow/git-branch-check": "^1.2.0",
-    "@voiceflow/prettier-config": "^1.0.5",
+    "@voiceflow/commitlint-config": "1.1.0",
+    "@voiceflow/git-branch-check": "1.2.0",
+    "@voiceflow/prettier-config": "1.0.5",
     "commitizen": "^4.2.4",
-    "commitlint": "^12.1.4",
+    "commitlint": "^13.1.0",
     "cz-conventional-changelog": "^3.3.0",
-    "eslint": "^7.26.0",
+    "eslint": "^7.32.0",
     "fixpack": "^4.0.0",
-    "husky": "^6.0.0",
-    "lint-staged": "^11.0.0",
-    "prettier": "^2.3.0"
+    "husky": "^7.0.2",
+    "lint-staged": "^11.1.2",
+    "prettier": "^2.4.0"
   },
   "files": [
     "*.js",

package/typescript.js

@@ -6,12 +6,26 @@ module.exports = {
       files: ['*.ts', '*.tsx'],
       extends: ['plugin:@typescript-eslint/recommended'],
       rules: {
+        // error
+        '@typescript-eslint/no-empty-interface': [
+          'error',
+          {
+            // Allow `interface T extends U {}`
+            allowSingleExtends: true,
+          },
+        ],
+        '@typescript-eslint/consistent-type-definitions': ['error', 'interface'],
+
         // off
         'no-shadow': 'off',
         'no-unused-vars': 'off',
         'no-use-before-define': 'off',
         'no-useless-constructor': 'off',
 
+        '@typescript-eslint/explicit-module-boundary-types': 'off',
+        '@typescript-eslint/no-non-null-assertion': 'off',
+        '@typescript-eslint/no-explicit-any': 'off',
+
         'import/no-unresolved': 'off',
         'import/export': 'off',
         'import/named': 'off',

package/utility.js

@@ -8,9 +8,6 @@ module.exports = {
       },
     ],
 
-    // off
-    'import/prefer-default-export': 'off',
-
     '@typescript-eslint/no-var-requires': 'off',
   },
 };