@vltpkg/graph 1.0.0-rc.30 → 1.0.0-rc.32

package/dist/ideal/append-nodes.js

@@ -175,6 +175,19 @@ const fetchManifestsForDeps = async (packageInfo, graph, fromNode, deps, scurry,
             reuseTasks.push({ type, spec, fromNode, toNode: existingNode });
             continue;
         }
+        // workspace: specs can only resolve to local workspace packages.
+        // If we didn't find a matching workspace node above, it means either
+        // the workspace doesn't exist or its version doesn't satisfy the range.
+        if (spec.final.type === 'workspace') {
+            const wsVersion = graph.nodesByName
+                .get(spec.name)
+                ?.values()
+                .next().value?.version;
+            throw error(wsVersion ?
+                `workspace dependency ${spec} does not match the ` +
+                    `local workspace version (${wsVersion})`
+                : `no workspace found matching ${spec}`, { spec });
+        }
         // is the current edge pointint go an optional dependency?
         const edgeOptional = type === 'optional' || type === 'peerOptional';
         // Start manifest fetch immediately for parallel processing

package/dist/ideal/get-importer-specs.js

@@ -49,8 +49,20 @@ export const getImporterSpecs = (options) => {
                 // skip if the edge exists and already uses the same spec
                 if (edge?.to && depSpec === edge.spec.bareSpec)
                     continue;
+                const spec = Spec.parse(depName, depSpec, options);
+                // if a workspace dep references a workspace that no longer exists
+                // (folder was removed), mark it for removal instead of trying to
+                // resolve it — the workspace can't be satisfied
+                if (spec.type === 'workspace' && !edge?.to) {
+                    const wsExists = [...graph.importers].some(n => n.name === depName);
+                    if (!wsExists) {
+                        removeDeps.add(depName);
+                        removeResult.modifiedDependencies = true;
+                        continue;
+                    }
+                }
                 const dependency = asDependency({
-                    spec: Spec.parse(depName, depSpec, options),
+                    spec,
                     type: shorten(depType, depName, importer.manifest),
                 });
                 addDeps.set(depName, dependency);

package/dist/lockfile/load-edges.js

@@ -7,6 +7,11 @@ import { isDependencyTypeShort } from "../dependencies.js";
 const retrieveNodeFromGraph = (key, value, graph, fromId, seenNodes) => {
     const foundNode = graph.nodes.get(asDepID(fromId));
     if (!foundNode) {
+        // workspace or file nodes may be missing if the folder was removed
+        // while still referenced in the lockfile — skip gracefully
+        if (fromId.startsWith('workspace') || fromId.startsWith('file')) {
+            return undefined;
+        }
         throw error('Edge info missing its `from` node', {
             found: {
                 nodes: [...graph.nodes].map(([id]) => id),
@@ -59,6 +64,9 @@ export const loadEdges = (graph, edges, options) => {
         else {
             fromNode = retrieveNodeFromGraph(key, value, graph, fromId);
         }
+        // skip edges from workspace nodes that no longer exist
+        if (!fromNode)
+            continue;
         const toId = valRest.substring(vrSplit + 1);
         let toNode = undefined;
         if (toId !== 'MISSING') {

package/dist/reify/index.js

@@ -70,7 +70,25 @@ export const reify = async (options) => {
     const skippable = skipOptionalOnly && !options.update;
     const res = { diff };
     if (!diff.hasChanges() || skippable) {
-        // nothing to do, so just return the diff
+        // Even when there are no changes to reify, ensure lockfiles
+        // exist on disk. This handles the case where a project has no
+        // dependencies (or only workspace importers) but still needs
+        // lockfiles written on the first install.
+        if (!scurry.lstatSync('vlt-lock.json') ||
+            !scurry.lstatSync('node_modules/.vlt-lock.json')) {
+            saveHidden(options);
+            const lfData = lockfileData(options);
+            saveData(lfData, scurry.resolve('vlt-lock.json'), false);
+        }
+        // Even with no reify changes, report nodes that still need building.
+        // Build state is persisted in the hidden lockfile and loaded into the
+        // actual graph, so check there for pending builds.
+        const pending = [...actual.nodes.values()]
+            .filter(n => n.buildState === 'needed')
+            .map(n => n.id);
+        if (pending.length) {
+            res.buildQueue = pending;
+        }
         done();
         return res;
     }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@vltpkg/graph",
   "description": "A library that helps understanding & expressing what happens on an install",
-  "version": "1.0.0-rc.30",
+  "version": "1.0.0-rc.32",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/vltpkg/vltpkg.git",
@@ -13,26 +13,26 @@
     "url": "http://vlt.sh"
   },
   "dependencies": {
-    "@vltpkg/cmd-shim": "1.0.0-rc.30",
-    "@vltpkg/dep-id": "1.0.0-rc.30",
-    "@vltpkg/dss-breadcrumb": "1.0.0-rc.30",
-    "@vltpkg/error-cause": "1.0.0-rc.30",
-    "@vltpkg/fast-split": "1.0.0-rc.30",
-    "@vltpkg/graph-run": "1.0.0-rc.30",
-    "@vltpkg/init": "1.0.0-rc.30",
-    "@vltpkg/output": "1.0.0-rc.30",
-    "@vltpkg/package-info": "1.0.0-rc.30",
-    "@vltpkg/package-json": "1.0.0-rc.30",
-    "@vltpkg/pick-manifest": "1.0.0-rc.30",
-    "@vltpkg/query": "1.0.0-rc.30",
-    "@vltpkg/rollback-remove": "1.0.0-rc.30",
-    "@vltpkg/run": "1.0.0-rc.30",
-    "@vltpkg/satisfies": "1.0.0-rc.30",
-    "@vltpkg/security-archive": "1.0.0-rc.30",
-    "@vltpkg/spec": "1.0.0-rc.30",
-    "@vltpkg/types": "1.0.0-rc.30",
-    "@vltpkg/vlt-json": "1.0.0-rc.30",
-    "@vltpkg/workspaces": "1.0.0-rc.30",
+    "@vltpkg/cmd-shim": "1.0.0-rc.32",
+    "@vltpkg/dep-id": "1.0.0-rc.32",
+    "@vltpkg/dss-breadcrumb": "1.0.0-rc.32",
+    "@vltpkg/error-cause": "1.0.0-rc.32",
+    "@vltpkg/fast-split": "1.0.0-rc.32",
+    "@vltpkg/graph-run": "1.0.0-rc.32",
+    "@vltpkg/init": "1.0.0-rc.32",
+    "@vltpkg/output": "1.0.0-rc.32",
+    "@vltpkg/package-info": "1.0.0-rc.32",
+    "@vltpkg/package-json": "1.0.0-rc.32",
+    "@vltpkg/pick-manifest": "1.0.0-rc.32",
+    "@vltpkg/query": "1.0.0-rc.32",
+    "@vltpkg/rollback-remove": "1.0.0-rc.32",
+    "@vltpkg/run": "1.0.0-rc.32",
+    "@vltpkg/satisfies": "1.0.0-rc.32",
+    "@vltpkg/security-archive": "1.0.0-rc.32",
+    "@vltpkg/spec": "1.0.0-rc.32",
+    "@vltpkg/types": "1.0.0-rc.32",
+    "@vltpkg/vlt-json": "1.0.0-rc.32",
+    "@vltpkg/workspaces": "1.0.0-rc.32",
     "path-scurry": "^2.0.1",
     "promise-call-limit": "^3.0.2"
   },