@vizzly/dashboard 0.15.0-dev-7c9658e993e6c1d321c4d69f2e166bbb37cca3aa → 0.15.0-dev-fc9a212537551949051fa3edc71c9f0f8be72497

package/dist/dashboard.cjs.development.js

@@ -40318,7 +40318,7 @@ var FiltersModal = function FiltersModal(_ref) {
     show = _ref.show,
     _onClose = _ref.onClose,
     source = _ref.source,
-    onDeleteItem = _ref.onDeleteItem,
+    _onDeleteItem = _ref.onDeleteItem,
     onUpdate = _ref.onUpdate;
   var dataSets = allDataSets.filter(function (dS) {
     return !dS.preAggregated;
@@ -40382,7 +40382,8 @@ var FiltersModal = function FiltersModal(_ref) {
           filterIndex: filterIndex
         });
       } : function () {},
-      id: "filter_" + filterIndex
+      id: "filter_" + filterIndex,
+      context: _extends({}, filter)
     });
   }).filter(function (item) {
     return !item.isHiddenFilter;
@@ -40401,7 +40402,18 @@ var FiltersModal = function FiltersModal(_ref) {
       }), jsxRuntime.jsx(Modal.Content, {
         children: jsxRuntime.jsx(ListView, {
           mode: mode,
-          onDeleteItem: onDeleteItem,
+          onDeleteItem: function onDeleteItem(_index, filterToRemove) {
+            var newFilters = [].concat(filters);
+            var index = newFilters.findIndex(function (f) {
+              return JSON.stringify(f) === JSON.stringify(filterToRemove);
+            });
+            if (index >= -1) {
+              newFilters.splice(index, 1);
+              _onDeleteItem(newFilters);
+            } else {
+              logDebug('Failed to find filter to remove', filters, filterToRemove);
+            }
+          },
           newItemBtn: {
             callToAction: source === 'global' ? textOverride('new_dashboard_filter', 'New dashboard filter') : textOverride('new_local_filter', 'New local filter'),
             onClick: function onClick() {
@@ -40486,10 +40498,8 @@ var ManageGlobalFiltersButton = function ManageGlobalFiltersButton() {
     var combineFilters = updateFilters(dashboard.globalFilters, payload);
     setGlobalFilters(combineFilters);
   };
-  var removeFilter = function removeFilter(index) {
-    var newGlobalFilters = [].concat(dashboard.globalFilters);
-    newGlobalFilters.splice(index, 1);
-    setGlobalFilters(newGlobalFilters);
+  var onFilterRemoved = function onFilterRemoved(remainingFilters) {
+    setGlobalFilters(remainingFilters);
   };
   return jsxRuntime.jsxs(jsxRuntime.Fragment, {
     children: [jsxRuntime.jsx(FilterButton, {
@@ -40504,7 +40514,7 @@ var ManageGlobalFiltersButton = function ManageGlobalFiltersButton() {
       show: isManageGlobalFiltersOpen,
       onUpdate: handleUpdateFilters,
       source: "global",
-      onDeleteItem: removeFilter,
+      onDeleteItem: onFilterRemoved,
       onClose: function onClose() {
         trackEvent('manageGlobalFilters.close');
         setManageGlobalFiltersOpen(false);
@@ -58374,10 +58384,8 @@ var LocalFiltersModal = function LocalFiltersModal(props) {
     var combineFilters = updateFilters(localFilters, payload);
     props == null || props.setLocalFilters(combineFilters);
   };
-  var removeFilter = function removeFilter(index) {
-    var newFilters = [].concat(localFilters);
-    newFilters.splice(index, 1);
-    props == null || props.setLocalFilters(newFilters);
+  var onFilterRemoved = function onFilterRemoved(remainingFilters) {
+    props.setLocalFilters(remainingFilters);
   };
   return jsxRuntime.jsx(FiltersModal, {
     dataSets: [dataSet],
@@ -58385,7 +58393,7 @@ var LocalFiltersModal = function LocalFiltersModal(props) {
     show: props == null ? void 0 : props.show,
     onUpdate: handleUpdateFilters,
     source: "local",
-    onDeleteItem: removeFilter,
+    onDeleteItem: onFilterRemoved,
     onClose: function onClose() {
       return props == null ? void 0 : props.onClose();
     }