@vizzly-testing/cli 0.7.0 → 0.7.2

package/dist/commands/finalize.js

@@ -38,7 +38,7 @@ export async function finalizeCommand(parallelId, options = {}, globalOptions =
     // Create service container and get API service
     ui.startSpinner('Finalizing parallel build...');
     const container = await createServiceContainer(config, 'finalize');
-    const apiService = await container.get('api');
+    const apiService = await container.get('apiService');
     ui.stopSpinner();
 
     // Call finalize endpoint

package/dist/services/api-service.js

@@ -113,29 +113,44 @@ export class ApiService {
 
   /**
    * Check if SHAs already exist on the server
-   * @param {string[]} shas - Array of SHA256 hashes to check
+   * @param {string[]|Object[]} shas - Array of SHA256 hashes to check, or array of screenshot objects with metadata
    * @param {string} buildId - Build ID for screenshot record creation
    * @returns {Promise<Object>} Response with existing SHAs and screenshot data
    */
   async checkShas(shas, buildId) {
     try {
+      let requestBody;
+
+      // Check if we're using the new signature-based format (array of objects) or legacy format (array of strings)
+      if (Array.isArray(shas) && shas.length > 0 && typeof shas[0] === 'object' && shas[0].sha256) {
+        // New signature-based format
+        requestBody = {
+          buildId,
+          screenshots: shas
+        };
+      } else {
+        // Legacy SHA-only format
+        requestBody = {
+          shas,
+          buildId
+        };
+      }
       const response = await this.request('/api/sdk/check-shas', {
         method: 'POST',
         headers: {
           'Content-Type': 'application/json'
         },
-        body: JSON.stringify({
-          shas,
-          buildId
-        })
+        body: JSON.stringify(requestBody)
       });
       return response;
     } catch (error) {
       // Continue without deduplication on error
       console.debug('SHA check failed, continuing without deduplication:', error.message);
+      // Extract SHAs for fallback response regardless of format
+      const shaList = Array.isArray(shas) && shas.length > 0 && typeof shas[0] === 'object' ? shas.map(s => s.sha256) : shas;
       return {
         existing: [],
-        missing: shas,
+        missing: shaList,
         screenshots: []
       };
     }
@@ -167,13 +182,22 @@ export class ApiService {
       });
     }
 
-    // Normal flow with SHA deduplication
+    // Normal flow with SHA deduplication using signature-based format
     const sha256 = crypto.createHash('sha256').update(buffer).digest('hex');
 
-    // Check if this SHA already exists
-    const checkResult = await this.checkShas([sha256], buildId);
+    // Create screenshot object with signature data for checking
+    const screenshotCheck = [{
+      sha256,
+      name,
+      browser: metadata?.browser || 'chrome',
+      viewport_width: metadata?.viewport?.width || 1920,
+      viewport_height: metadata?.viewport?.height || 1080
+    }];
+
+    // Check if this SHA with signature already exists
+    const checkResult = await this.checkShas(screenshotCheck, buildId);
     if (checkResult.existing && checkResult.existing.includes(sha256)) {
-      // File already exists, screenshot record was automatically created
+      // File already exists with same signature, screenshot record was automatically created
       const screenshot = checkResult.screenshots?.find(s => s.sha256 === sha256);
       return {
         message: 'Screenshot already exists, skipped upload',
@@ -184,7 +208,7 @@ export class ApiService {
       };
     }
 
-    // File doesn't exist, proceed with upload
+    // File doesn't exist or has different signature, proceed with upload
     return this.request(`/api/sdk/builds/${buildId}/screenshots`, {
       method: 'POST',
       headers: {

package/dist/services/uploader.js

@@ -274,29 +274,31 @@ async function processFiles(files, signal, onProgress) {
 }
 
 /**
- * Check which files already exist on the server
+ * Check which files already exist on the server using signature-based deduplication
  */
 async function checkExistingFiles(fileMetadata, api, signal, buildId) {
-  const allShas = fileMetadata.map(f => f.sha256);
   const existingShas = new Set();
   const allScreenshots = [];
 
-  // Check in batches
-  for (let i = 0; i < allShas.length; i += DEFAULT_SHA_CHECK_BATCH_SIZE) {
+  // Check in batches using the new signature-based format
+  for (let i = 0; i < fileMetadata.length; i += DEFAULT_SHA_CHECK_BATCH_SIZE) {
     if (signal.aborted) throw new UploadError('Operation cancelled');
-    const batch = allShas.slice(i, i + DEFAULT_SHA_CHECK_BATCH_SIZE);
+    const batch = fileMetadata.slice(i, i + DEFAULT_SHA_CHECK_BATCH_SIZE);
+
+    // Convert file metadata to screenshot objects with signature data
+    const screenshotBatch = batch.map(file => ({
+      sha256: file.sha256,
+      name: file.filename.replace(/\.png$/, ''),
+      // Remove .png extension for name
+      // Extract browser from filename if available (e.g., "homepage-chrome.png" -> "chrome")
+      browser: extractBrowserFromFilename(file.filename) || 'chrome',
+      // Default to chrome
+      // Default viewport dimensions (these could be extracted from filename or metadata if available)
+      viewport_width: 1920,
+      viewport_height: 1080
+    }));
     try {
-      const res = await api.request('/api/sdk/check-shas', {
-        method: 'POST',
-        headers: {
-          'Content-Type': 'application/json'
-        },
-        body: JSON.stringify({
-          shas: batch,
-          buildId
-        }),
-        signal
-      });
+      const res = await api.checkShas(screenshotBatch, buildId);
       const {
         existing = [],
         screenshots = []
@@ -315,6 +317,22 @@ async function checkExistingFiles(fileMetadata, api, signal, buildId) {
   };
 }
 
+/**
+ * Extract browser name from filename
+ * @param {string} filename - The screenshot filename
+ * @returns {string|null} Browser name or null if not found
+ */
+function extractBrowserFromFilename(filename) {
+  const browsers = ['chrome', 'firefox', 'safari', 'edge', 'webkit'];
+  const lowerFilename = filename.toLowerCase();
+  for (const browser of browsers) {
+    if (lowerFilename.includes(browser)) {
+      return browser;
+    }
+  }
+  return null;
+}
+
 /**
  * Upload files to Vizzly
  */

package/dist/types/services/api-service.d.ts

@@ -41,11 +41,11 @@ export class ApiService {
     createBuild(metadata: any): Promise<any>;
     /**
      * Check if SHAs already exist on the server
-     * @param {string[]} shas - Array of SHA256 hashes to check
+     * @param {string[]|Object[]} shas - Array of SHA256 hashes to check, or array of screenshot objects with metadata
      * @param {string} buildId - Build ID for screenshot record creation
      * @returns {Promise<Object>} Response with existing SHAs and screenshot data
      */
-    checkShas(shas: string[], buildId: string): Promise<any>;
+    checkShas(shas: string[] | any[], buildId: string): Promise<any>;
     /**
      * Upload a screenshot with SHA checking
      * @param {string} buildId - Build ID

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vizzly-testing/cli",
-  "version": "0.7.0",
+  "version": "0.7.2",
   "description": "Visual review platform for UI developers and designers",
   "keywords": [
     "visual-testing",