@vizzly-testing/cli 0.39.1 → 0.39.2

package/dist/{server/handlers/tdd-handler.js → domains/tdd/screenshot-handler.js}

@@ -2,119 +2,15 @@ import { Buffer as defaultBuffer } from 'node:buffer';
 import { existsSync as defaultExistsSync, readFileSync as defaultReadFileSync, unlinkSync as defaultUnlinkSync, writeFileSync as defaultWriteFileSync } from 'node:fs';
 import { join as defaultJoin, resolve as defaultResolve } from 'node:path';
 import { getDimensionsSync as defaultGetDimensionsSync } from '@vizzly-testing/honeydiff';
-import { TddService as DefaultTddService } from '../../tdd/tdd-service.js';
-import { detectImageInputType as defaultDetectImageInputType } from '../../utils/image-input-detector.js';
-import * as defaultOutput from '../../utils/output.js';
-import { safePath as defaultSafePath, sanitizeScreenshotName as defaultSanitizeScreenshotName, validateScreenshotProperties as defaultValidateScreenshotProperties } from '../../utils/security.js';
-
-/**
- * Build the flat internal comparison shape. Width and height always come from
- * the captured image. The untouched user bag remains available in metadata.
- */
-export const extractProperties = (validatedProperties, imageDimensions = {}) => {
-  if (!validatedProperties) return {};
-  return {
-    ...validatedProperties,
-    viewport_width: imageDimensions.width ?? null,
-    viewport_height: imageDimensions.height ?? null,
-    browser: validatedProperties.browser ?? null,
-    metadata: validatedProperties
-  };
-};
-
-/**
- * Convert absolute file paths to web-accessible URLs
- */
-export const convertPathToUrl = (filePath, vizzlyDir) => {
-  if (!filePath) return null;
-  // Convert absolute path to relative path from .vizzly directory
-  if (filePath.startsWith(vizzlyDir)) {
-    let relativePath = filePath.substring(vizzlyDir.length + 1);
-    return `/images/${relativePath}`;
-  }
-  return filePath;
-};
-
-/**
- * Group comparisons by screenshot name with variant structure
- * Matches cloud product's grouping logic from comparison.js
- */
-export const groupComparisons = comparisons => {
-  const groups = new Map();
-
-  // Group by screenshot name
-  for (const comp of comparisons) {
-    if (!groups.has(comp.name)) {
-      groups.set(comp.name, {
-        name: comp.name,
-        comparisons: [],
-        browsers: new Set(),
-        viewports: new Set(),
-        devices: new Set(),
-        totalVariants: 0
-      });
-    }
-    const group = groups.get(comp.name);
-    group.comparisons.push(comp);
-    group.totalVariants++;
-
-    // Track unique browsers, viewports, devices
-    if (comp.properties?.browser) {
-      group.browsers.add(comp.properties.browser);
-    }
-    if (comp.properties?.viewport_width && comp.properties?.viewport_height) {
-      group.viewports.add(`${comp.properties.viewport_width}x${comp.properties.viewport_height}`);
-    }
-    if (comp.properties?.device) {
-      group.devices.add(comp.properties.device);
-    }
-  }
-
-  // Convert to final structure
-  return Array.from(groups.values()).map(group => {
-    const browsers = Array.from(group.browsers);
-    const viewports = Array.from(group.viewports);
-    const devices = Array.from(group.devices);
-
-    // Build variants structure (browser -> viewport -> comparisons)
-    const variants = {};
-    group.comparisons.forEach(comp => {
-      const browser = comp.properties?.browser || null;
-      const viewport = comp.properties?.viewport_width && comp.properties?.viewport_height ? `${comp.properties.viewport_width}x${comp.properties.viewport_height}` : null;
-      if (!variants[browser]) variants[browser] = {};
-      if (!variants[browser][viewport]) variants[browser][viewport] = [];
-      variants[browser][viewport].push(comp);
-    });
-
-    // Determine grouping strategy
-    let groupingStrategy = 'flat';
-    if (browsers.length > 1) groupingStrategy = 'browser';else if (viewports.length > 1) groupingStrategy = 'viewport';
-
-    // Sort comparisons by viewport area (largest first)
-    group.comparisons.sort((a, b) => {
-      const aArea = (a.properties?.viewport_width || 0) * (a.properties?.viewport_height || 0);
-      const bArea = (b.properties?.viewport_width || 0) * (b.properties?.viewport_height || 0);
-      if (bArea !== aArea) return bArea - aArea;
-      return (b.properties?.viewport_width || 0) - (a.properties?.viewport_width || 0);
-    });
-    return {
-      ...group,
-      browsers,
-      viewports,
-      devices: Array.from(devices),
-      variants,
-      groupingStrategy
-    };
-  }).sort((a, b) => {
-    // Sort groups: multi-variant first (by variant count), then singles alphabetically
-    if (a.totalVariants > 1 && b.totalVariants === 1) return -1;
-    if (a.totalVariants === 1 && b.totalVariants > 1) return 1;
-    if (a.totalVariants > 1 && b.totalVariants > 1) {
-      return b.totalVariants - a.totalVariants;
-    }
-    return a.name.localeCompare(b.name);
-  });
-};
+import * as defaultOutput from '../../shared/output.js';
+import { safePath as defaultSafePath } from '../../shared/paths.js';
+import { convertPathToUrl } from '../reports/report.serializers.js';
+import { createEmptyReport, removeReportComparison, upsertReportComparison } from '../reports/report-state.js';
+import { createReportStore } from '../reports/report-store.js';
+import { detectImageInputType as defaultDetectImageInputType } from '../screenshots/image-input.js';
+import { extractProperties } from '../screenshots/screenshot.normalizers.js';
+import { sanitizeScreenshotName as defaultSanitizeScreenshotName, validateScreenshotProperties as defaultValidateScreenshotProperties } from '../screenshots/screenshot.validations.js';
+import { TddService as DefaultTddService } from './tdd.service.js';
 export const createTddHandler = (config, workingDir, baselineBuild, baselineComparison, setBaseline = false, deps = {}) => {
   // Inject dependencies with defaults
   let {
@@ -133,133 +29,45 @@ export const createTddHandler = (config, workingDir, baselineBuild, baselineComp
     validateScreenshotProperties = defaultValidateScreenshotProperties,
     output = defaultOutput
   } = deps;
-  const tddService = new TddService(config, workingDir, setBaseline);
-  const reportPath = join(workingDir, '.vizzly', 'report-data.json');
-  const detailsPath = join(workingDir, '.vizzly', 'comparison-details.json');
+  let tddService = new TddService(config, workingDir, setBaseline);
+  let reportStore = createReportStore(workingDir, {
+    existsSync,
+    readFileSync,
+    writeFileSync,
+    unlinkSync,
+    join,
+    output
+  });
   let capture = {
     accepted: 0,
     rejected: 0
   };
-  let clearJsonFile = path => {
-    if (existsSync(path)) {
-      unlinkSync(path);
-    }
-  };
+  let {
+    updateDetails: updateComparisonDetails,
+    removeDetails: removeComparisonDetails
+  } = reportStore;
   let prepareRunArtifacts = () => {
     capture = {
       accepted: 0,
       rejected: 0
     };
-    clearJsonFile(reportPath);
-    clearJsonFile(detailsPath);
+    reportStore.clear();
     tddService.clearRunData?.();
   };
-
-  /**
-   * Read heavy comparison details from comparison-details.json
-   * Returns a map of comparison ID -> heavy fields
-   */
-  const readComparisonDetails = () => {
-    try {
-      if (!existsSync(detailsPath)) return {};
-      return JSON.parse(readFileSync(detailsPath, 'utf8'));
-    } catch (error) {
-      output.debug('Failed to read comparison details:', error);
-      return {};
-    }
-  };
-
-  /**
-   * Persist heavy fields for a comparison to comparison-details.json
-   * This file is NOT watched by SSE, so writes here don't trigger broadcasts
-   * Skips writing if all heavy fields are empty (passed comparisons)
-   */
-  const updateComparisonDetails = (id, heavyFields) => {
-    let hasData = Object.values(heavyFields).some(v => v != null && (!Array.isArray(v) || v.length > 0));
-    if (!hasData) return;
-    let details = readComparisonDetails();
-    details[id] = heavyFields;
-    writeFileSync(detailsPath, JSON.stringify(details));
-  };
-
-  /**
-   * Remove a comparison's heavy fields from comparison-details.json
-   */
-  const removeComparisonDetails = id => {
-    let details = readComparisonDetails();
-    delete details[id];
-    writeFileSync(detailsPath, JSON.stringify(details));
-  };
-  const readReportData = () => {
+  let readReportData = () => {
     try {
-      if (!existsSync(reportPath)) {
-        return {
-          timestamp: Date.now(),
-          comparisons: [],
-          summary: {
-            total: 0,
-            passed: 0,
-            failed: 0,
-            errors: 0
-          }
-        };
-      }
-      const data = readFileSync(reportPath, 'utf8');
-      return JSON.parse(data);
+      return reportStore.readReport() || createEmptyReport(Date.now());
     } catch (error) {
       output.error('Failed to read report data:', error);
-      return {
-        timestamp: Date.now(),
-        comparisons: [],
-        summary: {
-          total: 0,
-          passed: 0,
-          failed: 0,
-          errors: 0
-        }
-      };
+      return createEmptyReport(Date.now());
     }
   };
-  const updateComparison = newComparison => {
+  let updateComparison = comparison => {
     try {
-      const reportData = readReportData();
-
-      // Ensure comparisons array exists (backward compatibility)
-      if (!reportData.comparisons) {
-        reportData.comparisons = [];
-      }
-
-      // Find existing comparison by unique ID
-      // This ensures we update the correct variant even with same name
-      const existingIndex = reportData.comparisons.findIndex(c => c.id === newComparison.id);
-      if (existingIndex >= 0) {
-        // Preserve initialStatus from the original comparison
-        // This keeps sort order stable when status changes (e.g., after approval)
-        const initialStatus = reportData.comparisons[existingIndex].initialStatus;
-        reportData.comparisons[existingIndex] = {
-          ...newComparison,
-          initialStatus: initialStatus || newComparison.status
-        };
-      } else {
-        // New comparison - set initialStatus to current status
-        reportData.comparisons.push({
-          ...newComparison,
-          initialStatus: newComparison.status
-        });
-      }
-
-      // Update summary (groups computed client-side from comparisons)
-      reportData.timestamp = Date.now();
-      reportData.summary = {
-        total: reportData.comparisons.length,
-        passed: reportData.comparisons.filter(c => c.status === 'passed' || c.status === 'baseline-created' || c.status === 'new').length,
-        failed: reportData.comparisons.filter(c => c.status === 'failed').length,
-        rejected: reportData.comparisons.filter(c => c.status === 'rejected').length,
-        errors: reportData.comparisons.filter(c => c.status === 'error').length
-      };
-      writeFileSync(reportPath, JSON.stringify(reportData));
+      reportStore.writeReport(upsertReportComparison(readReportData(), comparison, Date.now()));
     } catch (error) {
       output.error('Failed to update comparison:', error);
+      throw error;
     }
   };
   const initialize = async () => {
@@ -281,13 +89,7 @@ export const createTddHandler = (config, workingDir, baselineBuild, baselineComp
     }
     const baseline = await tddService.loadBaseline();
     if (!baseline) {
-      // Only download baselines if explicitly requested via baseline flags
-      if ((baselineBuild || baselineComparison) && config.apiKey) {
-        output.debug('tdd', 'downloading baselines');
-        await tddService.downloadBaselines(config.build?.environment || 'test', config.build?.branch || null, baselineBuild, baselineComparison);
-      } else {
-        output.debug('tdd', 'no baselines yet');
-      }
+      output.debug('tdd', 'no baselines yet');
     } else {
       output.debug('tdd', `baseline: ${baseline.buildName}`);
     }
@@ -637,27 +439,16 @@ export const createTddHandler = (config, workingDir, baselineBuild, baselineComp
       let deletedBaselines = 0;
       let deletedCurrents = 0;
       let deletedDiffs = 0;
-      let deleteResetFile = (imagePath, label, name) => {
-        if (!imagePath) return 0;
-        try {
-          let filePath = safePath(workingDir, '.vizzly', imagePath.replace('/images/', ''));
-          if (!existsSync(filePath)) return 0;
-          unlinkSync(filePath);
-          if (label === 'diff') {
-            output.debug(`Deleted diff for ${name}`);
-          }
-          return 1;
-        } catch (error) {
-          output.warn(`Failed to delete ${label} for ${name}: ${error.message}`);
-          return 0;
-        }
-      };
 
       // Delete all baseline, current, and diff images
       for (let comparison of reportData.comparisons) {
-        deletedBaselines += deleteResetFile(comparison.baseline, 'baseline', comparison.name);
-        deletedCurrents += deleteResetFile(comparison.current, 'current screenshot', comparison.name);
-        deletedDiffs += deleteResetFile(comparison.diff, 'diff', comparison.name);
+        deletedBaselines += safeDeleteFile(comparison.baseline, 'baseline', comparison.name, {
+          logDeletion: false
+        });
+        deletedCurrents += safeDeleteFile(comparison.current, 'current screenshot', comparison.name, {
+          logDeletion: false
+        });
+        deletedDiffs += safeDeleteFile(comparison.diff, 'diff', comparison.name);
       }
 
       // Delete baseline metadata
@@ -670,24 +461,7 @@ export const createTddHandler = (config, workingDir, baselineBuild, baselineComp
           output.warn(`Failed to delete baseline metadata: ${error.message}`);
         }
       }
-
-      // Clear the report data entirely - fresh start
-      const freshReportData = {
-        timestamp: Date.now(),
-        comparisons: [],
-        summary: {
-          total: 0,
-          passed: 0,
-          failed: 0,
-          errors: 0
-        }
-      };
-      writeFileSync(reportPath, JSON.stringify(freshReportData));
-
-      // Clear comparison details
-      if (existsSync(detailsPath)) {
-        writeFileSync(detailsPath, JSON.stringify({}));
-      }
+      reportStore.reset();
       output.info(`Baselines reset - ${deletedBaselines} baselines deleted, ${deletedCurrents} current screenshots deleted, ${deletedDiffs} diffs deleted`);
       return {
         success: true,
@@ -707,19 +481,23 @@ export const createTddHandler = (config, workingDir, baselineBuild, baselineComp
    * @param {string} label - Label for logging (e.g., "baseline", "current", "diff")
    * @param {string} name - Screenshot name for logging
    */
-  const safeDeleteFile = (imagePath, label, name) => {
-    if (!imagePath) return;
+  let safeDeleteFile = (imagePath, label, name, {
+    logDeletion = true
+  } = {}) => {
+    if (!imagePath) return 0;
     try {
       // Use safePath to validate the path stays within workingDir
       const filePath = safePath(workingDir, '.vizzly', imagePath.replace('/images/', ''));
       if (existsSync(filePath)) {
         unlinkSync(filePath);
-        output.debug(`Deleted ${label} for ${name}`);
+        if (logDeletion) output.debug(`Deleted ${label} for ${name}`);
+        return 1;
       }
     } catch (error) {
       // safePath throws if path traversal is attempted
       output.warn(`Failed to delete ${label} for ${name}: ${error.message}`);
     }
+    return 0;
   };
   const deleteComparison = async comparisonId => {
     const reportData = readReportData();
@@ -755,20 +533,7 @@ export const createTddHandler = (config, workingDir, baselineBuild, baselineComp
 
     // Remove heavy fields from comparison-details.json
     removeComparisonDetails(comparisonId);
-
-    // Remove comparison from report data
-    reportData.comparisons = reportData.comparisons.filter(c => c.id !== comparisonId);
-
-    // Regenerate summary (groups computed client-side)
-    reportData.timestamp = Date.now();
-    reportData.summary = {
-      total: reportData.comparisons.length,
-      passed: reportData.comparisons.filter(c => c.status === 'passed' || c.status === 'baseline-created' || c.status === 'new').length,
-      failed: reportData.comparisons.filter(c => c.status === 'failed').length,
-      rejected: reportData.comparisons.filter(c => c.status === 'rejected').length,
-      errors: reportData.comparisons.filter(c => c.status === 'error').length
-    };
-    writeFileSync(reportPath, JSON.stringify(reportData));
+    reportStore.writeReport(removeReportComparison(reportData, comparisonId, Date.now()));
     output.info(`Deleted comparison ${comparisonId} (${comparison.name})`);
     return {
       success: true,

package/dist/{commands/tdd-daemon.js → domains/tdd/tdd-daemon.commands.js}

@@ -1,12 +1,12 @@
 import { spawn } from 'node:child_process';
 import { existsSync, mkdirSync, readFileSync, unlinkSync, writeFileSync } from 'node:fs';
 import { basename, join } from 'node:path';
-import { getServerRegistry } from '../tdd/server-registry.js';
-import { withTimeout } from '../utils/async-utils.js';
-import * as output from '../utils/output.js';
-import { tddCommand } from './tdd.js';
-import { parsePositiveInteger, readDaemonPidFile, resolveDaemonPid, waitForProcessExit } from './tdd-daemon-process.js';
-export { findDaemonPidByPort, readDaemonPidFile, resolveDaemonPid, waitForProcessExit } from './tdd-daemon-process.js';
+import { withTimeout } from '../../shared/async-utils.js';
+import * as output from '../../shared/output.js';
+import { getServerRegistry } from './server-registry.js';
+import { tddCommand } from './tdd.commands.js';
+import { parsePositiveInteger, readDaemonPidFile, resolveDaemonPid, waitForProcessExit } from './tdd-daemon-process.commands.js';
+export { findDaemonPidByPort, readDaemonPidFile, resolveDaemonPid, waitForProcessExit } from './tdd-daemon-process.commands.js';
 let defaultTimers = {
   setTimeout,
   clearTimeout

package/dist/{commands/tdd-screenshots.js → domains/tdd/tdd-screenshots.commands.js}

@@ -1,10 +1,10 @@
 import { existsSync, readFileSync, writeFileSync } from 'node:fs';
 import { basename, join, resolve } from 'node:path';
-import { generateScreenshotSignature } from '../tdd/core/signature.js';
-import { TddService as defaultTddService } from '../tdd/tdd-service.js';
-import { loadConfig as defaultLoadConfig } from '../utils/config-loader.js';
-import * as output from '../utils/output.js';
-import { safePath } from '../utils/security.js';
+import * as output from '../../shared/output.js';
+import { safePath } from '../../shared/paths.js';
+import { loadConfig as defaultLoadConfig } from '../config/config-loader.js';
+import { generateScreenshotSignature } from '../screenshots/screenshot-identity.js';
+import { TddService as defaultTddService } from './tdd.service.js';
 let DEFAULT_PAGE_SIZE = 20;
 let MAX_PAGE_SIZE = 100;
 let TDD_SCREENSHOT_STATUSES = new Set(['baseline-created', 'baseline-updated', 'error', 'failed', 'new', 'passed', 'rejected']);

package/dist/{commands/tdd.js → domains/tdd/tdd.commands.js}

@@ -4,21 +4,22 @@
  */
 
 import { spawn as defaultSpawn } from 'node:child_process';
-import { createBuild as defaultCreateApiBuild, createApiClient as defaultCreateApiClient, finalizeBuild as defaultFinalizeApiBuild, getBuild as defaultGetBuild } from '../api/index.js';
-import { CONFIG_DEFAULTS } from '../config/core.js';
-import { VizzlyError } from '../errors/vizzly-error.js';
-import { createServerManager as defaultCreateServerManager } from '../server-manager/index.js';
-import { createAuthService as defaultCreateAuthService } from '../services/auth-service.js';
-import { createBuildObject as defaultCreateBuildObject } from '../services/build-manager.js';
-import { createConfigService as defaultCreateConfigService } from '../services/config-service.js';
-import { createProjectService as defaultCreateProjectService } from '../services/project-service.js';
-import { generateStaticReport as defaultGenerateStaticReport, getReportFileUrl } from '../services/static-report-generator.js';
-import { getServerRegistry } from '../tdd/server-registry.js';
-import { initializeDaemon as defaultInitializeDaemon, runTests as defaultRunTests } from '../test-runner/index.js';
-import { openBrowser as defaultOpenBrowser } from '../utils/browser.js';
-import { loadConfig as defaultLoadConfig } from '../utils/config-loader.js';
-import { detectBranch as defaultDetectBranch, detectCommit as defaultDetectCommit, detectCommitAuthor as defaultDetectCommitAuthor, detectCommitMessage as defaultDetectCommitMessage, detectPullRequestNumber as defaultDetectPullRequestNumber, generateBuildNameWithGit as defaultGenerateBuildNameWithGit } from '../utils/git.js';
-import * as defaultOutput from '../utils/output.js';
+import { createServerManager as defaultCreateServerManager } from '../../adapters/http/server-manager.js';
+import { openBrowser as defaultOpenBrowser } from '../../shared/browser.js';
+import { detectBranch as defaultDetectBranch, detectCommit as defaultDetectCommit, detectCommitAuthor as defaultDetectCommitAuthor, detectCommitMessage as defaultDetectCommitMessage, detectPullRequestNumber as defaultDetectPullRequestNumber, generateBuildNameWithGit as defaultGenerateBuildNameWithGit } from '../../shared/git.js';
+import * as defaultOutput from '../../shared/output.js';
+import { VizzlyError } from '../../shared/vizzly-error.js';
+import { createAuthService as defaultCreateAuthService } from '../auth/auth.service.js';
+import { createApiClient as defaultCreateApiClient } from '../auth/cloud-client.js';
+import { createBuild as defaultCreateApiBuild, finalizeBuild as defaultFinalizeApiBuild, getBuild as defaultGetBuild } from '../builds/build.service.js';
+import { createBuildObject as defaultCreateBuildObject } from '../builds/build-info.js';
+import { createConfigService as defaultCreateConfigService } from '../config/config.service.js';
+import { CONFIG_DEFAULTS } from '../config/config-defaults.js';
+import { loadConfig as defaultLoadConfig } from '../config/config-loader.js';
+import { createProjectService as defaultCreateProjectService } from '../projects/project.service.js';
+import { generateStaticReport as defaultGenerateStaticReport, getReportFileUrl } from '../reports/report.service.js';
+import { initializeDaemon as defaultInitializeDaemon, runTests as defaultRunTests } from '../runs/run.service.js';
+import { getServerRegistry } from './server-registry.js';
 
 /**
  * Build the follow-up command for local TDD evidence.