@vizzly-testing/cli 0.35.2 → 0.35.3-beta.1

package/dist/server/routers/events.js

@@ -19,7 +19,7 @@ let defaultTimers = {
 /**
  * Read and parse JSON from disk, returning null on missing or invalid files.
  */
-export function readJsonFile(path) {
+function readJsonFile(path) {
   if (!existsSync(path)) {
     return null;
   }
@@ -33,7 +33,7 @@ export function readJsonFile(path) {
 /**
  * Read report data and attach baseline metadata for the stats view.
  */
-export function readReportDataFile({
+function readReportDataFile({
   reportDataPath,
   baselineMetadataPath
 }) {
@@ -84,7 +84,7 @@ function summaryChanged(oldData, newData) {
 /**
  * Build incremental SSE events by diffing old vs new report data.
  */
-export function buildReportDataEvents(oldData, newData) {
+function buildReportDataEvents(oldData, newData) {
   if (!oldData) {
     return [{
       type: 'reportData',
@@ -129,7 +129,7 @@ export function buildReportDataEvents(oldData, newData) {
 /**
  * Watch report-data.json with fs.watch plus a lightweight mtime fallback.
  */
-export function watchReportDataFile({
+function watchReportDataFile({
   workingDir,
   reportDataPath,
   onReportDataChanged,

package/dist/test-runner/operations.js

@@ -57,6 +57,9 @@ export async function createBuild({
   let client = createApiClient(clientOptions);
   let payload = buildApiBuildPayload(runOptions, config.comparison);
   let buildResult = await createApiBuild(client, payload);
+  if (!buildResult?.id) {
+    throw new Error('Vizzly API did not return a build ID');
+  }
   output.debug('build', `created ${buildResult.id}`);
   return buildResult.id;
 }
@@ -227,6 +230,26 @@ export function executeTestCommand({
     resolve.__process = testProcess;
   });
 }
+async function executeDisabledTestRun({
+  testCommand,
+  json,
+  deps
+}) {
+  let {
+    spawn,
+    createError
+  } = deps;
+  await executeTestCommand({
+    command: testCommand,
+    env: buildDisabledEnv(),
+    json,
+    deps: {
+      spawn,
+      createError
+    }
+  });
+  return buildDisabledRunResult();
+}
 
 // ============================================================================
 // High-Level Run Operations
@@ -278,25 +301,22 @@ export async function runTests({
     hasApiKey: hasApiKey(config),
     tdd
   })) {
-    let env = buildDisabledEnv();
-    await executeTestCommand({
-      command: testCommand,
-      env,
+    return executeDisabledTestRun({
+      testCommand,
       json: runOptions.json,
       deps: {
         spawn,
         createError
       }
     });
-    return buildDisabledRunResult();
   }
   let buildId = null;
   let buildUrl = null;
   let screenshotCount = 0;
   let testSuccess = false;
   let testError = null;
+  let setBaseline;
   try {
-    // Create build
     buildId = await createBuild({
       runOptions,
       tdd,
@@ -332,7 +352,7 @@ export async function runTests({
     }
 
     // Start server
-    let setBaseline = normalizeSetBaseline(runOptions);
+    setBaseline = normalizeSetBaseline(runOptions);
     await serverManager.start(buildId, tdd, setBaseline);
     if (onServerReady) {
       onServerReady({
@@ -341,32 +361,48 @@ export async function runTests({
         tdd
       });
     }
-
-    // Execute test command
-    let env = buildTestEnv({
-      port: config.server?.port,
-      buildId,
-      setBaseline,
-      failOnDiff: runOptions.failOnDiff || false
+  } catch (error) {
+    output.warn('Vizzly encountered an error. Running tests without visual testing.');
+    output.debug('run', 'setup failed; disabling Vizzly', {
+      error: error.message
     });
     try {
-      await executeTestCommand({
-        command: testCommand,
-        env,
-        json: runOptions.json,
-        deps: {
-          spawn,
-          createError
-        }
+      await serverManager.stop();
+    } catch (stopError) {
+      output.debug('run', 'failed to stop Vizzly after setup error', {
+        error: stopError.message
       });
-      testSuccess = true;
-    } catch (error) {
-      testError = error;
-      testSuccess = false;
     }
+    return executeDisabledTestRun({
+      testCommand,
+      json: runOptions.json,
+      deps: {
+        spawn,
+        createError
+      }
+    });
+  }
+
+  // Execute the user's tests. This is the only error that can fail the run.
+  let env = buildTestEnv({
+    port: config.server?.port,
+    buildId,
+    setBaseline,
+    failOnDiff: runOptions.failOnDiff || false
+  });
+  try {
+    await executeTestCommand({
+      command: testCommand,
+      env,
+      json: runOptions.json,
+      deps: {
+        spawn,
+        createError
+      }
+    });
+    testSuccess = true;
   } catch (error) {
     testError = error;
-    testSuccess = false;
   }
 
   // Get TDD results before stopping the server
@@ -410,7 +446,13 @@ export async function runTests({
 
     // In API mode, get actual screenshot count from handler after flush
     if (!tdd && serverManager.server?.getScreenshotCount) {
-      screenshotCount = serverManager.server.getScreenshotCount(buildId) || 0;
+      try {
+        screenshotCount = serverManager.server.getScreenshotCount(buildId) || 0;
+      } catch (countError) {
+        output.debug('build', 'failed to get screenshot count', {
+          error: countError.message
+        });
+      }
     }
   } finally {
     try {

package/dist/types/index.d.ts

@@ -205,10 +205,12 @@ export interface BuildResult {
   status: 'completed' | 'failed' | 'pending';
   build: unknown;
   comparisons?: number;
-  totalComparisons: number;
+  totalComparisons?: number;
   passedComparisons?: number;
   failedComparisons?: number;
-  newComparisons: number;
+  newComparisons?: number;
+  identicalComparisons?: number;
+  approvalStatus?: string;
   url?: string;
 }
 

package/dist/uploader/core.js

@@ -340,15 +340,15 @@ export function buildUploadResult({
  * @returns {Object} Wait result
  */
 export function buildWaitResult(build) {
-  let totalComparisons = build.comparisonsTotal ?? build.total_comparisons ?? 0;
-  let passedComparisons = build.comparisonsPassed ?? build.passed_comparisons ?? build.identicalComparisons ?? build.identical_comparisons ?? 0;
-  let failedComparisons = build.comparisonsFailed ?? build.failed_comparisons ?? build.changedComparisons ?? build.changed_comparisons ?? 0;
-  let newComparisons = build.comparisonsNew ?? build.newComparisons ?? build.new_comparisons ?? 0;
+  let totalComparisons = build.comparisonsTotal ?? build.total_comparisons;
+  let passedComparisons = build.comparisonsPassed ?? build.passed_comparisons ?? build.identicalComparisons ?? build.identical_comparisons;
+  let failedComparisons = build.comparisonsFailed ?? build.failed_comparisons ?? build.changedComparisons ?? build.changed_comparisons;
+  let newComparisons = build.comparisonsNew ?? build.newComparisons ?? build.new_comparisons;
   let identicalComparisons = build.identicalComparisons ?? build.identical_comparisons ?? passedComparisons;
-  let approvalStatus = build.approvalStatus ?? build.approval_status ?? 'pending';
+  let approvalStatus = build.approvalStatus ?? build.approval_status;
   let hasComparisonCounts = build.comparisonsTotal !== undefined || build.total_comparisons !== undefined || build.comparisonsPassed !== undefined || build.passed_comparisons !== undefined || build.comparisonsFailed !== undefined || build.failed_comparisons !== undefined || build.comparisonsNew !== undefined || build.new_comparisons !== undefined || build.identicalComparisons !== undefined || build.identical_comparisons !== undefined;
   let result = {
-    status: 'completed',
+    status: build.status,
     build,
     passedComparisons,
     failedComparisons,

package/dist/uploader/operations.js

@@ -281,7 +281,10 @@ export async function waitForBuild({
       return buildWaitResult(build);
     }
     if (build.status === 'failed') {
-      throw createError(`Build failed: ${build.error || 'Unknown error'}`, 'BUILD_FAILED');
+      throw createError(`Build failed: ${build.error || 'Unknown error'}`, 'BUILD_FAILED', {
+        buildId,
+        build
+      });
     }
     let remaining = timeout - getElapsedTime(startTime, now());
     if (remaining <= 0) {