@vizzly-testing/cli 0.34.0 → 0.35.1

package/dist/commands/upload.js

@@ -1,4 +1,5 @@
 import { createApiClient as defaultCreateApiClient, finalizeBuild as defaultFinalizeBuild, getTokenContext as defaultGetTokenContext } from '../api/index.js';
+import { CONFIG_DEFAULTS } from '../config/core.js';
 import { createUploader as defaultCreateUploader } from '../uploader/index.js';
 import { getAppBaseUrl } from '../utils/api-url.js';
 import { loadConfig as defaultLoadConfig } from '../utils/config-loader.js';
@@ -73,12 +74,12 @@ export async function uploadCommand(screenshotsPath, options = {}, globalOptions
   });
   let buildId = null;
   let config = null;
-  const uploadStartTime = Date.now();
+  let uploadStartTime = Date.now();
   try {
     output.info('Starting upload process...');
 
     // Load configuration with CLI overrides
-    const allOptions = {
+    let allOptions = {
       ...globalOptions,
       ...options
     };
@@ -95,11 +96,12 @@ export async function uploadCommand(screenshotsPath, options = {}, globalOptions
     }
 
     // Collect git metadata if not provided
-    const branch = await detectBranch(options.branch);
-    const commit = await detectCommit(options.commit);
-    const message = options.message || (await detectCommitMessage());
-    const buildName = await generateBuildNameWithGit(options.buildName);
-    const pullRequestNumber = detectPullRequestNumber();
+    let configuredBuildName = config.build.name && config.build.name !== CONFIG_DEFAULTS.build.name ? config.build.name : undefined;
+    let branch = await detectBranch(options.branch || config.build.branch);
+    let commit = await detectCommit(options.commit || config.build.commit);
+    let message = options.message || config.build.message || (await detectCommitMessage());
+    let buildName = await generateBuildNameWithGit(options.buildName || configuredBuildName);
+    let pullRequestNumber = detectPullRequestNumber();
     output.info(`Uploading screenshots from: ${screenshotsPath}`);
     if (globalOptions.verbose) {
       output.info('Configuration loaded');
@@ -119,7 +121,7 @@ export async function uploadCommand(screenshotsPath, options = {}, globalOptions
     });
 
     // Prepare upload options with progress callback
-    const uploadOptions = {
+    let uploadOptions = {
       screenshotsDir: screenshotsPath,
       buildName,
       branch,
@@ -127,12 +129,13 @@ export async function uploadCommand(screenshotsPath, options = {}, globalOptions
       message,
       environment: config.build.environment,
       threshold: config.comparison.threshold,
+      minClusterSize: config.comparison.minClusterSize,
       uploadAll: options.uploadAll || false,
       metadata: options.metadata ? JSON.parse(options.metadata) : {},
       pullRequestNumber,
       parallelId: config.parallelId,
       onProgress: progressData => {
-        const {
+        let {
           message: progressMessage,
           current,
           total,
@@ -158,7 +161,7 @@ export async function uploadCommand(screenshotsPath, options = {}, globalOptions
 
     // Start upload
     output.progress('Starting upload...');
-    const result = await uploader.upload(uploadOptions);
+    let result = await uploader.upload(uploadOptions);
     buildId = result.buildId; // Ensure we have the buildId
 
     // Write session for subsequent commands (like preview)
@@ -263,8 +266,10 @@ export async function uploadCommand(screenshotsPath, options = {}, globalOptions
           executionTimeMs
         });
         output.cleanup();
+        let success = buildResult.failedComparisons === 0;
         return {
-          success: buildResult.failedComparisons === 0,
+          success,
+          exitCode: success ? 0 : 1,
           result
         };
       }
@@ -283,6 +288,14 @@ export async function uploadCommand(screenshotsPath, options = {}, globalOptions
       let waitBuildUrl = buildResult.url || (await buildUrlConstructor(result.buildId, config.apiUrl, config.apiKey, deps));
       output.blank();
       output.labelValue('View', output.link('Results', waitBuildUrl));
+      if (buildResult.failedComparisons > 0) {
+        output.cleanup();
+        return {
+          success: false,
+          exitCode: 1,
+          result
+        };
+      }
     }
     output.cleanup();
     return {
@@ -300,11 +313,10 @@ export async function uploadCommand(screenshotsPath, options = {}, globalOptions
           message: 'Vizzly API unavailable - upload skipped',
           executionTimeMs: Date.now() - uploadStartTime
         });
-        output.cleanup();
       } else {
         output.warn('Vizzly API unavailable - upload skipped. Your tests still ran.');
-        output.cleanup();
       }
+      output.cleanup();
       return {
         success: true,
         result: {
@@ -381,6 +393,12 @@ export function validateUploadOptions(screenshotsPath, options) {
       errors.push('Threshold must be a non-negative number (CIEDE2000 Delta E)');
     }
   }
+  if (options.minClusterSize !== undefined) {
+    let minClusterSize = Number(options.minClusterSize);
+    if (!Number.isInteger(minClusterSize) || minClusterSize < 1) {
+      errors.push('Min cluster size must be a positive integer');
+    }
+  }
   if (options.batchSize !== undefined) {
     let n = Number(options.batchSize);
     if (!Number.isInteger(n) || n <= 0) {