@vizzly-testing/cli 0.29.6 → 0.31.0

package/dist/services/config-service.js

@@ -12,30 +12,10 @@ import { existsSync } from 'node:fs';
 import { writeFile } from 'node:fs/promises';
 import { join } from 'node:path';
 import { cosmiconfigSync } from 'cosmiconfig';
+import { CONFIG_DEFAULTS } from '../config/core.js';
 import { loadGlobalConfig, saveGlobalConfig } from '../utils/global-config.js';
 import * as output from '../utils/output.js';
 
-/**
- * Default configuration values
- */
-let DEFAULT_CONFIG = {
-  comparison: {
-    threshold: 2.0,
-    minClusterSize: 2
-  },
-  server: {
-    port: 47392,
-    timeout: 30000
-  },
-  build: {
-    name: 'Build {timestamp}',
-    environment: 'test'
-  },
-  tdd: {
-    openReport: false
-  }
-};
-
 /**
  * Create a config service instance
  * @param {Object} options
@@ -76,9 +56,7 @@ export function createConfigService({
    * Get merged configuration with source tracking
    */
   async function getMergedConfig() {
-    let config = {
-      ...DEFAULT_CONFIG
-    };
+    let config = cloneConfigValue(CONFIG_DEFAULTS);
     let sources = {};
 
     // Layer 1: Global config
@@ -100,15 +78,15 @@ export function createConfigService({
 
     // Layer 3: Environment variables
     if (process.env.VIZZLY_THRESHOLD) {
-      config.comparison.threshold = parseFloat(process.env.VIZZLY_THRESHOLD);
+      config.comparison.threshold = Number(process.env.VIZZLY_THRESHOLD);
       sources.comparison = 'env';
     }
     if (process.env.VIZZLY_MIN_CLUSTER_SIZE) {
-      config.comparison.minClusterSize = parseInt(process.env.VIZZLY_MIN_CLUSTER_SIZE, 10);
+      config.comparison.minClusterSize = Number(process.env.VIZZLY_MIN_CLUSTER_SIZE);
       sources.comparison = 'env';
     }
     if (process.env.VIZZLY_PORT) {
-      config.server.port = parseInt(process.env.VIZZLY_PORT, 10);
+      config.server.port = Number(process.env.VIZZLY_PORT);
       sources.server = 'env';
     }
     return {
@@ -241,7 +219,7 @@ export default defineConfig(${JSON.stringify(newConfig, null, 2)});
     // Validate threshold
     if (config.comparison?.threshold !== undefined) {
       let threshold = config.comparison.threshold;
-      if (typeof threshold !== 'number' || threshold < 0) {
+      if (typeof threshold !== 'number' || !Number.isFinite(threshold) || threshold < 0) {
         errors.push('comparison.threshold must be a non-negative number');
       } else if (threshold > 100) {
         warnings.push('comparison.threshold above 100 may cause all comparisons to pass');
@@ -292,30 +270,44 @@ export default defineConfig(${JSON.stringify(newConfig, null, 2)});
  * Deep merge two objects
  */
 function mergeDeep(target, source) {
-  let result = {
-    ...target
-  };
+  let result = cloneConfigValue(target);
   for (let key in source) {
     if (source[key] && typeof source[key] === 'object' && !Array.isArray(source[key])) {
       result[key] = mergeDeep(result[key] || {}, source[key]);
+    } else if (Array.isArray(source[key])) {
+      result[key] = [...source[key]];
     } else {
       result[key] = source[key];
     }
   }
   return result;
 }
+function cloneConfigValue(value) {
+  if (Array.isArray(value)) {
+    return value.map(cloneConfigValue);
+  }
+  if (value && typeof value === 'object') {
+    let clone = {};
+    for (let key in value) {
+      clone[key] = cloneConfigValue(value[key]);
+    }
+    return clone;
+  }
+  return value;
+}
 
 /**
  * Merge config with source tracking
  */
-function mergeWithTracking(target, source, sources, sourceName) {
+function mergeWithTracking(target, source, sources, sourceName, sectionName) {
   for (let key in source) {
+    let sourceSection = sectionName || key;
     if (source[key] && typeof source[key] === 'object' && !Array.isArray(source[key])) {
       if (!target[key]) target[key] = {};
-      mergeWithTracking(target[key], source[key], sources, sourceName);
+      mergeWithTracking(target[key], source[key], sources, sourceName, sourceSection);
     } else {
       target[key] = source[key];
-      sources[key] = sourceName;
+      sources[sourceSection] = sourceName;
     }
   }
 }

package/dist/services/index.js

@@ -9,7 +9,7 @@
  * This factory is only used by cli.js to provide services to plugins.
  */
 
-import { ServerManager } from './server-manager.js';
+import { createServerManager } from '../server-manager/index.js';
 import { TestRunner } from './test-runner.js';
 
 /**
@@ -26,9 +26,7 @@ import { TestRunner } from './test-runner.js';
  * @returns {Object} Services object for plugins
  */
 export function createServices(config) {
-  let serverManager = new ServerManager(config, {
-    services: {}
-  });
+  let serverManager = createServerManager(config, {});
   let testRunner = new TestRunner(config, serverManager);
   return {
     serverManager,

package/dist/services/static-report-generator.js

@@ -7,7 +7,7 @@
 
 import { copyFileSync, existsSync, mkdirSync, readdirSync, readFileSync, statSync, writeFileSync } from 'node:fs';
 import { dirname, join } from 'node:path';
-import { fileURLToPath } from 'node:url';
+import { fileURLToPath, pathToFileURL } from 'node:url';
 let __dirname = dirname(fileURLToPath(import.meta.url));
 
 /**
@@ -119,6 +119,13 @@ ${css}
 </body>
 </html>`;
 }
+export async function loadStaticReportRenderer(ssrModulePath = getSSRModulePath()) {
+  let moduleUrl = pathToFileURL(ssrModulePath).href;
+  let {
+    renderStaticReport
+  } = await import(moduleUrl);
+  return renderStaticReport;
+}
 
 /**
  * Generate a static report from the current TDD results
@@ -155,17 +162,9 @@ export async function generateStaticReport(workingDir, options = {}) {
 
     // Transform image URLs to relative paths
     let transformedData = transformImageUrls(reportData);
-
-    // Load and use the SSR module
-    let ssrModulePath = getSSRModulePath();
-    let {
-      renderStaticReport
-    } = await import(ssrModulePath);
+    let renderStaticReport = options.renderStaticReport || (await loadStaticReportRenderer());
     let renderedContent = renderStaticReport(transformedData);
-
-    // Get CSS
-    let reporterDistPath = getReporterDistPath();
-    let css = readFileSync(join(reporterDistPath, 'reporter-bundle.css'), 'utf8');
+    let css = options.css ?? readFileSync(join(getReporterDistPath(), 'reporter-bundle.css'), 'utf8');
 
     // Create output directory
     mkdirSync(outputDir, {
@@ -201,5 +200,5 @@ export async function generateStaticReport(workingDir, options = {}) {
  * Get the file:// URL for a report path
  */
 export function getReportFileUrl(reportPath) {
-  return `file://${reportPath}`;
+  return pathToFileURL(reportPath).href;
 }

package/dist/services/test-runner.js

@@ -2,16 +2,15 @@
  * Test Runner Service
  * Orchestrates the test execution flow
  *
- * This class is a thin wrapper around the functional operations in
- * src/test-runner/. It maintains backwards compatibility while
- * delegating to pure functions for testability.
+ * This EventEmitter adapter keeps the stable plugin-facing runner contract
+ * while delegating execution to the functional operations in src/test-runner/.
  */
 
 import { spawn } from 'node:child_process';
 import { EventEmitter } from 'node:events';
 import { createBuild as createApiBuild, createApiClient, finalizeBuild as finalizeApiBuild, getBuild } from '../api/index.js';
 import { VizzlyError } from '../errors/vizzly-error.js';
-import { cancelTests, createBuild, finalizeBuild, initializeDaemon, runTests } from '../test-runner/index.js';
+import { cancelTests, createBuild, fetchBuildUrl, finalizeBuild, initializeDaemon, runTests } from '../test-runner/index.js';
 import * as output from '../utils/output.js';
 import { writeSession as defaultWriteSession } from '../utils/session.js';
 import { createBuildObject } from './build-manager.js';
@@ -81,6 +80,7 @@ export class TestRunner extends EventEmitter {
     return result;
   }
   async createBuild(options, tdd) {
+    let createdApiBuild = null;
     let buildId = await createBuild({
       runOptions: options,
       tdd,
@@ -88,11 +88,23 @@ export class TestRunner extends EventEmitter {
       deps: {
         buildManager: this.buildManager,
         createApiClient: this.deps.createApiClient,
-        createApiBuild: this.deps.createApiBuild,
+        createApiBuild: async (client, payload) => {
+          createdApiBuild = await this.deps.createApiBuild(client, payload);
+          return createdApiBuild;
+        },
         output: this.deps.output
       }
     });
     if (!tdd && buildId) {
+      let buildUrl = createdApiBuild?.url || (await fetchBuildUrl({
+        buildId,
+        config: this.config,
+        deps: {
+          createApiClient: this.deps.createApiClient,
+          getBuild: this.deps.getBuild,
+          output: this.deps.output
+        }
+      }));
       let writeSession = this.deps.writeSession || defaultWriteSession;
       writeSession({
         buildId,
@@ -100,6 +112,10 @@ export class TestRunner extends EventEmitter {
         commit: options?.commit,
         parallelId: options?.parallelId
       });
+      this.emit('build-created', {
+        buildId,
+        url: buildUrl
+      });
     }
     return buildId;
   }
@@ -119,28 +135,6 @@ export class TestRunner extends EventEmitter {
       }
     });
   }
-  async executeTestCommand(testCommand, env) {
-    return new Promise((resolve, reject) => {
-      let proc = this.deps.spawn(testCommand, {
-        env,
-        stdio: 'inherit',
-        shell: true
-      });
-      this.testProcess = proc;
-      proc.on('error', error => {
-        reject(this.deps.createError(`Failed to run test command: ${error.message}`, 'TEST_COMMAND_FAILED'));
-      });
-      proc.on('exit', (code, signal) => {
-        if (signal === 'SIGINT') {
-          reject(this.deps.createError('Test command was interrupted', 'TEST_COMMAND_INTERRUPTED'));
-        } else if (code !== 0) {
-          reject(this.deps.createError(`Test command exited with code ${code}`, 'TEST_COMMAND_FAILED'));
-        } else {
-          resolve();
-        }
-      });
-    });
-  }
   async cancel() {
     await cancelTests({
       testProcess: this.testProcess,

package/dist/tdd/core/hotspot-coverage.js

@@ -23,7 +23,7 @@ export function calculateHotspotCoverage(diffClusters, hotspotAnalysis) {
       totalLines: 0
     };
   }
-  if (!hotspotAnalysis || !hotspotAnalysis.regions || hotspotAnalysis.regions.length === 0) {
+  if (!hotspotAnalysis?.regions || hotspotAnalysis.regions.length === 0) {
     return {
       coverage: 0,
       linesInHotspots: 0,

package/dist/tdd/index.js

@@ -15,5 +15,5 @@ export { baselineMatchesSha, buildBaselineMetadataEntry, downloadBaselineImage,
 // Services
 export { baselineExists, clearBaselineData, getBaselinePath, getCurrentPath, getDiffPath, initializeDirectories, promoteCurrentToBaseline, readBaseline, readCurrent, saveBaseline, saveCurrent } from './services/baseline-manager.js';
 export { buildErrorComparison, buildFailedComparison, buildNewComparison, buildPassedComparison, compareImages, isDimensionMismatchError } from './services/comparison-service.js';
-export { downloadHotspots, extractScreenshotNames } from './services/hotspot-service.js';
+export { downloadHotspots } from './services/hotspot-service.js';
 export { buildResults, calculateSummary, findComparison, findComparisonById, getErrorComparisons, getFailedComparisons, getNewComparisons, isSuccessful } from './services/result-service.js';

package/dist/tdd/metadata/region-metadata.js

@@ -53,41 +53,4 @@ export function saveRegionMetadata(workingDir, regionData, summary = {}) {
     regions: regionData
   };
   writeFileSync(regionsPath, JSON.stringify(content, null, 2));
-}
-
-/**
- * Get regions for a specific screenshot with caching support
- *
- * This is a pure function that takes a cache object as parameter
- * for stateless operation. The cache is mutated if data needs to be loaded.
- *
- * @param {Object} cache - Cache object { data: Object|null, loaded: boolean }
- * @param {string} workingDir - Working directory
- * @param {string} screenshotName - Name of the screenshot
- * @returns {Object|null} Region data or null if not available
- */
-export function getRegionsForScreenshot(cache, workingDir, screenshotName) {
-  // Check cache first
-  if (cache.data?.[screenshotName]) {
-    return cache.data[screenshotName];
-  }
-
-  // Load from disk if not yet loaded
-  if (!cache.loaded) {
-    cache.data = loadRegionMetadata(workingDir);
-    cache.loaded = true;
-  }
-  return cache.data?.[screenshotName] || null;
-}
-
-/**
- * Create an empty region cache object
- *
- * @returns {{ data: null, loaded: boolean }}
- */
-export function createRegionCache() {
-  return {
-    data: null,
-    loaded: false
-  };
 }

package/dist/tdd/runtime-context.js

@@ -0,0 +1,78 @@
+/**
+ * Runtime context assembly for TddService constructor.
+ * Keeps dependency merging and path bootstrap logic isolated and testable.
+ */
+
+export function buildTddDependencyOps(deps = {}, defaults = {}) {
+  let {
+    output = defaults.output,
+    colors = defaults.colors,
+    validatePathSecurity = defaults.validatePathSecurity,
+    initializeDirectories = defaults.initializeDirectories,
+    calculateHotspotCoverage = defaults.calculateHotspotCoverage,
+    fs = {},
+    api = {},
+    metadata = {},
+    baseline = {},
+    comparison = {},
+    signature = {},
+    results = {}
+  } = deps;
+  let fsOps = {
+    ...defaults.fs,
+    ...fs
+  };
+  let apiOps = {
+    ...defaults.api,
+    ...api
+  };
+  let metadataOps = {
+    ...defaults.metadata,
+    ...metadata
+  };
+  let baselineOps = {
+    ...defaults.baseline,
+    ...baseline
+  };
+  let comparisonOps = {
+    ...defaults.comparison,
+    ...comparison
+  };
+  let signatureOps = {
+    ...defaults.signature,
+    ...signature
+  };
+  let resultsOps = {
+    ...defaults.results,
+    ...results
+  };
+  let runtimeDeps = {
+    output,
+    colors,
+    validatePathSecurity,
+    initializeDirectories,
+    calculateHotspotCoverage,
+    ...fsOps,
+    ...apiOps,
+    ...metadataOps,
+    ...baselineOps,
+    ...comparisonOps,
+    ...signatureOps,
+    ...resultsOps
+  };
+  return {
+    runtimeDeps,
+    apiOps
+  };
+}
+export function resolveTddWorkingDirectory(workingDir, validatePathSecurity, output) {
+  try {
+    return validatePathSecurity(workingDir, workingDir);
+  } catch (error) {
+    output.error(`Invalid working directory: ${error.message}`);
+    throw new Error(`Working directory validation failed: ${error.message}`);
+  }
+}
+export function resolveTddPaths(workingDir, initializeDirectories) {
+  return initializeDirectories(workingDir);
+}

package/dist/tdd/server-registry.js

@@ -1,4 +1,4 @@
-import { execSync } from 'node:child_process';
+import { execFileSync } from 'node:child_process';
 import { randomBytes } from 'node:crypto';
 import { existsSync, mkdirSync, readFileSync, writeFileSync } from 'node:fs';
 import { createServer } from 'node:net';
@@ -10,9 +10,13 @@ import { join } from 'node:path';
  * Enables the menubar app to discover and manage multiple concurrent servers.
  */
 export class ServerRegistry {
-  constructor() {
-    this.vizzlyHome = process.env.VIZZLY_HOME || join(homedir(), '.vizzly');
+  constructor({
+    vizzlyHome,
+    logger = console
+  } = {}) {
+    this.vizzlyHome = vizzlyHome || process.env.VIZZLY_HOME || join(homedir(), '.vizzly');
     this.registryPath = join(this.vizzlyHome, 'servers.json');
+    this.logger = logger;
   }
 
   /**
@@ -40,7 +44,7 @@ export class ServerRegistry {
       }
     } catch (_err) {
       // Corrupted file, start fresh
-      console.warn('Warning: Could not read server registry, starting fresh');
+      this.logger.warn('Warning: Could not read server registry, starting fresh');
     }
     return {
       version: 1,
@@ -64,10 +68,10 @@ export class ServerRegistry {
     if (!serverInfo.pid || !serverInfo.port || !serverInfo.directory) {
       throw new Error('Missing required fields: pid, port, directory');
     }
-    let port = Number(serverInfo.port);
-    let pid = Number(serverInfo.pid);
-    if (Number.isNaN(port) || Number.isNaN(pid)) {
-      throw new Error('Invalid port or pid - must be numbers');
+    let port = parsePositiveInteger(serverInfo.port);
+    let pid = parsePositiveInteger(serverInfo.pid);
+    if (port === null || pid === null) {
+      throw new Error('Invalid port or pid - must be positive integers');
     }
     let registry = this.read();
 
@@ -171,15 +175,7 @@ export class ServerRegistry {
    * The menubar app listens for this in addition to file watching.
    */
   notifyMenubar() {
-    if (process.platform !== 'darwin') return;
-    try {
-      execSync('notifyutil -p dev.vizzly.serverChanged', {
-        stdio: 'ignore',
-        timeout: 500
-      });
-    } catch {
-      // Non-fatal - menubar will still see changes via file watching
-    }
+    notifyServerRegistryChanged();
   }
 
   /**
@@ -218,6 +214,31 @@ export class ServerRegistry {
     return startPort;
   }
 }
+function parsePositiveInteger(value) {
+  if (typeof value === 'number') {
+    return Number.isInteger(value) && value > 0 ? value : null;
+  }
+  if (typeof value === 'string' && /^[1-9]\d*$/.test(value)) {
+    return Number(value);
+  }
+  return null;
+}
+export function notifyServerRegistryChanged({
+  platform = process.platform,
+  execFile = execFileSync
+} = {}) {
+  if (platform !== 'darwin') return false;
+  try {
+    execFile('notifyutil', ['-p', 'dev.vizzly.serverChanged'], {
+      stdio: 'ignore',
+      timeout: 500
+    });
+    return true;
+  } catch {
+    // Non-fatal - menubar will still see changes via file watching
+    return false;
+  }
+}
 
 /**
  * Check if a port is free (not in use by any process)

package/dist/tdd/services/baseline-manager.js

@@ -57,6 +57,29 @@ export function clearBaselineData(paths) {
   }
 }
 
+/**
+ * Clear per-run screenshot artifacts while preserving approved baselines.
+ *
+ * @param {{ currentPath: string, diffPath: string }} paths
+ */
+export function clearRunData(paths) {
+  let {
+    currentPath,
+    diffPath
+  } = paths;
+  for (let dir of [currentPath, diffPath]) {
+    if (existsSync(dir)) {
+      rmSync(dir, {
+        recursive: true,
+        force: true
+      });
+    }
+    mkdirSync(dir, {
+      recursive: true
+    });
+  }
+}
+
 /**
  * Save an image as baseline
  *

package/dist/tdd/services/hotspot-service.js

@@ -31,7 +31,7 @@ export async function downloadHotspots(options) {
   }
   try {
     let response = await api.getHotspots(screenshotNames);
-    if (!response || !response.hotspots) {
+    if (!response?.hotspots) {
       return {
         success: false,
         error: 'API returned no hotspot data'
@@ -55,17 +55,4 @@ export async function downloadHotspots(options) {
       error: error.message
     };
   }
-}
-
-/**
- * Extract screenshot names from a list of screenshots
- *
- * @param {Array} screenshots - Screenshots with name property
- * @returns {string[]}
- */
-export function extractScreenshotNames(screenshots) {
-  if (!screenshots || !Array.isArray(screenshots)) {
-    return [];
-  }
-  return screenshots.map(s => s.name).filter(Boolean);
 }