@vizzly-testing/cli 0.19.2 → 0.20.1-beta.0

package/dist/server-manager/core.js

@@ -0,0 +1,183 @@
+/**
+ * Server Manager Core - Pure functions for server management logic
+ *
+ * No I/O, no side effects - just data transformations.
+ */
+
+// ============================================================================
+// Default Configuration
+// ============================================================================
+
+/**
+ * Default server port
+ */
+export let DEFAULT_PORT = 47392;
+
+// ============================================================================
+// Config Extraction
+// ============================================================================
+
+/**
+ * Extract server port from config
+ * @param {Object|undefined} config - Configuration object
+ * @returns {number} Server port
+ */
+export function getPort(config) {
+  return config?.server?.port || DEFAULT_PORT;
+}
+
+/**
+ * Check if API key is present in config
+ * @param {Object|undefined} config - Configuration object
+ * @returns {boolean} Whether API key exists
+ */
+export function hasApiKey(config) {
+  return Boolean(config?.apiKey);
+}
+
+// ============================================================================
+// Server Info Building
+// ============================================================================
+
+/**
+ * Build server info object for server.json
+ * @param {Object} options - Options
+ * @param {number} options.port - Server port
+ * @param {number} options.pid - Process ID
+ * @param {number} options.startTime - Start timestamp
+ * @param {string|null} [options.buildId] - Optional build ID
+ * @returns {Object} Server info object
+ */
+export function buildServerInfo({
+  port,
+  pid,
+  startTime,
+  buildId = null
+}) {
+  let info = {
+    port: port.toString(),
+    pid,
+    startTime
+  };
+  if (buildId) {
+    info.buildId = buildId;
+  }
+  return info;
+}
+
+// ============================================================================
+// Services Building
+// ============================================================================
+
+/**
+ * Build services object with extras for http-server
+ * @param {Object} options - Options
+ * @param {Object} [options.services] - Base services object
+ * @param {string|null} [options.buildId] - Build ID
+ * @param {Object|null} [options.tddService] - TDD service (only in TDD mode)
+ * @returns {Object} Services object with extras
+ */
+export function buildServicesWithExtras({
+  services = {},
+  buildId = null,
+  tddService = null
+}) {
+  return {
+    ...services,
+    buildId,
+    tddService
+  };
+}
+
+// ============================================================================
+// Client Options Building
+// ============================================================================
+
+/**
+ * Build API client options from config
+ * @param {Object} config - Configuration object
+ * @returns {Object|null} Client options or null if no API key
+ */
+export function buildClientOptions(config) {
+  if (!hasApiKey(config)) {
+    return null;
+  }
+  return {
+    baseUrl: config.apiUrl,
+    token: config.apiKey,
+    command: 'run'
+  };
+}
+
+// ============================================================================
+// Server Interface Building
+// ============================================================================
+
+/**
+ * Build server interface object for compatibility
+ * @param {Object} options - Options
+ * @param {Object|null} options.handler - Screenshot handler
+ * @param {Object|null} options.httpServer - HTTP server instance
+ * @returns {Object} Server interface
+ */
+export function buildServerInterface({
+  handler,
+  httpServer
+}) {
+  return {
+    getScreenshotCount: buildId => handler?.getScreenshotCount?.(buildId) || 0,
+    finishBuild: buildId => httpServer?.finishBuild?.(buildId)
+  };
+}
+
+// ============================================================================
+// Handler Mode Determination
+// ============================================================================
+
+/**
+ * Determine handler mode configuration
+ * @param {Object} options - Options
+ * @param {boolean} options.tddMode - Whether in TDD mode
+ * @param {Object} options.config - Configuration object
+ * @param {boolean} options.setBaseline - Whether to set baseline
+ * @returns {{ mode: 'tdd'|'api', tddConfig: Object|null, clientOptions: Object|null }}
+ */
+export function determineHandlerMode({
+  tddMode,
+  config,
+  setBaseline
+}) {
+  if (tddMode) {
+    return {
+      mode: 'tdd',
+      tddConfig: {
+        config,
+        baselineBuildId: config?.baselineBuildId,
+        baselineComparisonId: config?.baselineComparisonId,
+        setBaseline
+      },
+      clientOptions: null
+    };
+  }
+  return {
+    mode: 'api',
+    tddConfig: null,
+    clientOptions: buildClientOptions(config)
+  };
+}
+
+// ============================================================================
+// Path Building
+// ============================================================================
+
+/**
+ * Build server.json file path
+ * @param {string} projectRoot - Project root directory
+ * @returns {{ dir: string, file: string }}
+ */
+export function buildServerJsonPaths(projectRoot) {
+  return {
+    dir: `${projectRoot}/.vizzly`,
+    file: `${projectRoot}/.vizzly/server.json`
+  };
+}

package/dist/server-manager/index.js

@@ -0,0 +1,81 @@
+/**
+ * Server Manager Module - Public exports
+ *
+ * Provides functional server management primitives:
+ * - core.js: Pure functions for building server info, configs, interfaces
+ * - operations.js: Server operations with dependency injection
+ */
+
+import { existsSync, mkdirSync, unlinkSync, writeFileSync } from 'node:fs';
+import { createApiClient } from '../api/index.js';
+import { createApiHandler } from '../server/handlers/api-handler.js';
+import { createTddHandler } from '../server/handlers/tdd-handler.js';
+import { createHttpServer } from '../server/http-server.js';
+
+// Core pure functions
+import { buildServerInterface } from './core.js';
+export { buildClientOptions, buildServerInfo, buildServerInterface, buildServerJsonPaths, buildServicesWithExtras, DEFAULT_PORT, determineHandlerMode, getPort, hasApiKey } from './core.js';
+
+// Server operations (take dependencies as parameters)
+import { getTddResults, startServer, stopServer } from './operations.js';
+export { getTddResults, removeServerJson, startServer, stopServer, writeServerJson } from './operations.js';
+
+/**
+ * Create a server manager object that provides the interface commands expect.
+ * This is a thin functional wrapper that encapsulates the server lifecycle.
+ *
+ * @param {Object} config - Configuration object
+ * @param {Object} [services={}] - Optional services object
+ * @returns {Object} Server manager with start/stop/getTddResults methods
+ */
+export function createServerManager(config, services = {}) {
+  let httpServer = null;
+  let handler = null;
+  let deps = {
+    createHttpServer,
+    createTddHandler,
+    createApiHandler,
+    createApiClient,
+    fs: {
+      mkdirSync,
+      writeFileSync,
+      existsSync,
+      unlinkSync
+    }
+  };
+  return {
+    async start(buildId, tddMode, setBaseline) {
+      let result = await startServer({
+        config,
+        buildId,
+        tddMode,
+        setBaseline,
+        projectRoot: process.cwd(),
+        services,
+        deps
+      });
+      httpServer = result.httpServer;
+      handler = result.handler;
+    },
+    async stop() {
+      await stopServer({
+        httpServer,
+        handler,
+        projectRoot: process.cwd(),
+        deps
+      });
+    },
+    async getTddResults() {
+      return getTddResults({
+        tddMode: true,
+        handler
+      });
+    },
+    get server() {
+      return buildServerInterface({
+        handler,
+        httpServer
+      });
+    }
+  };
+}

package/dist/server-manager/operations.js

@@ -0,0 +1,208 @@
+/**
+ * Server Manager Operations - Server operations with dependency injection
+ *
+ * Each operation takes its dependencies as parameters:
+ * - fs: filesystem operations (mkdirSync, writeFileSync, existsSync, unlinkSync)
+ * - createHttpServer: factory for HTTP server
+ * - createTddHandler: factory for TDD handler
+ * - createApiHandler: factory for API handler
+ * - createApiClient: factory for API client
+ *
+ * This makes them trivially testable without mocking modules.
+ */
+
+import { buildServerInfo, buildServerJsonPaths, buildServicesWithExtras, determineHandlerMode, getPort } from './core.js';
+
+// ============================================================================
+// Server Lifecycle Operations
+// ============================================================================
+
+/**
+ * Start the screenshot server
+ * @param {Object} options - Options
+ * @param {Object} options.config - Configuration object
+ * @param {string|null} [options.buildId] - Build ID
+ * @param {boolean} [options.tddMode] - Whether in TDD mode
+ * @param {boolean} [options.setBaseline] - Whether to set baseline
+ * @param {string} options.projectRoot - Project root directory
+ * @param {Object} [options.services] - Services object
+ * @param {Object} options.deps - Dependencies
+ * @param {Function} options.deps.createHttpServer - HTTP server factory
+ * @param {Function} options.deps.createTddHandler - TDD handler factory
+ * @param {Function} options.deps.createApiHandler - API handler factory
+ * @param {Function} options.deps.createApiClient - API client factory
+ * @param {Object} options.deps.fs - Filesystem operations
+ * @returns {Promise<{ httpServer: Object, handler: Object, tddMode: boolean }>}
+ */
+export async function startServer({
+  config,
+  buildId = null,
+  tddMode = false,
+  setBaseline = false,
+  projectRoot,
+  services = {},
+  deps
+}) {
+  let {
+    createHttpServer,
+    createTddHandler,
+    createApiHandler,
+    createApiClient,
+    fs
+  } = deps;
+  let port = getPort(config);
+  let handler;
+
+  // Determine which handler mode to use
+  let handlerMode = determineHandlerMode({
+    tddMode,
+    config,
+    setBaseline
+  });
+  if (handlerMode.mode === 'tdd') {
+    handler = createTddHandler(config, projectRoot, handlerMode.tddConfig.baselineBuildId, handlerMode.tddConfig.baselineComparisonId, setBaseline);
+    await handler.initialize();
+  } else {
+    let client = handlerMode.clientOptions ? createApiClient(handlerMode.clientOptions) : null;
+    handler = createApiHandler(client);
+  }
+
+  // Build services with extras
+  let servicesWithExtras = buildServicesWithExtras({
+    services,
+    buildId,
+    tddService: tddMode ? handler.tddService : null
+  });
+
+  // Create and start HTTP server
+  let httpServer = createHttpServer(port, handler, servicesWithExtras);
+  if (httpServer) {
+    await httpServer.start();
+  }
+
+  // Write server.json for SDK discovery
+  writeServerJson({
+    projectRoot,
+    port,
+    buildId,
+    fs
+  });
+  return {
+    httpServer,
+    handler,
+    tddMode
+  };
+}
+
+/**
+ * Stop the screenshot server
+ * @param {Object} options - Options
+ * @param {Object|null} options.httpServer - HTTP server instance
+ * @param {Object|null} options.handler - Handler instance
+ * @param {string} options.projectRoot - Project root directory
+ * @param {Object} options.deps - Dependencies
+ * @param {Object} options.deps.fs - Filesystem operations
+ * @returns {Promise<void>}
+ */
+export async function stopServer({
+  httpServer,
+  handler,
+  projectRoot,
+  deps
+}) {
+  let {
+    fs
+  } = deps;
+  if (httpServer) {
+    await httpServer.stop();
+  }
+  if (handler?.cleanup) {
+    try {
+      handler.cleanup();
+    } catch {
+      // Don't throw - cleanup errors shouldn't fail the stop process
+    }
+  }
+
+  // Clean up server.json
+  removeServerJson({
+    projectRoot,
+    fs
+  });
+}
+
+// ============================================================================
+// Server.json Operations
+// ============================================================================
+
+/**
+ * Write server.json file for SDK discovery
+ * @param {Object} options - Options
+ * @param {string} options.projectRoot - Project root directory
+ * @param {number} options.port - Server port
+ * @param {string|null} [options.buildId] - Optional build ID
+ * @param {Object} options.fs - Filesystem operations
+ */
+export function writeServerJson({
+  projectRoot,
+  port,
+  buildId = null,
+  fs
+}) {
+  try {
+    let paths = buildServerJsonPaths(projectRoot);
+    fs.mkdirSync(paths.dir, {
+      recursive: true
+    });
+    let serverInfo = buildServerInfo({
+      port,
+      pid: process.pid,
+      startTime: Date.now(),
+      buildId
+    });
+    fs.writeFileSync(paths.file, JSON.stringify(serverInfo, null, 2));
+  } catch {
+    // Non-fatal - SDK can still use health check or environment variables
+  }
+}
+
+/**
+ * Remove server.json file
+ * @param {Object} options - Options
+ * @param {string} options.projectRoot - Project root directory
+ * @param {Object} options.fs - Filesystem operations
+ */
+export function removeServerJson({
+  projectRoot,
+  fs
+}) {
+  try {
+    let paths = buildServerJsonPaths(projectRoot);
+    if (fs.existsSync(paths.file)) {
+      fs.unlinkSync(paths.file);
+    }
+  } catch {
+    // Non-fatal - cleanup errors shouldn't fail the stop process
+  }
+}
+
+// ============================================================================
+// TDD Results
+// ============================================================================
+
+/**
+ * Get TDD results from handler
+ * @param {Object} options - Options
+ * @param {boolean} options.tddMode - Whether in TDD mode
+ * @param {Object|null} options.handler - Handler instance
+ * @returns {Promise<Object|null>} TDD results or null
+ */
+export async function getTddResults({
+  tddMode,
+  handler
+}) {
+  if (!tddMode || !handler?.getResults) {
+    return null;
+  }
+  return await handler.getResults();
+}

package/dist/services/build-manager.js

@@ -1,10 +1,8 @@
 /**
- * Build Manager Service
- * Manages the build lifecycle and coordinates test execution
+ * Build Manager - Pure functions for build lifecycle management
  */
 
 import crypto from 'node:crypto';
-import { VizzlyError } from '../errors/vizzly-error.js';
 
 /**
  * Generate unique build ID for local build management only.
@@ -108,7 +106,7 @@ export function createQueuedBuild(buildOptions) {
  * @returns {Object} Validation result
  */
 export function validateBuildOptions(buildOptions) {
-  const errors = [];
+  let errors = [];
   if (!buildOptions.name && !buildOptions.branch) {
     errors.push('Either name or branch is required');
   }
@@ -119,69 +117,4 @@ export function validateBuildOptions(buildOptions) {
     valid: errors.length === 0,
     errors
   };
-}
-export class BuildManager {
-  constructor(config) {
-    this.config = config;
-    this.currentBuild = null;
-    this.buildQueue = [];
-  }
-  async createBuild(buildOptions) {
-    const build = createBuildObject(buildOptions);
-    this.currentBuild = build;
-    return build;
-  }
-  async updateBuildStatus(buildId, status, updates = {}) {
-    if (!this.currentBuild || this.currentBuild.id !== buildId) {
-      throw new VizzlyError(`Build ${buildId} not found`, 'BUILD_NOT_FOUND');
-    }
-    this.currentBuild = updateBuild(this.currentBuild, status, updates);
-    return this.currentBuild;
-  }
-  async addScreenshot(buildId, screenshot) {
-    if (!this.currentBuild || this.currentBuild.id !== buildId) {
-      throw new VizzlyError(`Build ${buildId} not found`, 'BUILD_NOT_FOUND');
-    }
-    this.currentBuild = addScreenshotToBuild(this.currentBuild, screenshot);
-    return this.currentBuild;
-  }
-  async finalizeBuild(buildId, result = {}) {
-    if (!this.currentBuild || this.currentBuild.id !== buildId) {
-      throw new VizzlyError(`Build ${buildId} not found`, 'BUILD_NOT_FOUND');
-    }
-    this.currentBuild = finalizeBuildObject(this.currentBuild, result);
-    return this.currentBuild;
-  }
-  getCurrentBuild() {
-    return this.currentBuild;
-  }
-  queueBuild(buildOptions) {
-    const queuedBuild = createQueuedBuild(buildOptions);
-    this.buildQueue.push(queuedBuild);
-  }
-  async clear() {
-    // Cancel pending build if exists
-    if (this.currentBuild && this.currentBuild.status === 'pending') {
-      await this.updateBuildStatus(this.currentBuild.id, 'cancelled');
-    }
-    this.buildQueue.length = 0;
-    this.currentBuild = null;
-  }
-  async processNextBuild() {
-    if (this.buildQueue.length === 0) {
-      return null;
-    }
-    const buildOptions = this.buildQueue.shift();
-    return await this.createBuild(buildOptions);
-  }
-  getQueueStatus() {
-    return {
-      length: this.buildQueue.length,
-      items: this.buildQueue.map(item => ({
-        name: item.name,
-        branch: item.branch,
-        queuedAt: item.queuedAt
-      }))
-    };
-  }
 }

package/dist/services/index.js

@@ -1,64 +1,37 @@
 /**
  * Service Factory
- * Creates all services with explicit dependencies - no DI container needed
+ * Creates services for plugin API compatibility.
+ *
+ * Internal commands now use functional modules directly:
+ * - API: import { createApiClient, getBuild } from '../api/index.js'
+ * - Auth: import { createAuthClient, whoami } from '../auth/index.js'
+ *
+ * This factory is only used by cli.js to provide services to plugins.
  */
 
-import { ApiService } from './api-service.js';
-import { AuthService } from './auth-service.js';
-import { BuildManager } from './build-manager.js';
-import { ConfigService } from './config-service.js';
-import { ProjectService } from './project-service.js';
 import { ServerManager } from './server-manager.js';
-import { createTDDService } from './tdd-service.js';
 import { TestRunner } from './test-runner.js';
-import { createUploader } from './uploader.js';
 
 /**
- * Create all services with their dependencies
+ * Create services for plugin API compatibility.
+ *
+ * Only creates services that plugins actually need:
+ * - testRunner: Build lifecycle management with EventEmitter
+ * - serverManager: Screenshot server control
+ *
+ * Commands use functional modules directly - this factory exists
+ * only to support the plugin API contract.
+ *
  * @param {Object} config - Configuration object
- * @param {string} [command='run'] - Command context ('run', 'tdd', 'status')
- * @returns {Object} Services object
+ * @returns {Object} Services object for plugins
  */
-export function createServices(config, command = 'run') {
-  const apiService = new ApiService({
-    ...config,
-    allowNoToken: true
+export function createServices(config) {
+  let serverManager = new ServerManager(config, {
+    services: {}
   });
-  const authService = new AuthService({
-    baseUrl: config.apiUrl
-  });
-  const configService = new ConfigService(config, {
-    projectRoot: process.cwd()
-  });
-  const projectService = new ProjectService(config, {
-    apiService,
-    authService
-  });
-  const uploader = createUploader({
-    ...config,
-    command
-  });
-  const buildManager = new BuildManager(config);
-  const tddService = createTDDService(config, {
-    authService
-  });
-  const serverManager = new ServerManager(config, {
-    services: {
-      configService,
-      authService,
-      projectService
-    }
-  });
-  const testRunner = new TestRunner(config, buildManager, serverManager, tddService);
+  let testRunner = new TestRunner(config, serverManager);
   return {
-    apiService,
-    authService,
-    configService,
-    projectService,
-    uploader,
-    buildManager,
     serverManager,
-    tddService,
     testRunner
   };
 }