@vizzly-testing/cli 0.10.1 → 0.10.2

package/dist/commands/tdd-daemon.js

@@ -1,4 +1,4 @@
-import { writeFileSync, readFileSync, existsSync, unlinkSync, mkdirSync, openSync } from 'fs';
+import { writeFileSync, readFileSync, existsSync, unlinkSync, mkdirSync } from 'fs';
 import { join } from 'path';
 import { spawn } from 'child_process';
 import { ConsoleUI } from '../utils/console-ui.js';
@@ -36,21 +36,56 @@ export async function tddStartCommand(options = {}, globalOptions = {}) {
     }
     const port = options.port || 47392;
 
-    // Prepare log files for daemon output
-    const logFile = join(vizzlyDir, 'daemon.log');
-    const errorFile = join(vizzlyDir, 'daemon-error.log');
+    // Show loading indicator if downloading baselines (but not in verbose mode since child shows progress)
+    if (options.baselineBuild && !globalOptions.verbose) {
+      ui.startSpinner(`Downloading baselines from build ${options.baselineBuild}...`);
+    }
 
-    // Spawn detached child process to run the server
+    // Spawn child process with stdio inherited during init for direct error visibility
     const child = spawn(process.execPath, [process.argv[1],
     // CLI entry point
     'tdd', 'start', '--daemon-child',
     // Special flag for child process
     '--port', port.toString(), ...(options.open ? ['--open'] : []), ...(options.baselineBuild ? ['--baseline-build', options.baselineBuild] : []), ...(options.baselineComparison ? ['--baseline-comparison', options.baselineComparison] : []), ...(options.environment ? ['--environment', options.environment] : []), ...(options.threshold !== undefined ? ['--threshold', options.threshold.toString()] : []), ...(options.timeout ? ['--timeout', options.timeout] : []), ...(options.token ? ['--token', options.token] : []), ...(globalOptions.json ? ['--json'] : []), ...(globalOptions.verbose ? ['--verbose'] : []), ...(globalOptions.noColor ? ['--no-color'] : [])], {
       detached: true,
-      stdio: ['ignore', openSync(logFile, 'a'), openSync(errorFile, 'a')],
+      stdio: ['ignore', 'inherit', 'inherit', 'ipc'],
       cwd: process.cwd()
     });
 
+    // Wait for child to signal successful init or exit with error
+    let initComplete = false;
+    let initFailed = false;
+    await new Promise(resolve => {
+      // Child disconnects IPC when initialization succeeds
+      child.on('disconnect', () => {
+        initComplete = true;
+        resolve();
+      });
+
+      // Child exits before disconnecting = initialization failed
+      child.on('exit', () => {
+        if (!initComplete) {
+          initFailed = true;
+          resolve();
+        }
+      });
+
+      // Timeout after 30 seconds to prevent indefinite wait
+      setTimeout(() => {
+        if (!initComplete && !initFailed) {
+          initFailed = true;
+          resolve();
+        }
+      }, 30000);
+    });
+    if (initFailed) {
+      if (options.baselineBuild && !globalOptions.verbose) {
+        ui.stopSpinner();
+      }
+      ui.error('TDD server failed to start');
+      process.exit(1);
+    }
+
     // Unref so parent can exit
     child.unref();
 
@@ -62,6 +97,9 @@ export async function tddStartCommand(options = {}, globalOptions = {}) {
       await new Promise(resolve => setTimeout(resolve, retryDelay * (i + 1)));
       running = await isServerRunning(port);
     }
+    if (options.baselineBuild && !globalOptions.verbose) {
+      ui.stopSpinner();
+    }
     if (!running) {
       ui.error('Failed to start TDD server - server not responding to health checks');
       process.exit(1);
@@ -106,6 +144,11 @@ export async function runDaemonChild(options = {}, globalOptions = {}) {
       daemon: true
     }, globalOptions);
 
+    // Disconnect IPC after successful initialization to signal parent
+    if (process.send) {
+      process.disconnect();
+    }
+
     // Store our PID for the stop command
     const pidFile = join(vizzlyDir, 'server.pid');
     writeFileSync(pidFile, process.pid.toString());
@@ -139,15 +182,8 @@ export async function runDaemonChild(options = {}, globalOptions = {}) {
     // Keep process alive
     process.stdin.resume();
   } catch (error) {
-    // Log error to file for debugging
-    const logFile = join(vizzlyDir, 'daemon-error.log');
-    try {
-      writeFileSync(logFile, `[${new Date().toISOString()}] ${error.stack || error}\n`, {
-        flag: 'a'
-      });
-    } catch {
-      // Silent failure if we can't write log
-    }
+    // Most errors shown via inherited stdio, but catch any that weren't
+    console.error(`Fatal error: ${error.message}`);
     process.exit(1);
   }
 }

package/dist/commands/tdd.js

@@ -53,7 +53,9 @@ export async function tddCommand(testCommand, options = {}, globalOptions = {})
     // Collect git metadata
     const branch = await detectBranch(options.branch);
     const commit = await detectCommit(options.commit);
-    if (globalOptions.verbose) {
+
+    // Only show config in verbose mode for non-daemon (daemon shows baseline info instead)
+    if (globalOptions.verbose && !options.daemon) {
       ui.info('TDD Configuration loaded', {
         testCommand,
         port: config.server.port,
@@ -97,8 +99,13 @@ export async function tddCommand(testCommand, options = {}, globalOptions = {})
         ui.info(`TDD screenshot server running on port ${serverInfo.port}`);
         ui.info(`Dashboard: http://localhost:${serverInfo.port}/dashboard`);
       }
-      if (globalOptions.verbose) {
-        ui.info('Server details', serverInfo);
+      // Verbose server details only in non-daemon mode
+      if (globalOptions.verbose && !options.daemon) {
+        ui.info('Server started', {
+          port: serverInfo.port,
+          pid: serverInfo.pid,
+          uptime: serverInfo.uptime
+        });
       }
     });
     testRunner.on('screenshot-captured', screenshotInfo => {

package/dist/services/tdd-service.js

@@ -90,8 +90,6 @@ export class TddService {
     });
   }
   async downloadBaselines(environment = 'test', branch = null, buildId = null, comparisonId = null) {
-    logger.info('🔍 Looking for baseline build...');
-
     // If no branch specified, try to detect the default branch
     if (!branch) {
       branch = await getDefaultBranch();
@@ -107,7 +105,6 @@ export class TddService {
       let baselineBuild;
       if (buildId) {
         // Use specific build ID - get it with screenshots in one call
-        logger.info(`📌 Using specified build: ${buildId}`);
         const apiResponse = await this.api.getBuild(buildId, 'screenshots');
 
         // Debug the full API response (only in debug mode)
@@ -154,7 +151,6 @@ export class TddService {
         }
         baselineBuild = builds.data[0];
       }
-      logger.info(`📥 Found baseline build: ${colors.cyan(baselineBuild.name || 'Unknown')} (${baselineBuild.id || 'Unknown ID'})`);
 
       // For specific buildId, we already have screenshots, otherwise get build details
       let buildDetails = baselineBuild;
@@ -167,7 +163,8 @@ export class TddService {
         logger.warn('⚠️  No screenshots found in baseline build');
         return null;
       }
-      logger.info(`📸 Downloading ${colors.cyan(buildDetails.screenshots.length)} baseline screenshots...`);
+      logger.info(`Using baseline from build: ${colors.cyan(baselineBuild.name || 'Unknown')} (${baselineBuild.id || 'Unknown ID'})`);
+      logger.info(`Checking ${colors.cyan(buildDetails.screenshots.length)} baseline screenshots...`);
 
       // Debug screenshots structure (only in debug mode)
       logger.debug(`📊 Screenshots array structure:`, {
@@ -352,17 +349,37 @@ export class TddService {
       const metadataPath = join(this.baselinePath, 'metadata.json');
       writeFileSync(metadataPath, JSON.stringify(this.baselineData, null, 2));
 
+      // Save baseline build metadata for MCP plugin
+      const baselineMetadataPath = safePath(this.workingDir, '.vizzly', 'baseline-metadata.json');
+      const buildMetadata = {
+        buildId: baselineBuild.id,
+        buildName: baselineBuild.name,
+        branch: branch,
+        environment: environment,
+        commitSha: baselineBuild.commit_sha,
+        commitMessage: baselineBuild.commit_message,
+        approvalStatus: baselineBuild.approval_status,
+        completedAt: baselineBuild.completed_at,
+        downloadedAt: new Date().toISOString()
+      };
+      writeFileSync(baselineMetadataPath, JSON.stringify(buildMetadata, null, 2));
+
       // Final summary
       const actualDownloads = downloadedCount - skippedCount;
-      const totalAttempted = downloadedCount + errorCount;
-      if (skippedCount > 0 || errorCount > 0) {
-        let summaryParts = [];
-        if (actualDownloads > 0) summaryParts.push(`${actualDownloads} downloaded`);
-        if (skippedCount > 0) summaryParts.push(`${skippedCount} skipped (matching SHA)`);
-        if (errorCount > 0) summaryParts.push(`${errorCount} failed`);
-        logger.info(`✅ Baseline ready - ${summaryParts.join(', ')} - ${totalAttempted}/${buildDetails.screenshots.length} total`);
+      if (skippedCount > 0) {
+        // All skipped (up-to-date)
+        if (actualDownloads === 0) {
+          logger.info(`✅ All ${skippedCount} baselines up-to-date (matching local SHA)`);
+        } else {
+          // Mixed: some downloaded, some skipped
+          logger.info(`✅ Downloaded ${actualDownloads} new screenshots, ${skippedCount} already up-to-date`);
+        }
       } else {
-        logger.info(`✅ Baseline downloaded successfully - ${downloadedCount}/${buildDetails.screenshots.length} screenshots`);
+        // Fresh download
+        logger.info(`✅ Downloaded ${downloadedCount}/${buildDetails.screenshots.length} screenshots successfully`);
+      }
+      if (errorCount > 0) {
+        logger.warn(`⚠️  ${errorCount} screenshots failed to download`);
       }
       return this.baselineData;
     } catch (error) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vizzly-testing/cli",
-  "version": "0.10.1",
+  "version": "0.10.2",
   "description": "Visual review platform for UI developers and designers",
   "keywords": [
     "visual-testing",