@vitest/eslint-plugin 1.1.21 → 1.1.23

package/README.md

@@ -178,6 +178,13 @@ export default [
 | [no-standalone-expect](docs/rules/no-standalone-expect.md)                                                               | disallow using `expect` outside of `it` or `test` blocks              |    | 🌐 |    |    |    |
 | [no-test-prefixes](docs/rules/no-test-prefixes.md)                                                                       | disallow using `test` as a prefix                                     |    | 🌐 | 🔧 |    |    |
 | [no-test-return-statement](docs/rules/no-test-return-statement.md)                                                       | disallow return statements in tests                                   |    | 🌐 |    |    |    |
+| [padding-around-after-all-blocks](docs/rules/padding-around-after-all-blocks.md)                                                       | enforce padding around `afterAll` blocks                                   |    | 🌐 | 🔧 |    |    |
+| [padding-around-after-each-blocks](docs/rules/padding-around-after-each-blocks.md)                                                       | enforce padding around `afterEach` blocks                                   |    | 🌐 | 🔧 |    |    |
+| [padding-around-all](docs/rules/padding-around-all.md)                                                       | enforce padding around vitest functions                                   |    | 🌐 | 🔧 |    |    |
+| [padding-around-before-all-blocks](docs/rules/padding-around-before-all-blocks.md)                                                       | enforce padding around `beforeAll` blocks                                   |    | 🌐 | 🔧 |    |    |
+| [padding-around-before-each-blocks](docs/rules/padding-around-before-each-blocks.md)                                                       | enforce padding around `beforeEach` blocks                                   |    | 🌐 | 🔧 |    |    |
+| [padding-around-describe-blocks](docs/rules/padding-around-describe-blocks.md)                                                       | enforce padding around `describe` blocks                                   |    | 🌐 | 🔧 |    |    |
+| [padding-around-expect-groups](docs/rules/padding-around-expect-groups.md)                                                       | enforce padding around `expect` groups                                   |    | 🌐 | 🔧 |    |    |
 | [prefer-called-with](docs/rules/prefer-called-with.md)                                                                   | enforce using `toBeCalledWith()` or `toHaveBeenCalledWith()`          |    | 🌐 | 🔧 |    |    |
 | [prefer-comparison-matcher](docs/rules/prefer-comparison-matcher.md)                                                     | enforce using the built-in comparison matchers                        |    | 🌐 | 🔧 |    |    |
 | [prefer-each](docs/rules/prefer-each.md)                                                                                 | enforce using `each` rather than manual loops                         |    | 🌐 |    |    |    |

package/dist/index.cjs

@@ -23,7 +23,7 @@ function _interopNamespaceCompat(e) {
 const path__namespace = /*#__PURE__*/_interopNamespaceCompat(path);
 const ts__default = /*#__PURE__*/_interopDefaultCompat(ts);
 
-const version = "1.1.20";
+const version = "1.1.22";
 
 function createEslintRule(rule) {
   const createRule = utils.ESLintUtils.RuleCreator(
@@ -530,7 +530,7 @@ const maxNestedDescribe = createEslintRule({
       }
     ],
     messages: {
-      maxNestedDescribe: "Nested describe block should be less than set max value."
+      maxNestedDescribe: "Nested describe block should be less than set max value"
     }
   },
   defaultOptions: [
@@ -660,7 +660,7 @@ const noFocusedTests = createEslintRule({
       }
     ],
     messages: {
-      noFocusedTests: "Focused tests are not allowed."
+      noFocusedTests: "Focused tests are not allowed"
     }
   },
   defaultOptions: [{ fixable: true }],
@@ -721,7 +721,7 @@ const noConditionalTest = createEslintRule({
     },
     schema: [],
     messages: {
-      noConditionalTests: "Avoid using if conditions in a test."
+      noConditionalTests: "Avoid using if conditions in a test"
     }
   },
   defaultOptions: [],
@@ -1141,7 +1141,7 @@ const consistentTestFilename = createEslintRule({
       description: "require .spec test file pattern"
     },
     messages: {
-      consistentTestFilename: "use test file name pattern {{pattern}}"
+      consistentTestFilename: "Use test file name pattern {{ pattern }}"
     },
     schema: [
       {
@@ -1197,7 +1197,7 @@ const maxExpect = createEslintRule({
       description: "enforce a maximum number of expect per test"
     },
     messages: {
-      maxExpect: "Too many assertion calls ({{count}}). Maximum is {{max}}."
+      maxExpect: "Too many assertion calls ({{ count }}) - maximum allowed is {{ max }}"
     },
     type: "suggestion",
     schema: [
@@ -1310,7 +1310,7 @@ const noCommentedOutTests = createEslintRule({
       recommended: false
     },
     messages: {
-      noCommentedOutTests: "Remove commented out tests. You may want to use `skip` or `only` instead."
+      noCommentedOutTests: "Remove commented out tests - you may want to use `skip` or `only` instead"
     },
     schema: [],
     type: "suggestion"
@@ -1479,8 +1479,8 @@ const noDisabledTests = createEslintRule({
       pending: "Call to pending()",
       pendingSuite: "Call to pending() within test suite",
       pendingTest: "Call to pending() within test",
-      disabledSuite: "Disabled test suite. If you want to skip a test suite temporarily, use .todo() instead.",
-      disabledTest: "Disabled test. If you want to skip a test temporarily, use .todo() instead."
+      disabledSuite: "Disabled test suite - if you want to skip a test suite temporarily, use .todo() instead",
+      disabledTest: "Disabled test - if you want to skip a test temporarily, use .todo() instead"
     },
     schema: []
   },
@@ -1654,7 +1654,7 @@ const noDuplicateHooks = createEslintRule({
       requiresTypeChecking: false
     },
     messages: {
-      noDuplicateHooks: "Duplicate {{hook}} in describe block."
+      noDuplicateHooks: "Duplicate {{ hook }} in describe block"
     },
     schema: [],
     type: "suggestion"
@@ -1832,7 +1832,7 @@ const noMocksImport = createEslintRule({
       recommended: false
     },
     messages: {
-      noMocksImport: `Mocks should not be manually imported from a ${mocksDirName} directory. Instead use \`vi.mock\` and import from the original module path.`
+      noMocksImport: `Mocks should not be manually imported from a ${mocksDirName} directory. Instead use \`vi.mock\` and import from the original module path`
     },
     schema: []
   },
@@ -1934,15 +1934,14 @@ const noStandaloneExpect = createEslintRule({
     },
     schema: [
       {
+        type: "object",
         properties: {
-          additionaltestblockfunctions: {
-            // @ts-ignore
+          additionalTestBlockFunctions: {
             type: "array",
-            // @ts-ignore
-            items: { type: `string` }
+            items: { type: "string" }
           }
         },
-        additionalproperties: false
+        additionalProperties: false
       }
     ]
   },
@@ -2005,7 +2004,7 @@ const noTestPrefixes = createEslintRule({
     },
     type: "suggestion",
     messages: {
-      usePreferredName: 'Use "{{preferredNodeName}}" instead'
+      usePreferredName: 'Use "{{ preferredNodeName }}" instead'
     },
     fixable: "code",
     schema: []
@@ -2176,14 +2175,14 @@ const validTitle = createEslintRule({
     },
     messages: {
       titleMustBeString: "Test title must be a string, a function or class name",
-      emptyTitle: "{{functionName}} should not have an empty title",
+      emptyTitle: "{{ functionName }} should not have an empty title",
       duplicatePrefix: "should not have duplicate prefix",
       accidentalSpace: "should not have leading or trailing spaces",
-      disallowedWord: '"{{word}}" is not allowed in test title',
-      mustNotMatch: "{{functionName}} should not match {{pattern}}",
-      mustMatch: "{{functionName}} should match {{pattern}}",
-      mustNotMatchCustom: "{{message}}",
-      mustMatchCustom: "{{message}}"
+      disallowedWord: '"{{ word }}" is not allowed in test title',
+      mustNotMatch: "{{ functionName }} should not match {{ pattern }}",
+      mustMatch: "{{ functionName }} should match {{ pattern }}",
+      mustNotMatchCustom: "{{ message }}",
+      mustMatchCustom: "{{ message }}"
     },
     type: "suggestion",
     schema: [
@@ -2242,7 +2241,9 @@ const validTitle = createEslintRule({
       CallExpression(node) {
         const vitestFnCall = parseVitestFnCall(node, context);
         if (vitestFnCall?.type !== "describe" && vitestFnCall?.type !== "test" && vitestFnCall?.type !== "it") return;
-        if (vitestFnCall.members.some((m) => m.type == utils.AST_NODE_TYPES.Identifier && m.name == "extend")) return;
+        if (vitestFnCall.members && vitestFnCall.members[0] && vitestFnCall.members[0].type === utils.AST_NODE_TYPES.Identifier && vitestFnCall.members[0].name === "extend") {
+          return;
+        }
         const [argument] = node.arguments;
         if (settings.typecheck) {
           const services = utils.ESLintUtils.getParserServices(context);
@@ -2395,13 +2396,13 @@ const validExpect = createEslintRule({
       recommended: false
     },
     messages: {
-      tooManyArgs: "Expect takes most {{ amount}} argument{{s}}",
-      notEnoughArgs: "Expect requires atleast {{ amount }} argument{{s}}",
-      modifierUnknown: "Expect has unknown modifier",
-      matcherNotFound: "Expect must have a corresponding matcher call.",
-      matcherNotCalled: "Matchers must be called to assert.",
-      asyncMustBeAwaited: "Async assertions must be awaited{{orReturned}}",
-      promisesWithAsyncAssertionsMustBeAwaited: "Promises which return async assertions must be awaited{{orReturned}}"
+      tooManyArgs: "Expect takes at most {{ amount}} argument{{ s }}",
+      notEnoughArgs: "Expect requires at least {{ amount }} argument{{ s }}",
+      modifierUnknown: "Expect has an unknown modifier",
+      matcherNotFound: "Expect must have a corresponding matcher call",
+      matcherNotCalled: "Matchers must be called to assert",
+      asyncMustBeAwaited: "Async assertions must be awaited{{ orReturned }}",
+      promisesWithAsyncAssertionsMustBeAwaited: "Promises which return async assertions must be awaited{{ orReturned }}"
     },
     type: "suggestion",
     fixable: "code",
@@ -2608,7 +2609,7 @@ const preferToBeObject = createEslintRule({
     },
     fixable: "code",
     messages: {
-      preferToBeObject: "Prefer toBeObject() to test if a value is an object."
+      preferToBeObject: "Prefer toBeObject() to test if a value is an object"
     },
     schema: []
   },
@@ -3472,8 +3473,8 @@ const requireTopLevelDescribe = createEslintRule({
     },
     messages: {
       tooManyDescribes: "There should not be more than {{ max }} describe{{ s }} at the top level",
-      unexpectedTestCase: "All test cases must be wrapped in a describe block.",
-      unexpectedHook: "All hooks must be wrapped in a describe block."
+      unexpectedTestCase: "All test cases must be wrapped in a describe block",
+      unexpectedHook: "All hooks must be wrapped in a describe block"
     },
     type: "suggestion",
     schema: [
@@ -4520,7 +4521,7 @@ const config = [
 ];
 const paddingAroundTestBlocks = createPaddingRule(
   RULE_NAME$2,
-  "Enforce padding around afterAll blocks",
+  "Enforce padding around `test` blocks",
   config
 );
 
@@ -4883,6 +4884,7 @@ const plugin = {
     name: "vitest",
     version
   },
+  configs: {},
   rules: {
     [RULE_NAME$Z]: lowerCaseTitle,
     [RULE_NAME$Y]: maxNestedDescribe,

package/dist/index.d.cts

@@ -1,14 +1,14 @@
 import { Linter, RuleModule } from '@typescript-eslint/utils/ts-eslint';
 
-interface VitestPLugin extends Linter.Plugin {
+interface VitestPlugin extends Linter.Plugin {
     meta: {
         name: string;
         version: string;
     };
     rules: Record<string, RuleModule<any, any>>;
-    configs?: Record<string, any>;
+    configs: Record<string, any>;
     environments?: Record<string, any>;
 }
-declare const plugin: VitestPLugin;
+declare const plugin: VitestPlugin;
 
 export { plugin as default };

package/dist/index.d.mts

@@ -1,14 +1,14 @@
 import { Linter, RuleModule } from '@typescript-eslint/utils/ts-eslint';
 
-interface VitestPLugin extends Linter.Plugin {
+interface VitestPlugin extends Linter.Plugin {
     meta: {
         name: string;
         version: string;
     };
     rules: Record<string, RuleModule<any, any>>;
-    configs?: Record<string, any>;
+    configs: Record<string, any>;
     environments?: Record<string, any>;
 }
-declare const plugin: VitestPLugin;
+declare const plugin: VitestPlugin;
 
 export { plugin as default };

package/dist/index.d.ts

@@ -1,14 +1,14 @@
 import { Linter, RuleModule } from '@typescript-eslint/utils/ts-eslint';
 
-interface VitestPLugin extends Linter.Plugin {
+interface VitestPlugin extends Linter.Plugin {
     meta: {
         name: string;
         version: string;
     };
     rules: Record<string, RuleModule<any, any>>;
-    configs?: Record<string, any>;
+    configs: Record<string, any>;
     environments?: Record<string, any>;
 }
-declare const plugin: VitestPLugin;
+declare const plugin: VitestPlugin;
 
 export { plugin as default };

package/dist/index.mjs

@@ -4,7 +4,7 @@ import { isAbsolute, posix } from 'node:path';
 import ts from 'typescript';
 import { createRequire } from 'node:module';
 
-const version = "1.1.20";
+const version = "1.1.22";
 
 function createEslintRule(rule) {
   const createRule = ESLintUtils.RuleCreator(
@@ -511,7 +511,7 @@ const maxNestedDescribe = createEslintRule({
       }
     ],
     messages: {
-      maxNestedDescribe: "Nested describe block should be less than set max value."
+      maxNestedDescribe: "Nested describe block should be less than set max value"
     }
   },
   defaultOptions: [
@@ -641,7 +641,7 @@ const noFocusedTests = createEslintRule({
       }
     ],
     messages: {
-      noFocusedTests: "Focused tests are not allowed."
+      noFocusedTests: "Focused tests are not allowed"
     }
   },
   defaultOptions: [{ fixable: true }],
@@ -702,7 +702,7 @@ const noConditionalTest = createEslintRule({
     },
     schema: [],
     messages: {
-      noConditionalTests: "Avoid using if conditions in a test."
+      noConditionalTests: "Avoid using if conditions in a test"
     }
   },
   defaultOptions: [],
@@ -1122,7 +1122,7 @@ const consistentTestFilename = createEslintRule({
       description: "require .spec test file pattern"
     },
     messages: {
-      consistentTestFilename: "use test file name pattern {{pattern}}"
+      consistentTestFilename: "Use test file name pattern {{ pattern }}"
     },
     schema: [
       {
@@ -1178,7 +1178,7 @@ const maxExpect = createEslintRule({
       description: "enforce a maximum number of expect per test"
     },
     messages: {
-      maxExpect: "Too many assertion calls ({{count}}). Maximum is {{max}}."
+      maxExpect: "Too many assertion calls ({{ count }}) - maximum allowed is {{ max }}"
     },
     type: "suggestion",
     schema: [
@@ -1291,7 +1291,7 @@ const noCommentedOutTests = createEslintRule({
       recommended: false
     },
     messages: {
-      noCommentedOutTests: "Remove commented out tests. You may want to use `skip` or `only` instead."
+      noCommentedOutTests: "Remove commented out tests - you may want to use `skip` or `only` instead"
     },
     schema: [],
     type: "suggestion"
@@ -1460,8 +1460,8 @@ const noDisabledTests = createEslintRule({
       pending: "Call to pending()",
       pendingSuite: "Call to pending() within test suite",
       pendingTest: "Call to pending() within test",
-      disabledSuite: "Disabled test suite. If you want to skip a test suite temporarily, use .todo() instead.",
-      disabledTest: "Disabled test. If you want to skip a test temporarily, use .todo() instead."
+      disabledSuite: "Disabled test suite - if you want to skip a test suite temporarily, use .todo() instead",
+      disabledTest: "Disabled test - if you want to skip a test temporarily, use .todo() instead"
     },
     schema: []
   },
@@ -1635,7 +1635,7 @@ const noDuplicateHooks = createEslintRule({
       requiresTypeChecking: false
     },
     messages: {
-      noDuplicateHooks: "Duplicate {{hook}} in describe block."
+      noDuplicateHooks: "Duplicate {{ hook }} in describe block"
     },
     schema: [],
     type: "suggestion"
@@ -1813,7 +1813,7 @@ const noMocksImport = createEslintRule({
       recommended: false
     },
     messages: {
-      noMocksImport: `Mocks should not be manually imported from a ${mocksDirName} directory. Instead use \`vi.mock\` and import from the original module path.`
+      noMocksImport: `Mocks should not be manually imported from a ${mocksDirName} directory. Instead use \`vi.mock\` and import from the original module path`
     },
     schema: []
   },
@@ -1915,15 +1915,14 @@ const noStandaloneExpect = createEslintRule({
     },
     schema: [
       {
+        type: "object",
         properties: {
-          additionaltestblockfunctions: {
-            // @ts-ignore
+          additionalTestBlockFunctions: {
             type: "array",
-            // @ts-ignore
-            items: { type: `string` }
+            items: { type: "string" }
           }
         },
-        additionalproperties: false
+        additionalProperties: false
       }
     ]
   },
@@ -1986,7 +1985,7 @@ const noTestPrefixes = createEslintRule({
     },
     type: "suggestion",
     messages: {
-      usePreferredName: 'Use "{{preferredNodeName}}" instead'
+      usePreferredName: 'Use "{{ preferredNodeName }}" instead'
     },
     fixable: "code",
     schema: []
@@ -2157,14 +2156,14 @@ const validTitle = createEslintRule({
     },
     messages: {
       titleMustBeString: "Test title must be a string, a function or class name",
-      emptyTitle: "{{functionName}} should not have an empty title",
+      emptyTitle: "{{ functionName }} should not have an empty title",
       duplicatePrefix: "should not have duplicate prefix",
       accidentalSpace: "should not have leading or trailing spaces",
-      disallowedWord: '"{{word}}" is not allowed in test title',
-      mustNotMatch: "{{functionName}} should not match {{pattern}}",
-      mustMatch: "{{functionName}} should match {{pattern}}",
-      mustNotMatchCustom: "{{message}}",
-      mustMatchCustom: "{{message}}"
+      disallowedWord: '"{{ word }}" is not allowed in test title',
+      mustNotMatch: "{{ functionName }} should not match {{ pattern }}",
+      mustMatch: "{{ functionName }} should match {{ pattern }}",
+      mustNotMatchCustom: "{{ message }}",
+      mustMatchCustom: "{{ message }}"
     },
     type: "suggestion",
     schema: [
@@ -2223,7 +2222,9 @@ const validTitle = createEslintRule({
       CallExpression(node) {
         const vitestFnCall = parseVitestFnCall(node, context);
         if (vitestFnCall?.type !== "describe" && vitestFnCall?.type !== "test" && vitestFnCall?.type !== "it") return;
-        if (vitestFnCall.members.some((m) => m.type == AST_NODE_TYPES.Identifier && m.name == "extend")) return;
+        if (vitestFnCall.members && vitestFnCall.members[0] && vitestFnCall.members[0].type === AST_NODE_TYPES.Identifier && vitestFnCall.members[0].name === "extend") {
+          return;
+        }
         const [argument] = node.arguments;
         if (settings.typecheck) {
           const services = ESLintUtils.getParserServices(context);
@@ -2376,13 +2377,13 @@ const validExpect = createEslintRule({
       recommended: false
     },
     messages: {
-      tooManyArgs: "Expect takes most {{ amount}} argument{{s}}",
-      notEnoughArgs: "Expect requires atleast {{ amount }} argument{{s}}",
-      modifierUnknown: "Expect has unknown modifier",
-      matcherNotFound: "Expect must have a corresponding matcher call.",
-      matcherNotCalled: "Matchers must be called to assert.",
-      asyncMustBeAwaited: "Async assertions must be awaited{{orReturned}}",
-      promisesWithAsyncAssertionsMustBeAwaited: "Promises which return async assertions must be awaited{{orReturned}}"
+      tooManyArgs: "Expect takes at most {{ amount}} argument{{ s }}",
+      notEnoughArgs: "Expect requires at least {{ amount }} argument{{ s }}",
+      modifierUnknown: "Expect has an unknown modifier",
+      matcherNotFound: "Expect must have a corresponding matcher call",
+      matcherNotCalled: "Matchers must be called to assert",
+      asyncMustBeAwaited: "Async assertions must be awaited{{ orReturned }}",
+      promisesWithAsyncAssertionsMustBeAwaited: "Promises which return async assertions must be awaited{{ orReturned }}"
     },
     type: "suggestion",
     fixable: "code",
@@ -2589,7 +2590,7 @@ const preferToBeObject = createEslintRule({
     },
     fixable: "code",
     messages: {
-      preferToBeObject: "Prefer toBeObject() to test if a value is an object."
+      preferToBeObject: "Prefer toBeObject() to test if a value is an object"
     },
     schema: []
   },
@@ -3453,8 +3454,8 @@ const requireTopLevelDescribe = createEslintRule({
     },
     messages: {
       tooManyDescribes: "There should not be more than {{ max }} describe{{ s }} at the top level",
-      unexpectedTestCase: "All test cases must be wrapped in a describe block.",
-      unexpectedHook: "All hooks must be wrapped in a describe block."
+      unexpectedTestCase: "All test cases must be wrapped in a describe block",
+      unexpectedHook: "All hooks must be wrapped in a describe block"
     },
     type: "suggestion",
     schema: [
@@ -4501,7 +4502,7 @@ const config = [
 ];
 const paddingAroundTestBlocks = createPaddingRule(
   RULE_NAME$2,
-  "Enforce padding around afterAll blocks",
+  "Enforce padding around `test` blocks",
   config
 );
 
@@ -4864,6 +4865,7 @@ const plugin = {
     name: "vitest",
     version
   },
+  configs: {},
   rules: {
     [RULE_NAME$Z]: lowerCaseTitle,
     [RULE_NAME$Y]: maxNestedDescribe,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vitest/eslint-plugin",
-  "version": "1.1.21",
+  "version": "1.1.23",
   "license": "MIT",
   "description": "Eslint plugin for vitest",
   "repository": "vitest-dev/eslint-plugin-vitest",
@@ -35,7 +35,7 @@
     "@types/node": "^22.10.2",
     "@typescript-eslint/eslint-plugin": "8.18.2",
     "@typescript-eslint/parser": "8.18.2",
-    "@typescript-eslint/rule-tester": "8.18.1",
+    "@typescript-eslint/rule-tester": "8.18.2",
     "@vitest/eslint-plugin": "^1.1.20",
     "bumpp": "^9.9.2",
     "concurrently": "^9.1.1",