@vitest/browser-playwright 5.0.0-beta.4 → 5.0.0-beta.6

package/dist/index.js

@@ -1,4 +1,4 @@
-import { parseKeyDef, resolveScreenshotPath, defineBrowserProvider } from '@vitest/browser';
+import { parseKeyDef, resolveScreenshotPath, assertBrowserApiWrite, assertBrowserFileAccess, defineBrowserProvider } from '@vitest/browser';
 export { defineBrowserCommand } from '@vitest/browser';
 import { createManualModuleSource } from '@vitest/mocker/node';
 import c from 'tinyrainbow';
@@ -522,6 +522,8 @@ async function takeScreenshot(context, name, options) {
 	let savePath;
 	if (options.save) {
 		savePath = normalize(path);
+		assertBrowserApiWrite(context.project, savePath);
+		assertBrowserFileAccess(context.project, savePath);
 		await mkdir(dirname(savePath), { recursive: true });
 	}
 	const mask = options.mask?.map((selector) => getDescribedLocator(context, selector));
@@ -622,6 +624,8 @@ const startChunkTrace = async (command, { name, title }) => {
 const stopChunkTrace = async (context, { name }) => {
 	if (isPlaywrightProvider(context.provider)) {
 		const path = resolveTracesPath(context, name);
+		assertBrowserApiWrite(context.project, path);
+		assertBrowserFileAccess(context.project, path);
 		context.provider.pendingTraces.delete(path);
 		await context.context.tracing.stopChunk({ path });
 		return { tracePath: path };
@@ -708,6 +712,10 @@ const deleteTracing = async (context, { traces }) => {
 		throw new Error(`stopChunkTrace cannot be called outside of the test file.`);
 	}
 	if (isPlaywrightProvider(context.provider)) {
+		for (const trace of traces) {
+			assertBrowserApiWrite(context.project, trace);
+			assertBrowserFileAccess(context.project, trace);
+		}
 		return Promise.all(traces.map((trace) => unlink(trace).catch((err) => {
 			if (err.code === "ENOENT") {
 				// Ignore the error if the file doesn't exist
@@ -722,6 +730,8 @@ const deleteTracing = async (context, { traces }) => {
 const annotateTraces = async ({ project }, { testId, traces }) => {
 	const vitest = project.vitest;
 	await Promise.all(traces.map((trace) => {
+		assertBrowserApiWrite(project, trace);
+		assertBrowserFileAccess(project, trace);
 		const entity = vitest.state.getReportedEntityById(testId);
 		const location = entity?.location ? {
 			file: entity.module.moduleId,
@@ -766,7 +776,9 @@ const upload = async (context, selector, files, options) => {
 	const root = context.project.config.root;
 	const playwrightFiles = files.map((file) => {
 		if (typeof file === "string") {
-			return resolve(root, file);
+			const filepath = resolve(root, file);
+			assertBrowserFileAccess(context.project, filepath);
+			return filepath;
 		}
 		return {
 			name: file.name,
@@ -1069,7 +1081,7 @@ class PlaywrightBrowserProvider {
 			clear: async (sessionId) => {
 				const page = this.getPage(sessionId);
 				const ids = sessionIds.get(sessionId) ?? new Set();
-				const promises = [...ids].map((id) => {
+				const promises = Array.from(ids, (id) => {
 					const key = predicateKey(sessionId, id);
 					const predicate = idPredicates.get(key);
 					if (predicate) {
@@ -1111,7 +1123,11 @@ class PlaywrightBrowserProvider {
 			...contextOptions,
 			ignoreHTTPSErrors: true
 		};
-		if (this.project.config.browser.ui) {
+		// A `null` viewport lets the page adopt the real window size, which is only
+		// meaningful for a headed UI. In headless mode there is no real window, so it
+		// would inherit the host's device scale factor and produce screenshots that
+		// differ from non-UI runs on the same machine.
+		if (this.project.config.browser.ui && !this.project.config.browser.headless) {
 			options.viewport = null;
 		}
 		return options;
@@ -1207,12 +1223,12 @@ class PlaywrightBrowserProvider {
 		}
 		const browser = this.browser;
 		this.browser = null;
-		await Promise.all([...this.pages.values()].map((p) => p.close()));
+		await Promise.all(Array.from(this.pages.values(), (p) => p.close()));
 		this.pages.clear();
 		if (this.persistentContext) {
 			await this.persistentContext.close();
 		} else {
-			await Promise.all([...this.contexts.values()].map((c) => c.close()));
+			await Promise.all(Array.from(this.contexts.values(), (c) => c.close()));
 		}
 		this.contexts.clear();
 		await browser?.close();

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@vitest/browser-playwright",
   "type": "module",
-  "version": "5.0.0-beta.4",
+  "version": "5.0.0-beta.6",
   "description": "Browser running for Vitest using playwright",
   "license": "MIT",
   "funding": "https://opencollective.com/vitest",
@@ -42,7 +42,7 @@
   ],
   "peerDependencies": {
     "playwright": "*",
-    "vitest": "5.0.0-beta.4"
+    "vitest": "5.0.0-beta.6"
   },
   "peerDependenciesMeta": {
     "playwright": {
@@ -51,12 +51,12 @@
   },
   "dependencies": {
     "tinyrainbow": "^3.1.0",
-    "@vitest/mocker": "5.0.0-beta.4",
-    "@vitest/browser": "5.0.0-beta.4"
+    "@vitest/browser": "5.0.0-beta.6",
+    "@vitest/mocker": "5.0.0-beta.6"
   },
   "devDependencies": {
-    "playwright": "^1.60.0",
-    "vitest": "5.0.0-beta.4"
+    "playwright": "^1.61.0",
+    "vitest": "5.0.0-beta.6"
   },
   "scripts": {
     "build": "premove dist && pnpm rollup -c",