@vitest-agent/plugin 3.0.0 → 3.0.1

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@vitest-agent/plugin",
-	"version": "3.0.0",
+	"version": "3.0.1",
 	"private": false,
 	"description": "Vitest plugin for the vitest-agent ecosystem: owns persistence, classification, baselines, trends, and dispatches rendering to a configurable reporter.",
 	"keywords": [
@@ -42,10 +42,10 @@
 		"@effect/platform-node": "4.0.0-rc.112",
 		"@effect/sql-sqlite-node": "4.0.0-rc.112",
 		"@effected/workspaces": "^0.20.1",
-		"@vitest-agent/cli": "2.2.16",
-		"@vitest-agent/mcp": "3.0.0",
-		"@vitest-agent/reporter": "3.0.0",
-		"@vitest-agent/sdk": "3.0.0",
+		"@vitest-agent/cli": "2.2.17",
+		"@vitest-agent/mcp": "3.0.1",
+		"@vitest-agent/reporter": "3.0.1",
+		"@vitest-agent/sdk": "3.1.0",
 		"effect": "4.0.0-rc.112",
 		"magic-string": "^1.2.3"
 	},

package/plugin.js

@@ -14,6 +14,7 @@ import { resolveCoverageDirIsolation } from "./utils/resolve-coverage-dir-isolat
 import { DEFAULT_BUILT_RECENTLY_MS, DEFAULT_LOCK_STALE_MS, DEFAULT_LOCK_WAIT_TIMEOUT_MS, acquireRunScriptLock, markRunScriptDone, parseLockTimingOverride, releaseRunScriptLock } from "./utils/run-script-lock.js";
 import { stripConsoleReporters } from "./utils/strip-console-reporters.js";
 import { makeTagCacheKeyGenerator } from "./utils/tag-cache-key.js";
+import { readVitestVersion, vitestPeerVersionMismatchMessage } from "./utils/vitest-peer-version-mismatch-error.js";
 import { execSync } from "node:child_process";
 import { mkdtempSync, rmSync } from "node:fs";
 import { tmpdir } from "node:os";
@@ -125,7 +126,7 @@ const coverageDirDecidedByVitest = /* @__PURE__ */ new WeakSet();
 *
 * @public
 */
-const CURRENT_PLUGIN_VERSION = "3.0.0";
+const CURRENT_PLUGIN_VERSION = "3.0.1";
 const TEST_FILE_DIR_RE = new RegExp(`/(?:${SRC_DIR}|${TEST_DIR})/`);
 const isTestFile = (id) => isTestFileName(id) && TEST_FILE_DIR_RE.test(id);
 /**
@@ -196,6 +197,7 @@ function AgentPlugin(options = {}, _layer) {
 			try {
 				const { vitest, project } = ctx;
 				log("configureVitest called | project:", project?.name ?? "(root)");
+				if (typeof ctx.defineCacheKeyGenerator !== "function") throw new ConfigurationError(vitestPeerVersionMismatchMessage(readVitestVersion(vitest)));
 				if (discoverStrategyResolved && !cacheKeyGeneratorByVitest.has(vitest)) {
 					cacheKeyGeneratorByVitest.add(vitest);
 					ctx.defineCacheKeyGenerator(makeTagCacheKeyGenerator(classifyForCache));

package/utils/is-test-shaped-package.js

@@ -1,32 +1,53 @@
 import { nodeWalkerFs } from "./walker-fs.js";
 import { findTestFiles } from "./find-test-files.js";
 import { join } from "node:path";
-import { SRC_DIR, TEST_DIR, TEST_FILE_GLOB_SUFFIX } from "@vitest-agent/sdk";
+import { BATS_FILE_GLOB_SUFFIX, SRC_DIR, TEST_DIR, TEST_FILE_GLOB_SUFFIX } from "@vitest-agent/sdk";
 
 //#region src/utils/is-test-shaped-package.ts
 /**
-* True when `pkgPath` looks like it was meant to hold tests: a `__test__/`
-* directory exists at the package root (regardless of what's inside it), or
-* `src/` contains at least one file matching the discoverable test-file
-* naming convention (`TEST_FILE_GLOB_SUFFIX`).
+* True when `pkgPath` looks like it was meant to hold tests, yet neither a
+* discoverable Vitest test file nor a Bats test file was found anywhere
+* under it — the condition `discoverProjects`'s declined-package warning
+* (issue #229) exists to catch.
 *
-* Reuses `SRC_DIR` / `TEST_DIR` / `TEST_FILE_GLOB_SUFFIX` from
-* `@vitest-agent/sdk`'s `utils/test-location.ts` — the single source of
-* truth for the test-layout rule — and the existing `findTestFiles` walker,
-* rather than re-deriving the shape independently.
+* We only want to surface a warning when NO vitest test and NO bats test
+* are found. Concretely, in order:
 *
-* A `__test__/` directory counts on existence alone, not on matching file
-* content: the failure mode this predicate exists to catch (issue #229) IS a
-* `__test__/` directory whose files don't match the naming convention (wrong
-* suffix, wrong extension, typo) — `DefaultDiscoverStrategy.buildProject`
-* already declined those packages by finding zero matching files, so
-* requiring a match here would make the predicate blind to exactly the case
-* it needs to catch.
+* 1. A Vitest-convention test file under `src/**` or `__test__/**`
+*    (`TEST_FILE_GLOB_SUFFIX`) → not test-shaped (false, no warning). The
+*    package has real, discoverable tests.
+* 2. A `.bats` file anywhere under the package (`BATS_FILE_GLOB_SUFFIX`,
+*    searched recursively — a nested `__test__/foo/bar.bats` counts) → not
+*    test-shaped (false, no warning). Bats tests are run by `bats`, not
+*    Vitest (`bats --recursive`, or the `test:bats` package script); a
+*    `__test__/` directory holding only `.bats` files (plus fixtures) is a
+*    fully supported, intentional layout — see `@effected/claude-code-plugin`'s
+*    `plugins/claude-code/__test__/` for the real case this fixes (issue
+*    #360-adjacent).
+* 3. Otherwise, a `__test__/` directory existing at all — regardless of what
+*    it contains — IS test-shaped (true, warn). This is deliberately
+*    existence-only, not content-matching: the failure mode this predicate
+*    exists to catch (issue #229) IS a `__test__/` directory whose files
+*    match neither convention (wrong suffix, wrong extension, typo, or
+*    nothing at all — an empty directory). `DefaultDiscoverStrategy
+*    .buildProject` already declined those packages by finding zero
+*    matching Vitest files; step 1 above already declined them by finding
+*    zero Bats files either; requiring a content match here too would make
+*    the predicate blind to exactly the case it needs to catch.
+*
+* Reuses `SRC_DIR` / `TEST_DIR` / `TEST_FILE_GLOB_SUFFIX` /
+* `BATS_FILE_GLOB_SUFFIX` from `@vitest-agent/sdk`'s `utils/test-location.ts`
+* — the single source of truth for the test-layout rule — and the existing
+* `findTestFiles` walker, rather than re-deriving the shape independently.
 * @internal
 */
 async function isTestShapedPackage(pkgPath, fs = nodeWalkerFs) {
-	if ((await fs.statEntry(join(pkgPath, TEST_DIR)))?.isDirectory === true) return true;
-	return (await findTestFiles(pkgPath, [`${SRC_DIR}/**/${TEST_FILE_GLOB_SUFFIX}`], fs)).length > 0;
+	if ((await findTestFiles(pkgPath, [
+		`${SRC_DIR}/**/${TEST_FILE_GLOB_SUFFIX}`,
+		`${TEST_DIR}/**/${TEST_FILE_GLOB_SUFFIX}`,
+		`**/${BATS_FILE_GLOB_SUFFIX}`
+	], fs)).length > 0) return false;
+	return (await fs.statEntry(join(pkgPath, TEST_DIR)))?.isDirectory === true;
 }
 
 //#endregion

package/utils/vitest-peer-version-mismatch-error.js

@@ -0,0 +1,40 @@
+//#region src/utils/vitest-peer-version-mismatch-error.ts
+/**
+* Builds the message `configureVitest` throws as a {@link ConfigurationError}
+* when the Vitest 5-only `ctx.defineCacheKeyGenerator` field is absent — the
+* reliable signal that the host project's `vitest` peer resolves to a pre-5
+* release (Vitest 4 exposes only the deprecated
+* `experimental_defineCacheKeyGenerator` alias).
+*
+* `@vitest-agent/plugin` 3.x is Vitest-5-only by design: no `experimental_`
+* fallback, no silent degradation. A version mismatch is the user's own
+* environment to fix, which is exactly what `ConfigurationError` means, so
+* this rides that class rather than introducing a parallel one — the catch
+* block in `configureVitest` keeps a single branch.
+*
+* The leading `vitest-agent: ` marker is part of the message because
+* `ConfigurationError` messages are written to stderr verbatim, not prefixed
+* at the write site.
+*
+* @internal
+*/
+function vitestPeerVersionMismatchMessage(detectedVersion) {
+	return `vitest-agent: @vitest-agent/plugin 3.x requires Vitest >= 5. ${detectedVersion !== void 0 ? `Detected Vitest ${detectedVersion}.` : "The installed Vitest version could not be detected."} Install @vitest-agent/plugin 2.x for Vitest 4.`;
+}
+/**
+* Reads a Vitest version string off the `ctx.vitest` instance handed to
+* `configureVitest`, if present and shaped as expected. Degrades to
+* `undefined` rather than throwing — this runs on the path that is already
+* diagnosing a version mismatch, so it must never itself fail on an
+* unexpected shape.
+*
+* @internal
+*/
+function readVitestVersion(vitest) {
+	if (vitest === null || typeof vitest !== "object") return void 0;
+	const version = vitest.version;
+	return typeof version === "string" ? version : void 0;
+}
+
+//#endregion
+export { readVitestVersion, vitestPeerVersionMismatchMessage };