@vitest-agent/cli 2.2.12 → 2.2.14

package/commands/agent.js

@@ -6,9 +6,9 @@ import { recordCommand } from "./record.js";
 import { triageCommand } from "./triage.js";
 import { wrapupCommand } from "./wrapup.js";
 import * as NodeServices from "@effect/platform-node/NodeServices";
-import { classifyTestPath, findOwningWorkspace, resolveProjectKeyFromCwd } from "@vitest-agent/sdk";
+import { classifyTestPath, detectNonDefaultDiscoverStrategy, findOwningWorkspace, resolveProjectKeyFromCwd } from "@vitest-agent/sdk";
 import { Cause, Effect, Option } from "effect";
-import { existsSync } from "node:fs";
+import { existsSync, readFileSync } from "node:fs";
 import { dirname, isAbsolute, join, relative, resolve, sep } from "node:path";
 import { Argument, Command, Flag } from "effect/unstable/cli";
 import { findWorkspaceRootSync, getWorkspacePackagesSync } from "@effected/workspaces";
@@ -182,11 +182,56 @@ function crossesNestedPackageBoundary(ownerPath, filePath) {
 	}
 	return false;
 }
+/**
+* Candidate Vitest/Vite config filenames at a workspace root, in the order
+* Vitest itself would prefer them. `vite.config.*` is a fallback for a
+* workspace that configures the plugin through Vite directly rather than a
+* dedicated `vitest.config.*`.
+* @internal
+*/
+const VITEST_CONFIG_CANDIDATES = [
+	"vitest.config.ts",
+	"vitest.config.mts",
+	"vitest.config.js",
+	"vitest.config.mjs",
+	"vitest.workspace.ts",
+	"vitest.workspace.mts",
+	"vitest.workspace.js",
+	"vitest.workspace.mjs",
+	"vite.config.ts",
+	"vite.config.mts",
+	"vite.config.js",
+	"vite.config.mjs"
+];
+/**
+* Reads the first Vitest/Vite config file found at `root`, returning its
+* source text, or `null` when none of {@link VITEST_CONFIG_CANDIDATES} exists
+* or the file that does exist cannot be read.
+*
+* A `null` result is deliberately indistinguishable between "no config file"
+* and "unreadable config file" — both mean the caller cannot rule out a
+* non-default `DiscoverStrategy` and must fail open (issue #230).
+* @internal
+*/
+function readWorkspaceVitestConfigSource(root) {
+	for (const candidate of VITEST_CONFIG_CANDIDATES) {
+		const candidatePath = join(root, candidate);
+		if (!existsSync(candidatePath)) continue;
+		try {
+			return readFileSync(candidatePath, "utf8");
+		} catch {
+			return null;
+		}
+	}
+	return null;
+}
 const checkTestPathSubcommand = Command.make("check-test-path", { path: testPathArg }, (opts) => Effect.sync(() => {
 	const from = process.env.VITEST_AGENT_PROJECT_DIR ?? process.cwd();
 	const absolute = isAbsolute(opts.path) ? opts.path : resolve(from, opts.path);
 	const root = findWorkspaceRootSync(from, nodeSyncOps);
 	if (root === null) process.exit(1);
+	const configSource = readWorkspaceVitestConfigSource(root);
+	if (configSource === null || detectNonDefaultDiscoverStrategy(configSource)) process.exit(1);
 	const packages = getWorkspacePackagesSync(root, nodeSyncOps);
 	const owner = findOwningWorkspace(packages, absolute);
 	if (owner === null) process.exit(1);

package/commands/record.js

@@ -1,5 +1,5 @@
 import { recordSessionEnd, recordSessionStart } from "../lib/record-session.js";
-import { recordTddArtifactEffect } from "../lib/record-tdd-artifact.js";
+import { dispatchRecordTddArtifactEffect } from "../lib/record-tdd-artifact.js";
 import { recordTurnEffect } from "../lib/record-turn.js";
 import { recordRunWorkspaceChangesEffect } from "../lib/record-workspace-changes.js";
 import { DataReader, DataStore } from "@vitest-agent/sdk";
@@ -85,8 +85,12 @@ const testRunIdOpt = Flag.optional(Flag.integer("test-run-id"));
 const testFirstFailureRunIdOpt = Flag.optional(Flag.integer("test-first-failure-run-id"));
 const diffExcerptOpt = Flag.optional(Flag.string("diff-excerpt"));
 const recordedAtOpt = Flag.string("recorded-at").pipe(Flag.withDefault((/* @__PURE__ */ new Date()).toISOString()));
+const chatIdOptional = Flag.optional(Flag.string("chat-id")).pipe(Flag.withDescription("Host chat id; omit when --tdd-task-id is supplied instead"));
+const tddTaskIdOpt = Flag.optional(Flag.integer("tdd-task-id")).pipe(Flag.withDescription("Explicit TDD task id escape hatch (issue #144): bypasses chat-id -> session -> task resolution entirely"));
+const suiteOpt = Flag.choice("suite", ["vitest", "bats"]).pipe(Flag.withDefault("vitest"), Flag.withDescription("Explicit test-runner marker (issue #363): 'vitest' (default) or 'bats'. Distinguishes a bats run-level artifact (no test_case_id) from a vitest one for the D2 phase-transition validator."));
 const tddArtifactSubcommand = Command.make("tdd-artifact", {
-	chatId,
+	chatId: chatIdOptional,
+	tddTaskId: tddTaskIdOpt,
 	project: projectOptional,
 	cwd: cwdOptional,
 	artifactKind: artifactKindOpt,
@@ -95,12 +99,14 @@ const tddArtifactSubcommand = Command.make("tdd-artifact", {
 	testRunId: testRunIdOpt,
 	testFirstFailureRunId: testFirstFailureRunIdOpt,
 	diffExcerpt: diffExcerptOpt,
-	recordedAt: recordedAtOpt
+	recordedAt: recordedAtOpt,
+	suite: suiteOpt
 }, (opts) => Effect.gen(function* () {
 	let fileId;
 	if (opts.filePath._tag === "Some") fileId = yield* (yield* DataStore).ensureFile(opts.filePath.value);
-	return yield* recordTddArtifactEffect({
-		chatId: opts.chatId,
+	return yield* dispatchRecordTddArtifactEffect({
+		...opts.chatId._tag === "Some" && { chatId: opts.chatId.value },
+		...opts.tddTaskId._tag === "Some" && { tddTaskId: opts.tddTaskId.value },
 		...opts.project._tag === "Some" && { project: opts.project.value },
 		...opts.cwd._tag === "Some" && { cwd: opts.cwd.value },
 		artifactKind: opts.artifactKind,
@@ -109,7 +115,8 @@ const tddArtifactSubcommand = Command.make("tdd-artifact", {
 		...opts.testRunId._tag === "Some" && { testRunId: opts.testRunId.value },
 		...opts.testFirstFailureRunId._tag === "Some" && { testFirstFailureRunId: opts.testFirstFailureRunId.value },
 		...opts.diffExcerpt._tag === "Some" && { diffExcerpt: opts.diffExcerpt.value },
-		recordedAt: opts.recordedAt
+		recordedAt: opts.recordedAt,
+		suite: opts.suite
 	});
 }).pipe(Effect.flatMap((result) => Effect.sync(() => process.stdout.write(`${JSON.stringify(result)}\n`))), Effect.catch((err) => Effect.sync(() => {
 	process.stderr.write(`record tdd-artifact: ${err instanceof Error ? err.message : String(err)}\n`);

package/index.js

@@ -11,7 +11,7 @@ import { DATA_DB_FILENAME, REGISTRY_DB_FILENAME, SESSIONS_DB_FILENAME, resolvePr
 *
 * @public
 */
-const CURRENT_CLI_VERSION = "2.2.12";
+const CURRENT_CLI_VERSION = "2.2.14";
 
 //#endregion
 export { CURRENT_CLI_VERSION, CliLive, DATA_DB_FILENAME, REGISTRY_DB_FILENAME, SESSIONS_DB_FILENAME, SidecarLive, registerAgentEffect, resolveProjectDataDir, resolveRegistryDir, resolveSessionMapPath };

package/lib/internal-register-agent.js

@@ -39,10 +39,15 @@ const registerAgentEffect = (input) => Effect.gen(function* () {
 			agentKind: input.parentAgentId === void 0 ? "main" : "subagent",
 			agentType: input.agentType,
 			triageWasNonEmpty: false,
-			startedAt: (/* @__PURE__ */ new Date()).toISOString()
+			startedAt: (/* @__PURE__ */ new Date()).toISOString(),
+			conversationId
 		}),
 		onSome: (s) => Effect.succeed(s.id)
 	});
+	yield* store.setSessionConversationIdIfNull({
+		sessionId: sessionRowId,
+		conversationId
+	});
 	const agentContext = yield* ctx.captureAgentContext(input.cwd);
 	const clientNonce = input.clientNonce ?? deriveDefaultClientNonce(input);
 	const idempotencyKey = deriveIdempotencyKey({

package/lib/record-tdd-artifact.js

@@ -3,20 +3,18 @@ import { DataReader, DataStore } from "@vitest-agent/sdk";
 import { Effect, Option } from "effect";
 
 //#region src/lib/record-tdd-artifact.ts
-const recordTddArtifactEffect = (input) => Effect.gen(function* () {
+/**
+* Resolve (auto-opening a `spike` phase if needed) the current open
+* phase for `tddTaskId`, then write the artifact under it. Shared by
+* both `recordTddArtifactEffect` (chat-id → session → task resolution)
+* and `recordTddArtifactByTaskIdEffect` (explicit task-id escape hatch).
+*/
+const writeArtifactUnderOpenPhase = (tddTaskId, input) => Effect.gen(function* () {
 	const reader = yield* DataReader;
 	const store = yield* DataStore;
-	const session = yield* resolveSessionForRecording({
-		chatId: input.chatId,
-		recordedAt: input.recordedAt,
-		...input.project !== void 0 && { project: input.project },
-		...input.cwd !== void 0 && { cwd: input.cwd }
-	});
-	const openTdd = (yield* reader.listTddTasksForSession(session.id, { walkParents: true })).find((t) => t.endedAt === null);
-	if (openTdd === void 0) return yield* Effect.fail(/* @__PURE__ */ new Error(`No open TDD task under chat_id ${input.chatId}. Call tdd_task start first.`));
-	const phaseOpt = yield* reader.getCurrentTddPhase(openTdd.id);
+	const phaseOpt = yield* reader.getCurrentTddPhase(tddTaskId);
 	const phaseId = Option.isSome(phaseOpt) ? phaseOpt.value.id : (yield* store.writeTddPhase({
-		tddTaskId: openTdd.id,
+		tddTaskId,
 		phase: "spike",
 		startedAt: input.recordedAt,
 		transitionReason: "auto-opened by record tdd-artifact (no prior phase)"
@@ -30,11 +28,77 @@ const recordTddArtifactEffect = (input) => Effect.gen(function* () {
 			...input.testRunId !== void 0 && { testRunId: input.testRunId },
 			...input.testFirstFailureRunId !== void 0 && { testFirstFailureRunId: input.testFirstFailureRunId },
 			...input.diffExcerpt !== void 0 && { diffExcerpt: input.diffExcerpt },
+			...input.suite !== void 0 && { suite: input.suite },
 			recordedAt: input.recordedAt
 		}),
 		phaseId
 	};
 });
+const recordTddArtifactEffect = (input) => Effect.gen(function* () {
+	const reader = yield* DataReader;
+	const session = yield* resolveSessionForRecording({
+		chatId: input.chatId,
+		recordedAt: input.recordedAt,
+		...input.project !== void 0 && { project: input.project },
+		...input.cwd !== void 0 && { cwd: input.cwd }
+	});
+	const openTdd = (yield* reader.listTddTasksForSession(session.id, {
+		walkParents: true,
+		walkConversation: true
+	})).find((t) => t.endedAt === null);
+	if (openTdd === void 0) return yield* Effect.fail(/* @__PURE__ */ new Error(`No open TDD task under chat_id ${input.chatId}. Call tdd_task start first.`));
+	return yield* writeArtifactUnderOpenPhase(openTdd.id, input);
+});
+/**
+* Explicit task-id escape hatch (issue #144). Bypasses `chat_id` →
+* session → task resolution entirely — the caller already knows which
+* TDD task the artifact belongs to (e.g. a hook seeded with
+* `VITEST_AGENT_TDD_TASK_ID` in a detached-session environment where
+* neither the parent walk nor the conversation-id fallback resolves
+* the right task). Fails loudly when the task does not exist or has
+* already ended — writing to a closed task's phase would silently
+* corrupt the evidence trail.
+*/
+const recordTddArtifactByTaskIdEffect = (input) => Effect.gen(function* () {
+	const taskOpt = yield* (yield* DataReader).getTddTaskById(input.tddTaskId);
+	if (Option.isNone(taskOpt)) return yield* Effect.fail(/* @__PURE__ */ new Error(`No TDD task found for id ${input.tddTaskId}.`));
+	if (taskOpt.value.endedAt !== null) return yield* Effect.fail(/* @__PURE__ */ new Error(`TDD task ${input.tddTaskId} has already ended (endedAt=${taskOpt.value.endedAt}).`));
+	return yield* writeArtifactUnderOpenPhase(input.tddTaskId, input);
+});
+/**
+* CLI-command-facing dispatcher (issue #144). Keeps `commands/record.ts`
+* a thin flag-parsing wrapper per this package's convention. `tddTaskId`
+* takes priority when both are supplied — it is the explicit escape
+* hatch and should never silently fall back to (weaker) session
+* resolution.
+*/
+const dispatchRecordTddArtifactEffect = (input) => {
+	if (input.tddTaskId !== void 0) return recordTddArtifactByTaskIdEffect({
+		tddTaskId: input.tddTaskId,
+		artifactKind: input.artifactKind,
+		...input.fileId !== void 0 && { fileId: input.fileId },
+		...input.testCaseId !== void 0 && { testCaseId: input.testCaseId },
+		...input.testRunId !== void 0 && { testRunId: input.testRunId },
+		...input.testFirstFailureRunId !== void 0 && { testFirstFailureRunId: input.testFirstFailureRunId },
+		...input.diffExcerpt !== void 0 && { diffExcerpt: input.diffExcerpt },
+		...input.suite !== void 0 && { suite: input.suite },
+		recordedAt: input.recordedAt
+	});
+	if (input.chatId !== void 0) return recordTddArtifactEffect({
+		chatId: input.chatId,
+		artifactKind: input.artifactKind,
+		...input.fileId !== void 0 && { fileId: input.fileId },
+		...input.testCaseId !== void 0 && { testCaseId: input.testCaseId },
+		...input.testRunId !== void 0 && { testRunId: input.testRunId },
+		...input.testFirstFailureRunId !== void 0 && { testFirstFailureRunId: input.testFirstFailureRunId },
+		...input.diffExcerpt !== void 0 && { diffExcerpt: input.diffExcerpt },
+		...input.suite !== void 0 && { suite: input.suite },
+		recordedAt: input.recordedAt,
+		...input.cwd !== void 0 && { cwd: input.cwd },
+		...input.project !== void 0 && { project: input.project }
+	});
+	return Effect.fail(/* @__PURE__ */ new Error("record tdd-artifact requires either --chat-id or --tdd-task-id."));
+};
 
 //#endregion
-export { recordTddArtifactEffect };
+export { dispatchRecordTddArtifactEffect, recordTddArtifactByTaskIdEffect, recordTddArtifactEffect };

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@vitest-agent/cli",
-	"version": "2.2.12",
+	"version": "2.2.14",
 	"private": false,
 	"description": "On-demand CLI for vitest-agent. Reads cached test data and reports status, overview, coverage, history, trends, and cache health.",
 	"keywords": [
@@ -40,9 +40,9 @@
 	"dependencies": {
 		"@effect/platform-node": "4.0.0-rc.109",
 		"@effect/sql-sqlite-node": "4.0.0-rc.109",
-		"@effected/workspaces": "^0.18.3",
-		"@vitest-agent/sdk": "2.4.12",
-		"@vitest-agent/sidecar": "2.1.12",
+		"@effected/workspaces": "^0.19.0",
+		"@vitest-agent/sdk": "2.5.0",
+		"@vitest-agent/sidecar": "2.1.14",
 		"effect": "4.0.0-rc.109"
 	},
 	"engines": {