@vitejs/plugin-legacy 3.0.1 → 4.0.0

package/README.md

@@ -8,7 +8,7 @@ By default, this plugin will:
 
 - Generate a polyfill chunk including SystemJS runtime, and any necessary polyfills determined by specified browser targets and **actual usage** in the bundle.
 
-- Inject `<script nomodule>` tags into generated HTML to conditionally load the polyfills and legacy bundle only in browsers without native ESM support.
+- Inject `<script nomodule>` tags into generated HTML to conditionally load the polyfills and legacy bundle only in browsers without widely-available features support.
 
 - Inject the `import.meta.env.LEGACY` env variable, which will only be `true` in the legacy production build, and `false` in all other cases.
 
@@ -38,11 +38,11 @@ npm add -D terser
 ### `targets`
 
 - **Type:** `string | string[] | { [key: string]: string }`
-- **Default:** `'defaults'`
+- **Default:** [`'last 2 versions and not dead, > 0.3%, Firefox ESR'`](https://browsersl.ist/#q=last+2+versions+and+not+dead%2C+%3E+0.3%25%2C+Firefox+ESR)
 
   If explicitly set, it's passed on to [`@babel/preset-env`](https://babeljs.io/docs/en/babel-preset-env#targets).
 
-  The query is also [Browserslist compatible](https://github.com/browserslist/browserslist). The default value, `'defaults'`, is what is recommended by Browserslist. See [Browserslist Best Practices](https://github.com/browserslist/browserslist#best-practices) for more details.
+  The query is also [Browserslist compatible](https://github.com/browserslist/browserslist). See [Browserslist Best Practices](https://github.com/browserslist/browserslist#best-practices) for more details.
 
 ### `polyfills`
 
@@ -117,12 +117,18 @@ npm add -D terser
 
   Defaults to `false`. Enabling this option will exclude `systemjs/dist/s.min.js` inside polyfills-legacy chunk.
 
-## Dynamic Import
+## Browsers that supports ESM but does not support widely-available features
 
-The legacy plugin offers a way to use native `import()` in the modern build while falling back to the legacy build in browsers with native ESM but without dynamic import support (e.g. Legacy Edge). This feature works by injecting a runtime check and loading the legacy bundle with SystemJs runtime if needed. There are the following drawbacks:
+The legacy plugin offers a way to use widely-available features natively in the modern build, while falling back to the legacy build in browsers with native ESM but without those features supported (e.g. Legacy Edge). This feature works by injecting a runtime check and loading the legacy bundle with SystemJs runtime if needed. There are the following drawbacks:
 
 - Modern bundle is downloaded in all ESM browsers
-- Modern bundle throws `SyntaxError` in browsers without dynamic import
+- Modern bundle throws `SyntaxError` in browsers without those features support
+
+The following syntax are considered as widely-available:
+
+- dynamic import
+- `import.meta`
+- async generator
 
 ## Polyfill Specifiers
 

package/dist/index.cjs

@@ -9,8 +9,13 @@ const node_url = require('node:url');
 const vite = require('vite');
 const MagicString = require('magic-string');
 const require$$0 = require('tty');
+const browserslist = require('browserslist');
 
-var picocolors = {exports: {}};
+var picocolorsExports = {};
+var picocolors = {
+  get exports(){ return picocolorsExports; },
+  set exports(v){ picocolorsExports = v; },
+};
 
 let tty = require$$0;
 
@@ -69,12 +74,22 @@ let createColors = (enabled = isColorSupported) => ({
 });
 
 picocolors.exports = createColors();
-picocolors.exports.createColors = createColors;
+picocolorsExports.createColors = createColors;
+
+const safari10NoModuleFix = `!function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",(function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()}),!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();`;
+const legacyPolyfillId = "vite-legacy-polyfill";
+const legacyEntryId = "vite-legacy-entry";
+const systemJSInlineCode = `System.import(document.getElementById('${legacyEntryId}').getAttribute('data-src'))`;
+const detectModernBrowserVarName = "__vite_is_modern_browser";
+const detectModernBrowserDetector = 'import.meta.url;import("_").catch(()=>1);async function* g(){};';
+const detectModernBrowserCode = `${detectModernBrowserDetector}window.${detectModernBrowserVarName}=true;`;
+const dynamicFallbackInlineCode = `!function(){if(window.${detectModernBrowserVarName})return;console.warn("vite: loading legacy chunks, syntax error above and the same error below should be ignored");var e=document.getElementById("${legacyPolyfillId}"),n=document.createElement("script");n.src=e.src,n.onload=function(){${systemJSInlineCode}},document.body.appendChild(n)}();`;
+const modernChunkLegacyGuard = `export function __vite_legacy_guard(){${detectModernBrowserDetector}};`;
 
 let babel;
 async function loadBabel() {
   if (!babel) {
-    babel = await import('@babel/standalone');
+    babel = await import('@babel/core');
   }
   return babel;
 }
@@ -125,21 +140,12 @@ function toAssetPathFromHtml(filename, htmlPath, config) {
     toRelative
   );
 }
-const safari10NoModuleFix = `!function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",(function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()}),!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();`;
-const legacyPolyfillId = "vite-legacy-polyfill";
-const legacyEntryId = "vite-legacy-entry";
-const systemJSInlineCode = `System.import(document.getElementById('${legacyEntryId}').getAttribute('data-src'))`;
-const detectModernBrowserVarName = "__vite_is_modern_browser";
-const detectModernBrowserCode = `try{import.meta.url;import("_").catch(()=>1);}catch(e){}window.${detectModernBrowserVarName}=true;`;
-const dynamicFallbackInlineCode = `!function(){if(window.${detectModernBrowserVarName})return;console.warn("vite: loading legacy build because dynamic import or import.meta.url is unsupported, syntax error above should be ignored");var e=document.getElementById("${legacyPolyfillId}"),n=document.createElement("script");n.src=e.src,n.onload=function(){${systemJSInlineCode}},document.body.appendChild(n)}();`;
-const forceDynamicImportUsage = `export function __vite_legacy_guard(){import('data:text/javascript,')};`;
 const legacyEnvVarMarker = `__VITE_IS_LEGACY__`;
 const _require = node_module.createRequire((typeof document === 'undefined' ? new (require('u' + 'rl').URL)('file:' + __filename).href : (document.currentScript && document.currentScript.src || new URL('index.cjs', document.baseURI).href)));
 function viteLegacyPlugin(options = {}) {
   let config;
-  const targets = options.targets || "defaults";
+  let targets;
   const genLegacy = options.renderLegacyChunks !== false;
-  const genDynamicFallback = genLegacy;
   const debugFlags = (process.env.DEBUG || "").split(",");
   const isDebug = debugFlags.includes("vite:*") || debugFlags.includes("vite:legacy");
   const facadeToLegacyChunkMap = /* @__PURE__ */ new Map();
@@ -188,7 +194,7 @@ function viteLegacyPlugin(options = {}) {
             "edge79",
             "firefox67",
             "chrome64",
-            "safari11.1"
+            "safari12"
           ];
         }
       }
@@ -201,7 +207,7 @@ function viteLegacyPlugin(options = {}) {
     configResolved(config2) {
       if (overriddenBuildTarget) {
         config2.logger.warn(
-          picocolors.exports.yellow(
+          picocolorsExports.yellow(
             `plugin-legacy overrode 'build.target'. You should pass 'targets' as an option to this plugin with the list of legacy browsers to support instead.`
           )
         );
@@ -238,7 +244,7 @@ function viteLegacyPlugin(options = {}) {
       if (!genLegacy) {
         return;
       }
-      if (legacyPolyfills.size || genDynamicFallback) {
+      if (legacyPolyfills.size) {
         await detectPolyfills(
           `Promise.resolve(); Promise.all();`,
           targets,
@@ -253,6 +259,8 @@ function viteLegacyPlugin(options = {}) {
           legacyPolyfills,
           bundle,
           facadeToLegacyPolyfillMap,
+          // force using terser for legacy polyfill minification, since esbuild
+          // isn't legacy-safe
           config.build,
           "iife",
           opts,
@@ -273,6 +281,8 @@ function viteLegacyPlugin(options = {}) {
       if (!genLegacy || config.build.ssr) {
         return;
       }
+      targets = options.targets || browserslist.loadConfig({ path: config.root }) || "last 2 versions and not dead, > 0.3%, Firefox ESR";
+      isDebug && console.log(`[@vitejs/plugin-legacy] targets:`, targets);
       const getLegacyOutputFileName = (fileNames, defaultFileName = "[name]-legacy-[hash].js") => {
         if (!fileNames) {
           return path.posix.join(config.build.assetsDir, defaultFileName);
@@ -312,8 +322,8 @@ function viteLegacyPlugin(options = {}) {
           await detectPolyfills(raw, { esmodules: true }, modernPolyfills);
         }
         const ms = new MagicString(raw);
-        if (genDynamicFallback && chunk.isEntry) {
-          ms.prepend(forceDynamicImportUsage);
+        if (genLegacy && chunk.isEntry) {
+          ms.prepend(modernChunkLegacyGuard);
         }
         if (raw.includes(legacyEnvVarMarker)) {
           const re = new RegExp(legacyEnvVarMarker, "g");
@@ -345,13 +355,16 @@ function viteLegacyPlugin(options = {}) {
       const needPolyfills = options.polyfills !== false && !Array.isArray(options.polyfills);
       const sourceMaps = !!config.build.sourcemap;
       const babel2 = await loadBabel();
-      const { code, map } = babel2.transform(raw, {
+      const result = babel2.transform(raw, {
         babelrc: false,
         configFile: false,
         compact: !!config.build.minify,
         sourceMaps,
         inputSourceMap: void 0,
+        // sourceMaps ? chunk.map : undefined, `.map` TODO: moved to OutputChunk?
         presets: [
+          // forcing our plugin to run before preset-env by wrapping it in a
+          // preset so we can catch the injected import statements...
           [
             () => ({
               plugins: [
@@ -362,7 +375,7 @@ function viteLegacyPlugin(options = {}) {
             })
           ],
           [
-            "env",
+            "@babel/preset-env",
             createBabelPresetEnvOptions(targets, {
               needPolyfills,
               ignoreBrowserslistConfig: options.ignoreBrowserslistConfig
@@ -370,8 +383,8 @@ function viteLegacyPlugin(options = {}) {
           ]
         ]
       });
-      if (code)
-        return { code, map };
+      if (result)
+        return { code: result.code, map: result.map };
       return null;
     },
     transformIndexHtml(html, { chunk }) {
@@ -447,6 +460,9 @@ function viteLegacyPlugin(options = {}) {
           attrs: {
             nomodule: true,
             crossorigin: true,
+            // we set the entry path on the element as an attribute so that the
+            // script content will stay consistent - which allows using a constant
+            // hash value for CSP.
             id: legacyEntryId,
             "data-src": toAssetPathFromHtml(
               legacyEntryFilename,
@@ -462,7 +478,7 @@ function viteLegacyPlugin(options = {}) {
           `No corresponding legacy entry chunk found for ${htmlFilename}`
         );
       }
-      if (genDynamicFallback && legacyPolyfillFilename && legacyEntryFilename) {
+      if (genLegacy && legacyPolyfillFilename && legacyEntryFilename) {
         tags.push({
           tag: "script",
           attrs: { type: "module" },
@@ -487,7 +503,7 @@ function viteLegacyPlugin(options = {}) {
       }
       if (isLegacyBundle(bundle, opts)) {
         for (const name in bundle) {
-          if (bundle[name].type === "asset") {
+          if (bundle[name].type === "asset" && !/.+\.map$/.test(name)) {
             delete bundle[name];
           }
         }
@@ -498,20 +514,20 @@ function viteLegacyPlugin(options = {}) {
 }
 async function detectPolyfills(code, targets, list) {
   const babel2 = await loadBabel();
-  const { ast } = babel2.transform(code, {
+  const result = babel2.transform(code, {
     ast: true,
     babelrc: false,
     configFile: false,
     presets: [
       [
-        "env",
+        "@babel/preset-env",
         createBabelPresetEnvOptions(targets, {
           ignoreBrowserslistConfig: true
         })
       ]
     ]
   });
-  for (const node of ast.program.body) {
+  for (const node of result.ast.program.body) {
     if (node.type === "ImportDeclaration") {
       const source = node.source.value;
       if (source.startsWith("core-js/") || source.startsWith("regenerator-runtime/")) {
@@ -543,6 +559,7 @@ async function buildPolyfillChunk(mode, imports, bundle, facadeToChunkMap, build
   minify = minify ? "terser" : false;
   const res = await vite.build({
     mode,
+    // so that everything is resolved from here
     root: path.dirname(node_url.fileURLToPath((typeof document === 'undefined' ? new (require('u' + 'rl').URL)('file:' + __filename).href : (document.currentScript && document.currentScript.src || new URL('index.cjs', document.baseURI).href)))),
     configFile: false,
     logLevel: "error",
@@ -561,9 +578,15 @@ async function buildPolyfillChunk(mode, imports, bundle, facadeToChunkMap, build
         }
       }
     },
+    // Don't run esbuild for transpilation or minification
+    // because we don't want to transpile code.
     esbuild: false,
     optimizeDeps: {
       esbuildOptions: {
+        // If a value above 'es5' is set, esbuild injects helper functions which uses es2015 features.
+        // This limits the input code not to include es2015+ codes.
+        // But core-js is the only dependency which includes commonjs code
+        // and core-js doesn't include es2015+ codes.
         target: "es5"
       }
     }
@@ -613,7 +636,7 @@ function recordAndRemovePolyfillBabelPlugin(polyfills) {
     name: "vite-remove-polyfill-import",
     post({ path: path2 }) {
       path2.get("body").forEach((p) => {
-        if (t.isImportDeclaration(p)) {
+        if (t.isImportDeclaration(p.node)) {
           polyfills.add(p.node.source.value);
           p.remove();
         }
@@ -648,11 +671,11 @@ function wrapIIFEBabelPlugin() {
   };
 }
 const cspHashes = [
-  node_crypto.createHash("sha256").update(safari10NoModuleFix).digest("base64"),
-  node_crypto.createHash("sha256").update(systemJSInlineCode).digest("base64"),
-  node_crypto.createHash("sha256").update(detectModernBrowserCode).digest("base64"),
-  node_crypto.createHash("sha256").update(dynamicFallbackInlineCode).digest("base64")
-];
+  safari10NoModuleFix,
+  systemJSInlineCode,
+  detectModernBrowserCode,
+  dynamicFallbackInlineCode
+].map((i) => node_crypto.createHash("sha256").update(i).digest("base64"));
 
 module.exports = viteLegacyPlugin;
 module.exports.cspHashes = cspHashes;

package/dist/index.mjs

@@ -5,8 +5,13 @@ import { fileURLToPath } from 'node:url';
 import { build, normalizePath } from 'vite';
 import MagicString from 'magic-string';
 import require$$0 from 'tty';
+import { loadConfig } from 'browserslist';
 
-var picocolors = {exports: {}};
+var picocolorsExports = {};
+var picocolors = {
+  get exports(){ return picocolorsExports; },
+  set exports(v){ picocolorsExports = v; },
+};
 
 let tty = require$$0;
 
@@ -65,12 +70,22 @@ let createColors = (enabled = isColorSupported) => ({
 });
 
 picocolors.exports = createColors();
-picocolors.exports.createColors = createColors;
+picocolorsExports.createColors = createColors;
+
+const safari10NoModuleFix = `!function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",(function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()}),!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();`;
+const legacyPolyfillId = "vite-legacy-polyfill";
+const legacyEntryId = "vite-legacy-entry";
+const systemJSInlineCode = `System.import(document.getElementById('${legacyEntryId}').getAttribute('data-src'))`;
+const detectModernBrowserVarName = "__vite_is_modern_browser";
+const detectModernBrowserDetector = 'import.meta.url;import("_").catch(()=>1);async function* g(){};';
+const detectModernBrowserCode = `${detectModernBrowserDetector}window.${detectModernBrowserVarName}=true;`;
+const dynamicFallbackInlineCode = `!function(){if(window.${detectModernBrowserVarName})return;console.warn("vite: loading legacy chunks, syntax error above and the same error below should be ignored");var e=document.getElementById("${legacyPolyfillId}"),n=document.createElement("script");n.src=e.src,n.onload=function(){${systemJSInlineCode}},document.body.appendChild(n)}();`;
+const modernChunkLegacyGuard = `export function __vite_legacy_guard(){${detectModernBrowserDetector}};`;
 
 let babel;
 async function loadBabel() {
   if (!babel) {
-    babel = await import('@babel/standalone');
+    babel = await import('@babel/core');
   }
   return babel;
 }
@@ -121,21 +136,12 @@ function toAssetPathFromHtml(filename, htmlPath, config) {
     toRelative
   );
 }
-const safari10NoModuleFix = `!function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",(function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()}),!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();`;
-const legacyPolyfillId = "vite-legacy-polyfill";
-const legacyEntryId = "vite-legacy-entry";
-const systemJSInlineCode = `System.import(document.getElementById('${legacyEntryId}').getAttribute('data-src'))`;
-const detectModernBrowserVarName = "__vite_is_modern_browser";
-const detectModernBrowserCode = `try{import.meta.url;import("_").catch(()=>1);}catch(e){}window.${detectModernBrowserVarName}=true;`;
-const dynamicFallbackInlineCode = `!function(){if(window.${detectModernBrowserVarName})return;console.warn("vite: loading legacy build because dynamic import or import.meta.url is unsupported, syntax error above should be ignored");var e=document.getElementById("${legacyPolyfillId}"),n=document.createElement("script");n.src=e.src,n.onload=function(){${systemJSInlineCode}},document.body.appendChild(n)}();`;
-const forceDynamicImportUsage = `export function __vite_legacy_guard(){import('data:text/javascript,')};`;
 const legacyEnvVarMarker = `__VITE_IS_LEGACY__`;
 const _require = createRequire(import.meta.url);
 function viteLegacyPlugin(options = {}) {
   let config;
-  const targets = options.targets || "defaults";
+  let targets;
   const genLegacy = options.renderLegacyChunks !== false;
-  const genDynamicFallback = genLegacy;
   const debugFlags = (process.env.DEBUG || "").split(",");
   const isDebug = debugFlags.includes("vite:*") || debugFlags.includes("vite:legacy");
   const facadeToLegacyChunkMap = /* @__PURE__ */ new Map();
@@ -184,7 +190,7 @@ function viteLegacyPlugin(options = {}) {
             "edge79",
             "firefox67",
             "chrome64",
-            "safari11.1"
+            "safari12"
           ];
         }
       }
@@ -197,7 +203,7 @@ function viteLegacyPlugin(options = {}) {
     configResolved(config2) {
       if (overriddenBuildTarget) {
         config2.logger.warn(
-          picocolors.exports.yellow(
+          picocolorsExports.yellow(
             `plugin-legacy overrode 'build.target'. You should pass 'targets' as an option to this plugin with the list of legacy browsers to support instead.`
           )
         );
@@ -234,7 +240,7 @@ function viteLegacyPlugin(options = {}) {
       if (!genLegacy) {
         return;
       }
-      if (legacyPolyfills.size || genDynamicFallback) {
+      if (legacyPolyfills.size) {
         await detectPolyfills(
           `Promise.resolve(); Promise.all();`,
           targets,
@@ -249,6 +255,8 @@ function viteLegacyPlugin(options = {}) {
           legacyPolyfills,
           bundle,
           facadeToLegacyPolyfillMap,
+          // force using terser for legacy polyfill minification, since esbuild
+          // isn't legacy-safe
           config.build,
           "iife",
           opts,
@@ -269,6 +277,8 @@ function viteLegacyPlugin(options = {}) {
       if (!genLegacy || config.build.ssr) {
         return;
       }
+      targets = options.targets || loadConfig({ path: config.root }) || "last 2 versions and not dead, > 0.3%, Firefox ESR";
+      isDebug && console.log(`[@vitejs/plugin-legacy] targets:`, targets);
       const getLegacyOutputFileName = (fileNames, defaultFileName = "[name]-legacy-[hash].js") => {
         if (!fileNames) {
           return path.posix.join(config.build.assetsDir, defaultFileName);
@@ -308,8 +318,8 @@ function viteLegacyPlugin(options = {}) {
           await detectPolyfills(raw, { esmodules: true }, modernPolyfills);
         }
         const ms = new MagicString(raw);
-        if (genDynamicFallback && chunk.isEntry) {
-          ms.prepend(forceDynamicImportUsage);
+        if (genLegacy && chunk.isEntry) {
+          ms.prepend(modernChunkLegacyGuard);
         }
         if (raw.includes(legacyEnvVarMarker)) {
           const re = new RegExp(legacyEnvVarMarker, "g");
@@ -341,13 +351,16 @@ function viteLegacyPlugin(options = {}) {
       const needPolyfills = options.polyfills !== false && !Array.isArray(options.polyfills);
       const sourceMaps = !!config.build.sourcemap;
       const babel2 = await loadBabel();
-      const { code, map } = babel2.transform(raw, {
+      const result = babel2.transform(raw, {
         babelrc: false,
         configFile: false,
         compact: !!config.build.minify,
         sourceMaps,
         inputSourceMap: void 0,
+        // sourceMaps ? chunk.map : undefined, `.map` TODO: moved to OutputChunk?
         presets: [
+          // forcing our plugin to run before preset-env by wrapping it in a
+          // preset so we can catch the injected import statements...
           [
             () => ({
               plugins: [
@@ -358,7 +371,7 @@ function viteLegacyPlugin(options = {}) {
             })
           ],
           [
-            "env",
+            "@babel/preset-env",
             createBabelPresetEnvOptions(targets, {
               needPolyfills,
               ignoreBrowserslistConfig: options.ignoreBrowserslistConfig
@@ -366,8 +379,8 @@ function viteLegacyPlugin(options = {}) {
           ]
         ]
       });
-      if (code)
-        return { code, map };
+      if (result)
+        return { code: result.code, map: result.map };
       return null;
     },
     transformIndexHtml(html, { chunk }) {
@@ -443,6 +456,9 @@ function viteLegacyPlugin(options = {}) {
           attrs: {
             nomodule: true,
             crossorigin: true,
+            // we set the entry path on the element as an attribute so that the
+            // script content will stay consistent - which allows using a constant
+            // hash value for CSP.
             id: legacyEntryId,
             "data-src": toAssetPathFromHtml(
               legacyEntryFilename,
@@ -458,7 +474,7 @@ function viteLegacyPlugin(options = {}) {
           `No corresponding legacy entry chunk found for ${htmlFilename}`
         );
       }
-      if (genDynamicFallback && legacyPolyfillFilename && legacyEntryFilename) {
+      if (genLegacy && legacyPolyfillFilename && legacyEntryFilename) {
         tags.push({
           tag: "script",
           attrs: { type: "module" },
@@ -483,7 +499,7 @@ function viteLegacyPlugin(options = {}) {
       }
       if (isLegacyBundle(bundle, opts)) {
         for (const name in bundle) {
-          if (bundle[name].type === "asset") {
+          if (bundle[name].type === "asset" && !/.+\.map$/.test(name)) {
             delete bundle[name];
           }
         }
@@ -494,20 +510,20 @@ function viteLegacyPlugin(options = {}) {
 }
 async function detectPolyfills(code, targets, list) {
   const babel2 = await loadBabel();
-  const { ast } = babel2.transform(code, {
+  const result = babel2.transform(code, {
     ast: true,
     babelrc: false,
     configFile: false,
     presets: [
       [
-        "env",
+        "@babel/preset-env",
         createBabelPresetEnvOptions(targets, {
           ignoreBrowserslistConfig: true
         })
       ]
     ]
   });
-  for (const node of ast.program.body) {
+  for (const node of result.ast.program.body) {
     if (node.type === "ImportDeclaration") {
       const source = node.source.value;
       if (source.startsWith("core-js/") || source.startsWith("regenerator-runtime/")) {
@@ -539,6 +555,7 @@ async function buildPolyfillChunk(mode, imports, bundle, facadeToChunkMap, build
   minify = minify ? "terser" : false;
   const res = await build({
     mode,
+    // so that everything is resolved from here
     root: path.dirname(fileURLToPath(import.meta.url)),
     configFile: false,
     logLevel: "error",
@@ -557,9 +574,15 @@ async function buildPolyfillChunk(mode, imports, bundle, facadeToChunkMap, build
         }
       }
     },
+    // Don't run esbuild for transpilation or minification
+    // because we don't want to transpile code.
     esbuild: false,
     optimizeDeps: {
       esbuildOptions: {
+        // If a value above 'es5' is set, esbuild injects helper functions which uses es2015 features.
+        // This limits the input code not to include es2015+ codes.
+        // But core-js is the only dependency which includes commonjs code
+        // and core-js doesn't include es2015+ codes.
         target: "es5"
       }
     }
@@ -609,7 +632,7 @@ function recordAndRemovePolyfillBabelPlugin(polyfills) {
     name: "vite-remove-polyfill-import",
     post({ path: path2 }) {
       path2.get("body").forEach((p) => {
-        if (t.isImportDeclaration(p)) {
+        if (t.isImportDeclaration(p.node)) {
           polyfills.add(p.node.source.value);
           p.remove();
         }
@@ -644,10 +667,10 @@ function wrapIIFEBabelPlugin() {
   };
 }
 const cspHashes = [
-  createHash("sha256").update(safari10NoModuleFix).digest("base64"),
-  createHash("sha256").update(systemJSInlineCode).digest("base64"),
-  createHash("sha256").update(detectModernBrowserCode).digest("base64"),
-  createHash("sha256").update(dynamicFallbackInlineCode).digest("base64")
-];
+  safari10NoModuleFix,
+  systemJSInlineCode,
+  detectModernBrowserCode,
+  dynamicFallbackInlineCode
+].map((i) => createHash("sha256").update(i).digest("base64"));
 
 export { cspHashes, viteLegacyPlugin as default, detectPolyfills };

package/package.json

@@ -1,11 +1,17 @@
 {
   "name": "@vitejs/plugin-legacy",
-  "version": "3.0.1",
+  "version": "4.0.0",
   "license": "MIT",
   "author": "Evan You",
   "files": [
     "dist"
   ],
+  "keywords": [
+    "frontend",
+    "vite",
+    "vite-plugin",
+    "@vitejs/plugin-legacy"
+  ],
   "main": "./dist/index.cjs",
   "module": "./dist/index.mjs",
   "types": "./dist/index.d.ts",
@@ -35,8 +41,10 @@
   },
   "homepage": "https://github.com/vitejs/vite/tree/main/packages/plugin-legacy#readme",
   "dependencies": {
-    "@babel/standalone": "^7.20.6",
-    "core-js": "^3.26.1",
+    "@babel/core": "^7.20.12",
+    "@babel/preset-env": "^7.20.2",
+    "browserslist": "^4.21.4",
+    "core-js": "^3.27.2",
     "magic-string": "^0.27.0",
     "regenerator-runtime": "^0.13.11",
     "systemjs": "^6.13.0"
@@ -46,7 +54,7 @@
     "vite": "^4.0.0"
   },
   "devDependencies": {
-    "@babel/core": "^7.20.5",
+    "acorn": "^8.8.2",
     "picocolors": "^1.0.0",
     "vite": "workspace:*"
   }