@vit-foundation/ui 0.23.0 → 0.24.0

package/dist/components/admin/Sidebar.svelte

@@ -95,7 +95,15 @@
 		box-shadow: var(--shadow-1);
 	}
 
-	.item {
+	/*
+	 * The rail's footprint, and the host's footer control with it — "should sit
+	 * like an item" was the comment on a second, identical copy of these eleven
+	 * declarations, and vit-brain had a third on its own logout button. One
+	 * selector list is the whole rule: a host's footer submit is an item that
+	 * happens to come from outside.
+	 */
+	.item,
+	.footer :global(button) {
 		display: inline-flex;
 		align-items: center;
 		justify-content: center;
@@ -109,7 +117,8 @@
 		transition: background var(--transition-fast);
 	}
 
-	.item:hover {
+	.item:hover,
+	.footer :global(button:hover) {
 		background: color-mix(in srgb, var(--color-navy) 10%, transparent);
 	}
 
@@ -122,25 +131,6 @@
 		margin-top: auto;
 	}
 
-	/* The host's footer control (a logout submit) should sit like an item. */
-	.footer :global(button) {
-		display: inline-flex;
-		align-items: center;
-		justify-content: center;
-		width: 2.4rem;
-		height: 2.4rem;
-		border-radius: 999px;
-		color: var(--color-navy);
-		border: none;
-		background: transparent;
-		cursor: pointer;
-		transition: background var(--transition-fast);
-	}
-
-	.footer :global(button:hover) {
-		background: color-mix(in srgb, var(--color-navy) 10%, transparent);
-	}
-
 	@media print {
 		.sidebar {
 			display: none;

package/dist/components/layout/PageShell.svelte

@@ -1,12 +1,13 @@
 <script lang="ts">
 	import type { Snippet } from 'svelte';
 	import { getUiConfig } from '../../config/context.js';
+	import { documentTitle } from '../../utils/document-title.js';
 
 	/**
 	 * The chrome every page shares: the content column, the vertical rhythm,
-	 * and the browser title, composed as `title — siteName` from the config's
-	 * site name. (The foundation site's error page spells the same format on
-	 * its own; the two are one decision, noted in both places.)
+	 * and the browser title. The title FORMAT is `documentTitle`'s — the
+	 * foundation site's error page cannot render through this component and
+	 * needs the same format, and the two used to spell it separately.
 	 *
 	 * The shape is one named variant rather than four presentation flags.
 	 * Width, spacing, stacking and the wrapper element were independent props,
@@ -45,7 +46,7 @@
 	let { title, description, variant = 'content', children }: Props = $props();
 
 	const config = getUiConfig();
-	const pageTitle = $derived(title ? `${title} — ${config.siteName}` : config.siteName);
+	const pageTitle = $derived(documentTitle(title, config.siteName));
 	/**
 	 * The editorial variants render an <article>, and say so to crawlers too.
 	 * og:type was hardcoded to 'website' while the element already switched,

package/dist/components/layout/PageShell.svelte.d.ts

@@ -1,9 +1,9 @@
 import type { Snippet } from 'svelte';
 /**
  * The chrome every page shares: the content column, the vertical rhythm,
- * and the browser title, composed as `title — siteName` from the config's
- * site name. (The foundation site's error page spells the same format on
- * its own; the two are one decision, noted in both places.)
+ * and the browser title. The title FORMAT is `documentTitle`'s — the
+ * foundation site's error page cannot render through this component and
+ * needs the same format, and the two used to spell it separately.
  *
  * The shape is one named variant rather than four presentation flags.
  * Width, spacing, stacking and the wrapper element were independent props,

package/dist/contract.d.ts

@@ -54,6 +54,11 @@ export { COMMENT_BODY, CONTACT_MESSAGE, CONTACT_NAME, DISPLAY_NAME, EMAIL, LOGIN
 export { hasNewsletterIntent, HONEYPOT_FIELD, isNewsletterIntent, NEWSLETTER_INTENT_PARAM, NEWSLETTER_INTENT_VALUE, withNewsletterIntent } from './forms/transport.js';
 export type { FormFail, FormFieldIssue, FormResultLike, FormResultOf, KeyedRemoteForms, RemoteField, RemoteFormAttributes, RemoteFormInstance } from './forms/types.js';
 export { buildQueryString, isExternalUrl, isInternalPath } from './utils/paths.js';
+/**
+ * The browser-title format. On `./contract` because its second reader is a
+ * host's error page, which composes a title without rendering `PageShell`.
+ */
+export { documentTitle } from './utils/document-title.js';
 /**
  * The descriptor factories. `edit/helpers.ts` imports nothing but types from
  * two modules this subpath already anchors, so it needed a door rather than a

package/dist/contract.js

@@ -57,6 +57,11 @@ export { hasNewsletterIntent, HONEYPOT_FIELD, isNewsletterIntent, NEWSLETTER_INT
 // import and no host has ever imported it, so exporting it pinned a prefix rule
 // into semver for nobody. See utils/paths.ts.
 export { buildQueryString, isExternalUrl, isInternalPath } from './utils/paths.js';
+/**
+ * The browser-title format. On `./contract` because its second reader is a
+ * host's error page, which composes a title without rendering `PageShell`.
+ */
+export { documentTitle } from './utils/document-title.js';
 /**
  * The descriptor factories. `edit/helpers.ts` imports nothing but types from
  * two modules this subpath already anchors, so it needed a door rather than a

package/dist/testing/imports.d.ts

@@ -0,0 +1,51 @@
+/**
+ * What a source scan needs to see, and the anchors that keep it honest.
+ *
+ * Two guards in this package walk the source: `contract.test.ts` follows the
+ * relative import graph beneath `./contract`, and `no-app-imports.test.ts`
+ * scans every module for an app virtual specifier. They ask different
+ * questions of the same rule — WHICH MODULES DOES THIS ONE NAME — and each
+ * used to answer it with a pattern of its own. `contract.test.ts` found the
+ * defect in its copy and fixed it there:
+ *
+ *     "THREE import forms, because two of them used to be invisible here. The
+ *     pattern required the `from` keyword, so a side-effect import and a
+ *     dynamic one both walked past a guard whose whole job is to see them."
+ *
+ * The other copy was not fixed and still required `from`, so a dynamic import
+ * of an $app specifier walked past the gate that decides whether this package
+ * is publishable. Copying the lesson a third time is how a guard
+ * starts missing things again; the grammar lives here instead, and each guard
+ * filters the specifiers it cares about.
+ */
+/**
+ * Every module specifier a source file names, in all three forms a bundler
+ * follows: `from '…'` (import and re-export alike), a bare side-effect
+ * `import '…'`, and a dynamic `import('…')`.
+ *
+ * A type-only import is reported like any other. That is deliberate, and it
+ * is `contract.test.ts`'s standing argument: erasure is a build-time fact, and
+ * a pattern that has to understand `import type` is a pattern with a second
+ * way to be wrong.
+ */
+export declare function importSpecifiers(source: string): readonly string[];
+/**
+ * Every `.ts` and `.svelte` file beneath `root`, and the ones the walk MUST
+ * find.
+ *
+ * `mustReach` is a required argument for the reason `contract.test.ts` gives
+ * at length: an assertion over an empty list passes. `expect(offenders)
+ * .toEqual([])` is a clean bill of health over a walk that enumerated nothing
+ * — a directory renamed, a `readdirSync` that threw and was caught upstream,
+ * an entry filter that stopped matching — and a safety net that can narrow in
+ * silence reproduces the defect it exists to prevent. fndvit-website's
+ * `src/lib/testing/source-scan.ts` settled the shape: a scan cannot walk the
+ * tree without saying what it must find.
+ *
+ * Anchors are relative to `root` with `/` separators, so one representation
+ * crosses this interface and an anchor cannot silently fail to match an
+ * absolute path. A FLOOR was the alternative and is the thing being replaced:
+ * a walk that quietly stopped seeing two thirds of the tree clears any floor
+ * worth setting.
+ */
+export declare function sourceFiles(root: string, mustReach: readonly string[]): readonly string[];

package/dist/testing/imports.js

@@ -0,0 +1,70 @@
+import { readdirSync } from 'node:fs';
+import { join, relative } from 'node:path';
+/**
+ * What a source scan needs to see, and the anchors that keep it honest.
+ *
+ * Two guards in this package walk the source: `contract.test.ts` follows the
+ * relative import graph beneath `./contract`, and `no-app-imports.test.ts`
+ * scans every module for an app virtual specifier. They ask different
+ * questions of the same rule — WHICH MODULES DOES THIS ONE NAME — and each
+ * used to answer it with a pattern of its own. `contract.test.ts` found the
+ * defect in its copy and fixed it there:
+ *
+ *     "THREE import forms, because two of them used to be invisible here. The
+ *     pattern required the `from` keyword, so a side-effect import and a
+ *     dynamic one both walked past a guard whose whole job is to see them."
+ *
+ * The other copy was not fixed and still required `from`, so a dynamic import
+ * of an $app specifier walked past the gate that decides whether this package
+ * is publishable. Copying the lesson a third time is how a guard
+ * starts missing things again; the grammar lives here instead, and each guard
+ * filters the specifiers it cares about.
+ */
+/**
+ * Every module specifier a source file names, in all three forms a bundler
+ * follows: `from '…'` (import and re-export alike), a bare side-effect
+ * `import '…'`, and a dynamic `import('…')`.
+ *
+ * A type-only import is reported like any other. That is deliberate, and it
+ * is `contract.test.ts`'s standing argument: erasure is a build-time fact, and
+ * a pattern that has to understand `import type` is a pattern with a second
+ * way to be wrong.
+ */
+export function importSpecifiers(source) {
+    return [...source.matchAll(/(?:\bfrom|\bimport)\s*\(?\s*['"]([^'"]*)['"]/g)].map(([, specifier]) => specifier);
+}
+/**
+ * Every `.ts` and `.svelte` file beneath `root`, and the ones the walk MUST
+ * find.
+ *
+ * `mustReach` is a required argument for the reason `contract.test.ts` gives
+ * at length: an assertion over an empty list passes. `expect(offenders)
+ * .toEqual([])` is a clean bill of health over a walk that enumerated nothing
+ * — a directory renamed, a `readdirSync` that threw and was caught upstream,
+ * an entry filter that stopped matching — and a safety net that can narrow in
+ * silence reproduces the defect it exists to prevent. fndvit-website's
+ * `src/lib/testing/source-scan.ts` settled the shape: a scan cannot walk the
+ * tree without saying what it must find.
+ *
+ * Anchors are relative to `root` with `/` separators, so one representation
+ * crosses this interface and an anchor cannot silently fail to match an
+ * absolute path. A FLOOR was the alternative and is the thing being replaced:
+ * a walk that quietly stopped seeing two thirds of the tree clears any floor
+ * worth setting.
+ */
+export function sourceFiles(root, mustReach) {
+    const walk = (dir) => readdirSync(dir, { withFileTypes: true }).flatMap((entry) => {
+        const path = join(dir, entry.name);
+        if (entry.isDirectory())
+            return walk(path);
+        return /\.(ts|svelte)$/.test(entry.name) ? [path] : [];
+    });
+    const files = walk(root);
+    const found = new Set(files.map((file) => relative(root, file).replaceAll('\\', '/')));
+    const missing = mustReach.filter((anchor) => !found.has(anchor));
+    if (missing.length > 0) {
+        throw new Error(`the source scan enumerated ${files.length} files but not ${missing.join(', ')} — ` +
+            'either the module moved or the walk stopped seeing it');
+    }
+    return files;
+}

package/dist/utils/document-title.d.ts

@@ -0,0 +1,22 @@
+/**
+ * How a page names itself to the browser: `title — siteName`, or the site name
+ * alone.
+ *
+ * The format had two owners. `PageShell` composed it from `UiConfig.siteName`,
+ * and fndvit-website's `$lib/site` composed it again for the one page that
+ * cannot render through `PageShell` — its error page, whose centred layout is
+ * not one of the six variants. Both spelled the same expression, both
+ * comments noted that the other existed, and `site.test.ts` pinned the result
+ * as the literal `'Transparència — ViT'`: change the separator in the package
+ * and the error page drifts with nothing failing.
+ *
+ * It lives on `./contract` rather than in `UiConfig` because a config field
+ * would need a package DEFAULT, and that default is the expression — the
+ * duplication would survive the move. No host wants a separator of its own;
+ * one is a hypothetical seam.
+ *
+ * `siteName` is a parameter rather than a read, so this stays component-free
+ * and a server module can call it (fndvit-website's `$lib/site` supplies
+ * `SITE_NAME`, `PageShell` supplies `config.siteName`).
+ */
+export declare function documentTitle(title: string, siteName: string): string;

package/dist/utils/document-title.js

@@ -0,0 +1,27 @@
+/**
+ * How a page names itself to the browser: `title — siteName`, or the site name
+ * alone.
+ *
+ * The format had two owners. `PageShell` composed it from `UiConfig.siteName`,
+ * and fndvit-website's `$lib/site` composed it again for the one page that
+ * cannot render through `PageShell` — its error page, whose centred layout is
+ * not one of the six variants. Both spelled the same expression, both
+ * comments noted that the other existed, and `site.test.ts` pinned the result
+ * as the literal `'Transparència — ViT'`: change the separator in the package
+ * and the error page drifts with nothing failing.
+ *
+ * It lives on `./contract` rather than in `UiConfig` because a config field
+ * would need a package DEFAULT, and that default is the expression — the
+ * duplication would survive the move. No host wants a separator of its own;
+ * one is a hypothetical seam.
+ *
+ * `siteName` is a parameter rather than a read, so this stays component-free
+ * and a server module can call it (fndvit-website's `$lib/site` supplies
+ * `SITE_NAME`, `PageShell` supplies `config.siteName`).
+ */
+export function documentTitle(title, siteName) {
+    // An empty title is a REAL state, not a guard: pages title themselves from
+    // page copy and `content.getPage` returns '' for a missing row, so the site
+    // name alone must ship rather than a dangling separator.
+    return title ? `${title} — ${siteName}` : siteName;
+}

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@vit-foundation/ui",
-	"version": "0.23.0",
+	"version": "0.24.0",
 	"scripts": {
 		"dev": "vite dev",
 		"build": "vite build && npm run prepack",