@visns-studio/visns-components 6.24.4 → 6.26.0

package/src/components/styles/global.css

@@ -314,6 +314,26 @@ input[type]:not([type='search']):not([type='url']):not([type='hidden']):not(
     }
 }
 
+/* THE DROPDOWN ARROW, restored. The rule further up gives `select` its
+   chevron and strips the native chrome (`appearance: none`), and then the
+   chained rule above this comment writes `background: white` — a SHORTHAND,
+   which resets background-image along with the colour. Net result shipped
+   for months: every native select rendered as a plain box visually identical
+   to a text input, with nothing saying "this opens".
+
+   This sits AFTER the chained rule so source order wins at equal
+   specificity, states only the longhands the shorthand clobbered, and
+   positions the chevron inside the field (the original hugged the raw right
+   edge) with the padding to keep long option text from running under it. */
+select {
+    background-image: url(data:image/svg+xml;base64,PHN2ZyBpZD0iTGF5ZXJfMSIgZGF0YS1uYW1lPSJMYXllciAxIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCA0Ljk1IDEwIj48ZGVmcz48c3R5bGU+LmNscy0xe2ZpbGw6I2ZmZjt9LmNscy0ye2ZpbGw6IzQ0NDt9PC9zdHlsZT48L2RlZnM+PHRpdGxlPmFycm93czwvdGl0bGU+PHJlY3QgY2xhc3M9ImNscy0xIiB3aWR0aD0iNC45NSIgaGVpZ2h0PSIxMCIvPjxwb2x5Z29uIGNsYXNzPSJjbHMtMiIgcG9pbnRzPSIxLjQxIDQuNjcgMi40OCAzLjE4IDMuNTQgNC42NyAxLjQxIDQuNjciLz48cG9seWdvbiBjbGFzcz0iY2xzLTIiIHBvaW50cz0iMy41NCA1LjMzIDIuNDggNi44MiAxLjQxIDUuMzMgMy41NCA1LjMzIi8+PC9zdmc+);
+    background-repeat: no-repeat;
+    background-position: right 0.65rem center;
+    background-size: 7px 14px;
+    padding-right: 2rem;
+    cursor: pointer;
+}
+
 /* A textarea is multi-line by definition, so it is the one control that opts
    out of the fixed height — it keeps the font and the horizontal padding, and
    takes the vertical padding that puts its FIRST row on the same line as the

package/src/components/tickets/TicketConversation.jsx

@@ -119,6 +119,19 @@ const TicketConversation = ({
         <div className={styles.wrap}>
             {ticket && <TicketHeader ticket={ticket} counts={counts} />}
 
+            {/* The composer sits ABOVE the thread, and a posted reply is
+                PREPENDED: the server answers newest-first now, so the top of
+                the list is where the conversation currently is — writing
+                happens beside the message being answered, not three scrolls
+                below it under the original request. */}
+            {canReply && (
+                <Composer
+                    base={base}
+                    ticketId={ticketId}
+                    onPosted={(entry) => setEntries((prev) => [entry, ...prev])}
+                />
+            )}
+
             {entries.length === 0 ? (
                 <p className={styles.state}>
                     Nothing has been said on this ticket yet.
@@ -130,14 +143,6 @@ const TicketConversation = ({
                     ))}
                 </ol>
             )}
-
-            {canReply && (
-                <Composer
-                    base={base}
-                    ticketId={ticketId}
-                    onPosted={(entry) => setEntries((prev) => [...prev, entry])}
-                />
-            )}
         </div>
     );
 };

package/src/components/utils/ConfirmDialog.js

@@ -42,9 +42,28 @@ export const confirmDialog = (options) => {
         data = null, // Optional data object from the selected row
     } = options;
 
-    // Find Yes and No buttons if they exist
-    const yesButton = buttons.find((btn) => btn.label === 'Yes');
-    const noButton = buttons.find((btn) => btn.label === 'No');
+    /*
+     * WHICH BUTTON CONFIRMS IS NOT A LABEL LOOKUP ANY MORE.
+     *
+     * This used to find the confirm handler with `label === 'Yes'` and
+     * nothing else — so a dialog whose button said "Delete" rendered
+     * perfectly, showed a default "Yes" button, and ran NOTHING when it was
+     * pressed. Two real screens shipped in that state (ticket delete,
+     * customer delete): the reader confirmed a deletion and the app silently
+     * did not delete, which is the worst available failure — no error, no
+     * effect, no clue. App code even grew comments warning that every
+     * confirm button must be labelled "Yes".
+     *
+     * Now: "No" or "Cancel" (either case) is the cancel button; the FIRST
+     * button that is neither is the confirm, whatever it says — "Yes",
+     * "Delete", "Remove from this project". Its label is what the reader
+     * sees, which is how a destructive dialog should read anyway.
+     */
+    const isCancelLabel = (label) =>
+        typeof label === 'string' && ['no', 'cancel'].includes(label.toLowerCase());
+
+    const yesButton = buttons.find((btn) => !isCancelLabel(btn.label));
+    const noButton = buttons.find((btn) => isCancelLabel(btn.label));
 
     // Default button text
     const confirmButtonText = yesButton ? yesButton.label : 'Yes';