@visns-studio/visns-components 6.1.7 → 6.1.8

package/package.json

@@ -91,7 +91,7 @@
         "react-dom": "^17.0.0 || ^18.0.0"
     },
     "name": "@visns-studio/visns-components",
-    "version": "6.1.7",
+    "version": "6.1.8",
     "description": "Various packages to assist in the development of our Custom Applications.",
     "main": "src/index.js",
     "files": [

package/src/components/TableFilter.jsx

@@ -390,6 +390,7 @@ function TableFilter({
 
         // Calculate the updated settings
         let updatedSettings = null;
+        let applySettingsUpdate = null;
 
         if (setSettings) {
             // For child items, non-parent items, or parent items with a value property
@@ -406,66 +407,73 @@ function TableFilter({
                 const filterId = id;
                 const filterValue = value || '';
 
-                // Start with the current settings
-                // Check if _currentValue exists (React state setter) or use the object directly
-                updatedSettings = setSettings._currentValue
-                    ? { ...setSettings._currentValue }
-                    : { ...setSettings };
-
-                if (updatedSettings.ajaxSetting) {
-                    // First, remove any existing filters that might conflict
-                    let _where = updatedSettings.ajaxSetting.where
-                        ? [...updatedSettings.ajaxSetting.where].filter(
-                              (item) => {
+                // Merge this filter into a settings object, supporting both
+                // ajaxSetting.where and a top-level where. Written as a pure
+                // function of the base settings so it can run either against
+                // the `settings` prop or inside a functional state update —
+                // a state setter carries no readable current value.
+                const mergeFilterIntoSettings = (base) => {
+                    let updated = base ? { ...base } : {};
+
+                    if (updated.ajaxSetting) {
+                        // First, remove any existing filters that might conflict
+                        let _where = updated.ajaxSetting.where
+                            ? [...updated.ajaxSetting.where].filter((item) => {
                                   // Keep items that don't match this filter ID
                                   return item.id !== filterId;
-                              }
-                          )
-                        : [];
+                              })
+                            : [];
 
-                    // Add the new filter only if both filterId and filterValue have values
-                    if (filterId && filterValue !== '') {
-                        _where.push({ id: filterId, value: filterValue });
+                        // Add the new filter only if both filterId and filterValue have values
+                        if (filterId && filterValue !== '') {
+                            _where.push({ id: filterId, value: filterValue });
+                        }
+
+                        return {
+                            ...updated,
+                            ajaxSetting: {
+                                ...updated.ajaxSetting,
+                                where: _where,
+                            },
+                        };
                     }
 
-                    updatedSettings = {
-                        ...updatedSettings,
-                        ajaxSetting: {
-                            ...updatedSettings.ajaxSetting,
-                            where: _where,
-                        },
-                    };
-                } else if (updatedSettings.where) {
-                    // Handle the case where we're using 'where' directly instead of ajaxSetting.where
-                    let w = updatedSettings.where
-                        ? [...updatedSettings.where]
-                        : [];
+                    if (updated.where) {
+                        // Handle the case where we're using 'where' directly instead of ajaxSetting.where
+                        let w = [...updated.where];
 
-                    // Remove any existing filters that might conflict
-                    w = w.filter((item) => item.id !== filterId);
+                        // Remove any existing filters that might conflict
+                        w = w.filter((item) => item.id !== filterId);
 
-                    // Add the new filter only if both filterId and filterValue have values
-                    if (filterId && filterValue !== '') {
-                        w.push({ id: filterId, value: filterValue });
+                        // Add the new filter only if both filterId and filterValue have values
+                        if (filterId && filterValue !== '') {
+                            w.push({ id: filterId, value: filterValue });
+                        }
+
+                        return { ...updated, where: w };
                     }
 
-                    updatedSettings = { ...updatedSettings, where: w };
-                } else {
                     // If neither ajaxSetting.where nor where exists, create a new ajaxSetting
                     // Only apply the filter if both filterId and filterValue have values
                     if (filterId && filterValue !== '') {
-                        updatedSettings = {
-                            ...settings,
+                        return {
+                            ...updated,
                             ajaxSetting: {
-                                ...(settings.ajaxSetting || {}),
                                 where: [{ id: filterId, value: filterValue }],
                             },
                         };
-                    } else {
-                        // If either filterId or filterValue is empty, just copy the existing settings
-                        updatedSettings = { ...settings };
                     }
-                }
+
+                    return updated;
+                };
+
+                applySettingsUpdate = mergeFilterIntoSettings;
+                // With a settings prop we can compute the result now (also
+                // feeds onFilterChange); without one the update happens as a
+                // functional setState below.
+                updatedSettings = settings
+                    ? mergeFilterIntoSettings(settings)
+                    : null;
             }
         }
 
@@ -477,8 +485,14 @@ function TableFilter({
             setFilters(updatedFilters);
 
             // Update the settings if needed
-            if (updatedSettings && setSettings) {
-                setSettings(updatedSettings);
+            if (setSettings && applySettingsUpdate) {
+                if (updatedSettings) {
+                    setSettings(updatedSettings);
+                } else {
+                    // No settings prop to read from — merge against the
+                    // live state via a functional update instead.
+                    setSettings((prev) => applySettingsUpdate(prev));
+                }
             }
         }