@visitwonders/assembly 0.16.1 → 0.18.0

package/dist/overlay/drawer.js

@@ -72,12 +72,6 @@ class DrawerClose extends Component {
 // Main Component
 // ============================================================================
 class Drawer extends Component {
-  static {
-    g(this.prototype, "_isOpenInternal", [tracked], function () {
-      return undefined;
-    });
-  }
-  #_isOpenInternal = (i(this, "_isOpenInternal"), void 0);
   static {
     g(this.prototype, "exitAnimationActive", [tracked], function () {
       return false;
@@ -92,20 +86,8 @@ class Drawer extends Component {
   // ============================================================================
   // Getters
   // ============================================================================
-  get isOpenInternal() {
-    if (this._isOpenInternal === undefined) {
-      return this.args.defaultOpen ?? false;
-    }
-    return this._isOpenInternal;
-  }
-  set isOpenInternal(value) {
-    this._isOpenInternal = value;
-  }
-  get isControlled() {
-    return this.args.open !== undefined;
-  }
   get isOpen() {
-    return this.isControlled ? this.args.open : this.isOpenInternal;
+    return this.args.open ?? false;
   }
   get side() {
     return this.args.side ?? 'right';
@@ -139,12 +121,10 @@ class Drawer extends Component {
   // ============================================================================
   // Actions
   // ============================================================================
-  setOpen = value => {
-    if (!this.isControlled) {
-      this.isOpenInternal = value;
-    }
-    this.args.onOpenChange?.(value);
-  };
+  // Requests a close and resolves once the slide-out animation has ended.
+  // The drawer holds no open state of its own — it fires the callback and
+  // the consumer sets `@open` to false. The returned promise is local
+  // teardown mechanics, awaited by consumers sequencing post-close work.
   closeDrawer = () => {
     if (!this.isOpen && !this.exitAnimationActive) {
       return Promise.resolve();
@@ -152,7 +132,7 @@ class Drawer extends Component {
     const promise = new Promise(resolve => {
       this.pendingCloseResolvers.push(resolve);
     });
-    this.setOpen(false);
+    this.args.onOpenChange?.(false);
     return promise;
   };
   drainCloseResolvers() {

package/dist/overlay/modal.js

@@ -72,12 +72,6 @@ class ModalClose extends Component {
 // Main Component
 // ============================================================================
 class Modal extends Component {
-  static {
-    g(this.prototype, "_isOpenInternal", [tracked], function () {
-      return undefined;
-    });
-  }
-  #_isOpenInternal = (i(this, "_isOpenInternal"), void 0);
   static {
     g(this.prototype, "exitAnimationActive", [tracked], function () {
       return false;
@@ -91,20 +85,8 @@ class Modal extends Component {
   // ============================================================================
   // Getters
   // ============================================================================
-  get isOpenInternal() {
-    if (this._isOpenInternal === undefined) {
-      return this.args.defaultOpen ?? false;
-    }
-    return this._isOpenInternal;
-  }
-  set isOpenInternal(value) {
-    this._isOpenInternal = value;
-  }
-  get isControlled() {
-    return this.args.open !== undefined;
-  }
   get isOpen() {
-    return this.isControlled ? this.args.open : this.isOpenInternal;
+    return this.args.open ?? false;
   }
   get size() {
     return this.args.size ?? 'md';
@@ -132,17 +114,11 @@ class Modal extends Component {
   // ============================================================================
   // Actions
   // ============================================================================
-  setOpen = value => {
-    if (!this.isControlled) {
-      this.isOpenInternal = value;
-    }
-    this.args.onOpenChange?.(value);
-  };
-  openModal = () => {
-    this.setOpen(true);
-  };
+  // Internal close triggers (Esc, backdrop, close buttons) request a close
+  // by firing the callback. The modal holds no open state of its own — the
+  // consumer sets `@open` to false in response.
   closeModal = () => {
-    this.setOpen(false);
+    this.args.onOpenChange?.(false);
   };
   handleBackdropClose = () => {
     if (this.closeOnBackdropClick) {

package/dist/overlay/popover.js

@@ -245,11 +245,14 @@ class PopoverClose extends Component {
 // ============================================================================
 class Popover extends Component {
   static {
-    g(this.prototype, "_isOpenInternal", [tracked], function () {
-      return undefined;
+    g(this.prototype, "_isOpen", [tracked], function () {
+      return false;
     });
   }
-  #_isOpenInternal = (i(this, "_isOpenInternal"), void 0);
+  #_isOpen = (i(this, "_isOpen"), void 0); // Self-managed open state. The popover opens and closes itself on click,
+  // hover, or focus (per `@trigger`); this is the component's own UI
+  // mechanics, the ember-basic-dropdown shape. `@open`, when provided,
+  // overrides it.
   static {
     g(this.prototype, "triggerElement", [tracked], function () {
       return null;
@@ -307,20 +310,13 @@ class Popover extends Component {
       });
     };
   });
-  get isOpenInternal() {
-    if (this._isOpenInternal === undefined) {
-      return this.args.defaultOpen ?? false;
-    }
-    return this._isOpenInternal;
-  }
-  set isOpenInternal(value) {
-    this._isOpenInternal = value;
-  }
-  get isControlled() {
+  // True when the consumer is driving open via `@open`. The override wins
+  // over the self-managed `_isOpen` state.
+  get hasOpenOverride() {
     return this.args.open !== undefined;
   }
   get isOpen() {
-    return this.isControlled ? this.args.open : this.isOpenInternal;
+    return this.args.open ?? this._isOpen;
   }
   get triggerMode() {
     return this.args.trigger ?? 'click';
@@ -338,8 +334,11 @@ class Popover extends Component {
     return this.args.closeDelay ?? 0;
   }
   setOpen = value => {
-    if (!this.isControlled) {
-      this.isOpenInternal = value;
+    // Update the self-managed state unless the consumer is driving `@open`.
+    // The callback fires either way so an `@open` consumer can follow the
+    // popover's own open/close intent rather than fighting it.
+    if (!this.hasOpenOverride) {
+      this._isOpen = value;
     }
     this.args.onOpenChange?.(value);
   };

package/dist/overlay/tooltip.js

@@ -67,11 +67,13 @@ class TooltipProvider extends Component {
  */
 class Tooltip extends Component {
   static {
-    g(this.prototype, "_isOpenInternal", [tracked], function () {
-      return undefined;
+    g(this.prototype, "_isOpen", [tracked], function () {
+      return false;
     });
   }
-  #_isOpenInternal = (i(this, "_isOpenInternal"), void 0);
+  #_isOpen = (i(this, "_isOpen"), void 0); // Self-managed open state. The tooltip opens and closes itself on hover and
+  // focus; this is the component's own UI mechanics, the ember-basic-dropdown
+  // shape. `@open`, when provided, overrides it.
   static {
     g(this.prototype, "actualSide", [tracked], function () {
       return 'top';
@@ -92,21 +94,14 @@ class Tooltip extends Component {
   // ============================================================================
   // Getters
   // ============================================================================
-  get isOpenInternal() {
-    if (this._isOpenInternal === undefined) {
-      return this.args.defaultOpen ?? false;
-    }
-    return this._isOpenInternal;
-  }
-  set isOpenInternal(value) {
-    this._isOpenInternal = value;
-  }
-  get isControlled() {
+  // True when the consumer is driving open via `@open`. The override wins
+  // over the self-managed `_isOpen` state.
+  get hasOpenOverride() {
     return this.args.open !== undefined;
   }
   get isOpen() {
     if (this.args.disabled) return false;
-    return this.isControlled ? this.args.open : this.isOpenInternal;
+    return this.args.open ?? this._isOpen;
   }
   get side() {
     return this.args.side ?? 'top';
@@ -244,8 +239,11 @@ class Tooltip extends Component {
   // State Management
   // ============================================================================
   setOpen = value => {
-    if (!this.isControlled) {
-      this.isOpenInternal = value;
+    // Update the self-managed state unless the consumer is driving `@open`.
+    // The callback fires either way so an `@open` consumer can follow the
+    // tooltip's own open/close intent rather than fighting it.
+    if (!this.hasOpenOverride) {
+      this._isOpen = value;
     }
     this.args.onOpenChange?.(value);
     // Track close time for skip delay behavior

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@visitwonders/assembly",
-  "version": "0.16.1",
+  "version": "0.18.0",
   "description": "The default blueprint for Embroider v2 addons.",
   "keywords": [
     "ember-addon"
@@ -77,21 +77,6 @@
     "declarations",
     "dist"
   ],
-  "scripts": {
-    "build": "rollup --config",
-    "format": "prettier . --cache --write",
-    "lint": "concurrently \"pnpm:lint:*(!fix)\" --names \"lint:\" --prefixColors auto",
-    "lint:fix": "concurrently \"pnpm:lint:*:fix\" --names \"fix:\" --prefixColors auto && pnpm run format",
-    "lint:format": "prettier . --cache --check",
-    "lint:hbs": "ember-template-lint . --no-error-on-unmatched-pattern",
-    "lint:hbs:fix": "ember-template-lint . --fix --no-error-on-unmatched-pattern",
-    "lint:js": "eslint . --cache",
-    "lint:js:fix": "eslint . --fix",
-    "lint:types": "ember-tsc",
-    "prepack": "rm -rf declarations dist && rollup --config",
-    "start": "rollup --config --watch",
-    "test": "echo 'A v2 addon does not have tests, run tests in showcase'"
-  },
   "dependencies": {
     "@arthur5005/dnd-kit-ember": "^0.1.2",
     "@embroider/addon-shim": "^1.8.9",
@@ -228,5 +213,19 @@
       "./typography/heading.js": "./dist/_app_/typography/heading.js",
       "./typography/text.js": "./dist/_app_/typography/text.js"
     }
+  },
+  "scripts": {
+    "build": "rollup --config",
+    "format": "prettier . --cache --write",
+    "lint": "concurrently \"pnpm:lint:*(!fix)\" --names \"lint:\" --prefixColors auto",
+    "lint:fix": "concurrently \"pnpm:lint:*:fix\" --names \"fix:\" --prefixColors auto && pnpm run format",
+    "lint:format": "prettier . --cache --check",
+    "lint:hbs": "ember-template-lint . --no-error-on-unmatched-pattern",
+    "lint:hbs:fix": "ember-template-lint . --fix --no-error-on-unmatched-pattern",
+    "lint:js": "eslint . --cache",
+    "lint:js:fix": "eslint . --fix",
+    "lint:types": "ember-tsc",
+    "start": "rollup --config --watch",
+    "test": "echo 'A v2 addon does not have tests, run tests in showcase'"
   }
-}
+}