@visa/cli 4.1.0-rc.99 → 5.0.0-rc.335

package/dist/skills/pair-visa-agent/scripts/__tests__/setup.test.mjs

@@ -0,0 +1,407 @@
+import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest'
+import { mkdirSync, writeFileSync, rmSync } from 'node:fs'
+import { join } from 'node:path'
+import { tmpdir } from 'node:os'
+import { randomUUID } from 'node:crypto'
+
+import {
+  parseSemver,
+  isSemverCompatible,
+  findCliBinary,
+  detectCliVersion,
+  probeMcpTools,
+  verifyCliReadiness,
+  runSetup,
+  REQUIRED_MCP_TOOLS,
+} from '../setup.mjs'
+
+describe('setup.mjs portable provisioner', () => {
+  let tempDir
+
+  beforeEach(() => {
+    tempDir = join(tmpdir(), `setup-test-${randomUUID()}`)
+    mkdirSync(tempDir, { recursive: true })
+  })
+
+  afterEach(() => {
+    rmSync(tempDir, { recursive: true, force: true })
+  })
+
+  describe('parseSemver', () => {
+    it('parses release and prerelease versions', () => {
+      expect(parseSemver('4.0.1')).toEqual({ major: 4, minor: 0, patch: 1, pre: null })
+      expect(parseSemver('v4.1.0-rc.159')).toEqual({ major: 4, minor: 1, patch: 0, pre: 'rc.159' })
+      expect(parseSemver('4.1.0-rc.166+build123')).toEqual({
+        major: 4,
+        minor: 1,
+        patch: 0,
+        pre: 'rc.166',
+      })
+      expect(parseSemver('not-a-version')).toBeNull()
+      expect(parseSemver(null)).toBeNull()
+    })
+  })
+
+  describe('isSemverCompatible', () => {
+    it('rejects stale 4.0.1 against 4.1.0-rc.159 floor', () => {
+      expect(isSemverCompatible('4.0.1', '4.1.0-rc.159')).toBe(false)
+      expect(isSemverCompatible('3.9.0', '4.1.0-rc.159')).toBe(false)
+    })
+
+    it('rejects older RC versions', () => {
+      expect(isSemverCompatible('4.1.0-rc.70', '4.1.0-rc.159')).toBe(false)
+      expect(isSemverCompatible('4.1.0-rc.158', '4.1.0-rc.159')).toBe(false)
+    })
+
+    it('accepts exact matching or newer RC versions', () => {
+      expect(isSemverCompatible('4.1.0-rc.159', '4.1.0-rc.159')).toBe(true)
+      expect(isSemverCompatible('4.1.0-rc.166', '4.1.0-rc.159')).toBe(true)
+      expect(isSemverCompatible('4.1.0-rc.200', '4.1.0-rc.159')).toBe(true)
+    })
+
+    it('accepts stable promotion (4.1.0 outranks 4.1.0-rc.159)', () => {
+      expect(isSemverCompatible('4.1.0', '4.1.0-rc.159')).toBe(true)
+      expect(isSemverCompatible('4.2.0', '4.1.0-rc.159')).toBe(true)
+      expect(isSemverCompatible('5.0.0', '4.1.0-rc.159')).toBe(true)
+    })
+  })
+
+  describe('findCliBinary', () => {
+    it('returns visa when visa --version succeeds', () => {
+      const mockExec = vi.fn((cmd) => {
+        if (cmd === 'visa') return 'visa 4.1.0-rc.166'
+        throw new Error('command not found')
+      })
+      expect(findCliBinary(mockExec)).toBe('visa')
+    })
+
+    it('returns visa-cli when only visa-cli succeeds', () => {
+      const mockExec = vi.fn((cmd) => {
+        if (cmd === 'visa-cli') return 'visa-cli 4.1.0-rc.166'
+        throw new Error('command not found')
+      })
+      expect(findCliBinary(mockExec)).toBe('visa-cli')
+    })
+
+    it('returns null when neither binary succeeds', () => {
+      const mockExec = vi.fn(() => {
+        throw new Error('command not found')
+      })
+      expect(findCliBinary(mockExec)).toBeNull()
+    })
+  })
+
+  describe('detectCliVersion', () => {
+    it('parses version from capabilities JSON output', () => {
+      const mockExec = vi.fn((cmd, args) => {
+        if (args.includes('capabilities')) {
+          return JSON.stringify({
+            data: { build: { version: '4.1.0-rc.166' } },
+          })
+        }
+        return '4.1.0-rc.166'
+      })
+      expect(detectCliVersion('visa', mockExec)).toBe('4.1.0-rc.166')
+    })
+
+    it('falls back to --version when capabilities fails', () => {
+      const mockExec = vi.fn((cmd, args) => {
+        if (args.includes('capabilities')) throw new Error('unknown command')
+        if (args.includes('--version')) return 'v4.1.0-rc.166\n'
+        throw new Error('unknown')
+      })
+      expect(detectCliVersion('visa', mockExec)).toBe('4.1.0-rc.166')
+    })
+  })
+
+  describe('probeMcpTools', () => {
+    it('returns ok: true when all required tools exist in bundle', () => {
+      const bundlePath = join(tempDir, 'index.js')
+      writeFileSync(
+        bundlePath,
+        `
+        const tools = ['agent_handoff_claim', 'agent_connect', 'agent_connect_poll', 'setup_start'];
+        `
+      )
+      const probe = probeMcpTools(bundlePath, REQUIRED_MCP_TOOLS)
+      expect(probe.ok).toBe(true)
+      expect(probe.missingTools).toEqual([])
+    })
+
+    it('returns missing tools when bundle lacks handoff tools (e.g. 4.0.1 bundle)', () => {
+      const bundlePath = join(tempDir, 'index.js')
+      writeFileSync(
+        bundlePath,
+        `
+        const tools = ['enroll_agent', 'pay_merchant'];
+        `
+      )
+      const probe = probeMcpTools(bundlePath, REQUIRED_MCP_TOOLS)
+      expect(probe.ok).toBe(false)
+      expect(probe.missingTools).toEqual([
+        'agent_handoff_claim',
+        'agent_connect',
+        'agent_connect_poll',
+      ])
+    })
+
+    it('returns false when bundle file is missing', () => {
+      const probe = probeMcpTools(join(tempDir, 'nonexistent.js'), REQUIRED_MCP_TOOLS)
+      expect(probe.ok).toBe(false)
+      expect(probe.missingTools).toEqual([...REQUIRED_MCP_TOOLS])
+    })
+
+    it('does not treat agent_connect_poll as a match for agent_connect', () => {
+      const bundlePath = join(tempDir, 'index.js')
+      writeFileSync(bundlePath, `const tools = ['agent_handoff_claim', 'agent_connect_poll'];`)
+      const probe = probeMcpTools(bundlePath, REQUIRED_MCP_TOOLS)
+      expect(probe.ok).toBe(false)
+      expect(probe.missingTools).toContain('agent_connect')
+      expect(probe.missingTools).not.toContain('agent_connect_poll')
+    })
+  })
+
+  describe('verifyCliReadiness', () => {
+    it('reports not_installed when no binary is found', () => {
+      const mockExec = vi.fn(() => {
+        throw new Error('command not found')
+      })
+      const result = verifyCliReadiness(mockExec)
+      expect(result.ready).toBe(false)
+      expect(result.reason).toBe('not_installed')
+    })
+
+    it('reports stale_or_incomplete when installed version is 4.0.1', () => {
+      const bundlePath = join(tempDir, 'index.js')
+      writeFileSync(bundlePath, `const tools = ['enroll_agent'];`)
+
+      const mockExec = vi.fn((cmd, args) => {
+        if (args.includes('--version')) return '4.0.1'
+        if (args.includes('capabilities'))
+          return JSON.stringify({ data: { build: { version: '4.0.1' } } })
+        throw new Error('unknown')
+      })
+      const mockNpmRoot = vi.fn(() => tempDir)
+
+      const result = verifyCliReadiness(mockExec, mockNpmRoot)
+      expect(result.ready).toBe(false)
+      expect(result.reason).toBe('stale_or_incomplete')
+      expect(result.version).toBe('4.0.1')
+    })
+
+    it('reports ready when version is >= 4.1.0-rc.159 and required tools exist', () => {
+      const bundleDir = join(tempDir, '@visa', 'cli', 'dist', 'mcp-server')
+      mkdirSync(bundleDir, { recursive: true })
+      writeFileSync(
+        join(bundleDir, 'index.js'),
+        `const tools = ['agent_handoff_claim', 'agent_connect', 'agent_connect_poll'];`
+      )
+
+      const mockExec = vi.fn((cmd, args) => {
+        if (args.includes('--version')) return '4.1.0-rc.166'
+        if (args.includes('capabilities')) {
+          return JSON.stringify({ data: { build: { version: '4.1.0-rc.166' } } })
+        }
+        throw new Error('unknown')
+      })
+      const mockNpmRoot = vi.fn(() => tempDir)
+
+      const result = verifyCliReadiness(mockExec, mockNpmRoot)
+      expect(result.ready).toBe(true)
+      expect(result.version).toBe('4.1.0-rc.166')
+      expect(result.missingTools).toEqual([])
+    })
+
+    it('reports stale_or_incomplete when version is compatible but the MCP bundle is missing', () => {
+      const mockExec = vi.fn((cmd, args) => {
+        if (args.includes('--version')) return '4.1.0-rc.166'
+        if (args.includes('capabilities')) {
+          return JSON.stringify({ data: { build: { version: '4.1.0-rc.166' } } })
+        }
+        throw new Error('unknown')
+      })
+      const mockNpmRoot = vi.fn(() => join(tempDir, 'no-such-npm-root'))
+
+      const result = verifyCliReadiness(mockExec, mockNpmRoot, () => null)
+      expect(result.ready).toBe(false)
+      expect(result.reason).toBe('stale_or_incomplete')
+      expect(result.version).toBe('4.1.0-rc.166')
+      expect(result.missingTools).toEqual([...REQUIRED_MCP_TOOLS])
+    })
+  })
+
+  describe('runSetup end-to-end scenarios', () => {
+    it('scenario 1: fresh box (no CLI installed) -> installs @visa/cli@rc and succeeds', async () => {
+      const bundleDir = join(tempDir, '@visa', 'cli', 'dist', 'mcp-server')
+      let installed = false
+
+      const mockExec = vi.fn((cmd, args) => {
+        if (cmd === 'npm' && args.includes('install')) {
+          installed = true
+          mkdirSync(bundleDir, { recursive: true })
+          writeFileSync(
+            join(bundleDir, 'index.js'),
+            `const tools = ['agent_handoff_claim', 'agent_connect', 'agent_connect_poll'];`
+          )
+          return ''
+        }
+        if (cmd === 'visa') {
+          if (!installed) throw new Error('command not found')
+          if (args.includes('--version')) return '4.1.0-rc.166'
+          if (args.includes('capabilities')) {
+            return JSON.stringify({ data: { build: { version: '4.1.0-rc.166' } } })
+          }
+        }
+        throw new Error(`unknown command ${cmd}`)
+      })
+      const mockNpmRoot = vi.fn(() => tempDir)
+
+      const logSpy = vi.spyOn(console, 'log').mockImplementation(() => {})
+      const result = await runSetup(
+        { VISA_RELEASE_CHANNEL: 'rc' },
+        { execFileSync: mockExec, npmRootFn: mockNpmRoot }
+      )
+      logSpy.mockRestore()
+
+      expect(mockExec).toHaveBeenCalledWith(
+        'npm',
+        ['install', '-g', '@visa/cli@rc'],
+        expect.any(Object)
+      )
+      expect(result.status).toBe('installed')
+      expect(result.version).toBe('4.1.0-rc.166')
+    })
+
+    it('scenario 2: stale CLI installed (4.0.1) -> upgrades to @visa/cli@rc and succeeds', async () => {
+      const bundleDir = join(tempDir, '@visa', 'cli', 'dist', 'mcp-server')
+      mkdirSync(bundleDir, { recursive: true })
+      writeFileSync(join(bundleDir, 'index.js'), `const tools = ['enroll_agent'];`)
+
+      let upgraded = false
+      const mockExec = vi.fn((cmd, args) => {
+        if (cmd === 'npm' && args.includes('install')) {
+          upgraded = true
+          writeFileSync(
+            join(bundleDir, 'index.js'),
+            `const tools = ['agent_handoff_claim', 'agent_connect', 'agent_connect_poll'];`
+          )
+          return ''
+        }
+        if (cmd === 'visa') {
+          const version = upgraded ? '4.1.0-rc.166' : '4.0.1'
+          if (args.includes('--version')) return version
+          if (args.includes('capabilities')) {
+            return JSON.stringify({ data: { build: { version } } })
+          }
+        }
+        throw new Error(`unknown command ${cmd}`)
+      })
+      const mockNpmRoot = vi.fn(() => tempDir)
+
+      const logSpy = vi.spyOn(console, 'log').mockImplementation(() => {})
+      const result = await runSetup(
+        { VISA_RELEASE_CHANNEL: 'rc' },
+        { execFileSync: mockExec, npmRootFn: mockNpmRoot }
+      )
+      logSpy.mockRestore()
+
+      expect(mockExec).toHaveBeenCalledWith(
+        'npm',
+        ['install', '-g', '@visa/cli@rc'],
+        expect.any(Object)
+      )
+      expect(result.status).toBe('upgraded')
+      expect(result.version).toBe('4.1.0-rc.166')
+    })
+
+    it('scenario 3: current CLI installed -> idempotent no-op', async () => {
+      const bundleDir = join(tempDir, '@visa', 'cli', 'dist', 'mcp-server')
+      mkdirSync(bundleDir, { recursive: true })
+      writeFileSync(
+        join(bundleDir, 'index.js'),
+        `const tools = ['agent_handoff_claim', 'agent_connect', 'agent_connect_poll'];`
+      )
+
+      const mockExec = vi.fn((cmd, args) => {
+        if (cmd === 'visa') {
+          if (args.includes('--version')) return '4.1.0-rc.166'
+          if (args.includes('capabilities')) {
+            return JSON.stringify({ data: { build: { version: '4.1.0-rc.166' } } })
+          }
+        }
+        throw new Error(`unexpected execution ${cmd}`)
+      })
+      const mockNpmRoot = vi.fn(() => tempDir)
+
+      const logSpy = vi.spyOn(console, 'log').mockImplementation(() => {})
+      const result = await runSetup(
+        { VISA_RELEASE_CHANNEL: 'rc' },
+        { execFileSync: mockExec, npmRootFn: mockNpmRoot }
+      )
+      logSpy.mockRestore()
+
+      expect(mockExec).not.toHaveBeenCalledWith('npm', expect.anything(), expect.anything())
+      expect(result.status).toBe('already_ready')
+      expect(result.version).toBe('4.1.0-rc.166')
+    })
+
+    it('scenario 4: install failure reports one explicit upgrade action and exits 1', async () => {
+      const mockExec = vi.fn((cmd) => {
+        if (cmd === 'npm') throw new Error('EACCES: permission denied')
+        throw new Error('not installed')
+      })
+      const mockNpmRoot = vi.fn(() => tempDir)
+
+      const errorSpy = vi.spyOn(console, 'error').mockImplementation(() => {})
+      const exitSpy = vi.spyOn(process, 'exit').mockImplementation((code) => {
+        throw new Error(`process.exit(${code})`)
+      })
+
+      await expect(
+        runSetup({ VISA_RELEASE_CHANNEL: 'rc' }, { execFileSync: mockExec, npmRootFn: mockNpmRoot })
+      ).rejects.toThrow('process.exit(1)')
+
+      expect(errorSpy).toHaveBeenCalledWith(expect.stringContaining('npm install -g @visa/cli@rc'))
+
+      errorSpy.mockRestore()
+      exitSpy.mockRestore()
+    })
+
+    it('scenario 5: version string appears current but tools missing after install -> fails readiness', async () => {
+      const bundleDir = join(tempDir, '@visa', 'cli', 'dist', 'mcp-server')
+      mkdirSync(bundleDir, { recursive: true })
+      writeFileSync(join(bundleDir, 'index.js'), `const tools = ['other_tool'];`)
+
+      const mockExec = vi.fn((cmd, args) => {
+        if (cmd === 'npm') return ''
+        if (cmd === 'visa') {
+          if (args.includes('--version')) return '4.1.0-rc.166'
+          if (args.includes('capabilities')) {
+            return JSON.stringify({ data: { build: { version: '4.1.0-rc.166' } } })
+          }
+        }
+        throw new Error(`unknown command ${cmd}`)
+      })
+      const mockNpmRoot = vi.fn(() => tempDir)
+
+      const errorSpy = vi.spyOn(console, 'error').mockImplementation(() => {})
+      const exitSpy = vi.spyOn(process, 'exit').mockImplementation((code) => {
+        throw new Error(`process.exit(${code})`)
+      })
+
+      await expect(
+        runSetup({ VISA_RELEASE_CHANNEL: 'rc' }, { execFileSync: mockExec, npmRootFn: mockNpmRoot })
+      ).rejects.toThrow('process.exit(1)')
+
+      expect(errorSpy).toHaveBeenCalledWith(
+        expect.stringContaining(
+          'Readiness check failed: installed CLI v4.1.0-rc.166 is missing required tools'
+        )
+      )
+      expect(errorSpy).toHaveBeenCalledWith(expect.stringContaining('npm install -g @visa/cli@rc'))
+
+      errorSpy.mockRestore()
+      exitSpy.mockRestore()
+    })
+  })
+})