@visa/cli 4.1.0-rc.191 → 4.1.0-rc.192

package/dist/checkout-engine/executor.d.ts

@@ -121,6 +121,14 @@ export type SubmitApprovedCheckoutOptions = {
     onChallengeHold?: (signal: string | null) => void;
     resolveEmailOtp?: OtpResolver;
 };
+export type SubmitCandidateMeta = {
+    label: string;
+    ariaHidden: boolean;
+    tabIndex: number | null;
+    visible: boolean;
+    area: number;
+};
+export declare function preferredSubmitIndex(cands: readonly SubmitCandidateMeta[]): number;
 export declare function snapshotOrigin(rawUrl: string): string;
 export type PreparedCheckoutSession = {
     checkout: PreparedCheckout;

package/dist/checkout-engine/executor.js

@@ -124,17 +124,52 @@ async function fingerprintSubmitTarget(locator, kind, fallbackLabel) {
         };
     }, { targetKind: kind, targetFallbackLabel: fallbackLabel });
 }
+// Shopify checkouts keep INERT duplicates of the pay control in the DOM —
+// aria-hidden="true", tabindex="-1", and/or zero-size. Playwright still reports
+// those as "visible, enabled and stable", so a bare `.first()` resolves to one
+// and then every click is swallowed by whatever paints on top of it
+// (observed live: `<h3 id="billingAddress"> intercepts pointer events`, retried
+// until the 6s timeout, deterministically, on casper.com). Rank the real
+// controls ahead of the inert ones and prefer a pay-labelled control.
+export function preferredSubmitIndex(cands) {
+    const usable = cands
+        .map((c, i) => ({ c, i }))
+        .filter(({ c }) => c.visible && !c.ariaHidden && c.tabIndex !== -1 && c.area > 0);
+    if (usable.length === 0)
+        return -1;
+    const payLike = usable.find(({ c }) => PAY_LABEL.test(c.label));
+    return (payLike ?? usable[0]).i;
+}
+const PAY_LABEL = /pay|place order|complete order|submit order|buy now/i;
 async function findSubmit(page) {
-    const submitBtn = page.locator('button[type="submit"], input[type="submit"]').first();
-    if ((await submitBtn.count().catch(() => 0)) > 0) {
-        const label = ((await submitBtn.textContent().catch(() => '')) || '').trim() ||
-            (await submitBtn.getAttribute('value').catch(() => '')) ||
-            'submit';
-        return {
-            desc: `submit button ("${label}")`,
-            fingerprint: await fingerprintSubmitTarget(submitBtn, 'submit-control', 'submit'),
-            click: () => submitBtn.click(),
-        };
+    const controls = page.locator('button[type="submit"], input[type="submit"]');
+    const handles = await controls.all().catch(() => []);
+    if (handles.length > 0) {
+        const metas = await Promise.all(handles.map(async (h) => {
+            const text = ((await h.textContent().catch(() => '')) || '').trim();
+            const value = text || (await h.getAttribute('value').catch(() => '')) || '';
+            const ariaHidden = await h.getAttribute('aria-hidden').catch(() => null);
+            const tabIndexRaw = await h.getAttribute('tabindex').catch(() => null);
+            const visible = await h.isVisible().catch(() => false);
+            const box = await h.boundingBox().catch(() => null);
+            return {
+                label: value,
+                ariaHidden: ariaHidden === 'true',
+                tabIndex: tabIndexRaw === null ? null : Number(tabIndexRaw),
+                visible,
+                area: box ? box.width * box.height : 0,
+            };
+        }));
+        const idx = preferredSubmitIndex(metas);
+        if (idx >= 0) {
+            const chosen = handles[idx];
+            const label = metas[idx].label || 'submit';
+            return {
+                desc: `submit button ("${label}")`,
+                fingerprint: await fingerprintSubmitTarget(chosen, 'submit-control', 'submit'),
+                click: () => chosen.click(),
+            };
+        }
     }
     const byText = page.getByRole('button', { name: SUBMIT_TEXT }).first();
     if ((await byText.count().catch(() => 0)) > 0) {