@visa/cli 4.1.0-rc.152 → 4.1.0-rc.153

package/dist/checkout-engine/cli-engine.d.ts

@@ -1,5 +1,5 @@
 import { type Browser } from 'playwright-core';
-import { prepareCheckout as realPrepareCheckout, submitApprovedCheckout as realSubmitApprovedCheckout, type PreparedCheckoutSessionStore } from './executor.js';
+import { prepareCheckout as realPrepareCheckout, submitApprovedCheckout as realSubmitApprovedCheckout, type CheckoutOutcome, type PreparedCheckoutSessionStore } from './executor.js';
 import { claimMandatePickup as realClaimMandatePickup, runHostedApproval as realRunHostedApproval } from './hosted-approval.js';
 import { type VgsCheckoutTarget } from './vgs-live-instrument.js';
 import { serverFetchCryptogram, serverPostConfirmation } from './vgs-gateway/server-mint-client.js';
@@ -58,7 +58,7 @@ export type CliPayInput = CliReviewInput & {
     onApprovalUrl?: (url: string) => void;
 };
 export type CliReceiptFacts = {
-    outcome: string;
+    outcome: CheckoutOutcome;
     confirmationRef: string | null;
     receiptPath: string | null;
     detail: string | null;
@@ -84,6 +84,10 @@ export type CliReceiptFacts = {
     /** True only when at least one payment field was successfully filled. */
     credentialDisclosed: boolean;
 };
+type PayAttempt = {
+    fingerprint: string;
+    promise: Promise<CliReceiptFacts>;
+};
 export type CliStartMandateInput = {
     /** Optional local card-capability selector (legacy name or exact request-key JKT). */
     agentRef?: string;
@@ -222,6 +226,8 @@ export type CliEngineDeps = {
     writeReceipt?: typeof realWriteReceipt;
     store?: PreparedCheckoutSessionStore;
     sessions?: Map<string, Session>;
+    /** Exact-review singleflight registry; tests inject a fresh map for isolation. */
+    payAttempts?: Map<string, PayAttempt>;
     ttlMs?: number;
     /** Owner-only card-mandate ledger — defaults to the ~/.visa-mcp singleton. */
     ledger?: MandateLedger;

package/dist/checkout-engine/cli-engine.js

@@ -119,16 +119,46 @@ async function resolveCardInstrument(input) {
         '`visa agent grant-card <agent-id> --ceiling <usd> --per-transaction <usd> --wait` to ' +
         'attach one, or use a pre-provisioned VIC runtime.', readError instanceof Error ? { cause: readError } : undefined);
 }
+function payAttemptFingerprint(input) {
+    return JSON.stringify([
+        input.url,
+        input.amount,
+        input.currency,
+        input.credentialPath,
+        input.cardTokenId ?? null,
+        input.agentJkt ?? null,
+        input.contact,
+        input.approvalBaseUrl,
+        input.merchantName ?? null,
+        input.merchantCountryCode ?? null,
+        input.submit,
+    ]);
+}
+function failedPay(detail) {
+    return {
+        outcome: 'failed',
+        confirmationRef: null,
+        receiptPath: null,
+        detail,
+        vicConfirmation: null,
+        source: null,
+        remainingMinor: null,
+        credentialIssued: false,
+        credentialDisclosed: false,
+    };
+}
 const RECEIPT_DIR = join(homedir(), '.visa-mcp', 'checkout-receipts');
 // Must match the prepared-checkout store TTL so a session and its store entry
 // expire together — an abandoned review can't leak the browser + state.
 const PREPARED_TTL_MS = 5 * 60 * 1000;
 const defaultStore = new InMemoryPreparedCheckoutStore({ ttlMs: PREPARED_TTL_MS });
 const defaultSessions = new Map();
+const defaultPayAttempts = new Map();
 const defaultLedger = new MandateLedger();
 export function createCliCheckoutEngine(deps = {}) {
     const store = deps.store ?? defaultStore;
     const sessions = deps.sessions ?? defaultSessions;
+    const payAttempts = deps.payAttempts ?? defaultPayAttempts;
     const ttlMs = deps.ttlMs ?? PREPARED_TTL_MS;
     const launchBrowser = deps.launchBrowser ?? (() => launchCheckoutBrowser());
     const prepareCheckout = deps.prepareCheckout ?? realPrepareCheckout;
@@ -508,12 +538,20 @@ export function createCliCheckoutEngine(deps = {}) {
          */
         async releaseReview(reviewId) {
             await closeSession(reviewId);
+            payAttempts.delete(reviewId);
         },
         async pay(input) {
             const noCredentialFacts = {
                 credentialIssued: false,
                 credentialDisclosed: false,
             };
+            const fingerprint = payAttemptFingerprint(input);
+            const priorAttempt = payAttempts.get(input.reviewId);
+            if (priorAttempt) {
+                return priorAttempt.fingerprint === fingerprint
+                    ? priorAttempt.promise
+                    : failedPay(`review ${input.reviewId} is already executing with different payment facts — wait for that exact attempt and inspect its receipt`);
+            }
             const session = sessions.get(input.reviewId);
             // One signal for the whole pay lifecycle. `cardTokenId` is populated only
             // by the resolved v4 card-grant authority; legacy credential-file calls
@@ -629,6 +667,23 @@ export function createCliCheckoutEngine(deps = {}) {
                     ...noCredentialFacts,
                 };
             }
+            let resolveAttempt;
+            let rejectAttempt;
+            const sharedResult = new Promise((resolve, reject) => {
+                resolveAttempt = resolve;
+                rejectAttempt = reject;
+            });
+            // The first caller still receives the direct execution result below; this
+            // retained promise exists for overlapping and bounded late duplicates.
+            // Mark its rejection handled even when there is no duplicate consumer.
+            void sharedResult.catch(() => undefined);
+            payAttempts.set(input.reviewId, { fingerprint, promise: sharedResult });
+            let completedAttempt;
+            const finishAttempt = (result) => {
+                completedAttempt = result;
+                resolveAttempt(result);
+                return result;
+            };
             clearTimeout(session.cleanupTimer);
             try {
                 // NO instrument read here. A tap-free mandate draw spends `covering
@@ -672,7 +727,7 @@ export function createCliCheckoutEngine(deps = {}) {
                     const verdictSeam = cardDrawVerdict;
                     const capability = verdictSeam?.loadCapability(covering.agentJkt) ?? null;
                     if (!capability || !verdictSeam) {
-                        return {
+                        return finishAttempt({
                             outcome: 'failed',
                             confirmationRef: null,
                             receiptPath: null,
@@ -682,10 +737,10 @@ export function createCliCheckoutEngine(deps = {}) {
                             source,
                             remainingMinor: null,
                             ...noCredentialFacts,
-                        };
+                        });
                     }
                     if (covering.agentJkt && capability.agentJkt !== covering.agentJkt) {
-                        return {
+                        return finishAttempt({
                             outcome: 'failed',
                             confirmationRef: null,
                             receiptPath: null,
@@ -695,7 +750,7 @@ export function createCliCheckoutEngine(deps = {}) {
                             source,
                             remainingMinor: null,
                             ...noCredentialFacts,
-                        };
+                        });
                     }
                     // VgsLiveInstrument mints against an EXISTING intent (the mandate) with
                     // no fresh assurance — exactly the draw semantics. The fetchCredential
@@ -803,7 +858,7 @@ export function createCliCheckoutEngine(deps = {}) {
                     // registration and non-budget mint tokens at verification; this
                     // client refusal exists to give the honest remedy up front instead
                     // of a mid-flow server error.
-                    return {
+                    return finishAttempt({
                         outcome: 'failed',
                         confirmationRef: null,
                         receiptPath: null,
@@ -821,7 +876,7 @@ export function createCliCheckoutEngine(deps = {}) {
                         source: null,
                         remainingMinor: null,
                         ...noCredentialFacts,
-                    };
+                    });
                 }
                 const mode = input.submit ? 'submit' : 'dry-run';
                 const result = await submitApprovedCheckout(input.reviewId, {
@@ -875,7 +930,7 @@ export function createCliCheckoutEngine(deps = {}) {
                 }));
                 if (report.written)
                     receiptPath = report.path;
-                return {
+                return finishAttempt({
                     outcome: result.outcome,
                     confirmationRef: result.confirmationRef ?? null,
                     receiptPath,
@@ -887,10 +942,29 @@ export function createCliCheckoutEngine(deps = {}) {
                     credentialIssued: result.credentialLifecycle !== 'not-requested',
                     credentialDisclosed: result.credentialLifecycle === 'partially-exposed' ||
                         result.credentialLifecycle === 'fully-filled',
-                };
+                });
+            }
+            catch (error) {
+                rejectAttempt(error);
+                throw error;
             }
             finally {
                 await closeSession(input.reviewId);
+                if (!completedAttempt ||
+                    completedAttempt.outcome === 'failed' ||
+                    completedAttempt.outcome === 'declined') {
+                    if (payAttempts.get(input.reviewId)?.promise === sharedResult) {
+                        payAttempts.delete(input.reviewId);
+                    }
+                }
+                else {
+                    const expiry = setTimeout(() => {
+                        if (payAttempts.get(input.reviewId)?.promise === sharedResult) {
+                            payAttempts.delete(input.reviewId);
+                        }
+                    }, ttlMs);
+                    expiry.unref?.();
+                }
             }
         },
     };