@violetflux/eslint-plugin-kerros 0.2.4 → 0.3.1

package/dist/index.cjs

@@ -80,6 +80,7 @@ function getTypeServices(context) {
 //#region src/internal/kerros-types.ts
 const markerNames = {
 	externalStoreProvider: "externalStoreProviderMarker",
+	storeGetter: "storeGetterMarker",
 	storeHook: "storeHookMarker",
 	storeInstanceHook: "storeInstanceHookMarker"
 };
@@ -177,11 +178,11 @@ function createKerrosProgramTools(program) {
 		const returnType = checker.getReturnTypeOfSignature(signature);
 		const hookType = getTupleMemberType(returnType, 0, node);
 		if (!hookType || !hasMarker(hookType, "storeHook")) return void 0;
-		const instanceType = getTupleMemberType(returnType, 2, node);
-		if (name === "createStore" && !instanceType) return "createStore";
-		if (name !== "bindStore" || !instanceType) return void 0;
+		const thirdType = getTupleMemberType(returnType, 2, node);
+		if (name === "createStore") return !thirdType || hasMarker(thirdType, "storeGetter") ? "createStore" : void 0;
+		if (name !== "bindStore" || !thirdType) return void 0;
 		const providerType = getTupleMemberType(returnType, 1, node);
-		return providerType && hasMarker(providerType, "externalStoreProvider") && hasMarker(instanceType, "storeInstanceHook") ? "bindStore" : void 0;
+		return providerType && hasMarker(providerType, "externalStoreProvider") && hasMarker(thirdType, "storeInstanceHook") ? "bindStore" : void 0;
 	};
 	/** Test whether a call invokes a nominal Kerros Store Hook. */
 	const isStoreHookCall = (node) => {
@@ -301,10 +302,11 @@ const bindingNaming = createRule({
 	name: "binding-naming",
 	meta: {
 		type: "problem",
-		docs: { description: "Keep Kerros Hook and Provider binding names aligned." },
+		docs: { description: "Keep Kerros Hook, Provider, and getter binding names aligned." },
 		schema: [],
 		messages: {
 			destructureBinding: "Kerros factory results must be destructured.",
+			getterName: "The Store getter must be named getXxx.",
 			hookName: "The Store Hook must be named useXxx.",
 			providerName: "The Provider name must match the Store Hook.",
 			instanceName: "The instance Hook name must match the Store Hook."
@@ -334,12 +336,12 @@ const bindingNaming = createRule({
 			}
 			const hook = getElement(declarator.id, 0);
 			const provider = getElement(declarator.id, 1);
-			const instance = getElement(declarator.id, 2);
+			const third = getElement(declarator.id, 2);
 			const explicitName = kind === "createStore" ? getCreateStoreName(node) : getBindStoreName(node);
 			const hookMatch = hook && /^use(?<name>[A-Z][A-Za-z0-9]*)$/u.exec(hook.name);
 			const providerMatch = provider && /^(?<name>[A-Z][A-Za-z0-9]*)Provider$/u.exec(provider.name);
-			const instanceMatch = instance && /^use(?<name>[A-Z][A-Za-z0-9]*)Instance$/u.exec(instance.name);
-			const inferredName = hookMatch?.groups?.name ?? providerMatch?.groups?.name ?? instanceMatch?.groups?.name;
+			const thirdMatch = third && (kind === "createStore" ? /^get(?<name>[A-Z][A-Za-z0-9]*)$/u.exec(third.name) : /^use(?<name>[A-Z][A-Za-z0-9]*)Instance$/u.exec(third.name));
+			const inferredName = hookMatch?.groups?.name ?? providerMatch?.groups?.name ?? thirdMatch?.groups?.name;
 			const name = explicitName ?? inferredName;
 			if (hook && (!hookMatch || name && hookMatch.groups?.name !== name)) context.report({
 				node: hook,
@@ -349,9 +351,9 @@ const bindingNaming = createRule({
 				node: provider,
 				messageId: "providerName"
 			});
-			if (instance && (!instanceMatch || name && instanceMatch.groups?.name !== name)) context.report({
-				node: instance,
-				messageId: "instanceName"
+			if (third && (!thirdMatch || name && thirdMatch.groups?.name !== name)) context.report({
+				node: third,
+				messageId: kind === "createStore" ? "getterName" : "instanceName"
 			});
 		} };
 	}
@@ -470,32 +472,51 @@ const setMutationMethods = /* @__PURE__ */ new Set([
 	"clear",
 	"delete"
 ]);
-/** Build separate dynamic call-site contexts for one local function. */
-function getFunctionCallSiteContexts(target, edges) {
+/** Build a reusable index that streams dynamic call-site contexts without retaining every path. */
+function createFunctionCallSiteContexts(edges) {
 	const incoming = /* @__PURE__ */ new Map();
 	for (const edge of edges) {
 		const existing = incoming.get(edge.callee) ?? [];
 		existing.push(edge);
 		incoming.set(edge.callee, existing);
 	}
-	const contexts = [];
-	/** Trace callers independently so states from different invocation paths never merge globally. */
-	const trace = (fn, calls, stack) => {
-		const edgesForFunction = incoming.get(fn) ?? [];
-		let advanced = false;
-		for (const edge of edgesForFunction) {
-			if (stack.has(edge.caller)) continue;
-			advanced = true;
-			const nextCalls = new Map(calls);
-			nextCalls.set(fn, edge.site);
-			const nextStack = new Set(stack);
-			nextStack.add(edge.caller);
-			trace(edge.caller, nextCalls, nextStack);
+	/** Visit paths independently while retaining only the current DFS path. */
+	const some = (target, predicate) => {
+		const calls = /* @__PURE__ */ new Map();
+		const active = /* @__PURE__ */ new Set([target]);
+		const frames = [{
+			advanced: false,
+			edges: incoming.get(target) ?? [],
+			fn: target,
+			index: 0
+		}];
+		while (frames.length > 0) {
+			const frame = frames.at(-1);
+			if (!frame) break;
+			const edge = frame.edges[frame.index];
+			if (edge) {
+				frame.index += 1;
+				if (active.has(edge.caller)) continue;
+				frame.advanced = true;
+				calls.set(frame.fn, edge.site);
+				active.add(edge.caller);
+				frames.push({
+					advanced: false,
+					edges: incoming.get(edge.caller) ?? [],
+					fn: edge.caller,
+					index: 0,
+					parent: frame.fn
+				});
+				continue;
+			}
+			if (!frame.advanced && predicate(calls)) return true;
+			frames.pop();
+			active.delete(frame.fn);
+			if (frame.parent) calls.delete(frame.parent);
 		}
-		if (!advanced) contexts.push(calls);
+		return false;
 	};
-	trace(target, /* @__PURE__ */ new Map(), /* @__PURE__ */ new Set([target]));
-	return contexts;
+	return { some };
 }
 /** Track assignment sources and resolve definitions that reach a concrete reference point. */
 function createReferenceOriginTracker(program) {
@@ -1479,7 +1500,7 @@ const noRenderInstanceSnapshot = createRule({
 						changed = true;
 					}
 				}
-				const renderedEdges = localEdges.filter((edge) => rendered.has(edge.caller));
+				const callContexts = createFunctionCallSiteContexts(localEdges.filter((edge) => rendered.has(edge.caller)));
 				/** Test whether an expression is a local alias of a Store instance Hook result. */
 				const isInstanceDerived = (input, calls, seen = /* @__PURE__ */ new Set()) => {
 					const node = unwrapExpression(input);
@@ -1512,7 +1533,7 @@ const noRenderInstanceSnapshot = createRule({
 				};
 				for (const snapshot of snapshots) {
 					if (!snapshot.owner || !rendered.has(snapshot.owner)) continue;
-					if (getFunctionCallSiteContexts(snapshot.owner, renderedEdges).some((calls) => {
+					if (callContexts.some(snapshot.owner, (calls) => {
 						return snapshot.kind === "instance" ? isInstanceDerived(snapshot.source, calls) : isSnapshotReaderDerived(snapshot.source, calls);
 					})) context.report({
 						node: snapshot.node,
@@ -1680,9 +1701,10 @@ const noStoreMutation = createRule({
 						site: node
 					});
 				}
-				for (const candidate of candidates) if ((candidate.owner ? getFunctionCallSiteContexts(candidate.owner, localEdges) : [/* @__PURE__ */ new Map()]).some((calls) => {
+				const callContexts = createFunctionCallSiteContexts(localEdges);
+				for (const candidate of candidates) if (candidate.owner ? callContexts.some(candidate.owner, (calls) => {
 					return isSnapshotDerived(candidate.expression, maxAliasDepth, /* @__PURE__ */ new Set(), calls);
-				})) context.report({
+				}) : isSnapshotDerived(candidate.expression, maxAliasDepth, /* @__PURE__ */ new Set(), /* @__PURE__ */ new Map())) context.report({
 					node: candidate.node,
 					messageId: "mutation"
 				});
@@ -2449,7 +2471,7 @@ const rules = {
 const plugin = {
 	meta: {
 		name: "@violetflux/eslint-plugin-kerros",
-		version: "0.2.4"
+		version: "0.3.1"
 	},
 	rules
 };

package/dist/index.mjs

@@ -52,6 +52,7 @@ function getTypeServices(context) {
 //#region src/internal/kerros-types.ts
 const markerNames = {
 	externalStoreProvider: "externalStoreProviderMarker",
+	storeGetter: "storeGetterMarker",
 	storeHook: "storeHookMarker",
 	storeInstanceHook: "storeInstanceHookMarker"
 };
@@ -149,11 +150,11 @@ function createKerrosProgramTools(program) {
 		const returnType = checker.getReturnTypeOfSignature(signature);
 		const hookType = getTupleMemberType(returnType, 0, node);
 		if (!hookType || !hasMarker(hookType, "storeHook")) return void 0;
-		const instanceType = getTupleMemberType(returnType, 2, node);
-		if (name === "createStore" && !instanceType) return "createStore";
-		if (name !== "bindStore" || !instanceType) return void 0;
+		const thirdType = getTupleMemberType(returnType, 2, node);
+		if (name === "createStore") return !thirdType || hasMarker(thirdType, "storeGetter") ? "createStore" : void 0;
+		if (name !== "bindStore" || !thirdType) return void 0;
 		const providerType = getTupleMemberType(returnType, 1, node);
-		return providerType && hasMarker(providerType, "externalStoreProvider") && hasMarker(instanceType, "storeInstanceHook") ? "bindStore" : void 0;
+		return providerType && hasMarker(providerType, "externalStoreProvider") && hasMarker(thirdType, "storeInstanceHook") ? "bindStore" : void 0;
 	};
 	/** Test whether a call invokes a nominal Kerros Store Hook. */
 	const isStoreHookCall = (node) => {
@@ -273,10 +274,11 @@ const bindingNaming = createRule({
 	name: "binding-naming",
 	meta: {
 		type: "problem",
-		docs: { description: "Keep Kerros Hook and Provider binding names aligned." },
+		docs: { description: "Keep Kerros Hook, Provider, and getter binding names aligned." },
 		schema: [],
 		messages: {
 			destructureBinding: "Kerros factory results must be destructured.",
+			getterName: "The Store getter must be named getXxx.",
 			hookName: "The Store Hook must be named useXxx.",
 			providerName: "The Provider name must match the Store Hook.",
 			instanceName: "The instance Hook name must match the Store Hook."
@@ -306,12 +308,12 @@ const bindingNaming = createRule({
 			}
 			const hook = getElement(declarator.id, 0);
 			const provider = getElement(declarator.id, 1);
-			const instance = getElement(declarator.id, 2);
+			const third = getElement(declarator.id, 2);
 			const explicitName = kind === "createStore" ? getCreateStoreName(node) : getBindStoreName(node);
 			const hookMatch = hook && /^use(?<name>[A-Z][A-Za-z0-9]*)$/u.exec(hook.name);
 			const providerMatch = provider && /^(?<name>[A-Z][A-Za-z0-9]*)Provider$/u.exec(provider.name);
-			const instanceMatch = instance && /^use(?<name>[A-Z][A-Za-z0-9]*)Instance$/u.exec(instance.name);
-			const inferredName = hookMatch?.groups?.name ?? providerMatch?.groups?.name ?? instanceMatch?.groups?.name;
+			const thirdMatch = third && (kind === "createStore" ? /^get(?<name>[A-Z][A-Za-z0-9]*)$/u.exec(third.name) : /^use(?<name>[A-Z][A-Za-z0-9]*)Instance$/u.exec(third.name));
+			const inferredName = hookMatch?.groups?.name ?? providerMatch?.groups?.name ?? thirdMatch?.groups?.name;
 			const name = explicitName ?? inferredName;
 			if (hook && (!hookMatch || name && hookMatch.groups?.name !== name)) context.report({
 				node: hook,
@@ -321,9 +323,9 @@ const bindingNaming = createRule({
 				node: provider,
 				messageId: "providerName"
 			});
-			if (instance && (!instanceMatch || name && instanceMatch.groups?.name !== name)) context.report({
-				node: instance,
-				messageId: "instanceName"
+			if (third && (!thirdMatch || name && thirdMatch.groups?.name !== name)) context.report({
+				node: third,
+				messageId: kind === "createStore" ? "getterName" : "instanceName"
 			});
 		} };
 	}
@@ -442,32 +444,51 @@ const setMutationMethods = /* @__PURE__ */ new Set([
 	"clear",
 	"delete"
 ]);
-/** Build separate dynamic call-site contexts for one local function. */
-function getFunctionCallSiteContexts(target, edges) {
+/** Build a reusable index that streams dynamic call-site contexts without retaining every path. */
+function createFunctionCallSiteContexts(edges) {
 	const incoming = /* @__PURE__ */ new Map();
 	for (const edge of edges) {
 		const existing = incoming.get(edge.callee) ?? [];
 		existing.push(edge);
 		incoming.set(edge.callee, existing);
 	}
-	const contexts = [];
-	/** Trace callers independently so states from different invocation paths never merge globally. */
-	const trace = (fn, calls, stack) => {
-		const edgesForFunction = incoming.get(fn) ?? [];
-		let advanced = false;
-		for (const edge of edgesForFunction) {
-			if (stack.has(edge.caller)) continue;
-			advanced = true;
-			const nextCalls = new Map(calls);
-			nextCalls.set(fn, edge.site);
-			const nextStack = new Set(stack);
-			nextStack.add(edge.caller);
-			trace(edge.caller, nextCalls, nextStack);
+	/** Visit paths independently while retaining only the current DFS path. */
+	const some = (target, predicate) => {
+		const calls = /* @__PURE__ */ new Map();
+		const active = /* @__PURE__ */ new Set([target]);
+		const frames = [{
+			advanced: false,
+			edges: incoming.get(target) ?? [],
+			fn: target,
+			index: 0
+		}];
+		while (frames.length > 0) {
+			const frame = frames.at(-1);
+			if (!frame) break;
+			const edge = frame.edges[frame.index];
+			if (edge) {
+				frame.index += 1;
+				if (active.has(edge.caller)) continue;
+				frame.advanced = true;
+				calls.set(frame.fn, edge.site);
+				active.add(edge.caller);
+				frames.push({
+					advanced: false,
+					edges: incoming.get(edge.caller) ?? [],
+					fn: edge.caller,
+					index: 0,
+					parent: frame.fn
+				});
+				continue;
+			}
+			if (!frame.advanced && predicate(calls)) return true;
+			frames.pop();
+			active.delete(frame.fn);
+			if (frame.parent) calls.delete(frame.parent);
 		}
-		if (!advanced) contexts.push(calls);
+		return false;
 	};
-	trace(target, /* @__PURE__ */ new Map(), /* @__PURE__ */ new Set([target]));
-	return contexts;
+	return { some };
 }
 /** Track assignment sources and resolve definitions that reach a concrete reference point. */
 function createReferenceOriginTracker(program) {
@@ -1451,7 +1472,7 @@ const noRenderInstanceSnapshot = createRule({
 						changed = true;
 					}
 				}
-				const renderedEdges = localEdges.filter((edge) => rendered.has(edge.caller));
+				const callContexts = createFunctionCallSiteContexts(localEdges.filter((edge) => rendered.has(edge.caller)));
 				/** Test whether an expression is a local alias of a Store instance Hook result. */
 				const isInstanceDerived = (input, calls, seen = /* @__PURE__ */ new Set()) => {
 					const node = unwrapExpression(input);
@@ -1484,7 +1505,7 @@ const noRenderInstanceSnapshot = createRule({
 				};
 				for (const snapshot of snapshots) {
 					if (!snapshot.owner || !rendered.has(snapshot.owner)) continue;
-					if (getFunctionCallSiteContexts(snapshot.owner, renderedEdges).some((calls) => {
+					if (callContexts.some(snapshot.owner, (calls) => {
 						return snapshot.kind === "instance" ? isInstanceDerived(snapshot.source, calls) : isSnapshotReaderDerived(snapshot.source, calls);
 					})) context.report({
 						node: snapshot.node,
@@ -1652,9 +1673,10 @@ const noStoreMutation = createRule({
 						site: node
 					});
 				}
-				for (const candidate of candidates) if ((candidate.owner ? getFunctionCallSiteContexts(candidate.owner, localEdges) : [/* @__PURE__ */ new Map()]).some((calls) => {
+				const callContexts = createFunctionCallSiteContexts(localEdges);
+				for (const candidate of candidates) if (candidate.owner ? callContexts.some(candidate.owner, (calls) => {
 					return isSnapshotDerived(candidate.expression, maxAliasDepth, /* @__PURE__ */ new Set(), calls);
-				})) context.report({
+				}) : isSnapshotDerived(candidate.expression, maxAliasDepth, /* @__PURE__ */ new Set(), /* @__PURE__ */ new Map())) context.report({
 					node: candidate.node,
 					messageId: "mutation"
 				});
@@ -2421,7 +2443,7 @@ const rules = {
 const plugin = {
 	meta: {
 		name: "@violetflux/eslint-plugin-kerros",
-		version: "0.2.4"
+		version: "0.3.1"
 	},
 	rules
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@violetflux/eslint-plugin-kerros",
-  "version": "0.2.4",
+  "version": "0.3.1",
   "description": "Type-aware ESLint rules for Kerros stores.",
   "repository": {
     "type": "git",
@@ -35,7 +35,7 @@
   },
   "peerDependencies": {
     "@typescript-eslint/parser": "^8.0.0",
-    "@violetflux/kerros": "^0.2.4",
+    "@violetflux/kerros": "^0.3.0",
     "eslint": "^9.0.0 || ^10.0.0",
     "typescript": "^5.0.0 || >=6.0.0 <6.1.0"
   },