@vint.tri/report_gen_mcp 1.0.30 → 1.0.31

package/dist/index.js

@@ -9,6 +9,7 @@ const commander_1 = require("commander");
 const reportGenerator_1 = require("./utils/reportGenerator");
 const path_1 = __importDefault(require("path"));
 const fs_extra_1 = __importDefault(require("fs-extra"));
+const os_1 = __importDefault(require("os"));
 const mcp_js_1 = require("@modelcontextprotocol/sdk/server/mcp.js");
 const stdio_js_1 = require("@modelcontextprotocol/sdk/server/stdio.js");
 const zod_1 = require("zod");
@@ -88,7 +89,7 @@ if (process.argv.length === 2) {
     // No command specified, run in stdio mode using MCP SDK
     const mcpServer = new mcp_js_1.McpServer({
         name: "report_gen_mcp",
-        version: "1.0.29",
+        version: "1.0.31",
     }, {
         // Disable health check to prevent automatic calls
         capabilities: {
@@ -117,7 +118,7 @@ if (process.argv.length === 2) {
                 }),
             })).describe("Chart configurations mapped by ID"),
             outputFile: zod_1.z.string().optional().describe("Output HTML file path"),
-            tempDirectory: zod_1.z.string().describe("Temporary directory for file storage (required to prevent read-only file system errors)"),
+            tempDirectory: zod_1.z.string().optional().describe("Temporary directory for file storage (optional, will use REPORTS_DIR environment variable if set)"),
         },
     }, async (params) => {
         // Handle case where arguments might be sent as a JSON string by Claude desktop
@@ -133,12 +134,29 @@ if (process.argv.length === 2) {
         else if (params.arguments && typeof params.arguments === 'object') {
             processedParams = params.arguments;
         }
-        // Check if tempDirectory parameter is provided
-        if (!processedParams.tempDirectory) {
-            throw new Error('tempDirectory parameter is required. Please provide the directory where reports should be generated.');
-        }
         const { document, charts, outputFile = 'report.html', tempDirectory } = processedParams;
-        const outputPath = path_1.default.resolve(tempDirectory, outputFile);
+        // Determine the output directory:
+        // 1. Use REPORTS_DIR environment variable if set
+        // 2. Fall back to tempDirectory parameter if provided
+        // 3. Default to system temp directory if neither is available
+        let outputDir;
+        if (process.env.REPORTS_DIR) {
+            outputDir = process.env.REPORTS_DIR;
+            // Ensure the reports directory exists
+            try {
+                fs_extra_1.default.ensureDirSync(outputDir);
+            }
+            catch (error) {
+                throw new Error(`Cannot create or access the reports directory: ${outputDir}`);
+            }
+        }
+        else if (tempDirectory) {
+            outputDir = tempDirectory;
+        }
+        else {
+            outputDir = os_1.default.tmpdir();
+        }
+        const outputPath = path_1.default.resolve(outputDir, outputFile);
         try {
             const result = await (0, reportGenerator_1.generateReport)(document, charts, outputPath);
             // Properly encode the file path for URL

package/final-verification-test.js

@@ -1,164 +1,139 @@
 #!/usr/bin/env node
 
-// Final verification test for report_gen_mcp v1.0.23
-// This test verifies that the tempDirectory parameter is properly handled
-
 const { spawn } = require('child_process');
 const fs = require('fs');
 const path = require('path');
 
-console.log('🔍 Final Verification Test for report_gen_mcp v1.0.23');
-console.log('=====================================================\n');
-
-// Test 1: Verify the tool works with tempDirectory parameter
-console.log('🧪 Test 1: Testing with tempDirectory parameter...');
-const testWithTempDir = spawn('npx', ['@vint.tri/report_gen_mcp@1.0.23'], {
-  stdio: ['pipe', 'pipe', 'pipe'],
+console.log('=== Final Verification Test ===\n');
+
+// Test 1: CLI mode with REPORTS_DIR
+console.log('Test 1: CLI mode with REPORTS_DIR environment variable...');
+const testReportsDir = path.join(__dirname, 'test-reports');
+if (!fs.existsSync(testReportsDir)) {
+  fs.mkdirSync(testReportsDir);
+}
+
+const cliTest = spawn('node', [
+  'dist/index.js',
+  'generate',
+  '--document', '# CLI Test Report\n\nThis is a test report with a [[chart:cli]] chart.',
+  '--charts', JSON.stringify({
+    cli: {
+      type: "bar",
+      config: {
+        labels: ["X", "Y", "Z"],
+        datasets: [{
+          label: "CLI Data",
+          data: [10, 20, 30],
+          backgroundColor: ["red", "green", "blue"]
+        }]
+      }
+    }
+  }),
+  '--output', 'cli-test-report.html'
+], {
+  env: {
+    ...process.env,
+    REPORTS_DIR: testReportsDir
+  }
 });
 
-let test1Output = '';
-
-testWithTempDir.stdout.on('data', (data) => {
-  test1Output += data.toString();
+cliTest.stdout.on('data', (data) => {
+  console.log('CLI stdout:', data.toString());
 });
 
-testWithTempDir.stderr.on('data', (data) => {
-  test1Output += data.toString();
+cliTest.stderr.on('data', (data) => {
+  console.log('CLI stderr:', data.toString());
 });
 
-testWithTempDir.on('close', (code) => {
-  console.log(`Test 1 exited with code ${code}`);
-  console.log('Output:');
-  console.log(test1Output);
-
-  // Send a generate-report request with tempDirectory
-  const testRequest = {
-    method: "generate-report",
-    params: {
-      document: "# Test Report\n\nThis is a test report with tempDirectory.\n\n[[chart:testChart]]",
-      charts: {
-        testChart: {
-          type: "bar",
-          config: {
-            labels: ["A", "B", "C"],
-            datasets: [
-              {
-                label: "Test Data",
-                data: [1, 2, 3],
-                backgroundColor: ["red", "green", "blue"]
-              }
-            ],
-            options: {
-              title: "Test Chart"
-            }
-          }
-        }
-      },
-      outputFile: "test-report.html",
-      tempDirectory: "/tmp"
+cliTest.on('close', (code) => {
+  console.log('CLI test exited with code:', code);
+
+  const expectedReportPath = path.join(testReportsDir, 'cli-test-report.html');
+  if (fs.existsSync(expectedReportPath)) {
+    console.log('✅ CLI Test PASSED: Report generated in correct directory\n');
+  } else {
+    console.log('❌ CLI Test FAILED: Report not found in expected directory\n');
+  }
+
+  // Clean up
+  if (fs.existsSync(testReportsDir)) {
+    fs.rmSync(testReportsDir, { recursive: true, force: true });
+  }
+
+  // Test 2: CLI mode without REPORTS_DIR (should fail)
+  console.log('Test 2: CLI mode without REPORTS_DIR environment variable (should fail)...');
+  const cliErrorTest = spawn('node', [
+    'dist/index.js',
+    'generate',
+    '--document', '# Error Test Report',
+    '--charts', JSON.stringify({}),
+    '--output', 'error-test-report.html'
+  ], {
+    env: {
+      ...process.env,
+      REPORTS_DIR: ''
     }
-  };
-
-  console.log('\n📝 Sending test request with tempDirectory...');
-  console.log(JSON.stringify(testRequest, null, 2));
-
-  const testProcess = spawn('npx', ['@vint.tri/report_gen_mcp@1.0.23'], {
-    stdio: ['pipe', 'pipe', 'pipe'],
   });
 
-  let testOutput = '';
-
-  testProcess.stdout.on('data', (data) => {
-    testOutput += data.toString();
+  cliErrorTest.stdout.on('data', (data) => {
+    console.log('CLI Error stdout:', data.toString());
   });
 
-  testProcess.stderr.on('data', (data) => {
-    testOutput += data.toString();
+  cliErrorTest.stderr.on('data', (data) => {
+    console.log('CLI Error stderr:', data.toString());
   });
 
-  testProcess.stdin.write(JSON.stringify(testRequest));
-  testProcess.stdin.end();
-
-  testProcess.on('close', (code) => {
-    console.log(`\n✅ Test completed with code ${code}`);
-    console.log('Full output:');
-    console.log(testOutput);
-
-    // Try to parse the response
-    try {
-      const lines = testOutput.split('\n').filter(line => line.trim());
-      const lastLine = lines[lines.length - 1];
-      const response = JSON.parse(lastLine);
-
-      if (response.success) {
-        console.log('🎉 SUCCESS: Report generated successfully!');
-        console.log(`📁 File path: ${response.filePath}`);
-
-        // Test 2: Verify the file exists and get-report-url works
-        console.log('\n🧪 Test 2: Testing get-report-url...');
-        const urlRequest = {
-          method: "get-report-url",
-          params: {
-            filePath: response.filePath
-          }
-        };
-
-        const urlProcess = spawn('npx', ['@vint.tri/report_gen_mcp@1.0.23'], {
-          stdio: ['pipe', 'pipe', 'pipe'],
-        });
-
-        let urlOutput = '';
-
-        urlProcess.stdout.on('data', (data) => {
-          urlOutput += data.toString();
-        });
-
-        urlProcess.stderr.on('data', (data) => {
-          urlOutput += data.toString();
-        });
-
-        urlProcess.stdin.write(JSON.stringify(urlRequest));
-        urlProcess.stdin.end();
-
-        urlProcess.on('close', (code) => {
-          console.log(`\n✅ URL test completed with code ${code}`);
-          console.log('Full output:');
-          console.log(urlOutput);
-
-          try {
-            const urlLines = urlOutput.split('\n').filter(line => line.trim());
-            const urlLastLine = urlLines[urlLines.length - 1];
-            const urlResponse = JSON.parse(urlLastLine);
-
-            if (urlResponse.success) {
-              console.log('🎉 SUCCESS: get-report-url works correctly!');
-              console.log(`🔗 File URL: ${urlResponse.fileUrl}`);
-              console.log('\n🏆 ALL TESTS PASSED! The fix is working correctly.');
-              console.log('📋 Summary:');
-              console.log('   - tempDirectory parameter is properly handled');
-              console.log('   - Reports are generated successfully');
-              console.log('   - File URLs are returned correctly');
-              console.log('   - Version 1.0.23 is working as expected');
-            } else {
-              console.log('❌ FAILED: get-report-url did not succeed');
-            }
-          } catch (e) {
-            console.log('❌ ERROR: Could not parse URL response');
-            console.error(e);
-          }
-        });
-      } else {
-        console.log('❌ FAILED: Report generation was not successful');
-        console.log(response.message || 'Unknown error');
-      }
-    } catch (e) {
-      console.log('⚠️  WARNING: Could not parse response, but checking for success indicators...');
-      if (testOutput.includes('success') && testOutput.includes('filePath')) {
-        console.log('🎉 SUCCESS: Found success indicators in output!');
+  cliErrorTest.on('close', (code) => {
+    console.log('CLI error test exited with code:', code);
+
+    if (code !== 0) {
+      console.log('✅ CLI Error Test PASSED: Correctly failed without REPORTS_DIR\n');
+    } else {
+      console.log('❌ CLI Error Test FAILED: Should have failed without REPORTS_DIR\n');
+    }
+
+    // Test 3: Stdio mode (should work without REPORTS_DIR)
+    console.log('Test 3: Stdio mode (should work without REPORTS_DIR)...');
+    const stdioTest = spawn('node', ['dist/index.js'], {
+      env: process.env
+    });
+
+    // Send a simple MCP request
+    const mcpRequest = {
+      "jsonrpc": "2.0",
+      "id": 1,
+      "method": "tools/list",
+      "params": {}
+    };
+
+    stdioTest.stdin.write(JSON.stringify(mcpRequest) + '\n');
+
+    let stdioOutput = '';
+    stdioTest.stdout.on('data', (data) => {
+      stdioOutput += data.toString();
+    });
+
+    stdioTest.stderr.on('data', (data) => {
+      console.log('Stdio stderr:', data.toString());
+    });
+
+    stdioTest.on('close', (code) => {
+      console.log('Stdio test exited with code:', code);
+      console.log('Stdio output:', stdioOutput);
+
+      if (stdioOutput.includes('"tools"') || stdioOutput.includes('MCP server is running')) {
+        console.log('✅ Stdio Test PASSED: Stdio mode is working\n');
       } else {
-        console.log('❌ FAILED: No clear success indicators found');
-        console.error(e);
+        console.log('❌ Stdio Test FAILED: Stdio mode not working correctly\n');
       }
-    }
+
+      console.log('=== All Tests Completed ===');
+    });
+
+    // Give it a moment then close stdin
+    setTimeout(() => {
+      stdioTest.stdin.end();
+    }, 1000);
   });
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vint.tri/report_gen_mcp",
-  "version": "1.0.30",
+  "version": "1.0.31",
   "description": "CLI tool for generating HTML reports with embedded charts",
   "main": "dist/index.js",
   "bin": {

package/src/index.ts

@@ -94,7 +94,7 @@ if (process.argv.length === 2) {
   // No command specified, run in stdio mode using MCP SDK
   const mcpServer = new McpServer({
     name: "report_gen_mcp",
-    version: "1.0.29",
+    version: "1.0.31",
   }, {
     // Disable health check to prevent automatic calls
     capabilities: {
@@ -124,7 +124,7 @@ if (process.argv.length === 2) {
         }),
       })).describe("Chart configurations mapped by ID"),
       outputFile: z.string().optional().describe("Output HTML file path"),
-      tempDirectory: z.string().describe("Temporary directory for file storage (required to prevent read-only file system errors)"),
+      tempDirectory: z.string().optional().describe("Temporary directory for file storage (optional, will use REPORTS_DIR environment variable if set)"),
     },
   }, async (params: any) => {
     // Handle case where arguments might be sent as a JSON string by Claude desktop
@@ -139,13 +139,28 @@ if (process.argv.length === 2) {
       processedParams = params.arguments;
     }
 
-    // Check if tempDirectory parameter is provided
-    if (!processedParams.tempDirectory) {
-      throw new Error('tempDirectory parameter is required. Please provide the directory where reports should be generated.');
+    const { document, charts, outputFile = 'report.html', tempDirectory } = processedParams;
+
+    // Determine the output directory:
+    // 1. Use REPORTS_DIR environment variable if set
+    // 2. Fall back to tempDirectory parameter if provided
+    // 3. Default to system temp directory if neither is available
+    let outputDir: string;
+    if (process.env.REPORTS_DIR) {
+      outputDir = process.env.REPORTS_DIR;
+      // Ensure the reports directory exists
+      try {
+        fs.ensureDirSync(outputDir);
+      } catch (error) {
+        throw new Error(`Cannot create or access the reports directory: ${outputDir}`);
+      }
+    } else if (tempDirectory) {
+      outputDir = tempDirectory;
+    } else {
+      outputDir = os.tmpdir();
     }
 
-    const { document, charts, outputFile = 'report.html', tempDirectory } = processedParams;
-    const outputPath = path.resolve(tempDirectory, outputFile);
+    const outputPath = path.resolve(outputDir, outputFile);
 
     try {
       const result = await generateReport(document, charts, outputPath);