@viewfly/core 1.0.0-alpha.18 → 1.0.0-alpha.19

package/bundles/index.esm.js

@@ -1679,11 +1679,8 @@ function updateNativeNodeProperties(nativeRenderer, newAtom, oldAtom, parentComp
     const changes = getObjectChanges(newVNode.props, oldVNode.props);
     let unBindRefs;
     let bindRefs;
-    newAtom.child = oldAtom.child;
     for (const [key, value] of changes.remove) {
         if (key === 'children') {
-            cleanElementChildren(oldAtom, nativeRenderer);
-            newAtom.child = null;
             continue;
         }
         if (key === 'class') {
@@ -1710,17 +1707,6 @@ function updateNativeNodeProperties(nativeRenderer, newAtom, oldAtom, parentComp
     }
     for (const [key, newValue, oldValue] of changes.replace) {
         if (key === 'children') {
-            newAtom.child = createChildChain(newValue, isSvg);
-            if (!newAtom.child) {
-                cleanElementChildren(oldAtom, nativeRenderer);
-            }
-            else {
-                diff(nativeRenderer, parentComponent, newAtom.child, oldAtom.child, {
-                    host: newAtom.nativeNode,
-                    isParent: true,
-                    rootHost: context.rootHost
-                });
-            }
             continue;
         }
         if (key === 'class') {
@@ -1755,8 +1741,6 @@ function updateNativeNodeProperties(nativeRenderer, newAtom, oldAtom, parentComp
     }
     for (const [key, value] of changes.add) {
         if (key === 'children') {
-            newAtom.child = createChildChain(value, isSvg);
-            buildElementChildren(newAtom, nativeRenderer, parentComponent, context);
             continue;
         }
         if (key === 'class') {
@@ -1782,6 +1766,31 @@ function updateNativeNodeProperties(nativeRenderer, newAtom, oldAtom, parentComp
         }
         nativeRenderer.setProperty(nativeNode, key, value, isSvg);
     }
+    /**
+     * 不能仅依赖 children 是否相等的判断来确定是否要继续向下 diff
+     * 如：
+     * ```tsx
+     * <Comp>
+     *   <div>
+     *     {props.children}
+     *   </div>
+     * </Comp>
+     * ```
+     * 其中当 Comp 产生变化时，children 来自父组件，这时 children 是相等的，
+     * 但，children 内可能有子组件也发生了变化，如果不继续 diff，那么，子组件
+     * 的视图更新将不会发生
+     */
+    newAtom.child = createChildChain(newVNode.props.children, isSvg);
+    if (!newAtom.child) {
+        cleanElementChildren(oldAtom, nativeRenderer);
+    }
+    else {
+        diff(nativeRenderer, parentComponent, newAtom.child, oldAtom.child, {
+            host: newAtom.nativeNode,
+            isParent: true,
+            rootHost: context.rootHost
+        });
+    }
     applyRefs(unBindRefs, nativeNode, false);
     applyRefs(bindRefs, nativeNode, true);
 }

package/bundles/index.js

@@ -1681,11 +1681,8 @@ function updateNativeNodeProperties(nativeRenderer, newAtom, oldAtom, parentComp
     const changes = getObjectChanges(newVNode.props, oldVNode.props);
     let unBindRefs;
     let bindRefs;
-    newAtom.child = oldAtom.child;
     for (const [key, value] of changes.remove) {
         if (key === 'children') {
-            cleanElementChildren(oldAtom, nativeRenderer);
-            newAtom.child = null;
             continue;
         }
         if (key === 'class') {
@@ -1712,17 +1709,6 @@ function updateNativeNodeProperties(nativeRenderer, newAtom, oldAtom, parentComp
     }
     for (const [key, newValue, oldValue] of changes.replace) {
         if (key === 'children') {
-            newAtom.child = createChildChain(newValue, isSvg);
-            if (!newAtom.child) {
-                cleanElementChildren(oldAtom, nativeRenderer);
-            }
-            else {
-                diff(nativeRenderer, parentComponent, newAtom.child, oldAtom.child, {
-                    host: newAtom.nativeNode,
-                    isParent: true,
-                    rootHost: context.rootHost
-                });
-            }
             continue;
         }
         if (key === 'class') {
@@ -1757,8 +1743,6 @@ function updateNativeNodeProperties(nativeRenderer, newAtom, oldAtom, parentComp
     }
     for (const [key, value] of changes.add) {
         if (key === 'children') {
-            newAtom.child = createChildChain(value, isSvg);
-            buildElementChildren(newAtom, nativeRenderer, parentComponent, context);
             continue;
         }
         if (key === 'class') {
@@ -1784,6 +1768,31 @@ function updateNativeNodeProperties(nativeRenderer, newAtom, oldAtom, parentComp
         }
         nativeRenderer.setProperty(nativeNode, key, value, isSvg);
     }
+    /**
+     * 不能仅依赖 children 是否相等的判断来确定是否要继续向下 diff
+     * 如：
+     * ```tsx
+     * <Comp>
+     *   <div>
+     *     {props.children}
+     *   </div>
+     * </Comp>
+     * ```
+     * 其中当 Comp 产生变化时，children 来自父组件，这时 children 是相等的，
+     * 但，children 内可能有子组件也发生了变化，如果不继续 diff，那么，子组件
+     * 的视图更新将不会发生
+     */
+    newAtom.child = createChildChain(newVNode.props.children, isSvg);
+    if (!newAtom.child) {
+        cleanElementChildren(oldAtom, nativeRenderer);
+    }
+    else {
+        diff(nativeRenderer, parentComponent, newAtom.child, oldAtom.child, {
+            host: newAtom.nativeNode,
+            isParent: true,
+            rootHost: context.rootHost
+        });
+    }
     applyRefs(unBindRefs, nativeNode, false);
     applyRefs(bindRefs, nativeNode, true);
 }

package/jsx-dev-runtime/node_modules/.bin/rimraf

@@ -0,0 +1,17 @@
+#!/bin/sh
+basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")
+
+case `uname` in
+    *CYGWIN*) basedir=`cygpath -w "$basedir"`;;
+esac
+
+if [ -z "$NODE_PATH" ]; then
+  export NODE_PATH="/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/rimraf@3.0.2/node_modules/rimraf/node_modules:/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/rimraf@3.0.2/node_modules:/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/node_modules"
+else
+  export NODE_PATH="/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/rimraf@3.0.2/node_modules/rimraf/node_modules:/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/rimraf@3.0.2/node_modules:/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/node_modules:$NODE_PATH"
+fi
+if [ -x "$basedir/node" ]; then
+  exec "$basedir/node"  "$basedir/../rimraf/bin.js" "$@"
+else
+  exec node  "$basedir/../rimraf/bin.js" "$@"
+fi

package/jsx-dev-runtime/node_modules/.bin/rollup

@@ -0,0 +1,17 @@
+#!/bin/sh
+basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")
+
+case `uname` in
+    *CYGWIN*) basedir=`cygpath -w "$basedir"`;;
+esac
+
+if [ -z "$NODE_PATH" ]; then
+  export NODE_PATH="/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/rollup@3.29.4/node_modules/rollup/dist/bin/node_modules:/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/rollup@3.29.4/node_modules/rollup/dist/node_modules:/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/rollup@3.29.4/node_modules/rollup/node_modules:/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/rollup@3.29.4/node_modules:/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/node_modules"
+else
+  export NODE_PATH="/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/rollup@3.29.4/node_modules/rollup/dist/bin/node_modules:/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/rollup@3.29.4/node_modules/rollup/dist/node_modules:/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/rollup@3.29.4/node_modules/rollup/node_modules:/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/rollup@3.29.4/node_modules:/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/node_modules:$NODE_PATH"
+fi
+if [ -x "$basedir/node" ]; then
+  exec "$basedir/node"  "$basedir/../rollup/dist/bin/rollup" "$@"
+else
+  exec node  "$basedir/../rollup/dist/bin/rollup" "$@"
+fi

package/jsx-dev-runtime/node_modules/.bin/tsc

@@ -0,0 +1,17 @@
+#!/bin/sh
+basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")
+
+case `uname` in
+    *CYGWIN*) basedir=`cygpath -w "$basedir"`;;
+esac
+
+if [ -z "$NODE_PATH" ]; then
+  export NODE_PATH="/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/typescript@5.4.5/node_modules/typescript/bin/node_modules:/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/typescript@5.4.5/node_modules/typescript/node_modules:/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/typescript@5.4.5/node_modules:/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/node_modules"
+else
+  export NODE_PATH="/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/typescript@5.4.5/node_modules/typescript/bin/node_modules:/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/typescript@5.4.5/node_modules/typescript/node_modules:/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/typescript@5.4.5/node_modules:/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/node_modules:$NODE_PATH"
+fi
+if [ -x "$basedir/node" ]; then
+  exec "$basedir/node"  "$basedir/../../../../../node_modules/.pnpm/typescript@5.4.5/node_modules/typescript/bin/tsc" "$@"
+else
+  exec node  "$basedir/../../../../../node_modules/.pnpm/typescript@5.4.5/node_modules/typescript/bin/tsc" "$@"
+fi

package/jsx-dev-runtime/node_modules/.bin/tsserver

@@ -0,0 +1,17 @@
+#!/bin/sh
+basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")
+
+case `uname` in
+    *CYGWIN*) basedir=`cygpath -w "$basedir"`;;
+esac
+
+if [ -z "$NODE_PATH" ]; then
+  export NODE_PATH="/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/typescript@5.4.5/node_modules/typescript/bin/node_modules:/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/typescript@5.4.5/node_modules/typescript/node_modules:/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/typescript@5.4.5/node_modules:/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/node_modules"
+else
+  export NODE_PATH="/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/typescript@5.4.5/node_modules/typescript/bin/node_modules:/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/typescript@5.4.5/node_modules/typescript/node_modules:/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/typescript@5.4.5/node_modules:/Users/tanbo/Documents/lib/viewfly/node_modules/.pnpm/node_modules:$NODE_PATH"
+fi
+if [ -x "$basedir/node" ]; then
+  exec "$basedir/node"  "$basedir/../../../../../node_modules/.pnpm/typescript@5.4.5/node_modules/typescript/bin/tsserver" "$@"
+else
+  exec node  "$basedir/../../../../../node_modules/.pnpm/typescript@5.4.5/node_modules/typescript/bin/tsserver" "$@"
+fi

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@viewfly/core",
-  "version": "1.0.0-alpha.18",
+  "version": "1.0.0-alpha.19",
   "description": "Viewfly is a simple and easy-to-use JavaScript framework with an intuitive development experience.",
   "main": "./bundles/index.js",
   "module": "./bundles/index.esm.js",
@@ -50,7 +50,7 @@
   "bugs": {
     "url": "https://github.com/viewfly/viewfly.git/issues"
   },
-  "gitHead": "b66ca589f7662cd518fc2e5955b3e3ff9de83f94",
+  "gitHead": "447225f74fc666916194372ba5f710a94c297541",
   "dependencies": {
     "reflect-metadata": "^0.2.2"
   }