@vibesdotdev/pm 0.0.0-stage → 1.0.0-rc.3

package/dist/daemon/liveness-checker.js

@@ -0,0 +1,330 @@
+/**
+ * Liveness Checker
+ * Detects processes killed externally and handles auto-restart
+ */
+import { attempt } from "../utils/attempt.js";
+import { processExitOf } from "../schemas/process.js";
+import { checkProcessLiveness, ownsLivePid } from "../utils/liveness.js";
+import { killProcessTree, verifyProcessOwnership } from "../utils/process-tree.js";
+import { valueFreeFailure } from '@vibesdotdev/kernel';
+import { getPMDaemonLogger } from "../utils/logging.js";
+import { mayRestart, processRestartPolicy, readSupervision } from "../services/supervision-policy.js";
+/** Liveness ticks a live process's socket may refuse connections before PM kills it. */
+const UNRESPONSIVE_TICKS_BEFORE_KILL = 3;
+/**
+ * Checks liveness of running processes and handles externally killed processes
+ */
+export class LivenessChecker {
+    deps;
+    crashLogIntervalMs;
+    // Track last log time for crashed processes to avoid spam
+    lastCrashLogTime = new Map();
+    // Consecutive ticks a live process's socket has refused connections
+    unresponsiveTicks = new Map();
+    /**
+     * The pid of each process's run that has answered at least once (its socket
+     * connected on a tick, or its health check passed). An unresponsive socket
+     * is escalated only for such a run: one that has never answered is still
+     * starting, and startup is the health monitor's call (warm-up and grace).
+     * Forgotten on a daemon restart, which only defers a kill, never adds one.
+     */
+    answered = new Map();
+    /** The daemon runtime's Logging, read per entry so it follows hot-reload generations (C083a). */
+    get logger() {
+        return getPMDaemonLogger(this.deps.getRuntime(), 'global').child('liveness');
+    }
+    constructor(deps) {
+        this.deps = deps;
+        this.crashLogIntervalMs = deps.crashLogIntervalMs ?? 60 * 1000;
+    }
+    /**
+     * Run liveness checks on all running processes
+     * Detects processes killed externally and updates their state
+     */
+    async runLivenessChecks() {
+        const states = await this.deps.pm.getAllStatus();
+        for (const state of states) {
+            // Check processes marked as running OR crashed (to clean up orphaned PIDs)
+            if (state.status !== 'running' && state.status !== 'crashed') {
+                continue;
+            }
+            // Use unified liveness checker to verify actual state
+            const checked = await attempt(() => this.checkState(state));
+            if (!checked.ok) {
+                this.logger.error('failed to check liveness', {
+                    processId: state.id,
+                    failure: valueFreeFailure(checked.failure)
+                });
+            }
+        }
+    }
+    /** One running or crashed state, checked against its liveness (a failure is the caller's to report). */
+    async checkState(state) {
+        const generation = state.startedAt?.getTime();
+        const sameObservation = (current) => current.status === state.status && current.pid === state.pid &&
+            current.startedAt?.getTime() === generation;
+        if (generation !== undefined && processExitOf(state) && (await this.deps.store.taskObligations(state.id)).some(entry => entry.startedAt === generation))
+            return;
+        const livenessResult = await checkProcessLiveness(this.deps.getRuntime(), state);
+        const observed = await this.deps.store.get(state.id);
+        if (!observed || !sameObservation(observed))
+            return;
+        if (state.pid !== undefined && (livenessResult.details.socketConnectable === true || state.healthStatus === 'healthy')) {
+            this.answered.set(state.id, state.pid);
+        }
+        if (!livenessResult.alive) {
+            // Rate-limit logging for already-crashed processes
+            const now = Date.now();
+            const lastLogTime = this.lastCrashLogTime.get(state.id) || 0;
+            const shouldLog = state.status !== 'crashed' || now - lastLogTime >= this.crashLogIntervalMs;
+            // Determine if this was a crash with stale socket
+            const isStaleSocket = livenessResult.details.socketExists && !livenessResult.details.socketConnectable;
+            // A socket that is missing or refuses a connect while its owner
+            // process is alive is unresponsive (booting or busy), not dead.
+            // Unlinking it strands a live daemon and a restart spawns a
+            // duplicate its serve pre-check turns away. Leave it through the
+            // declared health warm-up and a grace window; past that, kill the
+            // owned tree before the crash path cleans up and restarts.
+            const ownerConfig = state.pid ? await this.deps.pm.getConfig(state.id) : undefined;
+            if (livenessResult.details.socketConnectable === false &&
+                state.pid &&
+                (await ownsLivePid(this.deps.getRuntime(), state, ownerConfig))) {
+                const warmupMs = ownerConfig?.healthCheck?.warmupMs ?? 0;
+                const startedAt = state.startedAt?.getTime();
+                if (startedAt !== undefined && now - startedAt < warmupMs) {
+                    this.logger.debug('socket not answering during warm-up; leaving it', {
+                        processId: state.id,
+                        pid: state.pid,
+                        warmupMs
+                    });
+                    return;
+                }
+                if (this.answered.get(state.id) !== state.pid) {
+                    this.unresponsiveTicks.delete(state.id);
+                    this.logger.debug('socket has not answered yet this run; its startup is the health monitor\'s call', {
+                        processId: state.id,
+                        pid: state.pid
+                    });
+                    return;
+                }
+                const ticks = (this.unresponsiveTicks.get(state.id) ?? 0) + 1;
+                this.unresponsiveTicks.set(state.id, ticks);
+                if (ticks < UNRESPONSIVE_TICKS_BEFORE_KILL) {
+                    this.logger.warn('socket unresponsive while its process is alive; leaving it', {
+                        processId: state.id,
+                        pid: state.pid,
+                        tick: ticks,
+                        killAfterTicks: UNRESPONSIVE_TICKS_BEFORE_KILL
+                    });
+                    return;
+                }
+                this.logger.warn('socket stayed unresponsive; killing the owned process before restart', {
+                    processId: state.id,
+                    pid: state.pid,
+                    ticks
+                });
+                await killProcessTree(this.deps.getRuntime(), state.pid, state.id);
+                // PM's exit handler is the single writer of this run's terminal record
+                // and decides its restart through the restart policy. A child PM holds no
+                // handle for is seen dead on the next tick and handled below.
+                this.unresponsiveTicks.delete(state.id);
+                this.answered.delete(state.id);
+                return;
+            }
+            this.unresponsiveTicks.delete(state.id);
+            // Only log if this is a new crash or enough time has passed
+            if (shouldLog) {
+                const statusMsg = state.status === 'crashed' ? 'crashed' : 'running';
+                this.logger.warn('liveness check failed', {
+                    processId: state.id,
+                    status: statusMsg,
+                    reason: livenessResult.details.reason
+                });
+                this.lastCrashLogTime.set(state.id, now);
+            }
+            if (isStaleSocket) {
+                // Process crashed or was killed externally, leaving socket behind
+                // Only log on first detection or rate-limited interval
+                if (shouldLog) {
+                    this.logger.warn('stale socket detected', {
+                        processId: state.id,
+                        socketPath: state.socketPath
+                    });
+                }
+                // Try to cleanup the socket (may fail if another process holds it)
+                const cleaned = await attempt(() => this.deps.pm.cleanupSocket(state.id));
+                // Socket cleanup can fail if another process (e.g., cloud worker) holds it open
+                if (!cleaned.ok && shouldLog) {
+                    this.logger.warn('could not cleanup socket', {
+                        processId: state.id,
+                        failure: valueFreeFailure(cleaned.failure)
+                    });
+                }
+            }
+            // Issue 3 hardening: only update state when the OBSERVABLE state
+            // has changed. The previous diff used `!state.staleSocket !==
+            // !isStaleSocket` which is correct in isolation, but the
+            // surrounding update also rewrote `lastError` and `stoppedAt`
+            // on every tick — and once status had flipped to 'stopped',
+            // any subsequent transient that re-marked it 'crashed' (e.g.
+            // orphan-scanner, health-monitor) would trigger the same
+            // log line on the next liveness tick. Normalize both sides
+            // to a canonical boolean and compare ALL fields we touch
+            // before writing, then only log when something actually
+            // transitioned.
+            const newStatus = isStaleSocket ? 'crashed' : 'stopped';
+            const newStaleSocket = Boolean(isStaleSocket);
+            const oldStaleSocket = Boolean(state.staleSocket);
+            const statusChanged = state.status !== newStatus;
+            const staleSocketChanged = oldStaleSocket !== newStaleSocket;
+            if (statusChanged || staleSocketChanged) {
+                // Only refresh stoppedAt / lastError on the first
+                // transition into a terminal state. Re-writing these on
+                // every tick made the row appear to "change" downstream
+                // even when the semantic state was identical.
+                const flags = { status: newStatus, staleSocket: newStaleSocket };
+                const update = statusChanged
+                    ? {
+                        ...flags,
+                        stoppedAt: new Date(),
+                        lastError: `Process terminated externally: ${livenessResult.details.reason}`
+                    }
+                    : flags;
+                if (!(await this.deps.store.updateWhen(state.id, update, sameObservation)))
+                    return;
+                if (statusChanged) {
+                    this.logger.warn('updated process state from liveness', {
+                        processId: state.id,
+                        fromStatus: state.status,
+                        toStatus: newStatus,
+                        staleSocket: newStaleSocket,
+                        reason: livenessResult.details.reason
+                    });
+                }
+                else {
+                    // staleSocket flipped but status didn't — keep this
+                    // at debug, it's a low-signal field-only change.
+                    this.logger.debug('liveness updated staleSocket flag', {
+                        processId: state.id,
+                        status: newStatus,
+                        staleSocket: newStaleSocket
+                    });
+                }
+            }
+            // Check if process should be auto-restarted
+            // CRITICAL: Do not restart if user intentionally stopped the process
+            const currentState = await this.deps.store.get(state.id);
+            if (!currentState || currentState.pid !== state.pid || currentState.startedAt?.getTime() !== generation)
+                return;
+            if (currentState?.status === 'stopping' || currentState?.status === 'stopped') {
+                this.logger.debug('Process intentionally stopped, skipping liveness auto-restart', {
+                    processId: state.id,
+                    status: currentState?.status
+                });
+                return;
+            }
+            if (currentState.status !== 'crashed')
+                return;
+            const config = await this.deps.pm.getConfig(state.id);
+            if (config?.autoRestart) {
+                // The lifecycle's own restart policy and consecutive-crash budget, never
+                // the lifetime restart count: the same decision the exit handler makes.
+                const policy = processRestartPolicy(await readSupervision(this.deps.getRuntime()), config);
+                const attemptNumber = (currentState?.consecutiveCrashRestarts ?? 0) + 1;
+                const maxRestarts = policy.maxConsecutive;
+                if (mayRestart(policy, attemptNumber)) {
+                    this.logger.warn('auto restarting externally terminated process', {
+                        processId: state.id,
+                        attempt: attemptNumber,
+                        maxRestarts
+                    });
+                    const changed = await this.deps.store.updateWhen(state.id, { consecutiveCrashRestarts: attemptNumber }, current => current.status === currentState.status && current.pid === currentState.pid && current.startedAt?.getTime() === generation);
+                    if (!changed)
+                        return;
+                    const restarted = await attempt(() => this.deps.pm.restart(state.id, { resetRestartCount: false }, { expectedPid: state.pid }));
+                    if (!restarted.ok) {
+                        this.logger.error('failed to restart externally terminated process', {
+                            processId: state.id,
+                            failure: valueFreeFailure(restarted.failure)
+                        });
+                    }
+                }
+                else {
+                    this.logger.warn('max restarts exceeded; not restarting', {
+                        processId: state.id,
+                        attempt: attemptNumber,
+                        maxRestarts
+                    });
+                }
+            }
+        }
+        else if (state.status === 'crashed' && livenessResult.alive) {
+            // ORPHANED PROCESS DETECTED!
+            // Process is marked as crashed but actually still running
+            // This happens when restart attempts fail but the original process is still alive
+            // CRITICAL FIX: Verify PID ownership before killing
+            // The PID might have been reused by an unrelated process
+            if (state.pid && livenessResult.details.pidAlive) {
+                const config = await this.deps.pm.getConfig(state.id);
+                const verifyTokens = config
+                    ? [config.command, ...(config.args || [])].filter(Boolean)
+                    : [state.id];
+                const ownership = await verifyProcessOwnership(this.deps.getRuntime(), state.pid, state.id, verifyTokens);
+                if (ownership.owned) {
+                    // PID belongs to our process - kill it
+                    this.logger.warn('orphaned process detected', {
+                        processId: state.id,
+                        pid: state.pid
+                    });
+                    const orphanPid = state.pid;
+                    const killed = await attempt(() => killProcessTree(this.deps.getRuntime(), orphanPid, state.id));
+                    if (killed.ok) {
+                        this.logger.info('killed orphaned process tree', {
+                            processId: state.id,
+                            pid: state.pid
+                        });
+                    }
+                    else {
+                        this.logger.error('failed to kill orphaned process', {
+                            processId: state.id,
+                            pid: state.pid,
+                            failure: valueFreeFailure(killed.failure)
+                        });
+                    }
+                }
+                else {
+                    // PID was reused by different process - just clear our state
+                    this.logger.warn('pid reused by different process; clearing state', {
+                        processId: state.id,
+                        pid: state.pid
+                    });
+                }
+            }
+            // Cleanup any stale socket
+            if (state.socketPath) {
+                await this.deps.pm.cleanupSocket(state.id);
+            }
+            // Update state to reflect cleanup — only on TRANSITION. A row that
+            // keeps re-qualifying (e.g. a socket held by a foreign process) was
+            // rewritten every 10s tick forever, churning the store's WAL.
+            const alreadyCleaned = state.pid === undefined &&
+                state.lastError === 'Orphaned process detected and cleaned up';
+            if (!alreadyCleaned) {
+                await this.deps.store.updateWhen(state.id, {
+                    pid: undefined,
+                    stoppedAt: new Date(),
+                    lastActivity: new Date(),
+                    lastError: 'Orphaned process detected and cleaned up'
+                }, sameObservation);
+            }
+        }
+    }
+    /**
+     * Clear tracking state (used during shutdown)
+     */
+    clearTracking() {
+        this.lastCrashLogTime.clear();
+        this.unresponsiveTicks.clear();
+    }
+}
+//# sourceMappingURL=liveness-checker.js.map

package/dist/daemon/liveness-checker.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"liveness-checker.js","sourceRoot":"","sources":["../../src/daemon/liveness-checker.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAEH,OAAO,EAAE,OAAO,EAAE,MAAM,qBAAqB,CAAC;AAG9C,OAAO,EAAE,aAAa,EAAqB,MAAM,uBAAuB,CAAC;AACzE,OAAO,EAAE,oBAAoB,EAAE,WAAW,EAAE,MAAM,sBAAsB,CAAC;AACzE,OAAO,EAAE,eAAe,EAAE,sBAAsB,EAAE,MAAM,0BAA0B,CAAC;AAEnF,OAAO,EAAE,gBAAgB,EAAmB,MAAM,qBAAqB,CAAC;AACxE,OAAO,EAAE,iBAAiB,EAAE,MAAM,qBAAqB,CAAC;AACxD,OAAO,EAAE,UAAU,EAAE,oBAAoB,EAAE,eAAe,EAAE,MAAM,mCAAmC,CAAC;AAGtG,wFAAwF;AACxF,MAAM,8BAA8B,GAAG,CAAC,CAAC;AAazC;;GAEG;AACH,MAAM,OAAO,eAAe;IACnB,IAAI,CAAsB;IACjB,kBAAkB,CAAS;IAE5C,0DAA0D;IAClD,gBAAgB,GAAwB,IAAI,GAAG,EAAE,CAAC;IAE1D,oEAAoE;IAC5D,iBAAiB,GAAwB,IAAI,GAAG,EAAE,CAAC;IAE3D;;;;;;OAMG;IACc,QAAQ,GAAG,IAAI,GAAG,EAAkB,CAAC;IAGtD,iGAAiG;IACjG,IAAY,MAAM;QACjB,OAAO,iBAAiB,CAAC,IAAI,CAAC,IAAI,CAAC,UAAU,EAAE,EAAE,QAAQ,CAAC,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC;IAC9E,CAAC;IAED,YAAY,IAAyB;QACpC,IAAI,CAAC,IAAI,GAAG,IAAI,CAAC;QACjB,IAAI,CAAC,kBAAkB,GAAG,IAAI,CAAC,kBAAkB,IAAI,EAAE,GAAG,IAAI,CAAC;IAChE,CAAC;IAED;;;OAGG;IACH,KAAK,CAAC,iBAAiB;QACtB,MAAM,MAAM,GAAG,MAAM,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,YAAY,EAAE,CAAC;QAEjD,KAAK,MAAM,KAAK,IAAI,MAAM,EAAE,CAAC;YAC5B,2EAA2E;YAC3E,IAAI,KAAK,CAAC,MAAM,KAAK,SAAS,IAAI,KAAK,CAAC,MAAM,KAAK,SAAS,EAAE,CAAC;gBAC9D,SAAS;YACV,CAAC;YAED,sDAAsD;YACtD,MAAM,OAAO,GAAG,MAAM,OAAO,CAAC,GAAG,EAAE,CAAC,IAAI,CAAC,UAAU,CAAC,KAAK,CAAC,CAAC,CAAC;YAC5D,IAAI,CAAC,OAAO,CAAC,EAAE,EAAE,CAAC;gBACjB,IAAI,CAAC,MAAM,CAAC,KAAK,CAAC,0BAA0B,EAAE;oBAC7C,SAAS,EAAE,KAAK,CAAC,EAAE;oBACnB,OAAO,EAAE,gBAAgB,CAAC,OAAO,CAAC,OAAO,CAAC;iBAC1C,CAAC,CAAC;YACJ,CAAC;QACF,CAAC;IACF,CAAC;IAED,wGAAwG;IAChG,KAAK,CAAC,UAAU,CAAC,KAAmB;QAC3C,MAAM,UAAU,GAAG,KAAK,CAAC,SAAS,EAAE,OAAO,EAAE,CAAC;QAC9C,MAAM,eAAe,GAAG,CAAC,OAAqB,EAAE,EAAE,CAAC,OAAO,CAAC,MAAM,KAAK,KAAK,CAAC,MAAM,IAAI,OAAO,CAAC,GAAG,KAAK,KAAK,CAAC,GAAG;YAC9G,OAAO,CAAC,SAAS,EAAE,OAAO,EAAE,KAAK,UAAU,CAAC;QAC7C,IAAI,UAAU,KAAK,SAAS,IAAI,aAAa,CAAC,KAAK,CAAC,IAAI,CAAC,MAAM,IAAI,CAAC,IAAI,CAAC,KAAK,CAAC,eAAe,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,CAC7G,KAAK,CAAC,EAAE,CAAC,KAAK,CAAC,SAAS,KAAK,UAAU,CACvC;YAAE,OAAO;QACV,MAAM,cAAc,GAAG,MAAM,oBAAoB,CAAC,IAAI,CAAC,IAAI,CAAC,UAAU,EAAE,EAAE,KAAK,CAAC,CAAC;QACjF,MAAM,QAAQ,GAAG,MAAM,IAAI,CAAC,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;QACrD,IAAI,CAAC,QAAQ,IAAI,CAAC,eAAe,CAAC,QAAQ,CAAC;YAAE,OAAO;QACpD,IAAI,KAAK,CAAC,GAAG,KAAK,SAAS,IAAI,CAAC,cAAc,CAAC,OAAO,CAAC,iBAAiB,KAAK,IAAI,IAAI,KAAK,CAAC,YAAY,KAAK,SAAS,CAAC,EAAE,CAAC;YACxH,IAAI,CAAC,QAAQ,CAAC,GAAG,CAAC,KAAK,CAAC,EAAE,EAAE,KAAK,CAAC,GAAG,CAAC,CAAC;QACxC,CAAC;QAED,IAAI,CAAC,cAAc,CAAC,KAAK,EAAE,CAAC;YAC3B,mDAAmD;YACnD,MAAM,GAAG,GAAG,IAAI,CAAC,GAAG,EAAE,CAAC;YACvB,MAAM,WAAW,GAAG,IAAI,CAAC,gBAAgB,CAAC,GAAG,CAAC,KAAK,CAAC,EAAE,CAAC,IAAI,CAAC,CAAC;YAC7D,MAAM,SAAS,GACd,KAAK,CAAC,MAAM,KAAK,SAAS,IAAI,GAAG,GAAG,WAAW,IAAI,IAAI,CAAC,kBAAkB,CAAC;YAE5E,kDAAkD;YAClD,MAAM,aAAa,GAClB,cAAc,CAAC,OAAO,CAAC,YAAY,IAAI,CAAC,cAAc,CAAC,OAAO,CAAC,iBAAiB,CAAC;YAElF,gEAAgE;YAChE,gEAAgE;YAChE,4DAA4D;YAC5D,iEAAiE;YACjE,kEAAkE;YAClE,2DAA2D;YAC3D,MAAM,WAAW,GAAG,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC,MAAM,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,SAAS,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;YACnF,IACC,cAAc,CAAC,OAAO,CAAC,iBAAiB,KAAK,KAAK;gBAClD,KAAK,CAAC,GAAG;gBACT,CAAC,MAAM,WAAW,CAAC,IAAI,CAAC,IAAI,CAAC,UAAU,EAAE,EAAE,KAAK,EAAE,WAAW,CAAC,CAAC,EAC9D,CAAC;gBACF,MAAM,QAAQ,GAAG,WAAW,EAAE,WAAW,EAAE,QAAQ,IAAI,CAAC,CAAC;gBACzD,MAAM,SAAS,GAAG,KAAK,CAAC,SAAS,EAAE,OAAO,EAAE,CAAC;gBAC7C,IAAI,SAAS,KAAK,SAAS,IAAI,GAAG,GAAG,SAAS,GAAG,QAAQ,EAAE,CAAC;oBAC3D,IAAI,CAAC,MAAM,CAAC,KAAK,CAAC,iDAAiD,EAAE;wBACpE,SAAS,EAAE,KAAK,CAAC,EAAE;wBACnB,GAAG,EAAE,KAAK,CAAC,GAAG;wBACd,QAAQ;qBACR,CAAC,CAAC;oBACH,OAAO;gBACR,CAAC;gBACD,IAAI,IAAI,CAAC,QAAQ,CAAC,GAAG,CAAC,KAAK,CAAC,EAAE,CAAC,KAAK,KAAK,CAAC,GAAG,EAAE,CAAC;oBAC/C,IAAI,CAAC,iBAAiB,CAAC,MAAM,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;oBACxC,IAAI,CAAC,MAAM,CAAC,KAAK,CAAC,iFAAiF,EAAE;wBACpG,SAAS,EAAE,KAAK,CAAC,EAAE;wBACnB,GAAG,EAAE,KAAK,CAAC,GAAG;qBACd,CAAC,CAAC;oBACH,OAAO;gBACR,CAAC;gBACD,MAAM,KAAK,GAAG,CAAC,IAAI,CAAC,iBAAiB,CAAC,GAAG,CAAC,KAAK,CAAC,EAAE,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC,CAAC;gBAC9D,IAAI,CAAC,iBAAiB,CAAC,GAAG,CAAC,KAAK,CAAC,EAAE,EAAE,KAAK,CAAC,CAAC;gBAC5C,IAAI,KAAK,GAAG,8BAA8B,EAAE,CAAC;oBAC5C,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,4DAA4D,EAAE;wBAC9E,SAAS,EAAE,KAAK,CAAC,EAAE;wBACnB,GAAG,EAAE,KAAK,CAAC,GAAG;wBACd,IAAI,EAAE,KAAK;wBACX,cAAc,EAAE,8BAA8B;qBAC9C,CAAC,CAAC;oBACH,OAAO;gBACR,CAAC;gBACD,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,sEAAsE,EAAE;oBACxF,SAAS,EAAE,KAAK,CAAC,EAAE;oBACnB,GAAG,EAAE,KAAK,CAAC,GAAG;oBACd,KAAK;iBACL,CAAC,CAAC;gBACH,MAAM,eAAe,CAAC,IAAI,CAAC,IAAI,CAAC,UAAU,EAAE,EAAE,KAAK,CAAC,GAAG,EAAE,KAAK,CAAC,EAAE,CAAC,CAAC;gBACnE,uEAAuE;gBACvE,0EAA0E;gBAC1E,8DAA8D;gBAC9D,IAAI,CAAC,iBAAiB,CAAC,MAAM,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;gBACxC,IAAI,CAAC,QAAQ,CAAC,MAAM,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;gBAC/B,OAAO;YACR,CAAC;YACD,IAAI,CAAC,iBAAiB,CAAC,MAAM,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;YAExC,4DAA4D;YAC5D,IAAI,SAAS,EAAE,CAAC;gBACf,MAAM,SAAS,GAAG,KAAK,CAAC,MAAM,KAAK,SAAS,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,SAAS,CAAC;gBACrE,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,uBAAuB,EAAE;oBACzC,SAAS,EAAE,KAAK,CAAC,EAAE;oBACnB,MAAM,EAAE,SAAS;oBACjB,MAAM,EAAE,cAAc,CAAC,OAAO,CAAC,MAAM;iBACrC,CAAC,CAAC;gBACH,IAAI,CAAC,gBAAgB,CAAC,GAAG,CAAC,KAAK,CAAC,EAAE,EAAE,GAAG,CAAC,CAAC;YAC1C,CAAC;YAED,IAAI,aAAa,EAAE,CAAC;gBACnB,kEAAkE;gBAClE,uDAAuD;gBACvD,IAAI,SAAS,EAAE,CAAC;oBACf,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,uBAAuB,EAAE;wBACzC,SAAS,EAAE,KAAK,CAAC,EAAE;wBACnB,UAAU,EAAE,KAAK,CAAC,UAAU;qBAC5B,CAAC,CAAC;gBACJ,CAAC;gBACD,mEAAmE;gBACnE,MAAM,OAAO,GAAG,MAAM,OAAO,CAAC,GAAG,EAAE,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,aAAa,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC,CAAC;gBAC1E,gFAAgF;gBAChF,IAAI,CAAC,OAAO,CAAC,EAAE,IAAI,SAAS,EAAE,CAAC;oBAC9B,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,0BAA0B,EAAE;wBAC5C,SAAS,EAAE,KAAK,CAAC,EAAE;wBACnB,OAAO,EAAE,gBAAgB,CAAC,OAAO,CAAC,OAAO,CAAC;qBAC1C,CAAC,CAAC;gBACJ,CAAC;YACF,CAAC;YAED,iEAAiE;YACjE,8DAA8D;YAC9D,yDAAyD;YACzD,8DAA8D;YAC9D,4DAA4D;YAC5D,6DAA6D;YAC7D,yDAAyD;YACzD,2DAA2D;YAC3D,yDAAyD;YACzD,wDAAwD;YACxD,gBAAgB;YAChB,MAAM,SAAS,GAA0B,aAAa,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,SAAS,CAAC;YAC/E,MAAM,cAAc,GAAG,OAAO,CAAC,aAAa,CAAC,CAAC;YAC9C,MAAM,cAAc,GAAG,OAAO,CAAC,KAAK,CAAC,WAAW,CAAC,CAAC;YAClD,MAAM,aAAa,GAAG,KAAK,CAAC,MAAM,KAAK,SAAS,CAAC;YACjD,MAAM,kBAAkB,GAAG,cAAc,KAAK,cAAc,CAAC;YAE7D,IAAI,aAAa,IAAI,kBAAkB,EAAE,CAAC;gBACzC,kDAAkD;gBAClD,wDAAwD;gBACxD,wDAAwD;gBACxD,8CAA8C;gBAC9C,MAAM,KAAK,GAAG,EAAE,MAAM,EAAE,SAAS,EAAE,WAAW,EAAE,cAAc,EAAkC,CAAC;gBACjG,MAAM,MAAM,GAAG,aAAa;oBAC3B,CAAC,CAAC;wBACA,GAAG,KAAK;wBACR,SAAS,EAAE,IAAI,IAAI,EAAE;wBACrB,SAAS,EAAE,kCAAkC,cAAc,CAAC,OAAO,CAAC,MAAM,EAAE;qBAC5E;oBACF,CAAC,CAAC,KAAK,CAAC;gBAET,IAAI,CAAC,CAAC,MAAM,IAAI,CAAC,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,KAAK,CAAC,EAAE,EAAE,MAAM,EAAE,eAAe,CAAC,CAAC;oBAAE,OAAO;gBAEnF,IAAI,aAAa,EAAE,CAAC;oBACnB,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,qCAAqC,EAAE;wBACvD,SAAS,EAAE,KAAK,CAAC,EAAE;wBACnB,UAAU,EAAE,KAAK,CAAC,MAAM;wBACxB,QAAQ,EAAE,SAAS;wBACnB,WAAW,EAAE,cAAc;wBAC3B,MAAM,EAAE,cAAc,CAAC,OAAO,CAAC,MAAM;qBACrC,CAAC,CAAC;gBACJ,CAAC;qBAAM,CAAC;oBACP,oDAAoD;oBACpD,iDAAiD;oBACjD,IAAI,CAAC,MAAM,CAAC,KAAK,CAAC,mCAAmC,EAAE;wBACtD,SAAS,EAAE,KAAK,CAAC,EAAE;wBACnB,MAAM,EAAE,SAAS;wBACjB,WAAW,EAAE,cAAc;qBAC3B,CAAC,CAAC;gBACJ,CAAC;YACF,CAAC;YAED,4CAA4C;YAC5C,qEAAqE;YACrE,MAAM,YAAY,GAAG,MAAM,IAAI,CAAC,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;YACzD,IAAI,CAAC,YAAY,IAAI,YAAY,CAAC,GAAG,KAAK,KAAK,CAAC,GAAG,IAAI,YAAY,CAAC,SAAS,EAAE,OAAO,EAAE,KAAK,UAAU;gBAAE,OAAO;YAChH,IAAI,YAAY,EAAE,MAAM,KAAK,UAAU,IAAI,YAAY,EAAE,MAAM,KAAK,SAAS,EAAE,CAAC;gBAC/E,IAAI,CAAC,MAAM,CAAC,KAAK,CAAC,+DAA+D,EAAE;oBAClF,SAAS,EAAE,KAAK,CAAC,EAAE;oBACnB,MAAM,EAAE,YAAY,EAAE,MAAM;iBAC5B,CAAC,CAAC;gBACH,OAAO;YACR,CAAC;YACD,IAAI,YAAY,CAAC,MAAM,KAAK,SAAS;gBAAE,OAAO;YAE9C,MAAM,MAAM,GAAG,MAAM,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,SAAS,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;YACtD,IAAI,MAAM,EAAE,WAAW,EAAE,CAAC;gBACzB,yEAAyE;gBACzE,wEAAwE;gBACxE,MAAM,MAAM,GAAG,oBAAoB,CAAC,MAAM,eAAe,CAAC,IAAI,CAAC,IAAI,CAAC,UAAU,EAAE,CAAC,EAAE,MAAM,CAAC,CAAC;gBAC3F,MAAM,aAAa,GAAG,CAAC,YAAY,EAAE,wBAAwB,IAAI,CAAC,CAAC,GAAG,CAAC,CAAC;gBACxE,MAAM,WAAW,GAAG,MAAM,CAAC,cAAc,CAAC;gBAE1C,IAAI,UAAU,CAAC,MAAM,EAAE,aAAa,CAAC,EAAE,CAAC;oBACvC,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,+CAA+C,EAAE;wBACjE,SAAS,EAAE,KAAK,CAAC,EAAE;wBACnB,OAAO,EAAE,aAAa;wBACtB,WAAW;qBACX,CAAC,CAAC;oBACH,MAAM,OAAO,GAAG,MAAM,IAAI,CAAC,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,KAAK,CAAC,EAAE,EAAE,EAAE,wBAAwB,EAAE,aAAa,EAAE,EAAE,OAAO,CAAC,EAAE,CACjH,OAAO,CAAC,MAAM,KAAK,YAAY,CAAC,MAAM,IAAI,OAAO,CAAC,GAAG,KAAK,YAAY,CAAC,GAAG,IAAI,OAAO,CAAC,SAAS,EAAE,OAAO,EAAE,KAAK,UAAU,CACzH,CAAC;oBACF,IAAI,CAAC,OAAO;wBAAE,OAAO;oBACrB,MAAM,SAAS,GAAG,MAAM,OAAO,CAAC,GAAG,EAAE,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,OAAO,CAAC,KAAK,CAAC,EAAE,EAAE,EAAE,iBAAiB,EAAE,KAAK,EAAE,EAAE,EAAE,WAAW,EAAE,KAAK,CAAC,GAAG,EAAE,CAAC,CAAC,CAAC;oBAChI,IAAI,CAAC,SAAS,CAAC,EAAE,EAAE,CAAC;wBACnB,IAAI,CAAC,MAAM,CAAC,KAAK,CAAC,iDAAiD,EAAE;4BACpE,SAAS,EAAE,KAAK,CAAC,EAAE;4BACnB,OAAO,EAAE,gBAAgB,CAAC,SAAS,CAAC,OAAO,CAAC;yBAC5C,CAAC,CAAC;oBACJ,CAAC;gBACF,CAAC;qBAAM,CAAC;oBACP,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,uCAAuC,EAAE;wBACzD,SAAS,EAAE,KAAK,CAAC,EAAE;wBACnB,OAAO,EAAE,aAAa;wBACtB,WAAW;qBACX,CAAC,CAAC;gBACJ,CAAC;YACF,CAAC;QACF,CAAC;aAAM,IAAI,KAAK,CAAC,MAAM,KAAK,SAAS,IAAI,cAAc,CAAC,KAAK,EAAE,CAAC;YAC/D,6BAA6B;YAC7B,0DAA0D;YAC1D,kFAAkF;YAElF,oDAAoD;YACpD,yDAAyD;YACzD,IAAI,KAAK,CAAC,GAAG,IAAI,cAAc,CAAC,OAAO,CAAC,QAAQ,EAAE,CAAC;gBAClD,MAAM,MAAM,GAAG,MAAM,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,SAAS,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;gBACtD,MAAM,YAAY,GAAG,MAAM;oBAC1B,CAAC,CAAC,CAAC,MAAM,CAAC,OAAO,EAAE,GAAG,CAAC,MAAM,CAAC,IAAI,IAAI,EAAE,CAAC,CAAC,CAAC,MAAM,CAAC,OAAO,CAAC;oBAC1D,CAAC,CAAC,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;gBACd,MAAM,SAAS,GAAG,MAAM,sBAAsB,CAAC,IAAI,CAAC,IAAI,CAAC,UAAU,EAAE,EAAE,KAAK,CAAC,GAAG,EAAE,KAAK,CAAC,EAAE,EAAE,YAAY,CAAC,CAAC;gBAE1G,IAAI,SAAS,CAAC,KAAK,EAAE,CAAC;oBACrB,uCAAuC;oBACvC,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,2BAA2B,EAAE;wBAC7C,SAAS,EAAE,KAAK,CAAC,EAAE;wBACnB,GAAG,EAAE,KAAK,CAAC,GAAG;qBACd,CAAC,CAAC;oBACH,MAAM,SAAS,GAAG,KAAK,CAAC,GAAG,CAAC;oBAC5B,MAAM,MAAM,GAAG,MAAM,OAAO,CAAC,GAAG,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC,IAAI,CAAC,UAAU,EAAE,EAAE,SAAS,EAAE,KAAK,CAAC,EAAE,CAAC,CAAC,CAAC;oBACjG,IAAI,MAAM,CAAC,EAAE,EAAE,CAAC;wBACf,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,8BAA8B,EAAE;4BAChD,SAAS,EAAE,KAAK,CAAC,EAAE;4BACnB,GAAG,EAAE,KAAK,CAAC,GAAG;yBACd,CAAC,CAAC;oBACJ,CAAC;yBAAM,CAAC;wBACP,IAAI,CAAC,MAAM,CAAC,KAAK,CAAC,iCAAiC,EAAE;4BACpD,SAAS,EAAE,KAAK,CAAC,EAAE;4BACnB,GAAG,EAAE,KAAK,CAAC,GAAG;4BACd,OAAO,EAAE,gBAAgB,CAAC,MAAM,CAAC,OAAO,CAAC;yBACzC,CAAC,CAAC;oBACJ,CAAC;gBACF,CAAC;qBAAM,CAAC;oBACP,6DAA6D;oBAC7D,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,iDAAiD,EAAE;wBACnE,SAAS,EAAE,KAAK,CAAC,EAAE;wBACnB,GAAG,EAAE,KAAK,CAAC,GAAG;qBACd,CAAC,CAAC;gBACJ,CAAC;YACF,CAAC;YAED,2BAA2B;YAC3B,IAAI,KAAK,CAAC,UAAU,EAAE,CAAC;gBACtB,MAAM,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,aAAa,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;YAC5C,CAAC;YAED,mEAAmE;YACnE,oEAAoE;YACpE,8DAA8D;YAC9D,MAAM,cAAc,GACnB,KAAK,CAAC,GAAG,KAAK,SAAS;gBACvB,KAAK,CAAC,SAAS,KAAK,0CAA0C,CAAC;YAChE,IAAI,CAAC,cAAc,EAAE,CAAC;gBACrB,MAAM,IAAI,CAAC,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,KAAK,CAAC,EAAE,EAAE;oBAC1C,GAAG,EAAE,SAAS;oBACd,SAAS,EAAE,IAAI,IAAI,EAAE;oBACrB,YAAY,EAAE,IAAI,IAAI,EAAE;oBACxB,SAAS,EAAE,0CAA0C;iBACrD,EAAE,eAAe,CAAC,CAAC;YACrB,CAAC;QACF,CAAC;IACF,CAAC;IAED;;OAEG;IACH,aAAa;QACZ,IAAI,CAAC,gBAAgB,CAAC,KAAK,EAAE,CAAC;QAC9B,IAAI,CAAC,iBAAiB,CAAC,KAAK,EAAE,CAAC;IAChC,CAAC;CAED"}

package/dist/daemon/orphan-scanner.d.ts

@@ -0,0 +1,114 @@
+/**
+ * Orphan Scanner
+ * Detects and cleans up orphaned processes and sockets from previous daemon sessions
+ */
+import type { ProcessStore } from '../store.impl.consumer.ts';
+import type { ProcessManager } from '../manager.ts';
+import { type ProcessConfig } from '../schemas/process.ts';
+import { type DaemonScope } from '../utils/port-ownership.ts';
+import { type RuntimeRef } from '@vibesdotdev/kernel';
+export interface OrphanScannerDeps {
+    /** The daemon's runtime: its host process and socket services observe, signal and connect. */
+    getRuntime: () => RuntimeRef;
+    /** Process store for reading/updating state */
+    store: ProcessStore;
+    /** Process manager for socket cleanup and config access */
+    pm: ProcessManager;
+    /** Map of process configs by ID (for command signature matching) */
+    configs?: Map<string, ProcessConfig>;
+    /** The daemon's declared scope, which proves an adopted process ours. */
+    daemonScope?: DaemonScope;
+}
+/** Configuration for the orphan scanner */
+export interface OrphanScannerConfig {
+    /**
+     * Grace period in milliseconds before killing unknown processes.
+     * Processes observed for less than this time won't be killed immediately.
+     * Default: 30000 (30 seconds)
+     */
+    gracePeriodMs: number;
+    /**
+     * How long after daemon start before we start killing orphans.
+     * Gives time for processes to register naturally.
+     * Default: 60000 (60 seconds)
+     */
+    warmupPeriodMs: number;
+    /**
+     * Whether to adopt pre-daemon processes that match expected signatures.
+     * Default: true
+     */
+    enableAdoption: boolean;
+}
+/**
+ * Scans for and cleans up orphaned processes and sockets
+ * Coordinates with the startup-time orphan killer in services/orphans.ts
+ */
+export declare class OrphanScanner {
+    private deps;
+    private config;
+    private daemonStartTime;
+    private observedProcesses;
+    private portScanCache;
+    private readonly PORT_SCAN_CACHE_TTL_MS;
+    /** The daemon runtime's Logging, read per entry so it follows hot-reload generations (C083a). */
+    private get logger();
+    constructor(deps: OrphanScannerDeps, config?: Partial<OrphanScannerConfig>);
+    /**
+     * Update the daemon start time (call when daemon restarts)
+     */
+    setDaemonStartTime(time: Date): void;
+    /**
+     * Update available configs (for command signature matching)
+     */
+    setConfigs(configs: Map<string, ProcessConfig>): void;
+    private sameObservation;
+    private ownsObservation;
+    /** Recheck owed evidence under the existing admission, after external probes settle. */
+    private updateObservation;
+    /**
+     * Scan for and cleanup orphaned sockets from previous daemon sessions
+     * Uses unified liveness checking for consistent state detection
+     * This runs once at daemon startup to recover from crashes
+     */
+    scanForOrphanedSockets(): Promise<void>;
+    /**
+     * Reconcile one state the store calls running with its liveness. Returns 1
+     * when it cleaned that process's orphaned socket, else 0.
+     */
+    private reconcileRunningState;
+    /**
+     * Scan for and kill orphaned processes
+     * Runs periodically to find:
+     * 1. Processes marked as stopped/crashed but still running (orphans in state)
+     * 2. Unknown processes on monitored ports (orphans not in state)
+     *
+     * PART 2: Smart orphan detection with observation tracking and adoption
+     */
+    scanAndKillOrphans(): Promise<void>;
+    /**
+     * Get process ID on port with caching
+     * CRITICAL FIX (Issue 3.4): Cache port scan results to avoid redundant lsof calls
+     */
+    private getProcessOnPortCached;
+    /**
+     * Scan all monitored ports for running processes
+     */
+    private scanMonitoredPorts;
+    /**
+     * Evaluate whether to kill, adopt, wait, or ignore a process
+     */
+    private evaluateProcess;
+    /** Seam-friendly cwd read for refusal messages. */
+    private resolveHolderCwd;
+    /**
+     * Find a config that matches the observed process's command signature AND port.
+     * Returns the matching config if exactly one match; undefined if none; throws (refuse) if ambiguous.
+     */
+    private findMatchingConfig;
+    /**
+     * Adopt a process into our state
+     * Only adopts if the PID is not already tracked (idempotency).
+     */
+    private adoptProcess;
+}
+//# sourceMappingURL=orphan-scanner.d.ts.map

package/dist/daemon/orphan-scanner.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"orphan-scanner.d.ts","sourceRoot":"","sources":["../../src/daemon/orphan-scanner.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAGH,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,2BAA2B,CAAC;AAC9D,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,eAAe,CAAC;AACpD,OAAO,EAAiB,KAAK,aAAa,EAAqB,MAAM,uBAAuB,CAAC;AAa7F,OAAO,EAIN,KAAK,WAAW,EAChB,MAAM,4BAA4B,CAAC;AAEpC,OAAO,EAAoB,KAAK,UAAU,EAAE,MAAM,qBAAqB,CAAC;AAKxE,MAAM,WAAW,iBAAiB;IACjC,8FAA8F;IAC9F,UAAU,EAAE,MAAM,UAAU,CAAC;IAC7B,+CAA+C;IAC/C,KAAK,EAAE,YAAY,CAAC;IACpB,2DAA2D;IAC3D,EAAE,EAAE,cAAc,CAAC;IACnB,oEAAoE;IACpE,OAAO,CAAC,EAAE,GAAG,CAAC,MAAM,EAAE,aAAa,CAAC,CAAC;IACrC,yEAAyE;IACzE,WAAW,CAAC,EAAE,WAAW,CAAC;CAC1B;AAED,2CAA2C;AAC3C,MAAM,WAAW,mBAAmB;IACnC;;;;OAIG;IACH,aAAa,EAAE,MAAM,CAAC;IACtB;;;;OAIG;IACH,cAAc,EAAE,MAAM,CAAC;IACvB;;;OAGG;IACH,cAAc,EAAE,OAAO,CAAC;CACxB;AAgCD;;;GAGG;AACH,qBAAa,aAAa;IACzB,OAAO,CAAC,IAAI,CAAoB;IAChC,OAAO,CAAC,MAAM,CAAsB;IACpC,OAAO,CAAC,eAAe,CAAO;IAC9B,OAAO,CAAC,iBAAiB,CAA2C;IAIpE,OAAO,CAAC,aAAa,CAGP;IACd,OAAO,CAAC,QAAQ,CAAC,sBAAsB,CAAQ;IAG/C,iGAAiG;IACjG,OAAO,KAAK,MAAM,GAEjB;gBAEW,IAAI,EAAE,iBAAiB,EAAE,MAAM,CAAC,EAAE,OAAO,CAAC,mBAAmB,CAAC;IAU1E;;OAEG;IACH,kBAAkB,CAAC,IAAI,EAAE,IAAI,GAAG,IAAI;IAKpC;;OAEG;IACH,UAAU,CAAC,OAAO,EAAE,GAAG,CAAC,MAAM,EAAE,aAAa,CAAC,GAAG,IAAI;IAIrD,OAAO,CAAC,eAAe;YAKT,eAAe;IAS7B,wFAAwF;IACxF,OAAO,CAAC,iBAAiB;IAOzB;;;;OAIG;IACG,sBAAsB,IAAI,OAAO,CAAC,IAAI,CAAC;IA0B7C;;;OAGG;YACW,qBAAqB;IA+DnC;;;;;;;OAOG;IACG,kBAAkB,IAAI,OAAO,CAAC,IAAI,CAAC;IAiKzC;;;OAGG;YACW,sBAAsB;IA4BpC;;OAEG;YACW,kBAAkB;IA2GhC;;OAEG;YACW,eAAe;IAkH7B,mDAAmD;YACrC,gBAAgB;IAK9B;;;OAGG;YACW,kBAAkB;IA0DhC;;;OAGG;YACW,YAAY;CA8E1B"}